From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 086E3A0547; Wed, 21 Apr 2021 17:24:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC91741AC8; Wed, 21 Apr 2021 17:24:29 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 63EB4410F9; Wed, 21 Apr 2021 17:24:27 +0200 (CEST) IronPort-SDR: 1bi+fh1Lj3s/PKERHsiLfoYG/sl9Je4cVL5jlNZVgBBEvwcyxVYi5uFDB1KuP9DQCSx0fy2FC+ CJ7FxU8okoCw== X-IronPort-AV: E=McAfee;i="6200,9189,9961"; a="175203364" X-IronPort-AV: E=Sophos;i="5.82,240,1613462400"; d="scan'208";a="175203364" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2021 08:24:26 -0700 IronPort-SDR: jm0HhBjUtjSDs1/X67cfMbUmyq5rQH4xxy/OlWLlEA1yqxWr5KxS4986Vc3B2xOCv0MJ2xYw/J ZhcyDDEfGr+A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,240,1613462400"; d="scan'208";a="385806880" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga006.jf.intel.com with ESMTP; 21 Apr 2021 08:24:25 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 21 Apr 2021 08:24:25 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 21 Apr 2021 08:24:25 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.102) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 21 Apr 2021 08:24:25 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a8swVHjjNSNEfpYzv1AbqlP+sFAsVywR71v8gGXr5seY2xNzZXo60esMW4Ek4pvx0ptOxR79D7/IclM6cakp6pKqvCIM88s6nddilQOK+eK9pdtVdzQKLT+yp4cV2DpobAgeD9loLpqlIIhzIl/fX4/vy1oAa3jJEQkV0el/AJXK3mIt1gAtGZ6YUVHrxVotuW+rzC3t2TtqwIjmyMuRUuF5wX7H1ZM/IAtxZZzmsMCKU6y1oQRyjG3lzW7/xThn5PCFZOBO/2kIwiw7pUQ0D173B3FMqR35TJUc5GwRxXRXByP8Ys+Xjtqoph/tWrD5cuVBZoAq5GKtgFTgFxuz/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Upv4sW3ncg+SeIXzx/yynVmYr/rIyxLBw96LlvrFH54=; b=Qu40S/FKstKXxU5zyqGacmCR+uhyR5GC86niZRlCy8O/lsEImfIA8Bg+xFbfE1rkVHmHW5OlD62wOLQLy1jMDKrLDUgcNsaRne9ZJqVgefMg51ZlRHvBwsdisuk0aMMqlQmpVDGigTcy7OMmfNwQhSzcgI3i3svemFijhEDsR3egnyMTUlxdjTbg/2OTtgGkZc3ymNwHLZosxlNacbHeiH/QGSwhttYIrV7A2xWiuOQLBWPM+nbif+tEZ0glJJJJ0cwR+2QPzbFF55c0NOYZES71tP8FoQIoJi/fC4hPt7+pNd+eG2VNH4uFs1KXgAh/0ILO6B+RVkkgx+gMNEDzdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Upv4sW3ncg+SeIXzx/yynVmYr/rIyxLBw96LlvrFH54=; b=vZ8YYVy62UVfKrHjyewVdoMutEosY2ml/NULZym3ibSDX8htqSpgVot3lZ2YVe+FLraCSQXcGsubrAyihn6ZmZlUN8aw8p+QmMDlec2jgOuEd4Uai8f8IoltPwG8zrKKuA4nwRxmFHho/k0MXHFSaEX5csdyBt2tE6mD/+LwTUA= Received: from DM6PR11MB2796.namprd11.prod.outlook.com (2603:10b6:5:c8::23) by DM6PR11MB3644.namprd11.prod.outlook.com (2603:10b6:5:139::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Wed, 21 Apr 2021 15:24:24 +0000 Received: from DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::d099:834d:f5ad:39c9]) by DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::d099:834d:f5ad:39c9%3]) with mapi id 15.20.4042.024; Wed, 21 Apr 2021 15:24:24 +0000 From: "Dumitrescu, Cristian" To: "Dharmappa, Savinay" , "dev@dpdk.org" , "Singh, Jasvinder" CC: "stable@dpdk.org" Thread-Topic: [PATCH v3] sched : fix traffic class oversubscription parameter Thread-Index: AQHXNnqjrC8+Ezmioke9CzjemnRvA6q/F7Tg Date: Wed, 21 Apr 2021 15:24:24 +0000 Message-ID: References: <20210309161002.31384-1-savinay.dharmappa@intel.com> <20210421065001.96074-1-savinay.dharmappa@intel.com> In-Reply-To: <20210421065001.96074-1-savinay.dharmappa@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [51.37.10.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e6027a92-580a-4da6-4a77-08d904d98ba3 x-ms-traffictypediagnostic: DM6PR11MB3644: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ed+6tJ/Z3QD4ucsWxgqJHHWkD0k3r+5yWBRQaRrw5acT+rAH1NtMKNMIZxr5YE86hB0ltHtitVufMRIYqWvqNL2z8ATD4U/Wch9uswYJ4CdTPi8A8g7aNuUkJev6nrbxE5L1/i0bFh7TvMRiAemG0lwG+X4FL0CjtBSGQCv9A+ao0fjVGkHtd2BdOFZnUogKK+jElB/ZFuneCosqWaPomu3uLluQV2YWlVgpsCxVczHbIwbcC4KINEpUBoEYGyWUKMZoX15llYbfBaoSfwXjckQTtT/CK1Ndd6GM1wGLROPw72VHnRpxXxw2Ov54KoYws8Lxh+S3GSSImilfxAL5W4l7ZpnRg0R6av0wcbt882RWJHJ8ijMBynxg3Xuz3I85MikYavfpJ3cqULu9mi0RRO5pFx/dU5CKOK4lVb42uKBF9erAl9/8eJjgnk5kuK41jmTqAomgjAwkTuQcPR0Y/FkqU0oZKe6fRIBYP3DV7Vb4tHtPZWtn8v9lTx5KgqeiKNm41j+DnlgC4SW1c1/UuFFaLA7ptOyvcMV3OioDXFM2kZHx2waBdiyhlhGGFLKm2G9oVPZvl9Z6sTOa0BqmE1v/5NvnvNRv9tRyueBCIvU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2796.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(366004)(136003)(376002)(346002)(39860400002)(83380400001)(122000001)(38100700002)(52536014)(86362001)(8936002)(6636002)(66556008)(66946007)(66476007)(76116006)(66446008)(64756008)(55016002)(9686003)(33656002)(5660300002)(8676002)(53546011)(71200400001)(478600001)(4326008)(450100002)(110136005)(316002)(186003)(26005)(2906002)(7696005)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ZmQb8m8/xNhBKfeN48UI3JnBPk56uHZ9QLd67qhMIL9fDVgU6QLJ6Fsu+2xs?= =?us-ascii?Q?7NXxMEZpO36W6LV0PKMIM2DU9e+B1tS0jM2HD0Kjj7PpHdEpD3Su43nEiBB8?= =?us-ascii?Q?fsEa/KSUEJ6ikS2IIBO44cSNKXQW0O7TVW7bd1vJl2thA09zHUvi2GpOpi6I?= =?us-ascii?Q?/4gnRXpOlHmM5Yeub4vY5pfr36Hj1wmEKq1gTq+t29NURETn3eYsqJ83CTB2?= =?us-ascii?Q?lQsHLfISmEbImDEABcKkbEAMnOqXiqe4LJbd9nmNo4oOnVxtqI3lBgOHcG25?= =?us-ascii?Q?nNsFZutBwuP9l9M7Hm9lY/emrFPsozXQ+sr/HX61lttB7faBZmihGEP1uWUX?= =?us-ascii?Q?/8Lyn+NVnLI3zFCDvbbAXIRPESI4Rn6I82Hhz3aTqmYJwHjPvqjMidU9HwAF?= =?us-ascii?Q?QpI2hcHPageZUVPKZm0rXXb7JqQgqmAgeH7ddm3/NMJ3uqNM4MA7ECqvS9o7?= =?us-ascii?Q?Hu5xY4CCDSkQXkKuZLuOuUPjpqUU5n9Yz0g8ZiuNAjbedw97jvEpxcIytURd?= =?us-ascii?Q?CNdPn544/IoSdmrxJmuCc40XGddljuJ5jmOCqBTzntdyLd/8XFcDqLWVOjYY?= =?us-ascii?Q?Rg4j06T5AV7O9ffhgnuVc9irFmGrOGITAn30cVUmzUR8XNc/9caU+6vaUct3?= =?us-ascii?Q?wJCu0axVSqcFkQu1xHQ0R1X1EOYF6Akzh2GZVYMfwPFWGC4QUUYKpMO8tZhY?= =?us-ascii?Q?MLDJRcuOPVNw0oN7z1Fq4Znpo7KNLjnhePBJ/LZnTiWQD1NeYuE1N9GdQ0Vq?= =?us-ascii?Q?DWNci9+VjqG77iDxlf7cOIUvIBS+hvWeHokshY21Gr8KibJIbveB+URJr6oT?= =?us-ascii?Q?ylhdEkFg/tqZV7ylzpESI9LJiJbgQcIHASQppMbnXv2UJJQXLV3svyGSkS0y?= =?us-ascii?Q?XMBRi9mS1ktrJ5+IDDkv/yBe+P/E9BClKTGCE1OL8fjAk/F0r/a0U5jl5ve1?= =?us-ascii?Q?oeCkuSddBsByFX/F5gVcTtey3BsOpUVJHEYJkjeE2NLqBvDNp4s1Z1CGwXbT?= =?us-ascii?Q?6l4RwiL7M0VQhjL/5eUZLPAwYaMkIrzFV9pffFE7AgHHFOmequJbVj25ZDG3?= =?us-ascii?Q?ZZxepZvUr1lDbWrdOSwb13un3ESkRtbwK6rSqibLtC9oNDLx+km0h6j6Z+bd?= =?us-ascii?Q?HCWk6+/Xll9C9R7Y/PTyLLTmBoSZf97ClkGWLksIQsxtHcrobBtUAJ3rzm1I?= =?us-ascii?Q?o8AKR3rxvYjXMxcDfBhzSdwSDlx9nXQLYAj1+S4X8zbgzgqD7Mk83rkQ7TEw?= =?us-ascii?Q?KDE0PQ8if2nhIHktYANgAKpxQ6kU9zQ58alFBH96v4J8NV1BVFSKVpmp0DBc?= =?us-ascii?Q?/D8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2796.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e6027a92-580a-4da6-4a77-08d904d98ba3 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 15:24:24.6095 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: I95F3fxg5RsDddgvLpq3TiDLvifHyZHWNmZDNon9tFN6DEwN9d3jVVBzka9/3Xbct7c7/9Er5p4d6ktQUzQv5JSqGi+R3pkoE+6oLySI/4s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3644 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] sched : fix traffic class oversubscription parameter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Dharmappa, Savinay > Sent: Wednesday, April 21, 2021 7:50 AM > To: dev@dpdk.org; Singh, Jasvinder ; > Dumitrescu, Cristian > Cc: Dharmappa, Savinay ; stable@dpdk.org > Subject: [PATCH v3] sched : fix traffic class oversubscription parameter >=20 > This patch fixes the traffic class oversubscription watermark > value by initialising it with computed value of maximum watermark. >=20 > Fixes: ac6fcb841b0f ("sched: update subport rate dynamically") > Cc: stable@dpdk.org >=20 > Signed-off-by: Savinay Dharmappa > Acked-by: Jasvinder Singh > --- > v3: update the title. > --- > lib/librte_sched/rte_sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c > index 7c56880681..cd87e688e4 100644 > --- a/lib/librte_sched/rte_sched.c > +++ b/lib/librte_sched/rte_sched.c > @@ -1249,7 +1249,6 @@ rte_sched_subport_config(struct rte_sched_port > *port, > #ifdef RTE_SCHED_SUBPORT_TC_OV > /* TC oversubscription */ > s->tc_ov_wm_min =3D port->mtu; > - s->tc_ov_wm =3D s->tc_ov_wm_max; > s->tc_ov_period_id =3D 0; > s->tc_ov =3D 0; > s->tc_ov_n =3D 0; > @@ -1277,6 +1276,7 @@ rte_sched_subport_config(struct rte_sched_port > *port, > #ifdef RTE_SCHED_SUBPORT_TC_OV > s->tc_ov_wm_max =3D rte_sched_time_ms_to_bytes(profile- > >tc_period, > s- > >pipe_tc_be_rate_max); > + s->tc_ov_wm =3D s->tc_ov_wm_max; > #endif > s->profile =3D subport_profile_id; >=20 > -- > 2.17.1 Acked-by: Cristian Dumitrescu