[dpdk-dev] [PATCH] rte_swx: fix typo

[dpdk-dev] [PATCH] rte_swx: fix typo

[Thierry Herbelot]

Check Bucket key for all possible indices.

Fixes: d0a00966618ba ("table: add exact match SWX table")
Cc: stable@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
---
 lib/table/rte_swx_table_em.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
index 788e25f6b912..03b28c4c9da0 100644
--- a/lib/table/rte_swx_table_em.c
+++ b/lib/table/rte_swx_table_em.c
@@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
 static inline int
 bkt_is_empty(struct bucket_extension *bkt)
 {
-	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) ?
+	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3]) ?
 		1 : 0;
 }
 
-- 
2.29.2

Re: [dpdk-dev] [PATCH] rte_swx: fix typo

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Monday, May 24, 2021 9:54 AM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
> <thomas@monjalon.net>; stable@dpdk.org; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: [PATCH] rte_swx: fix typo
> 
> Check Bucket key for all possible indices.
> 
> Fixes: d0a00966618ba ("table: add exact match SWX table")
> Cc: stable@dpdk.org
> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> ---
>  lib/table/rte_swx_table_em.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
> index 788e25f6b912..03b28c4c9da0 100644
> --- a/lib/table/rte_swx_table_em.c
> +++ b/lib/table/rte_swx_table_em.c
> @@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
>  static inline int
>  bkt_is_empty(struct bucket_extension *bkt)
>  {
> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
> ?
> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
> ?
>  		1 : 0;
>  }
> 
> --
> 2.29.2

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Thanks very much, Thierry!

It would be great though if we could send a V2 with "table" instead of "rte_swx" in the title:
	[PATCH] table: fix typo

[dpdk-dev] [PATCH v2] table: fix typo

[Thierry Herbelot]

Check Bucket key for all possible indices.

Fixes: d0a00966618ba ("table: add exact match SWX table")
Cc: stable@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
--
V2: reword patch title
---
 lib/table/rte_swx_table_em.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
index 788e25f6b912..03b28c4c9da0 100644
--- a/lib/table/rte_swx_table_em.c
+++ b/lib/table/rte_swx_table_em.c
@@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
 static inline int
 bkt_is_empty(struct bucket_extension *bkt)
 {
-	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) ?
+	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3]) ?
 		1 : 0;
 }
 
-- 
2.29.2

Re: [dpdk-dev] [PATCH v2] table: fix typo

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Monday, May 24, 2021 12:29 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
> <thomas@monjalon.net>; stable@dpdk.org; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: [PATCH v2] table: fix typo
> 
> Check Bucket key for all possible indices.
> 
> Fixes: d0a00966618ba ("table: add exact match SWX table")
> Cc: stable@dpdk.org
> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V2: reword patch title
> ---
>  lib/table/rte_swx_table_em.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
> index 788e25f6b912..03b28c4c9da0 100644
> --- a/lib/table/rte_swx_table_em.c
> +++ b/lib/table/rte_swx_table_em.c
> @@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
>  static inline int
>  bkt_is_empty(struct bucket_extension *bkt)
>  {
> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
> ?
> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
> ?
>  		1 : 0;
>  }
> 
> --
> 2.29.2

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Thierry, thanks again, you could have actually added my ack from V1 :)

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

[Thomas Monjalon]

> > Check Bucket key for all possible indices.
> > 
> > Fixes: d0a00966618ba ("table: add exact match SWX table")
> > Cc: stable@dpdk.org
> > Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > 
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
[...]
> > -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
> > +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Thierry, thanks again, you could have actually added my ack from V1 :)

The root cause looks to be a typo indeed,
but the impact or the scope of the issue
should stated in few words in the title please.
No need to send a v3, please suggest a title and I will apply.

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

[Thierry Herbelot]

On 6/17/21 9:01 AM, Thomas Monjalon wrote:
>>> Check Bucket key for all possible indices.
>>>
>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
>>> Cc: stable@dpdk.org
>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>
>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> [...]
>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
>>
>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>
>> Thierry, thanks again, you could have actually added my ack from V1 :)
> 
> The root cause looks to be a typo indeed,
> but the impact or the scope of the issue
> should stated in few words in the title please.
> No need to send a v3, please suggest a title and I will apply.

table: check a bucket is empty for all bucket keys

	Thierry

> 
> 

-- 
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/

Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Thursday, June 17, 2021 8:12 AM
> To: Thomas Monjalon <thomas@monjalon.net>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
> 
> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> >>> Check Bucket key for all possible indices.
> >>>
> >>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> >>> Cc: stable@dpdk.org
> >>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>>
> >>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > [...]
> >>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
> >>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
> >>
> >> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>
> >> Thierry, thanks again, you could have actually added my ack from V1 :)
> >
> > The root cause looks to be a typo indeed,
> > but the impact or the scope of the issue
> > should stated in few words in the title please.
> > No need to send a v3, please suggest a title and I will apply.
> 
> table: check a bucket is empty for all bucket keys
> 
> 	Thierry
> 

Hi Thierry,

I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you?

Thanks,
Cristian

> >
> >
> 
> --
> Thierry Herbelot
> Senior Software Engineer
> Tel: +33 1 39 30 92 61
> http://www.6wind.com/
> 
> Follow us:
> https://www.linkedin.com/company/6wind/
> https://twitter.com/6WINDsoftware
> https://www.youtube.com/user/6windsoftware

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

[Thierry Herbelot]

On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> 
> 
>> -----Original Message-----
>> From: Thierry Herbelot <thierry.herbelot@6wind.com>
>> Sent: Thursday, June 17, 2021 8:12 AM
>> To: Thomas Monjalon <thomas@monjalon.net>; Dumitrescu, Cristian
>> <cristian.dumitrescu@intel.com>
>> Cc: dev@dpdk.org; stable@dpdk.org
>> Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
>>
>> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
>>>>> Check Bucket key for all possible indices.
>>>>>
>>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
>>>>> Cc: stable@dpdk.org
>>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>>>
>>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>>> [...]
>>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
>>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
>>>>
>>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>>
>>>> Thierry, thanks again, you could have actually added my ack from V1 :)
>>>
>>> The root cause looks to be a typo indeed,
>>> but the impact or the scope of the issue
>>> should stated in few words in the title please.
>>> No need to send a v3, please suggest a title and I will apply.
>>
>> table: check a bucket is empty for all bucket keys
>>
>> 	Thierry
>>
> 
> Hi Thierry,
> 
> I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you?
> 

Hello Cristian

Sure !

What do you think of this title:

"table: check a bucket is empty for all bucket keys"

	Best regards

	Thierry

> Thanks,
> Cristian
> 
>>>
>>>
>>
>> --
>> Thierry Herbelot
>> Senior Software Engineer
>> Tel: +33 1 39 30 92 61
>> http://www.6wind.com/
>>
>> Follow us:
>> https://www.linkedin.com/company/6wind/
>> https://twitter.com/6WINDsoftware
>> https://www.youtube.com/user/6windsoftware

-- 
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/

Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

[Thomas Monjalon]

21/06/2021 17:54, Thierry Herbelot:
> On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> >>>>> Check Bucket key for all possible indices.
> >>>>>
> >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> >>>>> Cc: stable@dpdk.org
> >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>>>>
> >>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> >>> [...]
> >>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
> >>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
> >>>>
> >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> >>>>
> >>>> Thierry, thanks again, you could have actually added my ack from V1 :)
> >>>
> >>> The root cause looks to be a typo indeed,
> >>> but the impact or the scope of the issue
> >>> should stated in few words in the title please.
> >>> No need to send a v3, please suggest a title and I will apply.
> >>
> >> table: check a bucket is empty for all bucket keys
> >>
> >> 	Thierry
> >>
> > 
> > Hi Thierry,
> > 
> > I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you?

No need to send a v3.
> 
> Hello Cristian
> 
> Sure !
> 
> What do you think of this title:
> 
> "table: check a bucket is empty for all bucket keys"

This title suggests it was not the intent before.
It should say that it fixes this check,
or better, name the area of the API which is fixed.

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, June 21, 2021 5:15 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Thierry Herbelot
> <thierry.herbelot@6wind.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
> 
> 21/06/2021 17:54, Thierry Herbelot:
> > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> > >>>>> Check Bucket key for all possible indices.
> > >>>>>
> > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> > >>>>> Cc: stable@dpdk.org
> > >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > >>>>>
> > >>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > >>> [...]
> > >>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> >sig[2])
> > >>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> >sig[3])
> > >>>>
> > >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > >>>>
> > >>>> Thierry, thanks again, you could have actually added my ack from V1
> :)
> > >>>
> > >>> The root cause looks to be a typo indeed,
> > >>> but the impact or the scope of the issue
> > >>> should stated in few words in the title please.
> > >>> No need to send a v3, please suggest a title and I will apply.
> > >>
> > >> table: check a bucket is empty for all bucket keys
> > >>
> > >> 	Thierry
> > >>
> > >
> > > Hi Thierry,
> > >
> > > I think Thomas is asking for you to send a new version of this patch with
> the title updated. Is this OK with you?
> 
> No need to send a v3.
> >

OK, so you're going to fix the title while applying? Thanks, Thomas.


> > Hello Cristian
> >
> > Sure !
> >
> > What do you think of this title:
> >
> > "table: check a bucket is empty for all bucket keys"
> 
> This title suggests it was not the intent before.
> It should say that it fixes this check,
> or better, name the area of the API which is fixed.
> 

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

[Thierry Herbelot]

On 6/21/21 6:14 PM, Thomas Monjalon wrote:
> 21/06/2021 17:54, Thierry Herbelot:
>> On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
>>> From: Thierry Herbelot <thierry.herbelot@6wind.com>
>>>> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
>>>>>>> Check Bucket key for all possible indices.
>>>>>>>
>>>>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
>>>>>>> Cc: stable@dpdk.org
>>>>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>>>>>
>>>>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
>>>>> [...]
>>>>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2])
>>>>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3])
>>>>>>
>>>>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>>>>>>
>>>>>> Thierry, thanks again, you could have actually added my ack from V1 :)
>>>>>
>>>>> The root cause looks to be a typo indeed,
>>>>> but the impact or the scope of the issue
>>>>> should stated in few words in the title please.
>>>>> No need to send a v3, please suggest a title and I will apply.
>>>>
>>>> table: check a bucket is empty for all bucket keys
>>>>
>>>> 	Thierry
>>>>
>>>
>>> Hi Thierry,
>>>
>>> I think Thomas is asking for you to send a new version of this patch with the title updated. Is this OK with you?
> 
> No need to send a v3.
>>
>> Hello Cristian
>>
>> Sure !
>>
>> What do you think of this title:
>>
>> "table: check a bucket is empty for all bucket keys"
> 
> This title suggests it was not the intent before.
> It should say that it fixes this check,
> or better, name the area of the API which is fixed.


"table: all keys must be checked to declare that a bucket is empty"

> 
> 

-- 
Thierry Herbelot
Senior Software Engineer
Tel: +33 1 39 30 92 61
http://www.6wind.com/

Follow us:
https://www.linkedin.com/company/6wind/
https://twitter.com/6WINDsoftware
https://www.youtube.com/user/6windsoftware

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

[Dumitrescu, Cristian]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dumitrescu, Cristian
> Sent: Monday, June 21, 2021 5:56 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Thierry Herbelot
> <thierry.herbelot@6wind.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo
> 
> 
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Monday, June 21, 2021 5:15 PM
> > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Thierry Herbelot
> > <thierry.herbelot@6wind.com>
> > Cc: dev@dpdk.org; stable@dpdk.org
> > Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
> >
> > 21/06/2021 17:54, Thierry Herbelot:
> > > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > > > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> > > >>>>> Check Bucket key for all possible indices.
> > > >>>>>
> > > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> > > >>>>> Cc: stable@dpdk.org
> > > >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > >>>>>
> > > >>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > >>> [...]
> > > >>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > >sig[2])
> > > >>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > >sig[3])
> > > >>>>
> > > >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > >>>>
> > > >>>> Thierry, thanks again, you could have actually added my ack from V1
> > :)
> > > >>>
> > > >>> The root cause looks to be a typo indeed,
> > > >>> but the impact or the scope of the issue
> > > >>> should stated in few words in the title please.
> > > >>> No need to send a v3, please suggest a title and I will apply.
> > > >>
> > > >> table: check a bucket is empty for all bucket keys
> > > >>
> > > >> 	Thierry
> > > >>
> > > >
> > > > Hi Thierry,
> > > >
> > > > I think Thomas is asking for you to send a new version of this patch with
> > the title updated. Is this OK with you?
> >
> > No need to send a v3.
> > >
> 
> OK, so you're going to fix the title while applying? Thanks, Thomas.
> 
> 

Hi Thomas,

I see this fix is not yet applied, is there any action required?

Thanks,
Cristian

> > > Hello Cristian
> > >
> > > Sure !
> > >
> > > What do you think of this title:
> > >
> > > "table: check a bucket is empty for all bucket keys"
> >
> > This title suggests it was not the intent before.
> > It should say that it fixes this check,
> > or better, name the area of the API which is fixed.
> >

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

[Thomas Monjalon]

29/06/2021 13:35, Dumitrescu, Cristian:
> From: dev <dev-bounces@dpdk.org> On Behalf Of Dumitrescu, Cristian
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 21/06/2021 17:54, Thierry Herbelot:
> > > > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > > > > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> > > > >>>>> Check Bucket key for all possible indices.
> > > > >>>>>
> > > > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> > > > >>>>> Cc: stable@dpdk.org
> > > > >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > >>>>>
> > > > >>>>> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > > >>> [...]
> > > > >>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > > >sig[2])
> > > > >>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > > >sig[3])
> > > > >>>>
> > > > >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > >>>>
> > > > >>>> Thierry, thanks again, you could have actually added my ack from V1
> > > :)
> > > > >>>
> > > > >>> The root cause looks to be a typo indeed,
> > > > >>> but the impact or the scope of the issue
> > > > >>> should stated in few words in the title please.
> > > > >>> No need to send a v3, please suggest a title and I will apply.
> > > > >>
> > > > >> table: check a bucket is empty for all bucket keys
> > > > >>
> > > > >> 	Thierry
> > > > >>
> > > > >
> > > > > Hi Thierry,
> > > > >
> > > > > I think Thomas is asking for you to send a new version of this patch with
> > > the title updated. Is this OK with you?
> > >
> > > No need to send a v3.
> > 
> > OK, so you're going to fix the title while applying? Thanks, Thomas.
> 
> Hi Thomas,
> 
> I see this fix is not yet applied, is there any action required?

The proposed title is not fantastic. Last one is:
table: all keys must be checked to declare that a bucket is empty

I just need a title showing what is fixed.
What is the impact of the bug in bkt_is_empty()?

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, June 29, 2021 2:41 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Thierry Herbelot
> <thierry.herbelot@6wind.com>
> Cc: dev@dpdk.org; stable@dpdk.org; david.marchand@redhat.com
> Subject: Re: [dpdk-stable] [PATCH v2] table: fix typo
> 
> 29/06/2021 13:35, Dumitrescu, Cristian:
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Dumitrescu, Cristian
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 21/06/2021 17:54, Thierry Herbelot:
> > > > > On 6/21/21 5:44 PM, Dumitrescu, Cristian wrote:
> > > > > > From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > > > >> On 6/17/21 9:01 AM, Thomas Monjalon wrote:
> > > > > >>>>> Check Bucket key for all possible indices.
> > > > > >>>>>
> > > > > >>>>> Fixes: d0a00966618ba ("table: add exact match SWX table")
> > > > > >>>>> Cc: stable@dpdk.org
> > > > > >>>>> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > > >>>>>
> > > > > >>>>> Signed-off-by: Thierry Herbelot
> <thierry.herbelot@6wind.com>
> > > > > >>> [...]
> > > > > >>>>> -	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt-
> > > > >sig[2])
> > > > > >>>>> +	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2]
> && !bkt-
> > > > >sig[3])
> > > > > >>>>
> > > > > >>>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > > > > >>>>
> > > > > >>>> Thierry, thanks again, you could have actually added my ack
> from V1
> > > > :)
> > > > > >>>
> > > > > >>> The root cause looks to be a typo indeed,
> > > > > >>> but the impact or the scope of the issue
> > > > > >>> should stated in few words in the title please.
> > > > > >>> No need to send a v3, please suggest a title and I will apply.
> > > > > >>
> > > > > >> table: check a bucket is empty for all bucket keys
> > > > > >>
> > > > > >> 	Thierry
> > > > > >>
> > > > > >
> > > > > > Hi Thierry,
> > > > > >
> > > > > > I think Thomas is asking for you to send a new version of this patch
> with
> > > > the title updated. Is this OK with you?
> > > >
> > > > No need to send a v3.
> > >
> > > OK, so you're going to fix the title while applying? Thanks, Thomas.
> >
> > Hi Thomas,
> >
> > I see this fix is not yet applied, is there any action required?
> 
> The proposed title is not fantastic. Last one is:
> table: all keys must be checked to declare that a bucket is empty
> 
> I just need a title showing what is fixed.
> What is the impact of the bug in bkt_is_empty()?
> 

Hi Thomas,

How about this one:

	table: fix bucket empty logic

	Due to a typo, only 3 our of 4 keys in the bucket of the exact match table were considered, which can result in valid keys being incorrectly dropped from the table.

Regards,
Cristian

Re: [dpdk-dev] [dpdk-stable] [PATCH v2] table: fix typo

[Dumitrescu, Cristian]

> > > > > > > Hi Thierry,
> > > > > > >
> > > > > > > I think Thomas is asking for you to send a new version of this patch
> > with
> > > > > the title updated. Is this OK with you?
> > > > >
> > > > > No need to send a v3.
> > > >
> > > > OK, so you're going to fix the title while applying? Thanks, Thomas.
> > >
> > > Hi Thomas,
> > >
> > > I see this fix is not yet applied, is there any action required?
> >
> > The proposed title is not fantastic. Last one is:
> > table: all keys must be checked to declare that a bucket is empty
> >
> > I just need a title showing what is fixed.
> > What is the impact of the bug in bkt_is_empty()?
> >
> 
> Hi Thomas,
> 
> How about this one:
> 
> 	table: fix bucket empty logic
> 
> 	Due to a typo, only 3 our of 4 keys in the bucket of the exact match
> table were considered, which can result in valid keys being incorrectly
> dropped from the table.
> 
> Regards,
> Cristian

Hi Thomas,

Ping,

[dpdk-dev] [PATCH V3] table: fix bucket empty logic

[Thierry Herbelot]

Due to a typo, only 3 out of 4 keys in the bucket of the exact match
table were considered, which can result in valid keys being
incorrectly dropped from the table.

Fixes: d0a00966618ba ("table: add exact match SWX table")
Cc: stable@dpdk.org
Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
--
V3: reword commit log
V2: reword patch title
---
 lib/table/rte_swx_table_em.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/table/rte_swx_table_em.c b/lib/table/rte_swx_table_em.c
index 788e25f6b912..03b28c4c9da0 100644
--- a/lib/table/rte_swx_table_em.c
+++ b/lib/table/rte_swx_table_em.c
@@ -280,7 +280,7 @@ table_key_data(struct table *t, uint32_t key_id)
 static inline int
 bkt_is_empty(struct bucket_extension *bkt)
 {
-	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[2]) ?
+	return (!bkt->sig[0] && !bkt->sig[1] && !bkt->sig[2] && !bkt->sig[3]) ?
 		1 : 0;
 }
 
-- 
2.29.2

Re: [dpdk-dev] [PATCH V3] table: fix bucket empty logic

[Dumitrescu, Cristian]

> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Wednesday, July 7, 2021 12:19 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; Thomas Monjalon
> <thomas@monjalon.net>; stable@dpdk.org; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Subject: [PATCH V3] table: fix bucket empty logic
> 
> Due to a typo, only 3 out of 4 keys in the bucket of the exact match
> table were considered, which can result in valid keys being
> incorrectly dropped from the table.
> 
> Fixes: d0a00966618ba ("table: add exact match SWX table")
> Cc: stable@dpdk.org
> Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V3: reword commit log
> V2: reword patch title
> ---
>  lib/table/rte_swx_table_em.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Re: [dpdk-dev] [PATCH V3] table: fix bucket empty logic

[Thomas Monjalon]

> > Due to a typo, only 3 out of 4 keys in the bucket of the exact match
> > table were considered, which can result in valid keys being
> > incorrectly dropped from the table.
> > 
> > Fixes: d0a00966618ba ("table: add exact match SWX table")
> > Cc: stable@dpdk.org
> > Cc: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> > 
> > Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Applied, thanks