From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34D62A0C52; Thu, 19 Aug 2021 18:21:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B6FFD4013F; Thu, 19 Aug 2021 18:21:19 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 3BA384003D for ; Thu, 19 Aug 2021 18:21:18 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10081"; a="238711583" X-IronPort-AV: E=Sophos;i="5.84,335,1620716400"; d="scan'208";a="238711583" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2021 09:21:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,335,1620716400"; d="scan'208";a="489725197" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga008.fm.intel.com with ESMTP; 19 Aug 2021 09:21:16 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 19 Aug 2021 09:21:15 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 19 Aug 2021 09:21:15 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 19 Aug 2021 09:21:15 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Thu, 19 Aug 2021 09:21:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LjxSXo5rMDOE7+4/jjIuEm8Oa3JS6iUMujTlpF5qhqI2OcJ9VhGSqiynQCSYgtGe28yFEt8Nt+8d48XJmBcuTwy17VJ4/iP6AyprXKygpTfXTep8ZBK8IVj9qqK45m5PiAVGtb9ZSSJoy9a39YncbwOzaRogp51PgckAPno2POs/Hl1ntQ8GkG5ZwY578fY1v7qyowW2/0Eb2nsvWiYVesqCn31jTAsCHAf5SmOyvqiUmDI8svGgUkoRfchP3ofYT/nD+3I4n+n1uDBjh3B4dC2BFfkQqvyX7eYCQTOC3JA79bbNn0HSFzqAysNXvaVVLgjX0c8jTVcKE+2MZ4Jymg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4UZbgZyTnRqXTn5AbBPXqjnTryakieU7RfA2sKGcQ+A=; b=TCGXMcTKdp9cV7Rny69txPqy+5aa5qSw6LQ772GVW7BrR0HDdRJ69/BeDPYfanzq9YKIBkgYyWzMctOXhJ3DM0JdiHDreJxLZ6BBVujxtBIFLw+GbaoUBu0ZAm6/g5dGIwqcYyLBOrXIe2ERBBdml5zCOGa+Om/2wkJywX8Vdq0Ft1e8uCrhuLkxwLiQ99fm9OGa+xcF+kD7Y/SIDx9c1iLjhgAZjMfN7oUURakIjc8rpU0hpv9xKixXgEuJAF8v38o6Pu7xkXOQpr57oOs3xnNu8dOnUW0ZaLvNWdTEXH/s/muOSY2fh0m8YdtjFQXDXXTVyfIKRsgOTB8RZAt8ZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4UZbgZyTnRqXTn5AbBPXqjnTryakieU7RfA2sKGcQ+A=; b=XxjSPrskRRNJjBEQGtnOmIaeWMiLsbVxg0v+Df++p1AwIpCCreWsTpvtn6zjF+i2AUfi4sbrZco8oiPSH//6ektZuapXcyJA/0Gn87jWloE0iix0NTzdT3fsPdMc8gKmtM4O/zMOJv59hAOkSxI8pVaVvqaM2Vq4uVtXEV+SVmQ= Received: from DM6PR11MB2890.namprd11.prod.outlook.com (2603:10b6:5:63::20) by DM6PR11MB4362.namprd11.prod.outlook.com (2603:10b6:5:1dd::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.19; Thu, 19 Aug 2021 16:21:14 +0000 Received: from DM6PR11MB2890.namprd11.prod.outlook.com ([fe80::867:8350:9cce:66e0]) by DM6PR11MB2890.namprd11.prod.outlook.com ([fe80::867:8350:9cce:66e0%7]) with mapi id 15.20.4415.024; Thu, 19 Aug 2021 16:21:14 +0000 From: "Iremonger, Bernard" To: Sowmini Varadhan CC: "sowmini05@gmail.com" , "dev@dpdk.org" , "thomas@monjalon.net" Thread-Topic: [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp Thread-Index: AQHXlEH3AmyHCiVG10m3os21jenGiat66OkQgAAKEACAAA/VgA== Date: Thu, 19 Aug 2021 16:21:14 +0000 Message-ID: References: <9085a3881fabec43eeeb5b3227c569cf559648a2.1629287046.git.sovaradh@linux.microsoft.com> <20210819152009.GA24347@microsoft.com> In-Reply-To: <20210819152009.GA24347@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a8a49b9e-eed0-4e1d-010f-08d9632d5d8d x-ms-traffictypediagnostic: DM6PR11MB4362: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: xOTCa5ZP0SbuOWjec1+OjFkjxcmXmaUM/axdsiLoCS22cUecjBWiiSpggNwuHcXgwxoKtB5OsUUP9G0qJJswuqg9mMracIhe2yDMOgCAnHF2Uo1mTGn7Qa9LPDr9iSGykt395leb0UJP1pMPLlRGVzgjM4OwuFaGJeWGjNioiPgTTJ+FdT2+iBpfCdztDis4rKh5667ob2k1pzPMTjSD5aO2QxbtVVhiWJT5/ppgJiVoRrBSiTspuIl5+ZAfh1u67HSpjgbiWF14nXXO9ipQnFW/1INoNGsRMrBIgsIrcv0NgWGZTBd8fne0nEWFp/xYpPzzSZmt312GN70UNqfBUffh29dUFs8l5LN3RTIXrNQagxYi6lu793voPelJr92lXypi+MutZiC4uiK3rsUXdQnpVlc5M8NdPQLyRBw+erX6M3wDjogTHq+pky9Bp+UCbE60XGyjkw5AX3uGqKKqSN8jJiIoAOQDrNosxw3jCp2lNi9KbhsUVygKHuRv+SPR17p1Y57aCQMNlRTGUG8r/xmVi7mlCUdQHe2Bp5T9slrFfasufkr8LuYl5usWa1bpTo41/P0gVZT8qevksJT3GAjUA7g3zKm9fzDZoWmYdI1l74bvmLKg88LuhxN8JPdrXAMegi6/OpBTNNRTWXUAm7RT5hLzg/x3O4r/dFH4tYuTXWYPttGQdLf9g+JE5lWNOnRzOfn531y9fTeV0lfXNA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2890.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(4326008)(52536014)(54906003)(9686003)(55016002)(38100700002)(316002)(66556008)(66476007)(86362001)(83380400001)(8936002)(8676002)(2906002)(66946007)(64756008)(66446008)(122000001)(76116006)(5660300002)(7696005)(38070700005)(71200400001)(26005)(6916009)(508600001)(186003)(53546011)(6506007)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pU7/EWN8Kc5CeLeBm5e97PdhPPqa1zkIhGf+cYFtkOYJHTnTyY7VJUkfj3sS?= =?us-ascii?Q?gsRG9qdrpfzhSSm3b7fJX9QTvNOtyp/y457dTWzSzkBDIXwwL0lhFZbI+syU?= =?us-ascii?Q?Lczx5YlfCi9Zy5jRwvQVR+lA6Z3YOz1Ts08J9xCfccINgxyXcnprmzqWVNsz?= =?us-ascii?Q?LvVZRWcH+Iw1G+ck2D/D1F4q/ChDZbM3O7kG4e0n9usikIGpYGUySP33KFbZ?= =?us-ascii?Q?8oiooU9U4yNcPNz1lwRc001UwdetTejrwdxlK0NP8zIqjlcO/JXGYEeraacn?= =?us-ascii?Q?AFfpWATLJroNQRQd6nNPM8D2MkwjrshI+XPofXXbw7d0MYNGL9WA7pNzBy7H?= =?us-ascii?Q?T+s30mosDyv+DBecmiKfDfYpkR7OyTG9Xdci+BPX/sO97SKOHc/a80NAncXS?= =?us-ascii?Q?u8mHxYXaZGd17L99bo9JSRM+VF2ZAEosCP2SJuBBVdEiXv3SoVSpTIkPY21O?= =?us-ascii?Q?f63iVWu6MrIyfyvsmn3nLvexkz2kva0Tdk4QmmNF2oNIFGgtArdLEEikzCg+?= =?us-ascii?Q?16t/lQU1JHuzQIEUbjgHxgetLFUMdx0nbnFVW1O5f2GT9rXniG6tdvca/XhG?= =?us-ascii?Q?sG2B1k2PCArHUbohj8cEzTiZ8dFCeGjJIe02kjFG6W82+UicwfAGZ8qWmbEp?= =?us-ascii?Q?dOKJtCergWlw8y6xf53xpYeWfv1zaF5KqGYoTWbhDxSguzMbKAi3OSxwyMsu?= =?us-ascii?Q?mgctfvQmr3qbr7siytw6um039fDGcIqJcmSwpmBNu82JsjnV0uPS1ympNdzZ?= =?us-ascii?Q?vTL2a928MKAckwSiZ9XQZFOSYTz6Lx46KSCer2QQNOwTfTSvkAWDPNcZZmRh?= =?us-ascii?Q?zKfIN7k/uwa7Z97a7bDs2QIPGBEzplcOkg+bccoCQuo7MF9ITkJ9FgsO0Xj4?= =?us-ascii?Q?BoUOngjKas4jB34XXy1jeagX4O65kpvNlaQ4DNp7SegWDX2Pj0GWM6XD4e1p?= =?us-ascii?Q?hhSg8XZo1kDzZ2htGIhz0f6v9LFQBZdEgCQ8h5/K94w2cObhdgKKeup6NyT0?= =?us-ascii?Q?mcGhs78M5IX2ey7pIc5pBKh/8G+AumGlH7X+OVFPEtcQFWHGRi3yF5keaO7v?= =?us-ascii?Q?p/GkrZLPW51/dKS+wwUJhuinkk+icPh4EKj3SmeSaJ+OcLhlRUqNjULOXZDk?= =?us-ascii?Q?dvtaF657xL2qK+0Ml/lFgV32gGc46zYGFEPF0PahQvWmoLMASxxsat+hAtT3?= =?us-ascii?Q?IOXqufFdgW3lk91iP9Qno1Rnpv14+4jpRyNQd/6K+SoiWKHMC+M0CXb+YjjW?= =?us-ascii?Q?mAvVjJG/fzT4wXsx2Ab8ZSS8aZokML0MYy6oYN+/22Vqo5+ZZFTwuI1G+tcl?= =?us-ascii?Q?AgI/IHEBo3jM+kza3/D7daH1?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2890.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8a49b9e-eed0-4e1d-010f-08d9632d5d8d X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Aug 2021 16:21:14.2476 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PuuS3tN+A5LQbCn+7uD90BYo8b1AoxyuwStsqzYWl/6XvZLd/vLXhCq2SxlYLp5piE4utc1Msfzw7vfSERkCA1RtRQEkI1C5xHKIqcMDYzk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4362 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Sowmini, Looking closer at this patchset, I am not sure that a second ACL table is n= eeded. The existing ACL table handles UDP, TCP and SCP, however it is not processi= ng the TCP flags. I think it just needs to be modified to process the TCP flags. Could you take another look to see if the above proposed solution will work= for you. Regards, Bernard.=20 > -----Original Message----- > From: Sowmini Varadhan > Sent: Thursday, August 19, 2021 4:21 PM > To: Iremonger, Bernard > Cc: sowmini05@gmail.com; dev@dpdk.org; thomas@monjalon.net > Subject: Re: [PATCH v2 2/2] examples/flow_classify: add an ACL table for = tcp >=20 > On (08/19/21 15:06), Iremonger, Bernard wrote: > > > v2 updates: typo fixes for checkpatch, bernard.iremonger comments > > > > The above line should not be added to the commit message. > > ~/dpdk/devtools/check-git-log.sh -1 > > Wrong tag: > > v2 fixes: typo fixes, get_tcp_flags returns -EINVAL > > > > The check-git-log.sh script is in your dpdk checkout, best to run this= script > before sending patches >=20 > apologies, I was not aware of this, I will fix and send out v3. > I did run check-git-log.sh but before editing the vX updates. >=20 > thanks for your patience. >=20 > --Sowmini