DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: "Ji, Kai" <kai.ji@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>
Subject: Re: [dpdk-dev] [dpdk-dev v1] cperf: fix crypto perf out-of-place mempool alloc
Date: Fri, 21 May 2021 09:04:45 +0000	[thread overview]
Message-ID: <DM6PR11MB30493DCB630F314313C343ECB8299@DM6PR11MB3049.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210520150711.28196-1-kai.ji@intel.com>

> -----Original Message-----
> From: Ji, Kai <kai.ji@intel.com>
> Sent: Thursday, May 20, 2021 4:07 PM
> To: dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Ji, Kai <kai.ji@intel.com>;
> De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev v1] cperf: fix crypto perf out-of-place mempool alloc
> 
> Add in missing rte_mbuf size in mempool allocation for out-of-place op.
> 
> Fixes: bf9d6702eca9 ("app/crypto-perf: use single mempool")
> Cc: pablo.de.lara.guarch@intel.com
> 
> Signed-off-by: Kai Ji <kai.ji@intel.com>
> ---
>  app/test-crypto-perf/cperf_test_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/test-crypto-perf/cperf_test_common.c b/app/test-crypto-
> perf/cperf_test_common.c
> index 058e0ba564..12925c7f22 100644
> --- a/app/test-crypto-perf/cperf_test_common.c
> +++ b/app/test-crypto-perf/cperf_test_common.c
> @@ -194,7 +194,7 @@ cperf_alloc_common_memory(const struct
> cperf_options *options,
>  				(mbuf_size * segments_nb);
>  		params.dst_buf_offset = *dst_buf_offset;
>  		/* Destination buffer will be one segment only */
> -		obj_size += max_size;
> +		obj_size += max_size + sizeof(struct rte_mbuf);
>  	}
> 
>  	*pool = rte_mempool_create_empty(pool_name,
> --
> 2.17.1

Acked-by: Fan Zhang <roy.fan.zhang@intel.com>


  reply	other threads:[~2021-05-21  9:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 15:07 Kai Ji
2021-05-21  9:04 ` Zhang, Roy Fan [this message]
2021-05-21 11:18   ` De Lara Guarch, Pablo
2021-05-21 15:36     ` Thomas Monjalon
2021-05-24  7:23       ` Zhang, Roy Fan
2021-05-24 16:46 ` [dpdk-dev] [dpdk-dev v2] test/crypto-perf: " Kai Ji
2021-06-29 20:11   ` [dpdk-dev] [EXT] " Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB30493DCB630F314313C343ECB8299@DM6PR11MB3049.namprd11.prod.outlook.com \
    --to=roy.fan.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=kai.ji@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).