From: "Xing, Beilei" <beilei.xing@intel.com>
To: Raja Zidane <rzidane@nvidia.com>,
"Singh, Aman Deep" <aman.deep.singh@intel.com>,
Matan Azrad <matan@nvidia.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode
Date: Wed, 16 Feb 2022 02:02:54 +0000 [thread overview]
Message-ID: <DM6PR11MB309826018DA91D6D9A75F8E1F7359@DM6PR11MB3098.namprd11.prod.outlook.com> (raw)
In-Reply-To: <BYAPR12MB459875A1BD54A26F039A5AF8C7349@BYAPR12MB4598.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 9391 bytes --]
Hi Zidane,
I40e used UDP dst port 4789 for Vxlan.
BR,
Beilei
From: Raja Zidane <rzidane@nvidia.com>
Sent: Tuesday, February 15, 2022 10:31 PM
To: Singh, Aman Deep <aman.deep.singh@intel.com>; Matan Azrad <matan@nvidia.com>; Yigit, Ferruh <ferruh.yigit@intel.com>; dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
Cc: stable@dpdk.org
Subject: RE: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode
Hi all,
reviving the discussion.
@Beilei Xing<mailto:beilei.xing@intel.com> could you please provide info on what UDP destination ports are used for VxLan by i40 driver?
if its just the default then we can remove "RTE_ETH_IS_TUNNEL_PKT(pkt_type) == 0"
From: Singh, Aman Deep <aman.deep.singh@intel.com<mailto:aman.deep.singh@intel.com>>
Sent: Monday, January 31, 2022 6:48 PM
To: Raja Zidane <rzidane@nvidia.com<mailto:rzidane@nvidia.com>>; Matan Azrad <matan@nvidia.com<mailto:matan@nvidia.com>>; Ferruh Yigit <ferruh.yigit@intel.com<mailto:ferruh.yigit@intel.com>>; dev@dpdk.org<mailto:dev@dpdk.org>; Beilei Xing <beilei.xing@intel.com<mailto:beilei.xing@intel.com>>; Qi Zhang <qi.z.zhang@intel.com<mailto:qi.z.zhang@intel.com>>
Cc: stable@dpdk.org<mailto:stable@dpdk.org>
Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode
External email: Use caution opening links or attachments
On 1/30/2022 4:48 PM, Raja Zidane wrote:
I didn't want to remove the default parsing of tunnel as VxLan because I thought it might be used,
Instead I moved it to the end, which makes it detect all supported tunnel through udp_dst_port,
And only if no tunnel was matched it would default to VxLan.
That was the reason geneve weren't detected and parsed as vxlan instead, which is the bug I was trying to solve.
We can take help/input from i40 maintainers for it.
Hi Beilei Xing,
For setting packet_type as Tunnel, what criteria is used by i40 driver. Is it only udp_dst port or any other parameters also.
-----Original Message-----
From: Singh, Aman Deep <aman.deep.singh@intel.com><mailto:aman.deep.singh@intel.com>
Sent: Thursday, January 20, 2022 12:47 PM
To: Matan Azrad <matan@nvidia.com><mailto:matan@nvidia.com>; Ferruh Yigit <ferruh.yigit@intel.com><mailto:ferruh.yigit@intel.com>; Raja Zidane <rzidane@nvidia.com><mailto:rzidane@nvidia.com>; dev@dpdk.org<mailto:dev@dpdk.org>
Cc: stable@dpdk.org<mailto:stable@dpdk.org>
Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward mode
External email: Use caution opening links or attachments
On 1/18/2022 6:49 PM, Matan Azrad wrote:
app/test-pmd/csumonly.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index 2aeea243b6..fe810fecdd 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -254,7 +254,10 @@ parse_gtp(struct rte_udp_hdr *udp_hdr,
info->l2_len += RTE_ETHER_GTP_HLEN;
}
-/* Parse a vxlan header */
+/*
+ * Parse a vxlan header.
+ * If a tunnel is detected in 'pkt_type' it will be parsed by default as vxlan.
+ */
static void
parse_vxlan(struct rte_udp_hdr *udp_hdr,
struct testpmd_offload_info *info, @@ -912,17
+915,18 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)
RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE;
goto tunnel_update;
}
- parse_vxlan(udp_hdr, &info,
- m->packet_type);
+ parse_geneve(udp_hdr, &info);
if (info.is_tunnel) {
tx_ol_flags |=
- RTE_MBUF_F_TX_TUNNEL_VXLAN;
+
+ RTE_MBUF_F_TX_TUNNEL_GENEVE;
goto tunnel_update;
}
- parse_geneve(udp_hdr, &info);
+ /* Always keep last. */
+ parse_vxlan(udp_hdr, &info,
+ m->packet_type);
if (info.is_tunnel) {
tx_ol_flags |=
- RTE_MBUF_F_TX_TUNNEL_GENEVE;
+
+ RTE_MBUF_F_TX_TUNNEL_VXLAN;
goto tunnel_update;
}
} else if (info.l4_proto ==
IPPROTO_GRE) {
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com><mailto:ferruh.yigit@intel.com>
Sent: Tuesday, January 18, 2022 3:03 PM
To: Matan Azrad <matan@nvidia.com><mailto:matan@nvidia.com>; Raja Zidane <rzidane@nvidia.com><mailto:rzidane@nvidia.com>;
dev@dpdk.org<mailto:dev@dpdk.org>
Cc: stable@dpdk.org<mailto:stable@dpdk.org>
Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum forward
mode
External email: Use caution opening links or attachments
On 1/18/2022 12:55 PM, Matan Azrad wrote:
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com><mailto:ferruh.yigit@intel.com>
Sent: Tuesday, January 18, 2022 2:28 PM
To: Matan Azrad <matan@nvidia.com><mailto:matan@nvidia.com>; Raja Zidane
<rzidane@nvidia.com><mailto:rzidane@nvidia.com>; dev@dpdk.org<mailto:dev@dpdk.org>
Cc: stable@dpdk.org<mailto:stable@dpdk.org>
Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum
forward mode
External email: Use caution opening links or attachments
On 1/18/2022 11:27 AM, Matan Azrad wrote:
-----Original Message-----
From: Ferruh Yigit <ferruh.yigit@intel.com><mailto:ferruh.yigit@intel.com>
Sent: Tuesday, January 18, 2022 11:52 AM
To: Raja Zidane <rzidane@nvidia.com><mailto:rzidane@nvidia.com>; dev@dpdk.org<mailto:dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com><mailto:matan@nvidia.com>; stable@dpdk.org<mailto:stable@dpdk.org>
Subject: Re: [PATCH] app/testpmd: fix GENEVE parsing in csum
forward mode
External email: Use caution opening links or attachments
On 12/5/2021 3:44 AM, Raja Zidane wrote:
The csum FWD mode parses any received packet to set mbuf
offloads for the transmitting burst, mainly in the checksum/TSO areas.
In the case of a tunnel header, the csum FWD tries to detect
known tunnels by the standard definition using the header'sdata
and fallback to check the packet type in the mbuf to see if the
Rx port driver already sign the packet as a tunnel.
In the fallback case, the csum assumes the tunnel is VXLAN and
parses the tunnel as VXLAN.
As far as I can see there is a VXLAN port check in
'parse_vxlan()', why it is not helping?
The problem is not the vxlan check but the tunnel type in mbuf
that caused the
packet to be detected as vxlan(default) before checking GENEVE tunnel case.
Check is as following:
if (udp_hdr->dst_port != _htons(RTE_VXLAN_DEFAULT_PORT) &&
RTE_ETH_IS_TUNNEL_PKT(pkt_type) == 0)
return;
Do you what is the intention for the
"RTE_ETH_IS_TUNNEL_PKT(pkt_type) ==
0"
check?
Why vxlan parsing doesn't stop when it is not default port?
Maybe some drivers set the tunnel type for vxlan packets coming
after non-
standard vxlan port.
But checking the tunnel flag to say that it is vxlan is too broad, isn't it?
And this is the problem you are having.
Can there be any way to detect and check non-standard vxlan port?
Maybe yes, but it is probably more complex solusion.
See this patch:
https://patches.dpdk.org/project/dpdk/patch/1423819371-24222-13-git-se
nd-email-olivier.matz@6wind.com/<mailto:nd-email-olivier.matz@6wind.com/>
comments there:
1. check udp destination port, 4789 is the default vxlan port (rfc7348).
2. currently, this flag is set by i40e only if the packet is vxlan
And maybe another driver assumes more ports here.
Collecting all the non-standard ports can start from i40 maintainers😊
I think, here we should check for supported tunnel types only. The i40 driver setting a Tunnel flag, does not means that it VxLan type only.
As in your case those were GENEVE packets getting treated as VxLan.
Making parse_vxlan() udp_dst_port specific can avoid this issue.
When the GENEVE tunnel was added to the known tunnels in csum,
its parsing trial was wrongly located after the pkt type
detection, causing the csum to parse the GENEVE header as VXLAN
when the Rx port set the tunnel packet type.
Locate the GENEVE parsing trial before the packet type detection.
Fixes: ea0e711b8ae0 ("app/testpmd: add GENEVE parsing")
Cc: stable@dpdk.org<mailto:stable@dpdk.org>
Signed-off-by: Raja Zidane <rzidane@nvidia.com><mailto:rzidane@nvidia.com>
---
Acked-by: Matan Azrad <matan@nvidia.com><mailto:matan@nvidia.com>
Ack should be before '---' to be part of the commit log,
otherwise it is dropped when applied as comment.
[-- Attachment #2: Type: text/html, Size: 23193 bytes --]
next prev parent reply other threads:[~2022-02-16 2:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-05 3:44 Raja Zidane
2022-01-18 9:51 ` Ferruh Yigit
2022-01-18 11:27 ` Matan Azrad
2022-01-18 12:28 ` Ferruh Yigit
2022-01-18 12:55 ` Matan Azrad
2022-01-18 13:03 ` Ferruh Yigit
2022-01-18 13:19 ` Matan Azrad
2022-01-20 10:46 ` Singh, Aman Deep
2022-01-30 11:18 ` Raja Zidane
2022-01-31 16:47 ` Singh, Aman Deep
2022-02-15 14:31 ` Raja Zidane
2022-02-15 14:43 ` Singh, Aman Deep
2022-02-16 2:02 ` Xing, Beilei [this message]
2022-02-16 12:37 ` [PATCH V2] " Raja Zidane
2022-02-18 9:09 ` Singh, Aman Deep
2022-02-20 12:09 ` [PATCH V3] " Raja Zidane
2022-02-21 10:24 ` Singh, Aman Deep
2022-02-21 12:08 ` Ferruh Yigit
2022-02-21 13:24 ` [PATCH V4] " Raja Zidane
2022-02-21 17:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB309826018DA91D6D9A75F8E1F7359@DM6PR11MB3098.namprd11.prod.outlook.com \
--to=beilei.xing@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@nvidia.com \
--cc=qi.z.zhang@intel.com \
--cc=rzidane@nvidia.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).