From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C39EEA034F; Wed, 9 Feb 2022 08:30:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9BCD7410FD; Wed, 9 Feb 2022 08:30:51 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 2224F410F3 for ; Wed, 9 Feb 2022 08:30:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644391850; x=1675927850; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=q8hd9xOCBQLAzPB9r/Gq8msY7we7N91Ps1YJq8hQzFo=; b=Knm/bGoJB7vS2pA37DDNM1q46kwhj+kXGE+x8Pt7p5pTlafudb8PLMlK yQx8dlthMvtGZQb1jcMp+CRfPQdUna3ZZ2I+mJC03kzBs42MvenzJ/d4h 7aBE63iyQI+VmmRKxA0XHOJaklnWUYBG6FzraZSxLLfvVntY1xDbCjC5n zxDzJmmpHtKUjW8cn3Dtb9s/LoLN0hByZ3Riv2Fo3EEfNUgZbdb86fhth dyjH9wECBCDNecC6DnNBAzF1NwFjVtP/UeteFx19p6B5DpDvKb0HqfQgV 2uRESuYtCMxYbmI/JHXb2W6+MP20Xiz/M7iq1lQaDuW59ReK78EpBxXCs g==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="229116258" X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="229116258" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 23:30:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,355,1635231600"; d="scan'208";a="771255962" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 08 Feb 2022 23:30:49 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 23:30:48 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 23:30:48 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 23:30:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ktTqU3SRr+C5LgCV7Cc/4+7RqsqALm1SXC3vUjWGZGKl6imokc1nhAhaXR76TiMfjyulUltgGrBrPENniU8/IURBreGalpmwePgMWof7YOeGl6wu56d69aNSM0flShg6ruX3SLnCukezk6BT9iTDla3URTMogTGrm6Y1waKezC03FOyCv+dCWy3tFYFP+uSspujy6UjBnR8VvgUMknoEnUuNmd9JD/3IxzwTo2WEefMJRXIsbn04/9nbAvxI71jHwhzeHeJk3xEVLHXwIhw4QQ06YcujziHS3AYP8FGnZQLOZyS3hXTD+ETNR1vW9llwd753brgVd55FRlSzqUsApg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BfmjRcentQ9N0djDZKo3l7VOORm3DuaVa65B3CrxZHY=; b=j7v6NIEh3XRRK4cDEe8aF/uL55vt9n+zsk7GvUxnbHSdnXN3WcUcdCfSOvhUT9FRwImmLaYqcbo8bwdxoEgq7AqpXbUlIK6jCNHj62ts+7vRiQDRHsUkpxy5OTcRkJD3eczlxMNT2vBykflR5rVzzhadzC/JE7x4t+4WY1kozgkJZYDWF4iBFDo6yS31HnVuKA7NKlILQ6lN8Nzx44jDEJzacVtHkpNnaFHJfoNTdu6Q62t9cqXTitfmiU+F8WFJvbfh/io/ogNu0GA9cTcDmn5G3IVZ3q4Yqmxr7WnNy2YmNIIU7qL6gfMXXdl4zuNpDiTKN9nGp2YO15m0jK2WJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR11MB3098.namprd11.prod.outlook.com (2603:10b6:5:70::11) by BN0PR11MB5694.namprd11.prod.outlook.com (2603:10b6:408:167::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Wed, 9 Feb 2022 07:30:46 +0000 Received: from DM6PR11MB3098.namprd11.prod.outlook.com ([fe80::4c15:87ef:5338:e0fa]) by DM6PR11MB3098.namprd11.prod.outlook.com ([fe80::4c15:87ef:5338:e0fa%4]) with mapi id 15.20.4951.019; Wed, 9 Feb 2022 07:30:46 +0000 From: "Xing, Beilei" To: "Wang, Jie1X" , "dev@dpdk.org" CC: "Yang, SteveX" , "orika@nvidia.com" , "Singh, Aman Deep" , "Yigit, Ferruh" , "thomas@monjalon.net" , "andrew.rybchenko@oktetlabs.ru" , "Wu, Jingjing" , "Zhang, Qi Z" , "olivier.matz@6wind.com" Subject: RE: [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR Thread-Topic: [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR Thread-Index: AQHYHMdnftIyDeEXAkeM7vLOByW9O6yK0DUQ Date: Wed, 9 Feb 2022 07:30:46 +0000 Message-ID: References: <20220129062434.2455711-1-jie1x.wang@intel.com> <20220208083849.510136-1-jie1x.wang@intel.com> <20220208083849.510136-7-jie1x.wang@intel.com> In-Reply-To: <20220208083849.510136-7-jie1x.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9e9b5cce-547a-441c-3c86-08d9eb9e1650 x-ms-traffictypediagnostic: BN0PR11MB5694:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3173; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iFc+/8I38r7zM+kTrXEvqz3WlZPQuP4K76UvM2TXmrj+rxN951yJ4Sg8YI61Qj8xDcVy9zVqR9KNT4g6I+qAt2lhFDUffRYBnB1UNoQWcXtfZwJhaYTcYHP4tGoqaCezQx+KmfDutKkOx21zgkrHOdqYnMVZiQBy0JmvgIsnm3GJSzxaFzR9A9wF6jsERh5MCc8iGpIVKA99l6u7nAPm+dzvkO9RZ/WmES13ebnR2byxQB0KXIMH7WosHMgdQV8ccr2iLq3AUQ2FNDvPeDUpcUG/ApglijtkqqNYZ4J5J8t2/IO1yZAYLNMu+nmbzSoh/Loa9OLLaCao/9yTMeYPeGG7MFYxgohtzmk89eL9ToVwwBjlFMxMNDdo9OnbzsY/d9ov6shCYDBZAU/ga/51IFgidMGkxnk6j9iMWn+tAS6ytJZ4hBw2eZ5jh+l7VasrKSo29GJekFXOwOoiUU//oqaV61Ad7NwCgMmr/k+jEinTIryzv2/K8/fr6x/YbUiH1pn8oYbWSjxPYDbxbjGbIx3oqeqCOz1ji9hEwJHJt2H7/iQUVnNrfJ4IvqQPfRtNNPVw618r4HvgcGXRWIGYen+toKSaRhz7FLGN4t/36QtFoHqs3Z5xzeOPyxmV5EzqRAgJ5zrsRiNzAc5kigrn94EK7V78Q+107YM2JlLm+Detf5yYGKNb0CYTH50XIP07DNwj6sb/E4w15HysbG5/3g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3098.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8936002)(9686003)(38070700005)(52536014)(110136005)(54906003)(316002)(122000001)(86362001)(66556008)(66476007)(66446008)(64756008)(66946007)(38100700002)(76116006)(83380400001)(8676002)(4326008)(82960400001)(186003)(26005)(7696005)(508600001)(55016003)(33656002)(5660300002)(6506007)(2906002)(71200400001)(53546011); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?MnQdewgWlOYtMzooooXvE6GeHCOOF0vuETFyzyPhVKkTdz7lyqZICSJTHc+p?= =?us-ascii?Q?dUk6lbptd6EX2YknCz7kg4GGQP8xZnc+WCmR+GPkslusd0OJixJBwSzlZTHe?= =?us-ascii?Q?iHEKhb270acBijTGBbiWIf4SUZP7ucl0kaazQuMTfBxrsCooqN+F36AK2jHg?= =?us-ascii?Q?OJZ+MTt0/bd7wfk/cXpAVvwoRJgDTo96Qz/MpCsWlChBktsV7qi1LJNfLTqm?= =?us-ascii?Q?A01Kn5CiAgBUg0Mvq9iFRrFS3Vxi6SAC4xmwq7/IqM+tRMNzCl96vlC8hOFa?= =?us-ascii?Q?BPPQ/wIfy+5vmRJ4bBAajQS/P1ExW1BX3zHlFXurAo9WiBBQBV0ISnwZreLl?= =?us-ascii?Q?+hwc5GJ+9ISbCl8BgROdIkOwt4BuvdYrnHOQQoG96R6Ww0LIqSRRIvB9Pn+Z?= =?us-ascii?Q?pxW8K0HKPrO3AkmFYk0YEmAYbLVW5NhYDNHYnkeaUT6qGGKBCpQtzYPVPOML?= =?us-ascii?Q?TovZyCeReQdaLsuZrxuzp0Wo7iU2FSfGPMApNvGGXADmsjTZA2lNRzZBZc9P?= =?us-ascii?Q?H+YAoex1hs4yLRuwhHA5pOhxJICpz7+yX4Or93XaDKKP5pTlhduzH+07RMUj?= =?us-ascii?Q?ZEMzOj+/uOy+AMlov1vXoMYzSNff/sTicY7YzhRFwLjg3CqQG8sA6lCaAKLl?= =?us-ascii?Q?nTuE/7O3XDbt8WbjBl8YHiJkBjF6U8cJXDdHGnpLW5EBUKr2U7eHhzEkfbsB?= =?us-ascii?Q?VzpAw53JojXDv7lr20msT4qtxs6qXTmnTTPeHDbA2elF+0Utwoh+Lxv+Hrlb?= =?us-ascii?Q?z0IZkX00dOqJato04RxdUVt4saxb4ql4gXWDYZKDxORSieYXsNac/237WVAK?= =?us-ascii?Q?MgPzvWqfAxPSUgOHSbDl42lQvpHP3K1ZPbfvowWoNpW3poYch0GZd3UHhD7O?= =?us-ascii?Q?ZFIUk28+ZOOkuD6lvAf/F4BcF7J0v2f4PvTNv/7CR93BaBdv1tvns1iiSISD?= =?us-ascii?Q?hqNOpLQSEvsh7NsF0SG9ybVI4adOo+TKzwzjlp0zmcepOQ1f3/y1QTTdCw0x?= =?us-ascii?Q?zzUBnuErG9hszBFgD0BmoTOhMFWidccqLcVSlW0HEA+y/+nL5I9S6OPKbwQv?= =?us-ascii?Q?U1EHdM18LA3QBx//xG6O/+0BnwK40GYJVILe+1fACBGL4b5yAZqUWHFZciin?= =?us-ascii?Q?J3eq0h49sKw7Y92l8OP6GezsUbPvwd4qQIesrFmIFtftDsNDBTaUvI7HMeXM?= =?us-ascii?Q?XFria2Kp5WqX2LyaZPT76SSB6MYHX3wKLdlJMo5a2OOrIdcZuaeihD7IDZwf?= =?us-ascii?Q?L1JmKJpYwxZNBR9aOXOsFqumd0tsJGBh5pODrSdtGrNIJfUm8WIakXPCeTjs?= =?us-ascii?Q?oR09iueJRPvBKa1L/ttZYuAE4ZK3pKPd0nRXbgfdt3n6tZht13URAubybUNy?= =?us-ascii?Q?12ZpJ1DsCWpl5frGoE5dfmP+k8vPnafmCdC1Qi1er4ahr4FJvsS/lNZcaxzc?= =?us-ascii?Q?WpPe1qH6zgx/ws8nhlP5dNH9oWB+ocL1zpNYG2XFnJW13tJ5sBKEKkZTofTe?= =?us-ascii?Q?OB16pH4UYStYeC20yB3KeyXzdTu2y9KarfByKRxOq2cE021N0XPgN8+3onto?= =?us-ascii?Q?8oIwdjgx1uN1hgvKJQDJEZEE1VdTAsfGmAV4JxDVvncVnn/YBRy7fOGPeRqO?= =?us-ascii?Q?bw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3098.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e9b5cce-547a-441c-3c86-08d9eb9e1650 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Feb 2022 07:30:46.0884 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nAw4jyijddgpuMX8dtc9mjX3e7SZMjtc+Jan25NX7IpPJ4x8wcaI2T+MNqqg/uQgEoah2F/ZMk6O3d9UUtC3RQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR11MB5694 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Wang, Jie1X > Sent: Tuesday, February 8, 2022 4:39 PM > To: dev@dpdk.org > Cc: Yang, SteveX ; orika@nvidia.com; Singh, Aman > Deep ; Yigit, Ferruh ; > thomas@monjalon.net; andrew.rybchenko@oktetlabs.ru; Wu, Jingjing > ; Xing, Beilei ; Zhang, Qi = Z > ; olivier.matz@6wind.com; Wang, Jie1X > > Subject: [PATCH v4 6/6] net/iavf: support L2TPv2 for AVF FDIR >=20 > Add support for L2TPv2(include PPP over L2TPv2) protocols FDIR based on o= uter > MAC src address and L2TPv2 session ID. >=20 > Add support for PPPoL2TPv2oUDP protocols FDIR based on inner IP src/dst > address and UDP/TCP src/dst port. >=20 > Patterns are listed below: > eth/ipv4(6)/udp/l2tpv2 > eth/ipv4(6)/udp/l2tpv2/ppp >=20 > eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6) > eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)/udp > eth/ipv4(6)/udp/l2tpv2/ppp/ipv4(6)/tcp >=20 > Signed-off-by: Jie Wang > --- > doc/guides/rel_notes/release_22_03.rst | 8 +- > drivers/net/iavf/iavf_fdir.c | 174 +++++++++++++++++++++---- > drivers/net/iavf/iavf_generic_flow.h | 4 + > 3 files changed, 156 insertions(+), 30 deletions(-) >=20 > diff --git a/doc/guides/rel_notes/release_22_03.rst > b/doc/guides/rel_notes/release_22_03.rst > index 0d1e4a0b61..5a73ccc14e 100644 > --- a/doc/guides/rel_notes/release_22_03.rst > +++ b/doc/guides/rel_notes/release_22_03.rst > @@ -66,8 +66,12 @@ New Features >=20 > * **Updated Intel iavf driver.** >=20 > - Added L2TPv2(include PPP over L2TPv2) RSS hash distribute packets > - based on outer MAC src address and L2TPv2 session ID. > + * Added L2TPv2(include PPP over L2TPv2) RSS hash distribute packets > + based on outer MAC src address and L2TPv2 session ID. Should fix in the patch 5/6. > + * Added L2TPv2(include PPP over L2TPv2) FDIR distribute packets > + based on outer MAC src address and L2TPv2 session ID. > + * Added PPPoL2TPv2oUDP FDIR distribute packets based on inner IP > + src/dst address and UDP/TCP src/dst port. >=20 >=20 > Removed Items > diff --git a/drivers/net/iavf/iavf_fdir.c b/drivers/net/iavf/iavf_fdir.c = index > b63aaca91d..2583b899aa 100644 > --- a/drivers/net/iavf/iavf_fdir.c > +++ b/drivers/net/iavf/iavf_fdir.c > @@ -168,6 +168,31 @@ > IAVF_FDIR_INSET_GRE_IPV6 | IAVF_INSET_TUN_UDP_SRC_PORT | \ > IAVF_INSET_TUN_UDP_DST_PORT) >=20 > +#define IAVF_FDIR_INSET_L2TPV2 (\ > + IAVF_INSET_SMAC | IAVF_INSET_L2TPV2) The same comment for FDIR: should we limit with source MAC? > + > +#define IAVF_FDIR_INSET_L2TPV2_PPP_IPV4 (\ > + IAVF_INSET_TUN_IPV4_SRC | IAVF_INSET_TUN_IPV4_DST) > + <...> BR, Beilei