From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F3B8A0540; Thu, 7 Jul 2022 10:59:41 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 13B2040A7B; Thu, 7 Jul 2022 10:59:41 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 68CE1406B4 for ; Thu, 7 Jul 2022 10:59:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657184379; x=1688720379; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=z2g4Ms57S0qNJEfBaOUMWPP+NdB0w2JpWTBf1Ok9Quk=; b=mjPt62wSgkVNRi/k5WbM0AziIzwNnLLEAWS85xs1ecIhwk5zn5Tz2vVj qw2rkElWb2jSLj0589FtGuXpYQd+K4e29Rrs+kh//F7Norn+9qKZzd9Lc KlQ7ZzoO74d8YSUXbFuUfspJNjF8eAqC6wenZqOJ6tqCWakkdP433Md26 lHIn9kM1cJEi3DIAIRkzAozDtNDY5SYd1QWl7Ag99AFEn43op4UMzvVOP qpYMwdjHXCBETA/NqvyzbddLVXi0IDLAFjkTxjXj0ilntk90jm4scdlbS nLLZ8B3zrLtk8CvKLa5xhE1P68Eggyt91ci1x0jx2PglKGacZvM0HkLnw A==; X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="263757767" X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="263757767" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 01:59:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="626243596" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 07 Jul 2022 01:59:37 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 7 Jul 2022 01:59:37 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 7 Jul 2022 01:59:37 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 7 Jul 2022 01:59:36 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hGuTyMIyiXisLfq+kbxhedqtPB0sxA5DNy3c/+obF241uXrV2rqubt9vdyQOJCrH8hPkBef8A2swbe9QxI4HOu1OvmBMkO/ZBoRm5kYGMdxroxQDylxMe7TDBG05IGXnnxMU6cxknL3xLWJGV3Os7ZWUYBp198rNjYwZEcdmJqfQYoMuyDGkG4QkuLMCrAHFp08APX64VW4kkAfhUEEjxaSnhMJ556prElf6sbuu8T/QwDhRzy3wdKaiHMhQSErL8DrOGNBVtpBhH5PpZjA/acyuHzKPamlL1P0QywL3QAx3xs6ml7x949jGVQctBE3O5qWugaHVmB6rET0izRBDAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xft/XKj+jOjHtG6m2y8HJNUA3ZnMw0rXd7s8eco+Rqs=; b=apZ6ONkItPQsDSokKAc3a1YI8cG36I/qHrgFg26d28ISf7B8sXudY0LwtF9AvaVhluWXlssqCUEjcBTCeskZ48kERpDOpuF+bg6mpVXBvzUGzjZzxAI5KKpcpuja+ZsEq2qIdLJlGjgi3lRaAFfQH3S0FT6u38kQowa0IrMwhLG5fwDWWCk58IZwkE/cbECsNU2yjr8+ebsRMgbBz6PGNLdRx3Y70x7jQ+waqRxC8gPKs57luWvx7XRfcC0PlJ2mmUPKhTcZXxOCAPdOYQwzUHJ1i5nkqnZFku4cHj9+Mpm9UoFyPU1auSDtIix8U2rvTldHbhwfw4L/MWX7bmkkQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3098.namprd11.prod.outlook.com (2603:10b6:5:70::11) by DM6PR11MB3498.namprd11.prod.outlook.com (2603:10b6:5:6c::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5395.19; Thu, 7 Jul 2022 08:59:35 +0000 Received: from DM6PR11MB3098.namprd11.prod.outlook.com ([fe80::e99f:9890:bcf2:86f3]) by DM6PR11MB3098.namprd11.prod.outlook.com ([fe80::e99f:9890:bcf2:86f3%7]) with mapi id 15.20.5395.021; Thu, 7 Jul 2022 08:59:35 +0000 From: "Xing, Beilei" To: "Liu, KevinX" , "dev@dpdk.org" CC: "Zhang, Yuying" , "Yang, SteveX" Subject: RE: [PATCH v3] net/i40e: restore disable double VLAN by default Thread-Topic: [PATCH v3] net/i40e: restore disable double VLAN by default Thread-Index: AQHYkduT08oYyMZGJE6P/wKVioFkMa1ymDxg Date: Thu, 7 Jul 2022 08:59:35 +0000 Message-ID: References: <20220707104732.1816933-1-kevinx.liu@intel.com> <20220707162602.2123584-1-kevinx.liu@intel.com> In-Reply-To: <20220707162602.2123584-1-kevinx.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b8fcac78-f31b-4d3c-c19b-08da5ff703d3 x-ms-traffictypediagnostic: DM6PR11MB3498:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: O+s22Vh7MxZORNVtL8h7N4Ik9o1dlefuXgRbV/kJpkS9F0UW5Ke7f0UemfSMfGbIya1DzWCxLHs1sjci+jgBbEYDC8pK3qAUywfTQawWw4jkh9pX2Hpc9t3/6F2ngCWBA8XRGBoXyg8yJtT7RCYP0hJQCKF2Lxjvcr4INb/9qZXLRHsaXNqR/FWvJYIlSkLlCr9a+NGjzou5bsYW5upxKConJSUtCBWRZLusbzZWBYvn5sCFXZR0RhwbtcyMKl6l5b1qgWhOhAPmiKBoIJK09wEWLvj4qy1m8gJ+IACLGmBb4tbFyAg9OwgjqQAWpctvOgs27qUXXkw2zITwFJ5WBXWb+crx6XkUItOaRGVaWUIXgTEp1Wl1YQfKcjBI/miVcLCFFC7CTE5vJ3dUTW+PeJUXMFPDrnItWheeIezZe5E7y72HNr4orrq2YH6WJTDkIhyH2pkOfGW2vdO1PH49xeLKSMRFPQN0FOdSS9L/iquxwfTejIEuNTu52UgQ2e4TGHKpCSX11DMb2ZOVvPgvgNQ6MOmv/CiTvr/hpuPFVVET6eaG4NdrF31DIjV4VN30rGDO53yeg+cahAY3RjO6lj/cLi/n9oDEH/6sgb7VONidbjVGHzcybpiuXlXOhtxYGE/aOGFHpdaPl9T0CT3/DFii2iEwnB5rrgj+mKvNGSymvEASsxQ3ImZa0yMiWnGkny981Y0XeM+2LUNJ0Ub3vExX6yhJR357dc0XE3/5J/c51j9R/T76Y884WieEBRrvrRJlm52y8NW4ZI7Ym50cG4XDvS1Em+mv6f/oMInIlQUq9Z+ZO1ykl5f0S+Xf2X6IyRvOhnrkpML1CKoDAYhqk2Q5dPqpvIEVmgz8BKrYU3U= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3098.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(39860400002)(346002)(396003)(366004)(376002)(136003)(38100700002)(83380400001)(41300700001)(2906002)(64756008)(66556008)(8676002)(38070700005)(186003)(33656002)(8936002)(86362001)(54906003)(6506007)(52536014)(4326008)(107886003)(53546011)(7696005)(71200400001)(26005)(478600001)(76116006)(316002)(66446008)(82960400001)(66946007)(66476007)(110136005)(122000001)(9686003)(5660300002)(55016003)(11706005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8XpMsyeFM3eAkuKV5se1MuJxZmmoISJqr0rUOU4XftFy78YAAzBXJw3Ao0Zq?= =?us-ascii?Q?Au/RPucP4DqK4w0ta3Z7b8a0DVhvlgqpwtZAS53mHDBIlA+6aatOO6F15UzW?= =?us-ascii?Q?0f4FPnlGqFliaLe/tV1ZmR4uFXM+aGsj9R79QyEYfF03+79IloSIbiZNm8hi?= =?us-ascii?Q?f06wukjQzsGzj9WAvvmPQIIMnEi9Csx+2Qv/dyXDR0qRiAqZXX6iEfaPk8VJ?= =?us-ascii?Q?rfEvAm24bNFgm4VT9OgyfKgx/magdJs2iexZqYUj36FaRMOVkuXNh3HXrLJS?= =?us-ascii?Q?oXexvuzFn892SNB3ztfENp0ntWmEpnnxMu3Dz5XopXt8M4fOP4BYcYNWRa2D?= =?us-ascii?Q?VlBKhqO97pZE2xi1Q3Jw8IXHxz5r1KqqWrLKCvsC7Q+7XvQboDU8S/cqetJH?= =?us-ascii?Q?cblEVMzKrZB/5zCeVz1lR3wWRruaqiIWnF+y6YZgBqwKC9RF8R2wQTALlxiH?= =?us-ascii?Q?8OMb3a9kfbRJUK/6xynrHBUMsZ3X7we4+ULxWTBJleCDVjCni5TVUHCuPdOA?= =?us-ascii?Q?Aelhm0KTRkZgbkFxbx4g3S7HcSso4M4GkOG/1/ecXhyk99TIugi6yVhKvLle?= =?us-ascii?Q?ggcyVW9cD4Zh111Va8SNohf7zE2LbNxroqbjAABVU2X+P5SuG7zlvQ2ZDHDx?= =?us-ascii?Q?t1glL6r2471ZvSV+T6jt06TBxDFP1BNOkDsII/kqHvs5sMxZwWWBA12GeErA?= =?us-ascii?Q?tYAJCyDjr2OHmHfhUnHZ0TZRwStt/uT/a7us1fLIyznRYvwCxSv8wHtOo0hz?= =?us-ascii?Q?UgdDoYXrJKScjMTSL1kBY/jhFNx3DZsXUmEpPwX+DCeJN8KjWGr3fminl6oM?= =?us-ascii?Q?mISye5eI5y/fR5mnQnVPibVFP0LDv613yQU1DHQ5AnMokaiH2CGRQUB2Pr6I?= =?us-ascii?Q?6D/GxhMS/voVozGUXKgbFSQkDPYFVl4SkcjipM2JTAGFg0nl5z/ksZMh/rsC?= =?us-ascii?Q?QPfeso50cjvwUdHZcgLMzJRB1dXjdc7G2FkA47RJiDKxc/Hs7LLIwkwRFm3v?= =?us-ascii?Q?Au/mUutUDIiE+8F+TcLzvlWOGwnYU0pft/PaEH6xC8I8rbwkzarP6zTQcKuL?= =?us-ascii?Q?Kzq5Pq8UYeZ/jyImeR9LwWmGgathcpK2T5bMW4t91j+KVtpuadhSBgibUGvP?= =?us-ascii?Q?JHa2RczkxlJnlbaajRLixg2tDa5Rh/AIuC/RD7V9yrNhFMQzfDlpBds0iiRm?= =?us-ascii?Q?p4gVMA5kSwtlbL2V39ZB78i1aw3zDJcZuefb0QxnN9XMtip9YLiOpgJ8OUZY?= =?us-ascii?Q?9JQYbP8jWOhWID+F7J0ik62Z+qAKNnnRbstIgq8GvGBQvwk1CW/2eOhKfSOH?= =?us-ascii?Q?V9ipdQQPV0lGSnjzDP6zfxrUzaNechRuyvFOlF8HJVT8IgF3CE8PetOa8dB7?= =?us-ascii?Q?4TvFvl+RHT+itYICZ+o7QQkWCvtKSHWzBdnDKkf4W5u3PV0VBPlOavQkdu6B?= =?us-ascii?Q?3DVCInesF1/bK87B1PxNbAgOICwHzAmXZ8fti2fsRPpdOyVBb1K/skrl3kbs?= =?us-ascii?Q?lEcLPSrXIEc/rQjThB52GPdcwE0ONrOrpvELtmVaVe90r+tgteRDqQq0rcw+?= =?us-ascii?Q?Gz5g+RFV1HIUEbsJuAO4+3woztXjT8uNVf5OTLbD?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3098.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b8fcac78-f31b-4d3c-c19b-08da5ff703d3 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 08:59:35.1960 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vs3kxc3OLKPbHlQwa8h4XcadtGQOrFH7lg8g3UUARrIRkyLmZD2F6aFHVw1VOiBvNAA8d2NRqDoCIX4rIsysrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3498 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Liu, KevinX > Sent: Friday, July 8, 2022 12:26 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Yuying > ; Yang, SteveX ; Liu, Kevi= nX > > Subject: [PATCH v3] net/i40e: restore disable double VLAN by default >=20 > Previously, QinQ is enabled by default and can't be disabled, but there'l= l be > performance drop if QinQ is enabled. >=20 > So, disable QinQ by default. >=20 > Fixes: ae97b8b89826 ("net/i40e: fix error disable double VLAN") > Signed-off-by: Kevin Liu >=20 > --- > v2: update doc and refine commit log > --- > v3: refine commit log > --- > doc/guides/nics/i40e.rst | 11 +++++++---- > drivers/net/i40e/i40e_ethdev.c | 12 ------------ > 2 files changed, 7 insertions(+), 16 deletions(-) >=20 > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index > 85fdc4944d..75ff40aa59 100644 > --- a/doc/guides/nics/i40e.rst > +++ b/doc/guides/nics/i40e.rst > @@ -969,11 +969,14 @@ it will fail and return the info "Conflict with the= first > rule's input set", which means the current rule's input set conflicts wi= th the first > rule's. > Remove the first rule if want to change the input set of the PCTYPE. >=20 > -Disable QinQ is not supported when FW >=3D 8.4 - > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > - > -If upgrade FW to version 8.4 and higher, enable QinQ by default and disa= ble > QinQ is not supported. > +Vlan related feature miss when FW >=3D 8.4 > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > +If upgrade FW to version 8.4 and higher, some vlan related issue exist: > +1. vlan tci input set not work > +2. tpid set fail > +3. need enable qinq before use vlan filter 4. outer vlan strip fail =20 Vlan related features miss when FW >=3D8.4 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ If FW version >=3D 8.4, there'll be some Vlan related issues: 1. TCI input set for QinQ is invalid. 2. Fail to configure TPID for QinQ. 3. Need to enable QinQ before enabling Vlan filter. 4. Fail to strip outer Vlan. >=20 > Example of getting best performance with l3fwd example > ------------------------------------------------------ > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 684e095026..117dd85c11 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -4027,12 +4027,6 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int > mask) > } >=20 > if (mask & RTE_ETH_VLAN_EXTEND_MASK) { > - /* Double VLAN not allowed to be disabled.*/ > - if (pf->fw8_3gt && !(rxmode->offloads & > RTE_ETH_RX_OFFLOAD_VLAN_EXTEND)) { > - PMD_DRV_LOG(WARNING, > - "Disable double VLAN is not allowed after > firmwarev8.3!"); > - return 0; > - } > i =3D 0; > num =3D vsi->mac_num; > mac_filter =3D rte_zmalloc("mac_filter_info_data", > @@ -6296,7 +6290,6 @@ int i40e_vsi_cfg_inner_vlan_stripping(struct i40e_v= si > *vsi, bool on) static int i40e_dev_init_vlan(struct rte_eth_dev *dev) = { > - struct i40e_pf *pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data- > >dev_private); > struct rte_eth_dev_data *data =3D dev->data; > int ret; > int mask =3D 0; > @@ -6307,11 +6300,6 @@ i40e_dev_init_vlan(struct rte_eth_dev *dev) > RTE_ETH_VLAN_FILTER_MASK | > RTE_ETH_VLAN_EXTEND_MASK; >=20 > - /* Double VLAN be enabled by default.*/ > - if (pf->fw8_3gt) { > - struct rte_eth_rxmode *rxmode =3D &dev->data- > >dev_conf.rxmode; > - rxmode->offloads |=3D RTE_ETH_RX_OFFLOAD_VLAN_EXTEND; > - } > ret =3D i40e_vlan_offload_set(dev, mask); > if (ret) { > PMD_DRV_LOG(INFO, "Failed to update vlan offload"); > -- > 2.34.1