From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32AEEA0543; Fri, 8 Jul 2022 02:21:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1EEA40A7B; Fri, 8 Jul 2022 02:21:38 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 3BDF1406B4 for ; Fri, 8 Jul 2022 02:21:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657239697; x=1688775697; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=uw4piZYx9likvww4DXeAzDOXxnFxVaF9Kb1YT2nU0+Q=; b=eO9NNt4t2YAjr244Kq9SIqOOche52dn/7E5UctYNRq3Q5CILUPVvATHu HiPK1kT/0hVz8AIdKl4hfphw19ObVYj+N0UF7QO7qxDk4HvYyth7qZM+t MozM+3x0zi6deqA79QBEZLQR+bWWgV7cEyhxWsazsuJ1N+botxmv5wkIr XpWL5N0QD+AAxGb1+4FxRAYwGkbntCVhrSrY8fy6erhYgRWSUddui1RJT bcwnnKxvSoj5Tefp8FMqNYJxrZ400oHrMpk9MpV+5EtzPq+LNLmTnPUE/ qCe9tx0TVFlFUcYHGwoEGSwbre1bVQTmoSJWB9ynk7SQ0Os0L+oPZJrp/ w==; X-IronPort-AV: E=McAfee;i="6400,9594,10401"; a="348135405" X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="348135405" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jul 2022 17:21:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,253,1650956400"; d="scan'208";a="840113936" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga006.fm.intel.com with ESMTP; 07 Jul 2022 17:21:35 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 7 Jul 2022 17:21:35 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Thu, 7 Jul 2022 17:21:35 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Thu, 7 Jul 2022 17:21:35 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Thu, 7 Jul 2022 17:21:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MPw2hejtzomfWaPt7m/zmYqGoS7lYWBALhJCQ6lMjUNAEpPNZDin00bCRrkQwPKMNc2hNKTwdm9ormfvwCMnmIlCFKz5Tx4FyDM8r6QITXZ2oRqs/2PqJl7PotZTiBMp9JJoILsTjHAyED+XzKNQoVaGp3I1WFxk7dUMA7BO17gQ9dC7A1+LniIAyDAI0daMtgWMZHJfmPeOAQwxiQQlRXbyjoMKOams1eSu3XcQfpg7h3Qk3pA11PLFCIVaGm0GbASS1uIAGzlO2ZgOlUp2XY1i97VaaDyXiT79cy2GebbZNGx+toWvl9elXtkAvo10m3Zmtpwuvw8NVH1qp9AF4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h5Ler2fufeg0mFt+xNGzMjVI1IUZbyOskvVRNY2DlxU=; b=laGztWWvbCL8zpIK5Y1ElgzR0IXU/SxupJ6WCho5buYwmg821wVuoI3SImZkhUkZb38J3ulDFgfsHxbMf7b2X3ll6mx3JigH49aAJ8o+/kBXtntLPoX1Gz7oVvJz9hJsf032Y+rx/JA6ApFp4F0HhhWTrnDfrF6xyXadnOOf+yBI3M3ADbGyG1N0V8eSmT90S/Vfl4yCRNr1qitCElpPILXKAzVIseOIz5U6LljX1S6sSDg1V5ozO2FO/1zCE/vgTEKaHuROdyOIvDeFCbbyYa9fsL0QVwgQVGLYGxLI239IwqqXJ273z6zef7nbPqLq+zHyRSDWDGLLWKh8l73d5g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3098.namprd11.prod.outlook.com (2603:10b6:5:70::11) by BL3PR11MB5699.namprd11.prod.outlook.com (2603:10b6:208:33e::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Fri, 8 Jul 2022 00:21:33 +0000 Received: from DM6PR11MB3098.namprd11.prod.outlook.com ([fe80::e99f:9890:bcf2:86f3]) by DM6PR11MB3098.namprd11.prod.outlook.com ([fe80::e99f:9890:bcf2:86f3%7]) with mapi id 15.20.5395.021; Fri, 8 Jul 2022 00:21:33 +0000 From: "Xing, Beilei" To: "Liu, KevinX" , "dev@dpdk.org" CC: "Zhang, Yuying" , "Yang, SteveX" Subject: RE: [PATCH v4] net/i40e: restore disable double VLAN by default Thread-Topic: [PATCH v4] net/i40e: restore disable double VLAN by default Thread-Index: AQHYkeDfNv6A5Tx6IUq0r72TUSh0Wa1znYjQ Date: Fri, 8 Jul 2022 00:21:33 +0000 Message-ID: References: <20220707104732.1816933-1-kevinx.liu@intel.com> <20220707170434.2159759-1-kevinx.liu@intel.com> In-Reply-To: <20220707170434.2159759-1-kevinx.liu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 012e9864-40de-44b6-f09d-08da6077d018 x-ms-traffictypediagnostic: BL3PR11MB5699:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: bMnzKLl0T8Jgrurfv6iAHbECjAxUNn4ubykXIk8XTpZVr1R1QXIvTY3Efky3HKs/JAm5cHayavt0sO1U6Tqj8NGRnHJf4QORHQmjcKCfiSefbhoY6G/OZXM8T7Y3w7BM4M4Vjmkqod+uQnwasLCv6N1RNSpBE1jPvsE03GRJGDLZwbe7Idep/oemwIMpMgKiVkKLpKuxyXPiags2csACg/DSNyQrKba7RDi7QjAd/4WPuW/Tk0mZkgRRmssRm4ARvptY5fvcPiwK4+aBMaQb8V5yNIIP2E2LfNt9Vd6nX5FLr1osLz5luTp+y8VVcep7jD+ywsN3gwYgABx6vbHEvuu59Y4ZS8m7wp+A4jOrGk2kYezIS83ibZNQv2Z013qbqSVnZD9IVFt1Z7JKkBOJiYlgOX8HYJouyGzDs0n+DYvXryVd8x8IEJhEKPu/E0AJ5mzrdBbi0Pp1PTJTKgkcT8ZQ0Ht8xayAzVVW7Apgw9MKq0YZ9qNzBKic1ER1O7gTndxwo/Jm5hHDP/Q5Mi59oNiE1nCvKpnACU+nYAdRUkMQGaKuvMjxv/XclllOoem7KeJ5nPhhq4ZkP7ScbBObxXylp6y3Jw6fgIPfHAYbFWKV+IzkRWgD4a67/W8m8SJHePhi23ZrwnnlvINGtyvBLAAB0TiwE34DfTa5nXOJ3FLElshPhdNgHkmtQuj/S730grOknCJfILlfkoiNJl0szWdS4QHI/ybFcldQZgw5Lw76GXaqM+z0TJpdJgTCx1/s5NV0pW11fucwScdrlvZN3uneMT6Vub/GewtE4saKZNdU1JkwYbgnN7sALlbLNJ7bPtCLOqHl7hKCa2usvgfenv1lZ+ubL+64iSgFtXvyJMs= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3098.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(346002)(376002)(366004)(39860400002)(396003)(122000001)(110136005)(55016003)(38100700002)(186003)(83380400001)(66476007)(54906003)(4326008)(316002)(66946007)(66446008)(64756008)(8676002)(66556008)(82960400001)(71200400001)(76116006)(53546011)(33656002)(8936002)(52536014)(478600001)(86362001)(7696005)(6506007)(9686003)(26005)(2906002)(41300700001)(38070700005)(107886003)(5660300002)(11706005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2XC/+IUQeH4J6F3FmkwpQMUeYgnwuYJoHs9a7RnMAPM6n3LGe8NgJKdc8MpQ?= =?us-ascii?Q?KWCM9SdU1/3kTHfGFGj3VBEb+3mCHRGlgULfGt4cx2KIl83oYLTEzNrWT+6L?= =?us-ascii?Q?7gm+I+47VvQpQkOdcbzB2oKKaaXrlEgfrDWTfcq+wY52dIiGaQ1oTgNBRKTH?= =?us-ascii?Q?+KQVUEM1Nfa6Dc1dFjBDWqLZuTTzvjveMq4+tE4JXlDT51lXZ76vg/qkxQ2A?= =?us-ascii?Q?sJhxWIbh6uExRGN3K8rgXJHd/po4oov11lFsfS+C3srDRrIIsT72oQw0HNpB?= =?us-ascii?Q?4YvR8P7HTGa7NIix1xFbqCAxmPwKbrUBSDs92gxvHzig8BJrlai8qUh4Npds?= =?us-ascii?Q?gJzAIpLW+rnTjuall2Nm4+4epml1J1WBQsvq7cwVU5FOmSPNx4JHm/J5TsaK?= =?us-ascii?Q?3rhp3BAGqsJWreBUdNyhQ4MssYj3G1+rDvfz7lAwZcq2jgZSOCdPgTHuzesR?= =?us-ascii?Q?w9V1w02Db2dFIr6rHenZS20RVnR4oF6Th/9IRfbCgJNgke368WhfqS9rbab5?= =?us-ascii?Q?6dRu6Fc/clFaLzf/9kwdwPcR8Xe5swt5XrqjTUo0vPlmQFHl/XtXqqxK28GB?= =?us-ascii?Q?92ldWcVNJK2QKoPg5o6DIVlWAmyqh9WDdevm9eOr4Hl/hGFg8sFJXcU/mGJh?= =?us-ascii?Q?5aI0vlU1L7YDKLvUijnuL+EijEvUkWu9WGIZ4I/drdfC5adcqfoACsM/x+RH?= =?us-ascii?Q?bQ1ufc8ZZe18GgkY0s+zm716Lpq497MxuM4QL1SCpPOrIYnnnynMsIiW9YdO?= =?us-ascii?Q?IA50NkPPOOgcYH/dhM09AHgBeohJeI64sCxbR+LheD4Lq6DDpBJGQXdXAgUL?= =?us-ascii?Q?M6NrEASflmVgOlb9xLJhuEbPRbnrVuLgR6p9EImb82BEDfMpBw8CyvwkI+tz?= =?us-ascii?Q?W0jOVXSAyiYIlO+o98tH+j6eb4+VI3NfxocX3NUMqeLT1JPY7X9oYy2zTeaC?= =?us-ascii?Q?Ktcstn7NNLcHzmCu4lbgc5bcMLlHbz1oZZaWX60/+4/kUbkIaxRbiWz18rub?= =?us-ascii?Q?RPZL/IAQVyotjeiAOURXtrJvAsa69T7w0w3tjj0jo1XqdNWhH7FXfIpG1FNN?= =?us-ascii?Q?dWoCBHRUzRP8ghdz9QP1MTqwl67C3Hkt7ALdNDA04i8Z4h3v1X56YLnFAZlj?= =?us-ascii?Q?ad5HKF6/Z/9YiMDyCgdvWGsRa7yoUlfVdnHQBRn8h3ghCTItr+EQWKJ3AoYO?= =?us-ascii?Q?iPYnL8V57hYoubMDt+W3g0miKuUOWj8HZLpi5xJnoSu/smfvNT+ajgSftOI+?= =?us-ascii?Q?HoIHlRaxa3f/Zuq5J5biTwKzp8iZnKr30j7fnQi6WqkE+Vb1dr+XpobEdUYB?= =?us-ascii?Q?rh7ppeh9oIKARMnBUc/U5F+olY4dLCvGFtp59P0IrW2ZdlHS7DSi6RiVjiRT?= =?us-ascii?Q?SnXSDH733mI1o3Si69o3QB7/HCEVtqGnw5Ck4HufyAW5COpT/cl1Aa8Xlm0x?= =?us-ascii?Q?3Xbhc2ltbqbYQteUIcsCbJR47ycLuMeboahoSgadVI4njBYaOtD3FENAtyOl?= =?us-ascii?Q?j6QTj0pKg4XQOPMsV/lqTEL2tV6QnzY+YA2oClMeesjhUe8h0DP98t5gX+p4?= =?us-ascii?Q?IFQE4VnSJpp7Yz7uSOscRzi7FirEetXLQZCHb+A3?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3098.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 012e9864-40de-44b6-f09d-08da6077d018 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jul 2022 00:21:33.4391 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gpfzfue9fVn5N4jXNaB/AWSfovZ/fq1XGCkUsCi8ceYE1ngQcxrQimB0dzb+htfLtQc5U2O+p++XD8n0conajA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB5699 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Liu, KevinX > Sent: Friday, July 8, 2022 1:05 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Yuying > ; Yang, SteveX ; Liu, Kevi= nX > > Subject: [PATCH v4] net/i40e: restore disable double VLAN by default >=20 > Previously, QinQ is enabled by default and can't be disabled, but there'l= l be > performance drop if QinQ is enabled. >=20 > So, disable QinQ by default. >=20 > Fixes: ae97b8b89826 ("net/i40e: fix error disable double VLAN") > Signed-off-by: Kevin Liu >=20 > --- > v2: update doc and refine commit log > --- > v3: refine commit log > --- > v4: update doc > --- > doc/guides/nics/i40e.rst | 13 ++++++++----- > drivers/net/i40e/i40e_ethdev.c | 12 ------------ > 2 files changed, 8 insertions(+), 17 deletions(-) >=20 > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index > 85fdc4944d..d5938fa8e4 100644 > --- a/doc/guides/nics/i40e.rst > +++ b/doc/guides/nics/i40e.rst > @@ -969,11 +969,14 @@ it will fail and return the info "Conflict with the= first > rule's input set", which means the current rule's input set conflicts wi= th the first > rule's. > Remove the first rule if want to change the input set of the PCTYPE. >=20 > -Disable QinQ is not supported when FW >=3D 8.4 - > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > - > -If upgrade FW to version 8.4 and higher, enable QinQ by default and disa= ble > QinQ is not supported. > - > +Vlan related Features miss when FW >=3D 8.4 > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +If FW version >=3D 8.4, there'll be some Vlan related issues: > +1. TCI input set for QinQ is invalid. > +2. Fail to configure TPID for QinQ. > +3. Need to enable QinQ before enabling Vlan filter. > +4. Fail to strip outer Vlan. >=20 > Example of getting best performance with l3fwd example > ------------------------------------------------------ > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 684e095026..117dd85c11 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -4027,12 +4027,6 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int > mask) > } >=20 > if (mask & RTE_ETH_VLAN_EXTEND_MASK) { > - /* Double VLAN not allowed to be disabled.*/ > - if (pf->fw8_3gt && !(rxmode->offloads & > RTE_ETH_RX_OFFLOAD_VLAN_EXTEND)) { > - PMD_DRV_LOG(WARNING, > - "Disable double VLAN is not allowed after > firmwarev8.3!"); > - return 0; > - } > i =3D 0; > num =3D vsi->mac_num; > mac_filter =3D rte_zmalloc("mac_filter_info_data", > @@ -6296,7 +6290,6 @@ int i40e_vsi_cfg_inner_vlan_stripping(struct i40e_v= si > *vsi, bool on) static int i40e_dev_init_vlan(struct rte_eth_dev *dev) = { > - struct i40e_pf *pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data- > >dev_private); > struct rte_eth_dev_data *data =3D dev->data; > int ret; > int mask =3D 0; > @@ -6307,11 +6300,6 @@ i40e_dev_init_vlan(struct rte_eth_dev *dev) > RTE_ETH_VLAN_FILTER_MASK | > RTE_ETH_VLAN_EXTEND_MASK; >=20 > - /* Double VLAN be enabled by default.*/ > - if (pf->fw8_3gt) { > - struct rte_eth_rxmode *rxmode =3D &dev->data- > >dev_conf.rxmode; > - rxmode->offloads |=3D RTE_ETH_RX_OFFLOAD_VLAN_EXTEND; > - } > ret =3D i40e_vlan_offload_set(dev, mask); > if (ret) { > PMD_DRV_LOG(INFO, "Failed to update vlan offload"); > -- > 2.34.1 Acked-by: Beilei Xing