From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1ADFEA04DD; Fri, 20 Nov 2020 02:51:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 01E27C884; Fri, 20 Nov 2020 02:51:22 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 4AD57DED; Fri, 20 Nov 2020 02:51:19 +0100 (CET) IronPort-SDR: otB6mpRTKDPUnXwkYekpH6obAOQGXV52P0QR3Q+rSNR0vb+Lh2uaMqVkZe2EGc2so5oxmQA7Bs R4xlK4VYUy/w== X-IronPort-AV: E=McAfee;i="6000,8403,9810"; a="171495645" X-IronPort-AV: E=Sophos;i="5.78,354,1599548400"; d="scan'208";a="171495645" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2020 17:51:16 -0800 IronPort-SDR: olfINglH2b0V79L4yQ6FHNCtOZDlsJiIaBjNSf9gvcoVxuT8d1JPrVPZRMUsIdGvlXGxUw86h3 sxMKhMOBpwTQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,354,1599548400"; d="scan'208";a="533393802" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga006.fm.intel.com with ESMTP; 19 Nov 2020 17:51:16 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 19 Nov 2020 17:51:16 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 19 Nov 2020 17:51:15 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 19 Nov 2020 17:51:15 -0800 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.56) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 19 Nov 2020 17:51:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KtsU9f2ZZ3SO0PXCZavUQE+xfvzyNQJx4h0HN65V6kRrI9NGf0zj1rQsVt41/UgKX5l4xqMbdGqfe+Sretpj7jeINMacTtT761ZnKBPLjXc+dZCNKCEhsUMxBgKg6O+dXEK7LugknDfGdtnnffJPJV7skYyNMeDW2rajk4oT8vRtDDPoLgmpzzkSfYINtWf0GvdXI5pLYp1puHplBi0Tq+78wHDRnh1OH1W6oOu4enpM6ZSW3fXhA3UtHXh+4T3QWUEAQli18Jnjh/0wI6o0Br/9qKZbx8uzFe4MIKqjKMUrJTRYKq6SPZbrPOtuEEcqmieTXZJZvSUpqKwSd1iFMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5wzPZ948OvwMmh7W/kCkLNo0a5NXxtb/woVdWQsxupQ=; b=Tg6e1LiABpTimLi2iCDEXj/K0le4yRfYAEp67dR37XWaTdqST0JXfqIhrjHrApAFQZojipPfUd6NXmLr8wXlwXxol8lBU7gbX8ztO25TZMO1c8wyi+AXikQO/3Ba2PsdHFCOKh4Pd6onhSs5dbKWbEtpZkqgMfT7zkf2z9n8WCsjdNbHSfhPZGtrLrA0rXeGQcRDyd/6hnNaGoyDvGOsoeuSqmYhWuk8Pa47qX7JE4wGSIauSdB8UKkwULgnIfReDKIPlShyUVewRl9HyW1JYTz4m/vFdPs6By6u/7miqnLiWOwBJOUjsnKe1O8DO73xrNKjB68aRhBH/sv5WaqnjA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5wzPZ948OvwMmh7W/kCkLNo0a5NXxtb/woVdWQsxupQ=; b=yRPJ386cC06qMZPlMg0ETgYhGEZ7PPFZ9Ah3L4horv05jfPrHU/ReJ+ijh94FCUE0nTq5bKxJb8j1MTyZBs7e+36yN+g146WurruqH3vWM2G8xwxltv1ZLBc+ofe9fDJaG4NMHbnPYT58nn2NlL/KTVc4ozHI0DqZ59rFAMK7Zg= Received: from DM6PR11MB3099.namprd11.prod.outlook.com (2603:10b6:5:6c::16) by DM6PR11MB2585.namprd11.prod.outlook.com (2603:10b6:5:ce::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3589.22; Fri, 20 Nov 2020 01:51:12 +0000 Received: from DM6PR11MB3099.namprd11.prod.outlook.com ([fe80::a94d:14c4:6041:7c7d]) by DM6PR11MB3099.namprd11.prod.outlook.com ([fe80::a94d:14c4:6041:7c7d%4]) with mapi id 15.20.3589.024; Fri, 20 Nov 2020 01:51:12 +0000 From: "Chen, BoX C" To: "Yigit, Ferruh" , "Lu, Wenzhuo" , "Xing, Beilei" , "Iremonger, Bernard" , "Zhang, Qi Z" , Andrew Rybchenko CC: "Yigit, Ferruh" , "dev@dpdk.org" , "stable@dpdk.org" , "Chen, BoX C" , "Yu, PingX" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: revert setting MTU explicitly after configure Thread-Index: AQHWvEuKSKi2s4CbCE+VY2vPj65LHanQRlYw Date: Fri, 20 Nov 2020 01:51:11 +0000 Message-ID: References: <20201116190355.3390447-1-ferruh.yigit@intel.com> In-Reply-To: <20201116190355.3390447-1-ferruh.yigit@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.102.204.36] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8c7fe99b-89eb-4f66-df77-08d88cf6c23d x-ms-traffictypediagnostic: DM6PR11MB2585: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KlnmEqaquyxPC3RJEP2NIPAUHS64eyb2IWuSuvWcd/z6Fm531Iq0C0HaJSma2LHg1VlakvHgY7jSA9JE8dr41mvs/6Z0ux1//Vpz867pnci+C1FbXjg7hVgyTe8TvHjS9eZTNrs4clYM9vweOxW4mHA3P5NReNxZUMEyUdBFTw+yv1RSASPsmceMN9GQDWleKVyrHv7ERGEK+QmbusNwqiorHU6wsKIC0Nor6Y6nME1DoXFwoMtrxWtnMBVcGMcgZA0Cbmv1y+X6JGEhKG8alXCMvp4Jyl8J7iBldPoIyG9DJg/UxNrSvRwH65uUhl1qBE4i2ZvxGd0E5s3MI7ZUQaYYxXgCvWnMumP3rcJ5hlBRkJc3s5uR6jR0NkF7dUnL x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3099.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(396003)(346002)(39860400002)(376002)(33656002)(6506007)(53546011)(86362001)(8936002)(4326008)(54906003)(55016002)(110136005)(316002)(71200400001)(83380400001)(9686003)(921005)(107886003)(7696005)(52536014)(478600001)(2906002)(76116006)(66476007)(66946007)(66556008)(66446008)(5660300002)(64756008)(26005)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: qojwjW0eu+EG/R7QtwAQBpmFfoichFrxCDjfFJgVJa02lhT5pHx2410mbJX1/CmPWQHw+8karWIN/JndQfnXlLxu2vNOUuWm8h+GFxbhKaTms5KJfPyyO9n+CJt8ACeDr9xWytNau2atnD5rm7mb2GjvbdIgKaG4/aSSxFeWdWncKH4Ufs5CiTINtBt7r3eQCq8g7hvYbOxCA4M0rDszjMDdEUgkzvVCgcmoghqOuTob3QURRi+Ckynz/M7+Aob9kW9hrgFJ8yaXKKytrWCW/sMIAhOVpz40XeInmDc361QshRxgdJW8b4JFe0u7K8mYswBkupmscteW1/TS0D+sgo4yXKbFtPKjYMaFRiktzY2jMrgK9Kw9bQPRbEhcKEy1ZdiVk8m0t5sa/p7UguHupLQDwF7vvL89k5YWOGGJhbdWlK4XqknLVxnRUwdln/pjdPqOaUm+4drfITHrYtAvljEw6whZdE4+3KE1prZKGklShHDLn+ZumTsNzbdZwdr7ZZ/Y2PhpMfeLutwDCkPqoijUjkTAjHldH0Cc24Ob0HcmiJPNJH83zOHKKSP+wH4IFnIl1nQZPBvG7WqMkwGeqQ52X9in14VQMjHkyiOey9CRoapU1PldCne2P66xuAKsweix7bEPGCQNqydrQFJHMw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3099.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8c7fe99b-89eb-4f66-df77-08d88cf6c23d X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Nov 2020 01:51:12.0284 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qJYCjkJEAVP/DKSrKdDo7PqNmoWmzJAG+Wb9gTDN7PQYXoRwqi68jq+QH96LzwoCf/ypXOwcaexAGMCST2DEvQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2585 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] app/testpmd: revert setting MTU explicitly after configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Chen, BoX C Thanks. Regards, Chen Bo > -----Original Message----- > From: dev On Behalf Of Ferruh Yigit > Sent: November 17, 2020 3:04 > To: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; Zhang, Qi Z ; > Andrew Rybchenko > Cc: Yigit, Ferruh ; dev@dpdk.org; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] app/testpmd: revert setting MTU explicitly > after configure >=20 > Setting MTU after each 'rte_eth_dev_configure()' prevents using "--max- > pkt-len=3DN" parameter and "port config all max-pkt-len #" command >=20 > This is breaking DTS scatter test case which is using "--max-pkt-len=3D90= 00" > testpmd parameter. >=20 > Reverting workaround to recover the DTS testcase. >=20 > Fixes: 1c21ee95cf52 ("app/testpmd: fix MTU after device configure") > Cc: stable@dpdk.org >=20 > Signed-off-by: Ferruh Yigit > --- > app/test-pmd/testpmd.c | 19 ------------------- > 1 file changed, 19 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 48e9647fc7..33fc0fddf5 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2537,8 +2537,6 @@ start_port(portid_t pid) > } >=20 > if (port->need_reconfig > 0) { > - uint16_t mtu =3D RTE_ETHER_MTU; > - > port->need_reconfig =3D 0; >=20 > if (flow_isolate_all) { > @@ -2572,23 +2570,6 @@ start_port(portid_t pid) > port->need_reconfig =3D 1; > return -1; > } > - > - /* > - * Workaround for rte_eth_dev_configure(), > max_rx_pkt_len > - * set MTU wrong for the PMDs that have frame > overhead > - * bigger than RTE_ETHER_HDR_LEN + > RTE_ETHER_CRC_LEN. > - * For a PMD that has 26 bytes overhead, > rte_eth_dev_configure() > - * can set MTU to max 1492, not to expected 1500 > bytes. > - * Using rte_eth_dev_set_mtu() to be able to set > MTU correctly, > - * default MTU value is 1500. > - */ > - diag =3D rte_eth_dev_get_mtu(pi, &mtu); > - if (diag) > - printf("Failed to get MTU for port %d\n", pi); > - diag =3D rte_eth_dev_set_mtu(pi, mtu); > - if (diag !=3D 0 && diag !=3D -ENOTSUP) > - printf("Failed to set MTU to %u for > port %d\n", > - mtu, pi); > } > if (port->need_reconfig_queues > 0) { > port->need_reconfig_queues =3D 0; > -- > 2.26.2