P.S., In Coverity there are a number of "Out-of-bounds access (OVERRUN)" defects that relate to rte_memcpy() or one of the wrappers around it. They look like this:
CID 362728 (#1 of 1): Out-of-bounds access (OVERRUN)
11. overrun-buffer-val: Overrunning array tdata->auth_tag.data of 16 bytes by
passing it to a function which accesses it at byte offset 160.
8182 rte_memcpy(sym_op->aead.digest.data, tdata->auth_tag.data,
8183 tdata->auth_tag.len);
8184 debug_hexdump(stdout, "digest:",
8185 sym_op->aead.digest.data,
8186 tdata->auth_tag.len);
8187 }
As far as we can tell these are false positives since there are a number of different size handling statements in rte_memcpy() and an issue like this would result in an immediate error under
any sort of load.
In this case you can edit the defect online and change the defect "Classification" to "False Positive" and change the "Action" to "Ignore".
If anyone disagrees and thinks that this is a real issue, let me know.
John
From: Mcnamara, John <john.mcnamara@intel.com>
Sent: Thursday, February 10, 2022 8:44 PM
To: gaetan.rivet@6wind.com; ilyes.ben_hamouda@6wind.com; olivier.matz@6wind.com; ajit.khaparde@broadcom.com; farah.smith@broadcom.com; kalesh-anakkur.purayil@broadcom.com; kishore.padmanabha@broadcom.com; lance.richardson@broadcom.com; michael.wildt@broadcom.com;
peter.spreadborough@broadcom.com; somnath.kotur@broadcom.com; stuart.schacher@broadcom.com; sunila.sahu@caviumnetworks.com; hyonkim@cisco.com; vatangchengchang@huawei.com; adwivedi@marvell.com; anoobj@marvell.com; asekhar@marvell.com; gmuthukrishn@marvell.com;
hkalra@marvell.com; jerinj@marvell.com; kirankumark@marvell.com; ktejasree@marvell.com; ndabilpuram@marvell.com; pbhagavatula@marvell.com; psatheesh@marvell.com; schalla@marvell.com; skori@marvell.com; sthotton@marvell.com; tduszynski@marvell.com; jackmin@mellanox.com;
viacheslavo@mellanox.com; xuemingl@mellanox.com; stephen@networkplumber.org; dkozlyuk@nvidia.com; eagostini@nvidia.com; shunh@nvidia.com; suanmingm@nvidia.com; xuemingl@nvidia.com; apeksha.gupta@nxp.com; franck.lenormand@nxp.com; g.singh@nxp.com; hemant.agrawal@nxp.com;
jun.yang@nxp.com; nipun.gupta@nxp.com; shreyansh.jain@nxp.com; ivan.ilchenko@oktetlabs.ru; zyta.szpak@semihalf.com; jiawenwu@trustnetic.com; vsrivast@xilinx.com
Cc: thomas@monjalon.net; Yigit, Ferruh <ferruh.yigit@intel.com>; Morrissey, Sean <sean.morrissey@intel.com>; dev@dpdk.org; jerinj@marvell.com
Subject: Open Coverity defects in DPDK
Folks,
If your email is on the "To" list then you have an open defect in the DPDK Coverity database. Due to an issue with an automated emailer you may not have received an email notifying you about
this. We will try to send them again.
In the meantime you can see the defects against your email in the list below. If you spot any email addresses that are no longer valid please let me and Sean know.
You can review the defects online at:
http://scan.coverity.com/projects/dpdk-data-plane-development-kit
If you aren't registered for the DPDK Coverity you can do so here:
http://scan.coverity.com/users/sign_up
CID Type Owner
------ ------------------------------ -----------------------------
373712 Resource leak
gaetan.rivet@6wind.com
373890 Negative array index read
ilyes.ben_hamouda@6wind.com
373888 Out-of-bounds read
ilyes.ben_hamouda@6wind.com
373855 Logically dead code
olivier.matz@6wind.com
373686 Waiting while holding a lock
olivier.matz@6wind.com
369668 Out-of-bounds access
ajit.khaparde@broadcom.com
371896 Out-of-bounds access
farah.smith@broadcom.com
371894 Out-of-bounds access
farah.smith@broadcom.com
369660 Out-of-bounds access
kalesh-anakkur.purayil@broadcom.com
373390 Untrusted value as argument
kishore.padmanabha@broadcom.com
373389 Untrusted value as argument
kishore.padmanabha@broadcom.com
369669 Out-of-bounds read
lance.richardson@broadcom.com
374939 Dereference after null check
michael.wildt@broadcom.com
369665 Out-of-bounds access
peter.spreadborough@broadcom.com
372064 Uninitialized scalar variable
somnath.kotur@broadcom.com
369667 Out-of-bounds access
somnath.kotur@broadcom.com
369666 Out-of-bounds access
somnath.kotur@broadcom.com
369662 Out-of-bounds access
somnath.kotur@broadcom.com
369661 Out-of-bounds access
somnath.kotur@broadcom.com
369659 Out-of-bounds access
somnath.kotur@broadcom.com
369658 Out-of-bounds access
stuart.schacher@broadcom.com
373869 Unchecked return value
sunila.sahu@caviumnetworks.com
373365 Dereference null return value
sunila.sahu@caviumnetworks.com
375064 Dereference after null check
hyonkim@cisco.com
367379 Failure to restore non-local
vatangchengchang@huawei.com
372137 Untrusted value as argument
adwivedi@marvell.com
372138 Untrusted value as argument
anoobj@marvell.com
370218 Dereference null return value
asekhar@marvell.com
373635 Logically dead code
gmuthukrishn@marvell.com
373628 Dereference null return value
gmuthukrishn@marvell.com
374858 Unchecked return value
hkalra@marvell.com
371880 Uninitialized scalar variable
jerinj@marvell.com
371876 Uninitialized scalar variable
jerinj@marvell.com
372065 Explicit null dereferenced
kirankumark@marvell.com
370225 Uninitialized pointer read
kirankumark@marvell.com
370224 Uninitialized pointer read
kirankumark@marvell.com
370223 Uninitialized pointer read
kirankumark@marvell.com
370221 Uninitialized pointer read
kirankumark@marvell.com
370220 Uninitialized pointer read
kirankumark@marvell.com
370219 Uninitialized pointer read
kirankumark@marvell.com
370217 Uninitialized pointer read
kirankumark@marvell.com
370214 Uninitialized pointer read
kirankumark@marvell.com
373857 Out-of-bounds access
ktejasree@marvell.com
371877 Uninitialized scalar variable
ndabilpuram@marvell.com
371872 Uninitialized scalar variable
ndabilpuram@marvell.com
370215 Unchecked return value
ndabilpuram@marvell.com
370213 Unchecked return value
ndabilpuram@marvell.com
374991 Resource leak
pbhagavatula@marvell.com
374990 Resource leak
pbhagavatula@marvell.com
370587 Uninitialized pointer read
pbhagavatula@marvell.com
370580 Unsigned compared against 0
pbhagavatula@marvell.com
370579 Uninitialized pointer read
pbhagavatula@marvell.com
370578 Uninitialized scalar variable
pbhagavatula@marvell.com
370222 Dereference null return value
pbhagavatula@marvell.com
373870 Division or modulo by zero
psatheesh@marvell.com
373258 Unintended sign extension
psatheesh@marvell.com
373859 Dereference after null check
schalla@marvell.com
373630 Uninitialized scalar variable
skori@marvell.com
373636 Uninitialized scalar variable
sthotton@marvell.com
373623 Uninitialized scalar variable
sthotton@marvell.com
373361 Logically dead code
sthotton@marvell.com
370584 Reliance on integer endianness
sthotton@marvell.com
370582 Reliance on integer endianness
sthotton@marvell.com
370581 Division or modulo by float
zersthotton@marvell.com
371873 Wrong sizeof argument
tduszynski@marvell.com
373627 Dereference after null check
jackmin@mellanox.com
373633 Out-of-bounds access
viacheslavo@mellanox.com
373708 Waiting while holding a lock
xuemingl@mellanox.com
373664 Unchecked return value
stephen@networkplumber.org
373662 Unchecked return value
stephen@networkplumber.org
373661 Dereference after null check
stephen@networkplumber.org
375091 Division or modulo by zero
dkozlyuk@nvidia.com
374940 Uninitialized scalar variable
eagostini@nvidia.com
374376 Unchecked return value
eagostini@nvidia.com
374373 Uninitialized pointer read
eagostini@nvidia.com
370611 Bad bit shift operation
shunh@nvidia.com
374378 Structurally dead code
suanmingm@nvidia.com
373691 Waiting while holding a lock
xuemingl@nvidia.com
374021 Untrusted value as argument
apeksha.gupta@nxp.com
374020 Argument cannot be negative
apeksha.gupta@nxp.com
374017 Resource leak
apeksha.gupta@nxp.com
374016 Unused value
apeksha.gupta@nxp.com
374015 String not null terminated
apeksha.gupta@nxp.com
373161 Structurally dead code
franck.lenormand@nxp.com
373908 Unused value g.singh@nxp.com
373907 Unused value
g.singh@nxp.com
373619 Out-of-bounds access
g.singh@nxp.com
373621 Resource leak
hemant.agrawal@nxp.com
373618 Uninitialized scalar variable
hemant.agrawal@nxp.com
373617 Argument cannot be negative
hemant.agrawal@nxp.com
373424 Dereference before null check
hemant.agrawal@nxp.com
373422 Dereference before null check
hemant.agrawal@nxp.com
373421 Unintentional integer overflow
hemant.agrawal@nxp.com
373415 Dereference before null check
hemant.agrawal@nxp.com
373414 Dereference before null check
hemant.agrawal@nxp.com
373412 Dereference before null check
hemant.agrawal@nxp.com
367380 Dereference before null check
hemant.agrawal@nxp.com
375066 Resource leak
jun.yang@nxp.com
375063 Resource leak
jun.yang@nxp.com
375062 Resource leak
jun.yang@nxp.com
375061 Resource leak
jun.yang@nxp.com
375060 Argument cannot be negative
jun.yang@nxp.com
367378 Explicit null dereferenced
nipun.gupta@nxp.com
373703 Resource leak shreyansh.jain@nxp.com
373874 Uninitialized scalar variable
ivan.ilchenko@oktetlabs.ru
372201 Unchecked return value
zyta.szpak@semihalf.com
373893 Out-of-bounds write
jiawenwu@trustnetic.com
373884 Logically dead code
jiawenwu@trustnetic.com
373883 Memset buffer size of 0
jiawenwu@trustnetic.com
373880 Out-of-bounds read
jiawenwu@trustnetic.com
373873 Unchecked return value
jiawenwu@trustnetic.com
373881 Dereference after null check
vsrivast@xilinx.com
373876 Dereference after null check
vsrivast@xilinx.com
373872 Dereference after null check
vsrivast@xilinx.com