From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01399A04B1; Wed, 23 Sep 2020 13:58:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D7F521DB51; Wed, 23 Sep 2020 13:58:31 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id EAE8D1DAD1 for ; Wed, 23 Sep 2020 13:58:29 +0200 (CEST) IronPort-SDR: L5Ltkzz82ixHBuAco9bSu/JXXaGVur7f/VTjb2Mv6KqG3UpwOvpuTBWWUilejR8U7WSQ1fuX91 Lrujdc06vD6A== X-IronPort-AV: E=McAfee;i="6000,8403,9752"; a="140337667" X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="140337667" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2020 04:58:27 -0700 IronPort-SDR: podeL0ZbMtNB/DUMcLH12OX51l4AnPfuZGhJVuFIJX/oG3DuEKNGF0FQkMZ/RbeI4ysKUEskaD xJMVUVXb8d3A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,293,1596524400"; d="scan'208";a="322573973" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga002.jf.intel.com with ESMTP; 23 Sep 2020 04:58:27 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 23 Sep 2020 04:58:27 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 23 Sep 2020 04:58:26 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 23 Sep 2020 04:58:26 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 23 Sep 2020 04:58:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMGgnVbcXDO9UnYFPi1W8obRIdqQ24ICzb/9oRlUp0ZsrWSaOFanh+xe8nILs8usdxIEywmxaMjk/FygIqJvz7ZjBtL+c/Eo7hM1HH+I2z0HbqKx+71/bXPj9mfcqnsKA/6JYzAJYqqOZW2TG4ACzF8iojU7BgcxjS/3oenS9rOf1vJX0SgBiXU3pMaDgMdUYhxA5INtdZvzPKKxO96mfvDCahdJykKsVe46WzaTME5WxyKzlHp4k/2Yc5t4sCTNruaUma6pRWXU+hp1eXHi3igZfs23QlKy9yqFcyFQjn2DP/cH7EcIUSEmxR3TRFh6wc1uS6iVzSEaWNlLKWSM8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OGPAUPETr2Np2GSJcFIap+Aa8IYEjwCGHdWNykn2GNA=; b=mv3B6yyqM4ws9n8VD4GkDU7+2Yjvf9/thhFI7yWOs5+ZypODZyqilqubUWjjdeF3FuNZdQeYDHs6RLFZHQatuB0/vdhWKDrlYcevilx+/v2OrPK8p4/H6yFPASJ7jl/DWb1RlmKVGZqSCgaJAuu0usfOpN0wQTfXC7YeKsb3gIiTtAEOAFtYvnm31ahtuA/utNfOvHOLlrOtffr8O+P4gyG9QzIKzjsk3oSt/eJaBzP935ozaRU3vbBiWpGX+9k68+L9tejfmFW/zIp7oFjkejkbtOAgFZu3oRSctpqa6JQugcY9z3mYnXJ1jZ1UxXHFwBxBi4GRAqtqh4jaQ7DQEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OGPAUPETr2Np2GSJcFIap+Aa8IYEjwCGHdWNykn2GNA=; b=VHoEpHGqxDTPs71Q8LDAl55Z74QFBzYQrCncHGyOhfrV76e2lYDncx22wK30T+Fgzyqv+yUwXEZlL/aTCPO+vWP+UhFWdpXsrd9f6t7p0jJSQxjhnfjonPK/oSEhfcyofwB4iAC4H6Y7ghBoXbVoa/btSWYo1nLQvq36xd+eUqE= Received: from DM6PR11MB3308.namprd11.prod.outlook.com (2603:10b6:5:d::22) by DM5PR1101MB2345.namprd11.prod.outlook.com (2603:10b6:3:a4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Wed, 23 Sep 2020 11:58:24 +0000 Received: from DM6PR11MB3308.namprd11.prod.outlook.com ([fe80::c4b7:e033:16a1:b8c9]) by DM6PR11MB3308.namprd11.prod.outlook.com ([fe80::c4b7:e033:16a1:b8c9%3]) with mapi id 15.20.3391.026; Wed, 23 Sep 2020 11:58:24 +0000 From: "Ananyev, Konstantin" To: Honnappa Nagarahalli , "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Doherty, Declan" CC: "jerinj@marvell.com" , "Akhil.goyal@nxp.com" , "Vangati, Narender" , nd , nd Thread-Topic: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions Thread-Index: AQHWhsTbY+pAzzKww0euN2orABmUValrRWzAgAAl9gCAAW0pMIAGJnUAgAAH/lCAAp3uAIAAgn/g Date: Wed, 23 Sep 2020 11:58:23 +0000 Message-ID: References: <1599549024-195051-1-git-send-email-abhinandan.gujjar@intel.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [46.7.39.127] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2fc31563-c58e-495a-60f7-08d85fb7f965 x-ms-traffictypediagnostic: DM5PR1101MB2345: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SXpiiyiUdefZhTJvRh3Wi6h85djDCxpyQ+zxs0gjdMf5FyiEFPKZ43UmOOGOuZh15bNMUpBHN7STKw1yBv8EcyngDdhBdBrXzpRCuugATE13ll9X/st3PEZWgmiKa5+Z6Kgpmxd6ke9lhcJ4DWf1JRqqWCXj58vvicTuylTy8xiw0NK5+JsBqg8ZXrMsZ+SKLTE0mQYJK3C0wYhF1RVd9jEoEeQ2u5qMBE54qUvclIJWtUC9dKH7S1m+lSoYMHm0Jb+lm7YaAlZ4cjjcglHvVI4Uf4dasOjSDnnGdgg909VdkG3PJa11wE6nWgMQSv87/zt/ipCbfYBG/NfZwAEszeijUiIsJfyP3KRpmRcpfXKq+iDh1Ibzi3Ghg//uCzDgY6w9+cg1hELSgevmIBU3hQj85IisKU9ZPXtj9HbWpJQvrrhJkStvLv7Z6RkvmJ2yuBcQpAT1AP+dYIP36hJZcQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3308.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(366004)(376002)(346002)(396003)(33656002)(71200400001)(7696005)(316002)(30864003)(2906002)(5660300002)(52536014)(966005)(54906003)(6636002)(110136005)(478600001)(186003)(83380400001)(26005)(66946007)(55016002)(66476007)(66556008)(64756008)(8676002)(76116006)(66446008)(6506007)(4326008)(9686003)(86362001)(8936002)(559001)(579004); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: lQx5i4l7COB0fXAGHwx9/Rz9wxWrjvZcgE+Bi45azeZBtT08Yb3e633UBoXPjGtLRvjt/XKr0NXB58R8+YUYlX4QmBo/gw1a9WbJk8mTCyYhlPc+m07V77YAabSuxpHSCRXp8bNLWPvozuXFOVFIpEylLbAe5h/t+AQd+ogv6tVzQ12/DxKUUJ1JZoVx2546kr8hWCNR0EZVGvoXtzXMNrzQjFWYJguH/AanKCH/Io9Snim9LhKum3dixtbAdqW1XNlUAvvsnWR1zERIyP1VIKhCOyCWa21qNkvvqavUa+HOlBPHRlWtJyeGuND191oH6AGaGfCFa5ajy5Ms0r9Of0+OkunIqh+VPEKBGNOMG0yzEf/ofdiIVpD4b1Xzg3AbCOP89xM9VHONAzm5d8bmtmCD7XbPncjB31sVWtoo7GOFrGY2zq1LfooqYHU/oMUq11x4vpAEs8nNy9mjsIs+rQhr2YMCzxfe9WMmLFeJR2fjeokZn+nvXhKr2u2ZHD6KjUpklaNUutVjf4cUZ97Q6HazhyCUoeFk0YCZYKbRSk/cwvSrJWKY9z7BzPUFMz6I6UvvWeXUFaE0b7rC2DenM2hVwHoIbgBirgK8cQZAcrm9VS+xa3MK10iFneqNx7NNyecijCifKBFfF2K7l5Wjqg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3308.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fc31563-c58e-495a-60f7-08d85fb7f965 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Sep 2020 11:58:23.9340 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SxAeCqVpoCPR4GZgQmD8wjFQMfS/9omBgYQWWSyzoZVWztsQ9p58nzjYux8nUzXZekcQtSM0s11nvKtMgfXuCSsStEpICwPS1UqMgr+dcY8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2345 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [v2 1/2] cryptodev: support enqueue callback functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > > > > > > > > > > > In an eventdev world, multiple workers (with ordered queue) > > > > > > > will be working on IPsec ESP processing. The ESP header's > > > > > > > sequence number is unique and has to be sequentially > > > > > > > incremented in an orderly > > > > manner. > > > > > > > This rises a need for incrementing sequence number in crypto > > > > > > > stage especially in event crypto adapter. By adding a user > > > > > > > callback to cryptodev at enqueue burst, the user callback wil= l > > > > > > > get executed in the context of event crypto adapter. This > > > > > > > helps the application to increment the ESP sequence number > > atomically and orderly manner. > > > > > > > > > > > > > > This patch adds APIs to add/remove callback functions. The > > > > > > > callback function will be called for each burst of crypto ops > > > > > > > received on a given crypto device queue pair. > > > > > > > > > > > > > > v1->v2: > > > > > > > Moved callback related members to the end of cryptodev struct > > > > > > > Added support for RCU > > > > > > > > > > > > > > Signed-off-by: Abhinandan Gujjar > > > > > > > --- > > > > > > > config/common_base | 1 + > > > > > > > lib/librte_cryptodev/Makefile | 2 +- > > > > > > > lib/librte_cryptodev/rte_cryptodev.c | 157 > > > > > > +++++++++++++++++++++++++ > > > > > > > lib/librte_cryptodev/rte_cryptodev.h | 154 > > > > > > +++++++++++++++++++++++- > > > > > > > lib/librte_cryptodev/rte_cryptodev_version.map | 6 + > > > > > > > 5 files changed, 318 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > diff --git a/config/common_base b/config/common_base index > > > > > > > fbf0ee7..f5ebde4 100644 > > > > > > > --- a/config/common_base > > > > > > > +++ b/config/common_base > > > > > > > @@ -599,6 +599,7 @@ > > > > > > CONFIG_RTE_LIBRTE_PMD_BBDEV_FPGA_5GNR_FEC=3Dy > > > > > > > # > > > > > > > CONFIG_RTE_LIBRTE_CRYPTODEV=3Dy > > > > > > > CONFIG_RTE_CRYPTO_MAX_DEVS=3D64 > > > > > > > +CONFIG_RTE_CRYPTODEV_CALLBACKS=3Dy > > > > > > > > > > > > > > # > > > > > > > # Compile PMD for ARMv8 Crypto device diff --git > > > > > > > a/lib/librte_cryptodev/Makefile > > > > > > > b/lib/librte_cryptodev/Makefile index > > > > > > > 73e77a2..514d552 100644 > > > > > > > --- a/lib/librte_cryptodev/Makefile > > > > > > > +++ b/lib/librte_cryptodev/Makefile > > > > > > > @@ -10,7 +10,7 @@ LIB =3D librte_cryptodev.a CFLAGS +=3D -O3 > > > > > > > CFLAGS > > > > > > > +=3D > > > > > > > $(WERROR_FLAGS) LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_ri= ng > > > > > > > -lrte_mbuf -LDLIBS +=3D -lrte_kvargs > > > > > > > +LDLIBS +=3D -lrte_kvargs -lrte_rcu > > > > > > > > > > > > > > # library source files > > > > > > > SRCS-y +=3D rte_cryptodev.c rte_cryptodev_pmd.c > > > > > > > cryptodev_trace_points.c diff --git > > > > > > > a/lib/librte_cryptodev/rte_cryptodev.c > > > > > > > b/lib/librte_cryptodev/rte_cryptodev.c > > > > > > > index 1dd795b..2fb3e35 100644 > > > > > > > --- a/lib/librte_cryptodev/rte_cryptodev.c > > > > > > > +++ b/lib/librte_cryptodev/rte_cryptodev.c > > > > > > > @@ -38,6 +38,7 @@ > > > > > > > #include > > > > > > > #include > > > > > > > #include > > > > > > > +#include > > > > > > > > > > > > > > #include "rte_crypto.h" > > > > > > > #include "rte_cryptodev.h" > > > > > > > @@ -499,6 +500,10 @@ struct > > > > > > rte_cryptodev_sym_session_pool_private_data { > > > > > > > return 0; > > > > > > > } > > > > > > > > > > > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > > > > > > +/* spinlock for crypto device enq callbacks */ static > > > > > > > +rte_spinlock_t rte_cryptodev_enq_cb_lock =3D > > > > > > > +RTE_SPINLOCK_INITIALIZER; #endif > > > > > > > > > > > > > > const char * > > > > > > > rte_cryptodev_get_feature_name(uint64_t flag) @@ -1449,6 > > > > > > > +1454,158 > > > > > > @@ > > > > > > > struct rte_cryptodev * > > > > > > > rte_spinlock_unlock(&rte_cryptodev_cb_lock); > > > > > > > } > > > > > > > > > > > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS int > > > > > > > +rte_cryptodev_rcu_qsbr_add(uint8_t dev_id, struct > > > > > > > +rte_rcu_qsbr > > > > > > > +*qsbr) { > > > > > > > + > > > > > > > + struct rte_cryptodev *dev; > > > > > > > + > > > > > > > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > > > > > > > + CDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, dev_id); > > > > > > > + return -EINVAL; > > > > > > > + } > > > > > > > + > > > > > > > + dev =3D &rte_crypto_devices[dev_id]; > > > > > > > + dev->qsbr =3D qsbr; > > > > > > > + return 0; > > > > > > > +} > > > > > > > > > > > > So if I understand your patch correctly you propose a new > > > > > > working model for > > > > > > crypto-devs: > > > > > > 1. Control-plane has to allocate/setup rcu_qsbr and do > > > > > > rte_cryptodev_rcu_qsbr_add(). > > > > > > 2. Data-plane has somehow to obtain pointer to that rcu_qsbr an= d > > > > > > wrap > > > > > > cryptodev_enqueue() > > > > > > with rcu_qsbr_quiescent() or rcu_qsbr_online()/rcu_qsbr_off= line(). > > > > > Yes. I think, it is not a new model. It is same as RCU integratio= n with > > LPM. > > > > > Please refer: https://patches.dpdk.org/cover/73673/ > > > > > > > > I am talking about new working model for crypto-dev enqueue/dequeue= . > > > > As I said above now it becomes data-plane thread responsibility to: > > > > -somehow to obtain pointer to that rcu_qsbr for each cryptodev it = is > > using. > > > > -call rcu sync functions (quiescent/online/offline) on a regular b= asis. > > > It is not on regular basis. When data plane comes up, they report onl= ine. > > > They report quiescent when they are done with critical section or sha= red > > structure. > > > > I understand that, but it means all existing apps have to be changed th= at way. > > > > > All though, there is some dataplane changes involved here, I don't th= ink, it > > is major. > > > > I still think our goal here should be to make no visible changes to the > > dataplane. > > I.E. all necessary data-plane changes need to be hidden inside CB invoc= ation > > part. > Please note that this is being implemented using the memory reclamation f= ramework documented at > https://doc.dpdk.org/guides/prog_guide/rcu_lib.html#resource-reclamation-= framework-for-dpdk >=20 > While using RCU there are couple of trade-offs that applications have to = consider: > 1) Performance - reporting the quiescent state too often results in perfo= rmance impact on data plane > 2) Amount of outstanding memory to reclaim - reporting less often results= in more outstanding memory to reclaim >=20 > Hence, the quiescent state reporting is left to the application. The appl= ication decides how often it reports the quiescent state and has > control over the data plane performance and the outstanding memory to rec= laim. >=20 > When you say "new working model for crypto-dev enqueue/dequeue", >=20 > 1) are you comparing these with existing crypto-dev enqueue/dequeue APIs?= If yes, these are new APIs, it is not breaking anything. > 2) are you comparing these with existing call back functions in ethdev en= queue/dequeue APIs? If yes, agree that this is a new model. But, it > is possible to support what ethdev supports along with the RCU method use= d in this patch. What I am talking about: Existing cryptodev enqueue/dequeue model doesn't require for the user to ma= nage any RCU QSBR state manually. I believe that addition of ability to add/remove enqueue/dequeue callbacks = shouldn't change existing working model. I think that adding/removing such callbacks has to be opaque to the user DP= code and shouldn't require user to change it. Same as we have now for ethdev callback implementation. I think that forcing DP code to be aware that callbacks are present or not = and to modify its behaviour depending on that nearly voids the purpose of havin= g callbacks at all. In that case DP can just invoke callback function directly from it's codepa= th . > > > > > > > > > Note that now data-plane thread would have to do that always - even > > > > if there are now callbacks installed for that cryptodev queue right= now. > > > > All that changes behaviour of existing apps and I presume would > > > > reduce adoption of that fature. > If I understand this correct, you are talking about a case where in the a= pplication might be registering/unregistering multiple times during its > lifetime. In this case, yes, the application might be reporting the quies= cent state even when it has not registered the call backs. But, it has > the flexibility to not report it if it implements additional logic. > Note that we are assuming that the application has to report quiescent st= ate only for using callback functions. Most probably the > application has other requirements to use RCU. > Why not support what is done for ethdev call back functions along with pr= oviding RCU method? >=20 > > > There is always trade off involved! > > > In the previous patch, you suggested that some lazy app may not free > > > up the memory allocated by add cb. For such apps, this patch has sync > > > mechanism with some additional cost of CP & DP changes. > > > > Sigh, it is not about laziness of the app. > > The problem with current ethedev cb mechanism and yours V1 (which was > > just a clone of it) - CP doesn't know when it is safe after CB removal = to free > > related memory. > > > > > > I still think all this callback mechanism should be totally opaque > > > > to data-plane threads - user shouldn't change his app code dependin= g > > > > on would some enqueue/dequeue callbacks be installed or not. > > > I am not sure, how that can be implemented with existing RCU design. > > > > As I said below the simplest way - with calling rcu onine/offline insid= e CB > > invocation block. > > That's why I asked you - did you try that approach and what is the perf > > numbers? > > I presume with no callbacks installed the perf change should be nearly = zero. > > > > > @Honnappa Nagarahalli, Do you have any suggestions? > Reporting quiescent state in the call back functions has several disadvan= tages: > 1) it will have performance impacts and the impacts will increase as the = number of data plane threads increase. > 2) It will require additional configuration parameters to control how oft= en the quiescent state is reported to control the performance > impact. > 3) Does not take advantage of the fact that most probably the application= is using RCU already > 4) There are few difficulties as well, please see below. I suggested Abhinandan to use RCU library because it is already there, and I thought it would be good not to re-implement the wheel. Though if you feel librte_rcu doesn't match that task - fine, let's do it w= ithout librte_rcu. After all, what we need here - just an atomic ref count per queue that we a= re going to increment at entering and leaving list of callbacks inside enqueue/dequeue.=20 >=20 > > > > > > > > > > > > > > > > > > > > > > > > That seems quite a big change and I don't think it is acceptabl= e > > > > > > for most users. > > > > > > From my perspective adding/installing call-backs to the dev has > > > > > > to be opaque to the data-plane code. > > > > > > Also note that different callbacks can be installed by differen= t > > > > > > entities (libs) and might have no idea about each other. > > > > > > That's why I thought it would be better to make all this RCU > > > > > > stuff internal inside cryptodev: > > > > > > hide all this rcu_qsbr allocation/setup inside cryptod > > > > > > somehow to > > > > obtain pointer to that rcu_qsbr ev init/queue setup > > > > > > invoke rcu_qsbr_online()/rcu_qsbr_offline() inside > > > > cryptodev_enqueue(). > This will bring in the application related information such as the thread= ID into the library. I don't think it would. Cryptodev enqueue/dequeue functions are not supposed to be thread safe (sam= e as rx/tx burst). So we can always use RCU with just one thread(thread_id =3D 0). But as I said above - if you feel RCU lib is an overhead here, that's fine = - I think it would be easy enough to do without librte_rcu.=20 > If the same API calls are being made from multiple > data plane threads, you need a way to configure that information to the l= ibrary. So, it is better to leave those details for the application to > handle. >=20 > > > > > I have already tried exploring above stuffs. There are too many > > constraints. > > > > > The changes don't fit in, as per RCU design. > > > > > > > > Hmm could you be more specific here - what constraints are you > > > > referring to? > > > > > > > > > Moreover, having rcu api under enqueue_burst() will affect the > > > > performance. > > > > > > > > It most likely will. Though my expectation it will affect > > > > performance only when some callbacks are installed. My thought here= : > > > > callback function by itself will affect cryptdev_enqueue performanc= e > > > > anyway, > > > With existing callback design, I have measured the performance(with > > crypto perf test) on xeon. > > > It was almost negligible and same was shared with Declan. > > > > I am asking about different thing: did you try alternate approach I des= cribed, > > that wouldn't require changes in the user data-plane code. > > > > > That is one of the reasons, I didn't want to add to many stuffs in to= the > > callback. > > > The best part of existing design is crypto lib is not much modified. > > > The changes are either pushed to CP or DP. > > > > > > so adding extra overhead for sync is probably ok here. > > > > I think that extra overhead when callbacks are present is expected and > > probably acceptable. > > Changes in the upper-layer data-plane code - probably not. > > > > > > Though for situation when no callbacks are installed - perfomance > > > > should be left unaffected (or impact should be as small as possible= ). > > > > > > > > > The changes are more on control plane side, which is one time. > > > > > The data plane changes are minimal. > > > > > > > > I still think upper layer data-plane code should stay unaffected > > > > (zero changes). > > > > > > > > > > > > > > > > > + > > > > > > > +struct rte_cryptodev_enq_callback * > > > > > > > +rte_cryptodev_add_enq_callback(uint8_t dev_id, > > > > > > > + uint16_t qp_id, > > > > > > > + rte_cryptodev_enq_cb_fn cb_fn, > > > > > > > + void *cb_arg) > > > > > > > +{ > > > > > > > + struct rte_cryptodev *dev; > > > > > > > + struct rte_cryptodev_enq_callback *cb, *tail; > > > > > > > + > > > > > > > + if (!cb_fn) > > > > > > > + return NULL; > > > > > > > + > > > > > > > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > > > > > > > + CDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, dev_id); > > > > > > > + return NULL; > > > > > > > + } > > > > > > > + > > > > > > > + dev =3D &rte_crypto_devices[dev_id]; > > > > > > > + if (qp_id >=3D dev->data->nb_queue_pairs) { > > > > > > > + CDEV_LOG_ERR("Invalid queue_pair_id=3D%d", qp_id); > > > > > > > + return NULL; > > > > > > > + } > > > > > > > + > > > > > > > + cb =3D rte_zmalloc(NULL, sizeof(*cb), 0); > > > > > > > + if (cb =3D=3D NULL) { > > > > > > > + CDEV_LOG_ERR("Failed to allocate memory for > > callback on " > > > > > > > + "dev=3D%d, queue_pair_id=3D%d", dev_id, > > qp_id); > > > > > > > + rte_errno =3D ENOMEM; > > > > > > > + return NULL; > > > > > > > + } > > > > > > > + > > > > > > > + cb->fn =3D cb_fn; > > > > > > > + cb->arg =3D cb_arg; > > > > > > > + > > > > > > > + rte_spinlock_lock(&rte_cryptodev_enq_cb_lock); > > > > > > > + if (dev->enq_cbs =3D=3D NULL) { > > > > > > > + dev->enq_cbs =3D rte_zmalloc(NULL, sizeof(cb) * > > > > > > > + dev->data- > > >nb_queue_pairs, 0); > > > > > > > + if (dev->enq_cbs =3D=3D NULL) { > > > > > > > + CDEV_LOG_ERR("Failed to allocate memory > > for > > > > > > callbacks"); > > > > > > > + rte_errno =3D ENOMEM; > > > > > > > + rte_free(cb); > > > > > > > + return NULL; > > > > > > > + } > > > > > > > + } > > > > > > > + > > > > > > > + /* Add the callbacks in fifo order. */ > > > > > > > + tail =3D dev->enq_cbs[qp_id]; > > > > > > > + if (tail) { > > > > > > > + while (tail->next) > > > > > > > + tail =3D tail->next; > > > > > > > + tail->next =3D cb; > > > > > > > + } else > > > > > > > + dev->enq_cbs[qp_id] =3D cb; > > > > > > > + > > > > > > > + rte_spinlock_unlock(&rte_cryptodev_enq_cb_lock); > > > > > > > + > > > > > > > + return cb; > > > > > > > +} > > > > > > > + > > > > > > > +int > > > > > > > +rte_cryptodev_remove_enq_callback(uint8_t dev_id, > > > > > > > + uint16_t qp_id, > > > > > > > + struct rte_cryptodev_enq_callback > > *cb) { > > > > > > > + struct rte_cryptodev *dev; > > > > > > > + struct rte_cryptodev_enq_callback **prev_cb, *curr_cb; > > > > > > > + uint16_t qp; > > > > > > > + int free_mem; > > > > > > > + int ret; > > > > > > > + > > > > > > > + free_mem =3D 1; > > > > > > > + > > > > > > > + if (!cb) { > > > > > > > + CDEV_LOG_ERR("cb is NULL"); > > > > > > > + return -EINVAL; > > > > > > > + } > > > > > > > + > > > > > > > + if (!rte_cryptodev_pmd_is_valid_dev(dev_id)) { > > > > > > > + CDEV_LOG_ERR("Invalid dev_id=3D%" PRIu8, dev_id); > > > > > > > + return -EINVAL; > > > > > > > + } > > > > > > > + > > > > > > > + dev =3D &rte_crypto_devices[dev_id]; > > > > > > > + if (qp_id >=3D dev->data->nb_queue_pairs) { > > > > > > > + CDEV_LOG_ERR("Invalid queue_pair_id=3D%d", qp_id); > > > > > > > + return -EINVAL; > > > > > > > + } > > > > > > > + > > > > > > > + if (!dev->qsbr) { > > > > > > > + CDEV_LOG_ERR("Rcu qsbr is NULL"); > > > > > > > + return -EINVAL; > > > > > > > + } > > > > > > > + > > > > > > > + rte_spinlock_lock(&rte_cryptodev_enq_cb_lock); > > > > > > > + if (dev->enq_cbs =3D=3D NULL) { > > > > > > > + rte_spinlock_unlock(&rte_cryptodev_enq_cb_lock); > > > > > > > + return -EINVAL; > > > > > > > + } > > > > > > > + > > > > > > > + prev_cb =3D &dev->enq_cbs[qp_id]; > > > > > > > + for (; *prev_cb !=3D NULL; prev_cb =3D &curr_cb->next) { > > > > > > > + curr_cb =3D *prev_cb; > > > > > > > + if (curr_cb =3D=3D cb) { > > > > > > > + /* Remove the user cb from the callback list. > > */ > > > > > > > + *prev_cb =3D curr_cb->next; > > > > > > > + ret =3D 0; > > > > > > > + break; > > > > > > > + } > > > > > > > + } > > > > > > > + > > > > > > > + if (!ret) { > > > > > > > + /* Call sync with invalid thread id as this is part of > > > > > > > + * control plane API */ > > > > > > > + rte_rcu_qsbr_synchronize(dev->qsbr, > > > > > > > + RTE_QSBR_THRID_INVALID); > > > > > > > + rte_free(cb); > > > > > > > + } > > > > > > > + > > > > > > > + for (qp =3D 0; qp < dev->data->nb_queue_pairs; qp++) > > > > > > > + if (dev->enq_cbs[qp] !=3D NULL) { > > > > > > > > > > > > Some reference count (number of callbacks) seems like a better > > > > > > approach here. > > > > > Ok. > > > > > > > > > > > > > + free_mem =3D 0; > > > > > > > + break; > > > > > > > + } > > > > > > > + > > > > > > > + if (free_mem) { > > > > > > > + rte_free(dev->enq_cbs); > > > > > > > + dev->enq_cbs =3D NULL; > > > > > > > + } > > > > > > > + > > > > > > > + rte_spinlock_unlock(&rte_cryptodev_enq_cb_lock); > > > > > > > + > > > > > > > + return ret; > > > > > > > +} > > > > > > > +#endif > > > > > > > > > > > > > > int > > > > > > > rte_cryptodev_sym_session_init(uint8_t dev_id, diff --git > > > > > > > a/lib/librte_cryptodev/rte_cryptodev.h > > > > > > > b/lib/librte_cryptodev/rte_cryptodev.h > > > > > > > index 7b3ebc2..2c7a47b 100644 > > > > > > > --- a/lib/librte_cryptodev/rte_cryptodev.h > > > > > > > +++ b/lib/librte_cryptodev/rte_cryptodev.h > > > > > > > @@ -530,6 +530,32 @@ struct rte_cryptodev_qp_conf { }; > > > > > > > > > > > > > > /** > > > > > > > + * Function type used for pre processing crypto ops when > > > > > > > +enqueue burst is > > > > > > > + * called. > > > > > > > + * > > > > > > > + * The callback function is called on enqueue burst > > > > > > > +immediately > > > > > > > + * before the crypto ops are put onto the hardware queue for > > > > processing. > > > > > > > + * > > > > > > > + * @param dev_id The identifier of the device. > > > > > > > + * @param qp_id The index of the queue pair in which > > > > ops are > > > > > > > + * to be enqueued for processing. The > > > > value > > > > > > > + * must be in the range [0, > > > > nb_queue_pairs - 1] > > > > > > > + * previously supplied to > > > > > > > + * *rte_cryptodev_configure*. > > > > > > > + * @param ops The address of an array of *nb_ops* > > > > pointers > > > > > > > + * to *rte_crypto_op* structures which > > > > contain > > > > > > > + * the crypto operations to be > > > > processed. > > > > > > > + * @param nb_ops The number of operations to process. > > > > > > > + * @param user_param The arbitrary user parameter passed > > > > in by the > > > > > > > + * application when the callback was > > > > originally > > > > > > > + * registered. > > > > > > > + * @return The number of ops to be enqueued > > > > to the > > > > > > > + * crypto device. > > > > > > > + */ > > > > > > > +typedef uint16_t (*rte_cryptodev_enq_cb_fn)(uint16_t dev_id, > > > > > > > +uint16_t > > > > > > qp_id, > > > > > > > + struct rte_crypto_op **ops, uint16_t nb_ops, void > > > > > > *user_param); > > > > > > > + > > > > > > > +/** > > > > > > > * Typedef for application callback function to be registere= d > > > > > > > by > > > > application > > > > > > > * software for notification of device events > > > > > > > * > > > > > > > @@ -853,7 +879,6 @@ struct rte_cryptodev_config { > > > > > > > enum rte_cryptodev_event_type event, > > > > > > > rte_cryptodev_cb_fn cb_fn, void *cb_arg); > > > > > > > > > > > > > > - > > > > > > > typedef uint16_t (*dequeue_pkt_burst_t)(void *qp, > > > > > > > struct rte_crypto_op **ops, uint16_t nb_ops); > > > > > > > /**< Dequeue processed packets from queue pair of a device. > > > > > > > */ @@ > > > > > > > -870,6 +895,17 @@ typedef uint16_t (*enqueue_pkt_burst_t)(voi= d > > > > > > > *qp, > > > > > > > /** Structure to keep track of registered callbacks */ > > > > > > > TAILQ_HEAD(rte_cryptodev_cb_list, rte_cryptodev_callback); > > > > > > > > > > > > > > +/** > > > > > > > + * @internal > > > > > > > + * Structure used to hold information about the callbacks to > > > > > > > +be called for a > > > > > > > + * queue pair on enqueue. > > > > > > > + */ > > > > > > > +struct rte_cryptodev_enq_callback { > > > > > > > + struct rte_cryptodev_enq_callback *next; > > > > > > > + rte_cryptodev_enq_cb_fn fn; > > > > > > > + void *arg; > > > > > > > +}; > > > > > > > + > > > > > > > /** The data structure associated with each crypto device. *= / > > > > > > > struct rte_cryptodev { > > > > > > > dequeue_pkt_burst_t dequeue_burst; @@ -898,6 +934,14 > > @@ > > > > struct > > > > > > > rte_cryptodev { > > > > > > > __extension__ > > > > > > > uint8_t attached : 1; > > > > > > > /**< Flag indicating the device is attached */ > > > > > > > + > > > > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > > > > > > + struct rte_cryptodev_enq_callback **enq_cbs; > > > > > > > + /**< User application callback for pre enqueue processing *= / > > > > > > > + > > > > > > > + struct rte_rcu_qsbr *qsbr; > > > > > > > + /** < RCU QSBR variable for rte_cryptodev_enq_callback */ > > > > > > > > > > > > Probably better to have both these fields per queue. > > > > > > Space for them can be allocated at dev_configure() or so. > > > > > enq_cbs is allocated during callback add. > > > > > Unlike ethdev, each cryptodev have their own max queue pair. Ther= e > > > > > is no > > > > macro for that. > > > > > I think, single RCU should be good enough, as it has mechanism to > > > > > track all > > > > its reporting threads. > > > > > > > > > > > BTW, wouldn't it make sense to have ability to add callback for > > > > > > dequeue > > > > too? > > > > > As mentioned in the commit message, this patch was driven by a > > > > requirement. > > > > > If required, callback for the dequeue can be added in a separate = patch. > > > > > > > > > > > > > +#endif > > > > > > > } __rte_cache_aligned; > > > > > > > > > > > > > > void * > > > > > > > @@ -1019,6 +1063,18 @@ struct rte_cryptodev_data { > > > > > > > struct rte_crypto_op **ops, uint16_t nb_ops) { > > > > > > > struct rte_cryptodev *dev =3D &rte_cryptodevs[dev_id]; > > > > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > > > > > > + if (unlikely(dev->enq_cbs !=3D NULL && dev- > > >enq_cbs[qp_id] !=3D > > > > > > NULL)) { > > > > > > > + struct rte_cryptodev_enq_callback *cb =3D > > > > > > > + dev->enq_cbs[qp_id]; > > > > > > > + > > > > > > > + do { > > > > > > > + nb_ops =3D cb->fn(dev_id, qp_id, ops, nb_ops, > > > > > > > + cb->arg); > > > > > > > + cb =3D cb->next; > > > > > > > + } while (cb !=3D NULL); > > > > > > > + } > > > > > > > +#endif > > > > > > > > > > > > > > rte_cryptodev_trace_enqueue_burst(dev_id, qp_id, (void > > > > > > > **)ops, > > > > > > nb_ops); > > > > > > > return (*dev->enqueue_burst)( @@ -1351,6 +1407,102 @@ > > struct > > > > > > > rte_cryptodev_asym_session * > > > > > > > struct rte_cryptodev_sym_session *sess, union > > > > > > > rte_crypto_sym_ofs > > > > > > ofs, > > > > > > > struct rte_crypto_sym_vec *vec); > > > > > > > > > > > > > > +#ifdef RTE_CRYPTODEV_CALLBACKS > > > > > > > +/** > > > > > > > + * @warning > > > > > > > + * @b EXPERIMENTAL: this API may change without prior notice > > > > > > > + * > > > > > > > + * Add a user callback for a given crypto device and queue > > > > > > > +pair which will be > > > > > > > + * called on crypto ops enqueue. > > > > > > > + * > > > > > > > + * This API configures a function to be called for each burs= t > > > > > > > +of crypto ops > > > > > > > + * received on a given crypto device queue pair. The return > > > > > > > +value is a pointer > > > > > > > + * that can be used later to remove the callback using > > > > > > > + * rte_cryptodev_remove_enq_callback(). > > > > > > > + * > > > > > > > + * Multiple functions are called in the order that they are = added. > > > > > > > + * > > > > > > > + * @param dev_id The identifier of the device. > > > > > > > + * @param qp_id The index of the queue pair in which > > > > ops are > > > > > > > + * to be enqueued for processing. The > > > > value > > > > > > > + * must be in the range [0, > > > > nb_queue_pairs - 1] > > > > > > > + * previously supplied to > > > > > > > + * *rte_cryptodev_configure*. > > > > > > > + * @param cb_fn The callback function > > > > > > > + * @param cb_arg A generic pointer parameter which > > > > will be > > > > > > passed > > > > > > > + * to each invocation of the callback > > > > function on > > > > > > > + * this crypto device and queue pair. > > > > > > > + * > > > > > > > + * @return > > > > > > > + * NULL on error. > > > > > > > + * On success, a pointer value which can later be used to = remove > > the > > > > > > callback. > > > > > > > + */ > > > > > > > + > > > > > > > +__rte_experimental > > > > > > > +struct rte_cryptodev_enq_callback * > > > > > > > +rte_cryptodev_add_enq_callback(uint8_t dev_id, > > > > > > > + uint16_t qp_id, > > > > > > > + rte_cryptodev_enq_cb_fn cb_fn, > > > > > > > + void *cb_arg); > > > > > > > + > > > > > > > + > > > > > > > +/** > > > > > > > + * @warning > > > > > > > + * @b EXPERIMENTAL: this API may change without prior notice > > > > > > > + * > > > > > > > + * Remove a user callback function for given crypto device > > > > > > > +and queue > > > > pair. > > > > > > > + * > > > > > > > + * This function is used to removed callbacks that were adde= d > > > > > > > +to a crypto > > > > > > > + * device queue pair using rte_cryptodev_add_enq_callback(). > > > > > > > + * > > > > > > > + * Note: The callback expects a RCU QSBR to be configured to > > > > > > > +synchronize > > > > > > > + * to free the memory. Application is expected to configure > > > > > > > +RCU QSBR after > > > > > > > + * adding an enqueue callback. > > > > > > > + * > > > > > > > + * > > > > > > > + * @param dev_id The identifier of the device. > > > > > > > + * @param qp_id The index of the queue pair in which > > > > ops are > > > > > > > + * to be enqueued for processing. The > > > > value > > > > > > > + * must be in the range [0, > > > > nb_queue_pairs - 1] > > > > > > > + * previously supplied to > > > > > > > + * *rte_cryptodev_configure*. > > > > > > > + * @param cb Pointer to user supplied callback > > > > created via > > > > > > > + * rte_cryptodev_add_enq_callback(). > > > > > > > + * > > > > > > > + * @return > > > > > > > + * - 0: Success. Callback was removed. > > > > > > > + * - -EINVAL: The dev_id or the qp_id is out of range, or= the > > callback > > > > > > > + * is NULL or not found for the crypto device = queue pair. > > > > > > > + */ > > > > > > > + > > > > > > > +__rte_experimental > > > > > > > +int rte_cryptodev_remove_enq_callback(uint8_t dev_id, > > > > > > > + uint16_t qp_id, > > > > > > > + struct rte_cryptodev_enq_callback > > *cb); > > > > > > > + > > > > > > > + > > > > > > > +/** > > > > > > > + * @warning > > > > > > > + * @b EXPERIMENTAL: this API may change without prior notice > > > > > > > + * > > > > > > > + * Associate RCU QSBR variable with a cryptodev. > > > > > > > + * > > > > > > > + * This function is used to add RCU QSBR to a crypto device. > > > > > > > + * The purpose of RCU is to help multiple threads to > > > > > > > +synchronize > > > > > > > + * with each other before initiating adding/removing callbac= k > > > > > > > + * while dataplane threads are running enqueue callbacks. > > > > > > > + * > > > > > > > + * @param dev_id The identifier of the device. > > > > > > > + * @param qsr RCU QSBR configuration > > > > > > > + * @return > > > > > > > + * On success - 0 > > > > > > > + * On error - EINVAL. > > > > > > > + */ > > > > > > > + > > > > > > > +__rte_experimental > > > > > > > +int rte_cryptodev_rcu_qsbr_add(uint8_t dev_id, struct > > > > > > > +rte_rcu_qsbr *qsbr); #endif > > > > > > > + > > > > > > > #ifdef __cplusplus > > > > > > > } > > > > > > > #endif > > > > > > > diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map > > > > > > > b/lib/librte_cryptodev/rte_cryptodev_version.map > > > > > > > index 02f6dcf..46de3ca 100644 > > > > > > > --- a/lib/librte_cryptodev/rte_cryptodev_version.map > > > > > > > +++ b/lib/librte_cryptodev/rte_cryptodev_version.map > > > > > > > @@ -64,6 +64,7 @@ DPDK_20.0 { > > > > > > > rte_cryptodev_sym_capability_get; }; > > > > > > > > > > > > > > + > > > > > > > EXPERIMENTAL { > > > > > > > global: > > > > > > > > > > > > > > @@ -105,4 +106,9 @@ EXPERIMENTAL { > > > > > > > > > > > > > > # added in 20.08 > > > > > > > rte_cryptodev_get_qp_status; > > > > > > > + > > > > > > > + # added in 20.11 > > > > > > > + rte_cryptodev_add_enq_callback; > > > > > > > + rte_cryptodev_remove_enq_callback; > > > > > > > + rte_cryptodev_rcu_qsbr_add; > > > > > > > }; > > > > > > > -- > > > > > > > 1.9.1