From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AEE89A0542; Fri, 11 Nov 2022 08:12:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 90F2840141; Fri, 11 Nov 2022 08:12:13 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id F24BF400EF for ; Fri, 11 Nov 2022 08:12:11 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668150732; x=1699686732; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=0AXlR0sNkdjWi9/e8N9xXEAfAsQ/V4vyFLBNJ17UH5E=; b=f89EAisgQoIMvsaYyGKLMGZr3cyqpsJXj7lg/0vEMvN5wMd5V9aF8fe7 NXqAAHpAbGPozVIqX6jipjApN0FFOz7mjiG3hIWhYzn/mDDuBRlQ327lL HvG7qig6VTT7IOR9ppdUnPA7Ad2Yj0mebCLigJY1STz9hsSENewsHiYR5 XoBx5fjWvo7mvORaeV0ofymV3bOmVulCqoC2PVYRVSaQDI7qmNIYx4Wai fNuq0RkakK2Rzz5EBy0fc1AWAvhkdE4IQEf9qBTFuzvTIOu7fB8SEZ/A+ Pgn1jStleilYZ7sqFw4QAXiaMP6Uq6MJqyGGbWi5qgdq51faUGxw7ImO5 A==; X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="309167584" X-IronPort-AV: E=Sophos;i="5.96,156,1665471600"; d="scan'208";a="309167584" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2022 23:12:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10527"; a="812351325" X-IronPort-AV: E=Sophos;i="5.96,156,1665471600"; d="scan'208";a="812351325" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga005.jf.intel.com with ESMTP; 10 Nov 2022 23:12:10 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 10 Nov 2022 23:12:10 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Thu, 10 Nov 2022 23:12:10 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Thu, 10 Nov 2022 23:12:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NCQYwSUUH2JTZ4yph4aOFl5EiA35PI5ZNjTVi9rT/A7MyNanOqx5nicwXP/S33Ad53AlBBcjm3NiVlEYLfJc9nJJ8vLl1HbcoFRU4CmrOjhhbK+w7o3tGq8O5Qwxw8mVqewcO/UbcBUct7hLT4nvrKR1FEr4tV9YZvr2i5OVGZYriWizlID+RC9aZ/chyBQE5072HhMYRb/nRZ/SPunFtqng/cHpS7hha+SjlfwgUqkOb4BnAWDdlmKm99cBJR9NqOJAkSjhnybByQ5e9SCyspCPNBm/QJtGAjHLaTN7UJw3geUXYEBuAd6mHPZDDwV5ubUvp2/vobmH3aObm/g3hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=A4ssJiS1W3m620+61H8T7vm4W+EMVz38M3cNaN2Ryik=; b=QfkCD24d487Fnb1f/dO7vIQ0Vxd50i7kD2oTuqbQOW6NxHkV1jYWXeL4KijHj/aQGZHeDZY3KHynMl1WoU8NeH9CheTu1RUmCAKD2t6omO/xnRfIMH2RwMUE4L2g6/EbVlzrfhZY8S21xObARtrWPlHAAxyWDsmydYNF471WtVMCrGJDgr8R1B+/Aip6j16gpFbPEWxurdxs6xOBnaLcMPBUdY1R7mNd+eudKx5ZI4reR6JAIDFUA6aptGFsZRgr6Dh3UURy66ofneVjDYK3nclXSzSKoEUHUrgYQ6uPzpnRJYyS5hTA9yrH4ly2uLesK0bsCCgb2P7PJ+6l5aPW5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3516.namprd11.prod.outlook.com (2603:10b6:5:72::13) by DS0PR11MB7408.namprd11.prod.outlook.com (2603:10b6:8:136::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26; Fri, 11 Nov 2022 07:12:01 +0000 Received: from DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::9f93:b8a6:f860:e660]) by DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::9f93:b8a6:f860:e660%3]) with mapi id 15.20.5813.013; Fri, 11 Nov 2022 07:12:01 +0000 From: "Zhang, Yuying" To: Stephen Hemminger , "dev@dpdk.org" CC: "Singh, Aman Deep" Subject: RE: [PATCH v3 05/14] testpmd: fix whitespace Thread-Topic: [PATCH v3 05/14] testpmd: fix whitespace Thread-Index: AQHY9JKKtd6pJdOtvUuMgOP0Xmu6v645RLXggAALwFA= Date: Fri, 11 Nov 2022 07:12:01 +0000 Message-ID: References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> <20221109232451.265059-6-stephen@networkplumber.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.500.17 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3516:EE_|DS0PR11MB7408:EE_ x-ms-office365-filtering-correlation-id: 42a23811-1503-4624-446a-08dac3b40769 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GCG7V3l4bRzPxdhlSHjw/bnf6/VJMR4FnQR047U6oEupa0Z/n08695TNnLfrVCclnGkVp4tV5Ub+lFpa1EaIWXLjOZMi2AyP94k4Uf9VWJ1Ciyc7/xPgFvssZ+uOsyuVyMviheQJE+ppl3bHx/M+CmyZPzCXdGKF7hA9uyG2QbSNgulXmJqFfBnZVe+gS7KivFMHGCgEJHYULEawnCRBG0CtJSWQD5CF2KlbAOoWZLPSi/0Ozdjq4Nz5N8KNZiJmZzHF7EJJxl2H62fw/BgeOIBdeRWy4wL3gRtU2V5baZtoUDANtnP4UOK1QDaQtmJPT4yO1EgHHSaO6Oy+kRPAFre1pm2aD10E/gHhk55ZrbaJM4Qiy/S071N5ZO7q+0ZkiFY639vNgUql7wwcgD6xGWao3MM8OYmEGcsiLGgjuzeOxWd+aLTvnIbYZRssH+2LJfdbiysUuD3Occ7yiDZuKbYfHGv3AIWGVZlICNUJFnhSWCi4ZAhGasVPusNVfqr7bw86GTzTcl6KfSirmrVwgVcYgLdg+skmNeo7WvGb+3yB0O3mcZD/TczKBOjncP7K2Jq7K0VMzzvYiIWJwEuY9TCuUgLTLGsI9ix/pNkJgmdAR5FK4OEE+NcCjA/CkGIXPxqpE0DMN7grpMS6TAMSLlSUmvoXcK2j8zQj5xSHav3uu5SL7kIrc+urDjM5bWnPMVOEZdVw3+ssWpWEErFXDFFOv2btE9qpWiOARM8SvWpwuIKbF8F8IH1ODJhoK2d8yF3CD+RHN685qxV0jbsRKw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3516.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(396003)(366004)(136003)(376002)(39860400002)(451199015)(33656002)(110136005)(122000001)(66446008)(66476007)(66556008)(64756008)(66946007)(8676002)(41300700001)(38070700005)(82960400001)(86362001)(55016003)(38100700002)(71200400001)(7696005)(107886003)(478600001)(83380400001)(2906002)(5660300002)(76116006)(316002)(9686003)(4326008)(8936002)(186003)(2940100002)(53546011)(26005)(52536014)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?alYrZU5uT2ljZ0x2aXR6TXhxRFVqemp1YWNXRHQwYVU4ZmRDYWRhSXg3?= =?iso-2022-jp?B?T3VYb3hYbU5pVzdNRTJ0T1FCaklLS0lZVWx3emdBSHFrbGI5UkZzYVFu?= =?iso-2022-jp?B?TGdCYnE4RXZTRWxHYmxRVlBNbTAzYUUrVDNIU1NveGIwRUhLbnZRNHAw?= =?iso-2022-jp?B?aWNPVXI0YTU2MGVkT3d0YVR0NnlJYWFHSGpmNkd0TDlqU3FrZnV0QnV2?= =?iso-2022-jp?B?WURrUWk1WHpnRFFKTmJwTENOc2NVQUdlL1pOSWROd1pVMUE5Mmo2dDNl?= =?iso-2022-jp?B?ZGJmNGw3SHhPemVLV2EvbzgvdGE1RnNyRE1ReE9vdytRYkIvUFc0SGZl?= =?iso-2022-jp?B?Z2J4RURMM3hHdTJRMUJLOTQ1RmJwQ2RwUS9KL3VyK0M0TFpzSE1McFNG?= =?iso-2022-jp?B?OTBQYWdrSG4vVUlSdUdNL05nbnN5T052RUllWUczdU9kZXkrd2lUR0Jh?= =?iso-2022-jp?B?WHo3R0cyR3MwSmVyYWFHWWJ0M044QnJqcXZ1VFMrYmdobHlSZmthNFFs?= =?iso-2022-jp?B?RCtXbGNLVVlCQ0RZTEFCVHJyYWJCcklmTk9rR1krdW56TWlEOG9VTmhV?= =?iso-2022-jp?B?dEtaTEVWTWxib1NLc3lmZitiUTlRMFU4TGFxSmN0YnFJeHdLMUE4TGQw?= =?iso-2022-jp?B?Z3BWL3dHd3Rza3huTFZrT3FzbDM0MmxMNHVsejJ4OGdzQ05zZ09YZGxH?= =?iso-2022-jp?B?cUg0QktwOU4rRWRxTlFmZDRmai9HaUNKS3FER3FmcDVmK01FRVcwTmtn?= =?iso-2022-jp?B?QlVRaVJ5ZGljVnhRUGo0OWtOQnkzQ0dxWVhXdUQwVXJUWDFSdW4zMi9J?= =?iso-2022-jp?B?eVNYV0R5WkYwUUFvMGVkbnhWaDBrV0dXMm4rcDFvUWR0MWJxdkFMUWRE?= =?iso-2022-jp?B?R0VDbWJrclpHaWp0TDcyR2pOUEpIU2FyRjRRci9HVTN1OWhydytmcldP?= =?iso-2022-jp?B?bXppVU03RnBjTDlaYk4reFNYOHVHNHBlZVEzc2JFekExZHd6UWsvM2FP?= =?iso-2022-jp?B?cGQ4SnIxZ0FhQTFDN2lObmhRVjFlRitrVStQUWN5bnlpaG9NMnZENXdu?= =?iso-2022-jp?B?VHVHbngzZDdqSDRadEdHRi9FWjdkVWVHUFF2U0wwUVdEN0Y3UHlYT3VE?= =?iso-2022-jp?B?bGkyK1FKdG0xQmFUbksrTTNrT1J4WGQ3WDU0MUpYdUFwN3gvZUNGV3hp?= =?iso-2022-jp?B?N3ZoS1RtR3lqZ0xhMTNZVFlEUDJLM3AzaFIwVnl4QjZYKzBRcTVCQzky?= =?iso-2022-jp?B?bDZtLzN1ZzRvYU5KVDl1QmM5Rnk4MnRnVEVwRUlFTGZoSys4Q216aFQ0?= =?iso-2022-jp?B?WWZJVDFLOGhaMmJFMExFZ2p4WWlhbndISzY2eGFBTGpXeVdwL1VOY2ZD?= =?iso-2022-jp?B?dG8wZ2lKYTgxdHlNOXMrbWprSXhZSWRrdzcydGRqemdHZWNta1g3Ni9B?= =?iso-2022-jp?B?VStseTB3cFkzR3RSblEwOFhOVmkwby96b2VaYzA1OG9LMmVBTnZXWVlY?= =?iso-2022-jp?B?SXhUK2J2N1d6aG0rcGxsRjUwaWNXcS9Hc2Z0Y1pZWmtSUWNLRGFNa3pL?= =?iso-2022-jp?B?enFXVHM4T2FaUHBpTGo5RG52Vk12K3lacDYvMVREQkxxd0Z6RzBNMzJD?= =?iso-2022-jp?B?SUNKdmNmS08zanJBQ2x0K0dqZjhMR0o4OVRMdkpmMG1SN2Fad2VTOUpu?= =?iso-2022-jp?B?SllXTGxNS2RwQUd3TE5xYTM5MzBSVWVodlVmRmJaNUx4d3p3b0h2V0x1?= =?iso-2022-jp?B?WUFWRHoyN2dHM2NsTEJVZTUwSG1ScDJsV1lSYWdMV0hKNlduUUFkSTk0?= =?iso-2022-jp?B?RWRkNjNnVDRwVkx2dFNrS2dubWRHZ2hScUN2bG9hQkZFQnBMQ2VWcWgy?= =?iso-2022-jp?B?a0JmblFSb0dVZDRNNXNKS0Jpb2ZZTFNHV3BqNXIrUzFvdEtsQ1MzU045?= =?iso-2022-jp?B?bFR5RG1sTktaUUpPNmNXK1hGd3IyN3BBVC93L09MSjAvdHRpd2QzOE1u?= =?iso-2022-jp?B?cC96WStnMThRSmRwYXpsYU9NcFEyV1VSblFjcUg1Mzd4RU9FL0VhOGJp?= =?iso-2022-jp?B?cmRkSmY2UGJqQlMyU2hNMEpSR0VLaENHVXh1NzlzZWxmM1BOYkJiVVVV?= =?iso-2022-jp?B?ZjBqZjlmcjQ0NkNyVklPRlowbEM0b2pNdFQ3c1FnZWdyWWxPdktjdUU2?= =?iso-2022-jp?B?YW8wQ252UlJkTmxiTEtzWFpWeitvOXpJSVkwQmtVMm1SajdUb1VYS0dm?= =?iso-2022-jp?B?clJaRTRtYkY4MHJ5MjR6KzBmUlJ6WUk0L1h5MTVTbGJpaHZveGROZmky?= =?iso-2022-jp?B?Q1c1eA==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3516.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 42a23811-1503-4624-446a-08dac3b40769 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Nov 2022 07:12:01.1746 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: UjTFeX/uJZSjUVqUnZpPFp/lLK93OBU7HJx0d0a6rFnOI4zrStyG8O17lhxRjo38SJWPdRS4gK4LkpBjl7SDVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7408 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org fix > -----Original Message----- > From: Zhang, Yuying > Sent: 2022=1B$BG/=1B(B11=1B$B7n=1B(B11=1B$BF|=1B(B 14:30 > To: Stephen Hemminger ; dev@dpdk.org > Cc: Singh, Aman Deep > Subject: RE: [PATCH v3 05/14] testpmd: fix whitespace >=20 >=20 >=20 > > -----Original Message----- > > From: Stephen Hemminger > > Sent: 2022=1B$BG/=1B(B11=1B$B7n=1B(B10=1B$BF|=1B(B 7:25 > > To: dev@dpdk.org > > Cc: Stephen Hemminger ; Singh, Aman Deep > > ; Zhang, Yuying > > Subject: [PATCH v3 05/14] testpmd: fix whitespace > > > > Add space after keywords. > > > > Signed-off-by: Stephen Hemminger Reviewed-by: Yuying Zhang > > --- > > app/test-pmd/cmdline.c | 31 ++++++++++++++++--------------- > > app/test-pmd/parameters.c | 10 ++++++---- > > app/test-pmd/testpmd.c | 2 +- > > 3 files changed, 23 insertions(+), 20 deletions(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 8dc60e938830..7721006cc310 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -2730,11 +2730,12 @@ parse_reta_config(const char *str, > > > > while ((p =3D strchr(p0,'(')) !=3D NULL) { > > ++p; > > - if((p0 =3D strchr(p,')')) =3D=3D NULL) > > + p0 =3D strchr(p, ')'); > > + if (p0 =3D=3D NULL) > > return -1; > > > > size =3D p0 - p; > > - if(size >=3D sizeof(s)) > > + if (size >=3D sizeof(s)) > > return -1; > > > > snprintf(s, sizeof(s), "%.*s", size, p); @@ -3242,15 +3243,15 > @@ > > cmd_config_thresh_parsed(void *parsed_result, > > > > if (!strcmp(res->name, "txpt")) > > tx_pthresh =3D res->value; > > - else if(!strcmp(res->name, "txht")) > > + else if (!strcmp(res->name, "txht")) > > tx_hthresh =3D res->value; > > - else if(!strcmp(res->name, "txwt")) > > + else if (!strcmp(res->name, "txwt")) > > tx_wthresh =3D res->value; > > - else if(!strcmp(res->name, "rxpt")) > > + else if (!strcmp(res->name, "rxpt")) > > rx_pthresh =3D res->value; > > - else if(!strcmp(res->name, "rxht")) > > + else if (!strcmp(res->name, "rxht")) > > rx_hthresh =3D res->value; > > - else if(!strcmp(res->name, "rxwt")) > > + else if (!strcmp(res->name, "rxwt")) > > rx_wthresh =3D res->value; > > else { > > fprintf(stderr, "Unknown parameter\n"); @@ -4088,8 +4089,8 > @@ > > cmd_vlan_offload_parsed(void *parsed_result, > > len =3D strnlen(str, STR_TOKEN_SIZE); > > i =3D 0; > > /* Get port_id first */ > > - while(i < len){ > > - if(str[i] =3D=3D ',') > > + while (i < len) { > > + if (str[i] =3D=3D ',') > > break; > > > > i++; > > @@ -4097,7 +4098,7 @@ cmd_vlan_offload_parsed(void *parsed_result, > > str[i]=3D'\0'; > > tmp =3D strtoul(str, NULL, 0); > > /* If port_id greater that what portid_t can represent, return */ > > - if(tmp >=3D RTE_MAX_ETHPORTS) > > + if (tmp >=3D RTE_MAX_ETHPORTS) > > return; > > port_id =3D (portid_t)tmp; > > > > @@ -4108,17 +4109,17 @@ cmd_vlan_offload_parsed(void *parsed_result, > > > > if (!strcmp(res->what, "strip")) > > rx_vlan_strip_set(port_id, on); > > - else if(!strcmp(res->what, "stripq")){ > > + else if (!strcmp(res->what, "stripq")) { > > uint16_t queue_id =3D 0; > > > > /* No queue_id, return */ > > - if(i + 1 >=3D len) { > > + if (i + 1 >=3D len) { > > fprintf(stderr, "must specify (port,queue_id)\n"); > > return; > > } > > tmp =3D strtoul(str + i + 1, NULL, 0); > > /* If queue_id greater that what 16-bits can represent, return */ > > - if(tmp > 0xffff) > > + if (tmp > 0xffff) > > return; > > > > queue_id =3D (uint16_t)tmp; > > @@ -7207,7 +7208,7 @@ static void cmd_mac_addr_parsed(void > > *parsed_result, > > ret =3D rte_eth_dev_mac_addr_remove(res->port_num, &res- > > >address); > > > > /* check the return value and print it if is < 0 */ > > - if(ret < 0) > > + if (ret < 0) > > fprintf(stderr, "mac_addr_cmd error: (%s)\n", strerror(-ret)); > > > > } > > @@ -7780,7 +7781,7 @@ static void cmd_vf_mac_addr_parsed(void > > *parsed_result, > > res->vf_num); > > #endif > > > > - if(ret < 0) > > + if (ret < 0) > > fprintf(stderr, "vf_mac_addr_cmd error: (%s)\n", strerror(-ret)); > > > > } > > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > > index > > aed4cdcb8485..7fc6d91f0210 100644 > > --- a/app/test-pmd/parameters.c > > +++ b/app/test-pmd/parameters.c > > @@ -306,11 +306,12 @@ parse_portnuma_config(const char *q_arg) > > /* reset from value set at definition */ > > while ((p =3D strchr(p0,'(')) !=3D NULL) { > > ++p; > > - if((p0 =3D strchr(p,')')) =3D=3D NULL) > > + p0 =3D strchr(p, ')'); > > + if (p0 =3D=3D NULL) > > return -1; > > > > size =3D p0 - p; > > - if(size >=3D sizeof(s)) > > + if (size >=3D sizeof(s)) > > return -1; > > > > snprintf(s, sizeof(s), "%.*s", size, p); @@ -366,11 +367,12 @@ > > parse_ringnuma_config(const char *q_arg) > > /* reset from value set at definition */ > > while ((p =3D strchr(p0,'(')) !=3D NULL) { > > ++p; > > - if((p0 =3D strchr(p,')')) =3D=3D NULL) > > + p0 =3D strchr(p, ')'); > > + if (p0 =3D=3D NULL) > > return -1; > > > > size =3D p0 - p; > > - if(size >=3D sizeof(s)) > > + if (size >=3D sizeof(s)) > > return -1; > > > > snprintf(s, sizeof(s), "%.*s", size, p); diff --git a/app/test- > > pmd/testpmd.c b/app/test-pmd/testpmd.c index > > aa7ea29f15ba..04b078a2938b > > 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -2406,7 +2406,7 @@ start_packet_forwarding(int with_tx_first) > > > > test_done =3D 0; > > > > - if(!no_flush_rx) > > + if (!no_flush_rx) > > flush_fwd_rx_queues(); > > > > rxtx_config_display(); > > -- > > 2.35.1