From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D8D34A00BE; Tue, 15 Mar 2022 11:01:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6E13940395; Tue, 15 Mar 2022 11:01:02 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 401DB4014F for ; Tue, 15 Mar 2022 11:01:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647338461; x=1678874461; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=R9Mni4GuThmlT6kb7OzAFcOd7Phj64jf3y7VGzvVF98=; b=AoOMX8V0woJhbCjBXdypzIRJZSqNDgX47BfzNtiD7zw1Co7xmc24iy30 Kpg1sT7X68GL6xG01IQZ/bve3g0nLvyGdc7ymYRJdfNlYtWv1KE8RO/Ir a7LVqVm1hKTZB1hatNVcIyn9XH7rxEMdvcoe8/82fDJr4CxigusWijFTx 6HSgDfsqOXFT1bQLwJFYGeO/RxR7fvfqGNFlCP3nmP3wGV5VIqKQD0eea 6PeRDLdp6Xnw3pXk095+nVHfjlSOwn+BVch5z8tUeapDBG8W/cloZ7Fgu rP3kS8wd3ZDr7wbnsE/4d2d6Di4rVnwjbG33nigu/0MbP73TboLN3QexH w==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="236207424" X-IronPort-AV: E=Sophos;i="5.90,183,1643702400"; d="scan'208";a="236207424" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 03:01:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,183,1643702400"; d="scan'208";a="613211000" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga004.fm.intel.com with ESMTP; 15 Mar 2022 03:01:00 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 03:00:59 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 03:00:59 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 15 Mar 2022 03:00:59 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 15 Mar 2022 03:00:58 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n/KB1fNlWRCukClgUVrsv1SgM71y/l7PATzJT5EVbsMeowYKZHvQgQ1ej6K4bNlR9/8mfZv0vqYnqYi4c60pNDdRJh3HvHb760UCxGvPeANpagjcqm49llKrxyJpAh/jp4QRaYoLr0h863H9FkFIlXxf809I0mPisLcdYaiVRwYxiJeFz1AH2oHi0F2TclB7FZGrB9+dE8BLonk27grBUEJWcRxQ6zTpCc42pnmGi+3txE22OD3bry2wBZhKE6bdWqrwtmekC4YeDKS5qW3HbBzWle5v3tfAEQHskszQm4Rz00NYSbJ383dkW80n6Zkq31jQAYw7WKMgC9Rr7UKy7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jf1QltKlrbWJNutzz272SS5lTsoCnfpwG+CdJh2jjkM=; b=SMXQsJtkOdarVMt+kILo0Ki2WOgkLeInZSo4Z3yBUAm49wNjdUz7Plm48Wp+r1yIqknmamfyjfY3TAVLT7lKDdgDSk3NNy/J8F8YXm6zgzyi1g8nRJDxOa87+5COj7aB+x8Njiak3nyQol/VSHtqGZWcBW+yjFQe6698K1hXsunrEomlk4sfGRTWIoHkqBl24opXD73KmdM/AjEfuH6I6CBVnuLgBkbowp5G1OIr0RymOtSippJbxzWWYBS/FYN9feuPPMcoX+1csDunlMr20fU1YMW4iPr4EXwJ421pS1jwsIgfW5jnT+S4jad1IP3IbH3PQOhXM+Gf/cg2F4DugQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3516.namprd11.prod.outlook.com (2603:10b6:5:72::13) by BL0PR11MB3267.namprd11.prod.outlook.com (2603:10b6:208:6b::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.22; Tue, 15 Mar 2022 10:00:57 +0000 Received: from DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::1c27:af5d:3e9e:d172]) by DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::1c27:af5d:3e9e:d172%4]) with mapi id 15.20.5061.028; Tue, 15 Mar 2022 10:00:56 +0000 From: "Zhang, Yuying" To: "Zhang, Ke1X" , "Li, Xiaoyun" , "Singh, Aman Deep" , "dev@dpdk.org" Subject: RE: [PATCH v2] app/testpmd: fix issue with memory leaks when quit testpmd Thread-Topic: [PATCH v2] app/testpmd: fix issue with memory leaks when quit testpmd Thread-Index: AQHYN2ff8gHnfdRkvEq/92qw1UVTkKzANb7A Date: Tue, 15 Mar 2022 10:00:56 +0000 Message-ID: References: <20220314054717.391952-1-ke1x.zhang@intel.com> In-Reply-To: <20220314054717.391952-1-ke1x.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.6.401.20 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 51f7890b-1c3d-4034-f362-08da066ab32d x-ms-traffictypediagnostic: BL0PR11MB3267:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uvKAsNIhCGDltgJEwcMts0esEbnLrlkvyoMFbxtCqkbSSsV2TZcNnYsxM4R4KKKEENqUMDEJn8NFcTrHWe3EvXDLZaZW+Cwo7KXfHtJ/VgSdDPzaBZFLjV6lnpzn+JpwZ+MKhOHu+iOJMktYZQ6gI2k76oma8Qs4P62tX2aCVwXlZwFVEnY4wt0NOq0jOla7mveIf6vfDnboqrE0SqIgxDq38fGxIpPCBYHVfr323skwPaZqZh20SWO9iMcSnOmNpxAXxSdvGDV9kWEkp6dWheTYfu9GJ/TBnGFItomZs16/+ptIgunNrbCHTfSesc3nTq/m8e6mtlGfZo+rSs8n+tUTF3zmC1pveeQY+GQgmiJtWMXIOF4PYfB9zL/W8NngdjO78RirqNmaWNZtb96qT671ZxgSDo72Y0ihrsYjrsEK+61UF0S/VL+Zm2kcIEP/IyPlKroVylfO5JoALq+u2xXXA4wXSu/78vPxAwyI28xO/GDn97hm6odyLbjcSCu5gLJDOhXQvTX4iRdoXu1e7dB1J2vE31uodapF4LDqCMgEF5w0gOYiE8hpX4fCfJOvM0To6MnCPfadsoJkqaiNTwiHbvUFwRT33xGIU+ZuXPSiEKXR08uN2XWxlpzizBOHzUgnoQKtNWgo6N3Hzqn6LTt6DpLKbuWW/A0x6orLoSb7OApv8qPHeA27AlF5EFrLoPOZ09aWJwv3pZ/HOkZB4g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3516.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(83380400001)(8676002)(76116006)(66476007)(64756008)(66446008)(66946007)(2906002)(33656002)(66556008)(122000001)(26005)(316002)(8936002)(52536014)(5660300002)(82960400001)(186003)(38100700002)(86362001)(38070700005)(6506007)(7696005)(110136005)(9686003)(53546011)(508600001)(71200400001)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?eU5hOWxXMXhRRUJCM0pBRHMzanJJTWJvZzYwMm1heDZxWFZLZ0dUZjRq?= =?iso-2022-jp?B?SWJCVVJIZWdiVFhCRDY4QkE0THZsVHc2SUZJVDBaREtBUTI2TnBxeUhL?= =?iso-2022-jp?B?dmttVno4ZzFCcmNpU0ZpYWxBcVJXNFlKVEFQWGcvNlBOb1N4SDZZcmp5?= =?iso-2022-jp?B?U01lZmNTOVpZai9ORFJMbXJiSDAxbDhTNnlyaHV6WDNBOVE4RE5nbmJ1?= =?iso-2022-jp?B?bmJsNjZHWjhVUjdjRUlxQU5HR0JkSEFOUHEyN0xkOEVhUEJrMmI3SFpL?= =?iso-2022-jp?B?VElTNWZSOWZrU21HeXFVVVozM3ZwZ3BMNFZPYnZ5aEN0RUhuV3B2TSs0?= =?iso-2022-jp?B?djVKL1JHZ0FUMUVicVBaQjJpWkhISjFMMjRWWC9yVS95cUZWbytNQW1h?= =?iso-2022-jp?B?QXVZOEwxbXgzRUtRQnBsL0xDZ3pRb0c2VEgrQTJqY0RRdllhTm1yZ0hr?= =?iso-2022-jp?B?bVFzSXBKamtHTWRxdnBMekRqT2pPUXE0QWRid1d2eFJlUEdRTlc0NG5B?= =?iso-2022-jp?B?M2Z6STZXNGpuU0VWWkZlOHU1Lzh1WWVmRkFmZ1RLaTgvaEplM212cDlp?= =?iso-2022-jp?B?dDJVZUdVRElCYit0amVKV2ZrQUJHSmtIaXh2eG5WQjdUbXcwakErU1NL?= =?iso-2022-jp?B?SStERG1KbkoxV0N2SHBFMEpycWlacElyZE1HTVYwNnVwNE1BUFFmZmlv?= =?iso-2022-jp?B?NzhIRjdVMjErTkNYd0l5V1A5TDBCYVBHaHJQYXdUZlhoQkJJckk2VStP?= =?iso-2022-jp?B?M0dKVVZUMnZlT3ljU2VoVXdHdWx6c2hQZ3BRUk12Vkd5cXl4WmhsTkZR?= =?iso-2022-jp?B?ZjF6cEJpQng4QnJBLzkxN3Q4RmJ2UjRuSmlpNHEwQmM5UlQ3eUFHWXRG?= =?iso-2022-jp?B?dkFmQWFFU20vazZmRXYwYnQra0JsV3U5c1JLM0Y1ZmVRZGRVa09sYkpt?= =?iso-2022-jp?B?Wk9kTnExSzNMcHpTY21VM29WOFArMkJYTFNYYjlFVlhNZEF2cnlwNjdS?= =?iso-2022-jp?B?YUVKTFFiaHVaRHFlU3pTSm5QS0w5T2xLZWZ6ZUM3Q0NTcURUYTNpdlp3?= =?iso-2022-jp?B?aHBXYitlZHBVUnYzV2JXcWNtVEpMOXlSSUdaU2hqZm5UY3B4OEFxOE8v?= =?iso-2022-jp?B?ZmhBMjhLeHNZU2R2RTB3Ym1HRGtYZTcxd05kZHVud2pFMDhscVZSVFRm?= =?iso-2022-jp?B?V1dtcDVFWGJwb25iNit4NHd2RTl6bVpJbHBJeTJhMklCbkxWem9LMm1n?= =?iso-2022-jp?B?alhFaituQXBOVXc3eHdqcVhVTFBYWmwzWXhRN3VmUzdNbmFmZFF3NTVU?= =?iso-2022-jp?B?UVIyTEN4SG1EK3V1L2lZc0JWUkFkVjlsdzhYQmxNaHlXblI1VXMvSm1I?= =?iso-2022-jp?B?USsvTkNaZCtLVkVKenR3NlFGQ2pyc2dvRUg4dnpWVnJLNXJjVmRKb1Bq?= =?iso-2022-jp?B?WGdiUUtobUR1TWNBMitiUUF5VHFZMTZYQ08yeStUbFVYd2RhTW92Nllr?= =?iso-2022-jp?B?R2FoaWhRWkFOTm5tV2IyS21zK1NKbzY2S3I5MkNDQjVVNGI5Z1Z0cHdD?= =?iso-2022-jp?B?Zlp4TnpVcGdyY204Zk1nMCtZNTJ1ZVZGVWtnS0NIMi96OEpBR0dnOE1r?= =?iso-2022-jp?B?QWdNK2EyME91NmJ6Y3hXN21SSXViWFlIUXBVUTQ2SzVyc3lrV0RicTVD?= =?iso-2022-jp?B?VkJQQTBPU0hrS2p3aHd4TDM1dFNEakRHUDhLcERrU1BJRlhybU1rbU1X?= =?iso-2022-jp?B?ek1URzlCc2ZFbXJMWVVGSHFQeVp1d3JFWnNMc20wUWtzcEpmMmhjbHFp?= =?iso-2022-jp?B?dE4wWTliV3RoWWJ2OXNjWGVpOHhmQ2kza2FDYnRuM1drbVY0ZTNVZWtx?= =?iso-2022-jp?B?OWQyR1pYZU5aYkFSM0M4YzhRandpOUYxelB2RHl1c3huR3ovbzZCRVBs?= =?iso-2022-jp?B?L3BHZ2NpRnRqd2dES3J0NzUvRXJVenRvZ0dPMGt2ZUtOT2Nxc1NtRENM?= =?iso-2022-jp?B?YUw2N0hKRTdmYUViZXNtRTROREIrYlFEcU9ybXFtenc2TXFLYkJVMlcw?= =?iso-2022-jp?B?QTJ4ZXJMcHNueW1WWGliekFzcER5azJkVzJ2YmFBdk9YV29vU2J3RWtF?= =?iso-2022-jp?B?M2c=?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3516.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 51f7890b-1c3d-4034-f362-08da066ab32d X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2022 10:00:56.7529 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1I6RoCDa8ceA51ib2q2CKToJNyhAVHY/9Klx+/p2UiikSO2Ww8tqNKCPdbQJKz3VrfsXQKTMURnguEyzChzyiQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3267 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ke, -----Original Message----- From: Zhang, Ke1X =20 Sent: 2022=1B$BG/=1B(B3=1B$B7n=1B(B14=1B$BF|=1B(B 13:47 To: Li, Xiaoyun ; Singh, Aman Deep ; Zhang, Yuying ; dev@dpdk.org Cc: Zhang, Ke1X Subject: [PATCH v2] app/testpmd: fix issue with memory leaks when quit test= pmd when dpdk is compiled in ASan, there is a memory leaks after quit testpmd i= f set mcast_addr, this patch fix this issue. Error info as following: ERROR: LeakSanitizer: detected memory leaksDirect leak of 192 byte(s) 0 0x7f6a2e0aeffe in __interceptor_realloc (/lib/x86_64-linux-gnu/libasan.so.5+0x10dffe) 1 0x565361eb340f in mcast_addr_pool_extend ../app/test-pmd/config.c:5162 2 0x565361eb3556 in mcast_addr_pool_append ../app/test-pmd/config.c:5180 3 0x565361eb3aae in mcast_addr_add ../app/test-pmd/config.c:5243 Signed-off-by: Ke Zhang --- app/test-pmd/testpmd.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index fe2ce19f= 99..f7e18aee25 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -3136,6 +3136,12 @@ close_port(portid_t pid) continue; } =20 + if (port->mc_addr_nb !=3D 0) { + /* free the pool of multicast addresses. */ + free(port->mc_addr_pool); + port->mc_addr_pool =3D NULL; + } + Is port->mc_addr_pool located in shared memory and may it be freed in prima= ry process? BTW, you can write a function in config.c such as mcast_addr_pool_extend()= and reference in close_port(). if (is_proc_primary()) { port_flow_flush(pi); port_flex_item_flush(pi); -- 2.25.1