From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49EC6A00BE; Tue, 15 Mar 2022 11:06:14 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D99F340395; Tue, 15 Mar 2022 11:06:13 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 30AF24014F for ; Tue, 15 Mar 2022 11:06:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1647338772; x=1678874772; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=XcoCjn2roMjWFM22wJYypDQJ0L7VhrIoIfD+MZQmOKU=; b=NbU2ckafpa/8vWB8Zi4hMNFFypYQUGyLv+x9AASqxCM7lqZdM5DDuuZP TFJok+cUDG7NfmtuiGBzXuHUl8djO4itt3ikYcntOI1rh0sohbGpCFz/1 IP/BdzhCFli68J/45Hd2bymH3m3AbSoGqqUzIafVlfzg+hHzEBfRWYhqD 3k3+0jXZt1jl/AiUcIwG78tGJm7lvg7ru9xrracHff7L1HAo4j7gM0xeA wkR5rLn6VxW3o6Sb1s2c/ZE1Cw5uO62j/FCuixE4XLs9Kh6cSnVgRT2dT cKApvdWhVx6HJK2hQm1Z+vh8beScaM+fywaohYCA/+Oo05ORIVj0drD3V A==; X-IronPort-AV: E=McAfee;i="6200,9189,10286"; a="255990113" X-IronPort-AV: E=Sophos;i="5.90,183,1643702400"; d="scan'208";a="255990113" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Mar 2022 03:06:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,183,1643702400"; d="scan'208";a="690142384" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 15 Mar 2022 03:06:07 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 03:06:07 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 15 Mar 2022 03:06:07 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Tue, 15 Mar 2022 03:06:07 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.21; Tue, 15 Mar 2022 03:06:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hv+zKNCE1iPHLrrOKSe0FOHZHdpJk4u3WBAkKMm7+UcpNh48oejMwqwHjgXpxIAOW5YqU+c7GF3PR4RcSYGzMI7WRUaPbhDtSbZIdO9shHnDozCsiTmloS5esVKsvI0iqeF1mgSqQy6wF2dhIBsEqRW4pslH9LRMp2GvwspRYxca7Xam44YKFseYiJxkqGznnEgfOKKzTkR1A+Af9z41G3NWudlEczolBIsrFYyGzZCo6kNNIONSfOLAq6n8Yvmlj6Jo+JJZXvlIx+nAypA5MWngIznupJkyQIxktHJWCYot5XN2SBupRjIBnPyUghgII3vk7HkDAoFN9DY8tJyi3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/woiPxuw8Px5JlwRen8gvySnpOLXYUcHHyvXpy2xqv8=; b=L76U7sRQ5+ihcYuLHS3CDaIpbmAIXJKD15rewWkmSiLs8wUBOK7wIIylcCWCinITeZrQ/Lc3KAIaHMU4LyUxLD7Mwpe4w3GWz90SH+/1KSnLSgwahM1yDUtGKxBMh+c4hFo/tgWJuiQWZ0EOrazdfQg9zn1U3pLN3CSELg5l/WQSWMo8gKZ0bTvBOj82uSPaFWRy8tge+qUTLAx0KBfq4giR6pH/3+DNhU6c93fkGy6YS2u6HVasXAy8IOm962K1p//s1dKwa2xudTY6Zpes/sbRRKr5S2DVk5jnKLiibKTtBvF9wtHsgS0X9ox5ZQhaxY8aGVYEcZPwdlUiSpCbcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3516.namprd11.prod.outlook.com (2603:10b6:5:72::13) by BL0PR11MB2948.namprd11.prod.outlook.com (2603:10b6:208:75::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5061.25; Tue, 15 Mar 2022 10:06:05 +0000 Received: from DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::1c27:af5d:3e9e:d172]) by DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::1c27:af5d:3e9e:d172%4]) with mapi id 15.20.5061.028; Tue, 15 Mar 2022 10:06:05 +0000 From: "Zhang, Yuying" To: "Zhang, Ke1X" , "Li, Xiaoyun" , "Singh, Aman Deep" , "dev@dpdk.org" Subject: RE: [PATCH v2] app/testpmd: fix issue with memory leaks when quit testpmd Thread-Topic: [PATCH v2] app/testpmd: fix issue with memory leaks when quit testpmd Thread-Index: AQHYN2ipE277iwBOQUqThmBIoYnkEKzAOZrA Date: Tue, 15 Mar 2022 10:06:05 +0000 Message-ID: References: <20220301020653.329263-1-ke1x.zhang@intel.com> <20220314055252.392004-1-ke1x.zhang@intel.com> In-Reply-To: <20220314055252.392004-1-ke1x.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 724c2375-42be-48bf-1248-08da066b6b24 x-ms-traffictypediagnostic: BL0PR11MB2948:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PUZzYv+uIOcR8Cka1DsAm2AWPAbxmXEPszGuKvBIUiyoQXHgh/wJfa0aiEU4/YYNxFh2Wnx04mcN6xrmZz4tJSE/1+lPDo7SxMWCtgISfegWpx6Y8co6B0hWVAqDPfYUZMG/dMKk4YpiqDez/r1WqpuNAGxPvoujDNZDPkTrzuAhk67GMsrTbejFNR4W8XVcCrEu5BR8JpLiv9fMFpeSDD231tQLOHzYDdtcULDLdoZSfHtVp4q+P4hat8Gn1GD3z8u/lDpDvS6FXkA8otzrC6/yelM14gThZkx84y2U/wHt/0xhdmlAnN/PEKjCdOW/s1qWIarv/NgX1dBx7W7LO4uM5BQ9Hte4ezalDjwWJCccXIxwQ/ivRcx05rIso5E3zAhDiBPFep9+xqxIW03O3Zl2IqT/6xsD82Pg/xWNjM+SSYy70OOnRs+uG+oA2DKYPCbfXz6/MszRoxiC+y1qDeHo9NUDtEtQ2aI7x3uH70ENCeI28PMmaqjOBWGdHA6/8DOZrR0UOcPYprSiFWSOVNzm6crx9enCEeLxtVGRYq2ygIiBgmDgutCFO0ZPt6yNQ1CKVDB568zVyqjDmFL9dxuqYoIyduUXE4QUbCN/YgUUIPZXGT2gZ2Rf1AQbfliFn0jiz6GGjKhwIOU2JndNXGgH8foYC3jDZfzbJscGKLhEydcZzE2/DMZtb8k5f6h+b1vnuZcIEQJ+L3ymEMhrnQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3516.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6506007)(7696005)(8936002)(53546011)(33656002)(8676002)(86362001)(9686003)(66556008)(66946007)(66476007)(66446008)(64756008)(76116006)(71200400001)(122000001)(316002)(38100700002)(55016003)(110136005)(2906002)(508600001)(38070700005)(83380400001)(5660300002)(52536014)(82960400001)(26005)(186003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D9IGa0hQxl54rGXCeoxKMPTTSx/+tD6d/bumy3+cjoNanh11LJFEb0rim0iO?= =?us-ascii?Q?3LNIjdItvIsEvV6v2cjJbbLWNLa0M5XavBFWpIyhkITf9edJv2jW9I8rQIL8?= =?us-ascii?Q?6En/G/Iw2VL5Goh8ZLUA75pJQExeBoleMm3g7jZsORqiv4rstpuOKu2IRvzK?= =?us-ascii?Q?78JK2o4xkLMv8KCp9PyDuP3jxpa31QcW9GQYiwKiJuBAJpg09N3mb7EtFgXk?= =?us-ascii?Q?YP5+vuDPuZ8J3voEi9+RsAWeEnvghzPp5QhbjzAQeGHYuGfnZ9k2kkVbO7hm?= =?us-ascii?Q?2KfpTbMG4YyNQDsyNIx8hqBtDd9fm9cyoRbJTRR4V2PT7FJbCA11dWCuE9ay?= =?us-ascii?Q?Toq0/R4QfIkw1Evez13NywvwLa8hAtuJmLrzI+oxESeNE3Xk56TRjovMDouB?= =?us-ascii?Q?k05BZX6i10xnM5RIGxS8my1tnoB6N5VpD3v5hmX4dMq5kRhbvoC2PqSbMj8c?= =?us-ascii?Q?ee1BOJyd5du7qRfA9eW/eiILo9xCUZ1r4LMHx7GVJ3yzvrNaeca2Ei8ZJJ9/?= =?us-ascii?Q?fjuNJ5/f4xiHnEu4pqC9phaKQ/uRrslU/mQ0DOlS7sfwfkcXQQEVCF6rJNT4?= =?us-ascii?Q?lXYHitBaLb6iyWbZf4H0DFM5F8Zb/2NQq/7RVfRnrgGLvgWjKoFCf1FWHQqF?= =?us-ascii?Q?cy4bNI74ktPvVtk7NNd2qN4ktekVVZmfzShzM4WNWqUDO31wOO0reUj1IUJR?= =?us-ascii?Q?3kFh+5YRG+h+mx+npnqNCJQ9RHxxsHDYpvF0qrKs1FAOsSfAclcamX04/a93?= =?us-ascii?Q?yT72jH0xdXytnodQ1NOmmfrvzBXrahZ65LvgvwX40ztkfwD2BQeHiropMHLN?= =?us-ascii?Q?E/jLdKPsT5Cssd8PN4sQEVZVKX3Naj+pT/RUZhQShB7pkCUTb1kUMNuzpIjL?= =?us-ascii?Q?7EbSVrqEk6GU24pJfdCrXIevQmqo8L0O+cK9UUZe9K19ww+/1WPfcU6EryuI?= =?us-ascii?Q?dE68hpv9yuLCA387Oqrs7icCVnMPPci2swZ698v4qgEJ+jMs2C+xE/jvfI4U?= =?us-ascii?Q?9soH2qzG+YKXoGU8KNGeJl9vZHujL2b14tiI9yUrDWzU52RF5YM1w/9lLwkO?= =?us-ascii?Q?ELFIYsU/WxP1XvzPcAU/itxQwYWHxgSX0WXkBwjoBgfB6xR8NDg2hJPUajUd?= =?us-ascii?Q?Yokx2HI6Ef3rdbbR8GZXlYjirZvzHYZPnCtJzWGPqwYQ58U1XmIhFxn2Jsga?= =?us-ascii?Q?naC1UKFuoqwJJNRkhDKYtORfWnQYJPiFWJtsu5nSb++Y0oc1izde1S5VhyED?= =?us-ascii?Q?PKzjTud7g20zIgwT9E3g4xZ82I+Jvz+rgUOJKBfeICKxdIGBrESvuFe9+0hN?= =?us-ascii?Q?NBF71XoiBty37vurU4m6P/OonUe8mWWpFNYkl8ooWEA72pr5W9rQNToR5UBn?= =?us-ascii?Q?FC0p/OWb5NnZ1XAueJPS1fFkVKBQInC1Pgsn7Uy4Rq9PEg1nAeXHiv9kBwJE?= =?us-ascii?Q?NbjBeUy2DhTPsBMWbBC/j6mBGO3bO43E?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3516.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 724c2375-42be-48bf-1248-08da066b6b24 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2022 10:06:05.4358 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: c9zOqNTCzGXqKyMAwGlKOZ2s/JhR5XThiNaPp+r/EJ3qySSbLC/Cj+ZwEJpHnLicSFIGV06Qr8XxayKlIssJkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB2948 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Ke, > -----Original Message----- > From: Zhang, Ke1X > Sent: Monday, March 14, 2022 1:53 PM > To: Li, Xiaoyun ; Singh, Aman Deep > ; Zhang, Yuying ; > dev@dpdk.org > Cc: Zhang, Ke1X > Subject: [PATCH v2] app/testpmd: fix issue with memory leaks when quit > testpmd >=20 > when dpdk is compiled in ASan, there is a memory leaks after quit testpmd= if > set mcast_addr, this patch fix this issue. >=20 > Error info as following: > ERROR: LeakSanitizer: detected memory leaksDirect leak of > 192 byte(s) > 0 0x7f6a2e0aeffe in __interceptor_realloc > (/lib/x86_64-linux-gnu/libasan.so.5+0x10dffe) > 1 0x565361eb340f in mcast_addr_pool_extend > ../app/test-pmd/config.c:5162 > 2 0x565361eb3556 in mcast_addr_pool_append > ../app/test-pmd/config.c:5180 > 3 0x565361eb3aae in mcast_addr_add > ../app/test-pmd/config.c:5243 >=20 > Signed-off-by: Ke Zhang > --- > app/test-pmd/testpmd.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > fe2ce19f99..f7e18aee25 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3136,6 +3136,12 @@ close_port(portid_t pid) > continue; > } >=20 > + if (port->mc_addr_nb !=3D 0) { > + /* free the pool of multicast addresses. */ > + free(port->mc_addr_pool); > + port->mc_addr_pool =3D NULL; > + } > + Is port->mc_addr_pool located in shared memory and may it be freed in prima= ry process? BTW, you can write a function in config.c such as mcast_addr_pool_extend()= and reference in close_port(). > if (is_proc_primary()) { > port_flow_flush(pi); > port_flex_item_flush(pi); > -- > 2.25.1