From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ECD8BA0032; Fri, 18 Feb 2022 09:41:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D996440395; Fri, 18 Feb 2022 09:41:23 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id C3FF840150 for ; Fri, 18 Feb 2022 09:41:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645173682; x=1676709682; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=VhWdm8CZXZCx5fQO8pUv/JnnrKX2xoNY9kV0k5MOHKk=; b=XoAihoATmZTRBp6TfZ1uvNb1ve099vuk8TqA32dbXSGIfg+0qmHzt13D ldHlQXIlVrB5vMwR8FjJ9pZAHk6DHgUfXim6HiYhKVtqlQRLRqdwy1f4D sHGF/byhX6quRXa+eNH6IjCq2tn3UzLXGxPQjNHFS2MsgAB/6zQxCLneR NQxQVvbYBFiCjoXL07Xs8X6+dZT4VDsCU5JDszsfCmdfHb6MofcILq7e2 IplkAWDWTbhHAFSUdGtjyL1P8FzNUc6GaIY36oDqQ8+kz6QT57LAUD/qX mIqykS8YqKciGaeo6YeTTIwKo2EPGEUqFndxLGeTPGJouumquXiE9tlTi Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="311827309" X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="311827309" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 00:40:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="489285280" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 18 Feb 2022 00:40:27 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 00:40:26 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 00:40:26 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 00:40:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NVuVITSBInsifEbCDNMgKv+kQuKIYDLe1Ecuutt73wGlDFxEOnmiPLnMcCWgcAxoF4XAijiQXUSSVDeKqQ662ShJcDy7FzaDdwTus8TPrwzZORR5bCoa6r2aWe90YPFkYAvUYUH1b7WhJlcTY7rcIoGrOaloZRrrYvDZza/jCXfE/sVD1i/edFPNoRT4hi4dgHMkLH3IGNp2iRScFB3a/9hzBLk6eQghRzJMGaDtuPcjz7ZfYQlAhO8fGoED0WefiHJzJ+pOttMTD8hBp5XPzLk1RRsprBasQ8uyPv9CYC1A8B3WVZYp0clNEt6QlNho/L9UOzRIcW6Q8o2adUrkmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ywBc1QCsSQCt7JmD89HI2LRtfQyfOhE+wFqreI/socY=; b=nvtOqblfRSbiBOT7p2UC/F9WVfMb+WUxYSR1PGQD51nnWLdozyDfOozXLGHJKyV8/RWslMjmOgk25UylGCTd91RxRw6iJ9IatfmvCD1P7Upv0gaGWKdDm250/gxwim6xnlgsZOrvlxxpad5YlREU5qqZ5FayX5qzR+R729/TJQ2BHTvIkOhuHPi129tY6ptS3MbznRWyatb5Oy3c1HwjibWNVuLWk3BVhtbTI7xB3zddu2bSFLHdyMxw3EYMmwNCdeYET19k6q73KmPNTM2zbsW46P3vYxbs8O2+aZp5A0dA//obCkP0HzsDE6S+fMomEmA5iMF24pryGsaU1lakJg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3516.namprd11.prod.outlook.com (2603:10b6:5:72::13) by DM5PR1101MB2233.namprd11.prod.outlook.com (2603:10b6:4:4f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 08:40:22 +0000 Received: from DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::1c27:af5d:3e9e:d172]) by DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::1c27:af5d:3e9e:d172%4]) with mapi id 15.20.4975.019; Fri, 18 Feb 2022 08:40:22 +0000 From: "Zhang, Yuying" To: "Wu, WenxuanX" , "Yang, Qiming" , "Zhang, Qi Z" , "Li, Xiaoyun" , "Singh, Aman Deep" CC: "dev@dpdk.org" Subject: RE: [PATCH 1/2] app/testpmd: fix quit testpmd with vfs and pf Thread-Topic: [PATCH 1/2] app/testpmd: fix quit testpmd with vfs and pf Thread-Index: AQHYI+oMD3AOvhL/U0WtbMT3HjfwKKyY/Qug Date: Fri, 18 Feb 2022 08:40:22 +0000 Message-ID: References: <20220217101428.385751-1-wenxuanx.wu@intel.com> <20220217101428.385751-2-wenxuanx.wu@intel.com> In-Reply-To: <20220217101428.385751-2-wenxuanx.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dc681210-f06a-4c5a-99e9-08d9f2ba4d46 x-ms-traffictypediagnostic: DM5PR1101MB2233:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1388; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: o3NUbPl7GWuCQZKn6GirAJ+rxDabsU9VXFHnZvRV3WAh+5Uu5xJeoasGRGrHXjpGZp22dW5pw/KsGQjkM2nUUvq2dLKWKcBl1W1pewwq3pN3Y/U1MsmBifO83EZXo13zkNXwqdRd1+dlnnG3H/n+CglKWyVxXG5qCV/p3ggqWxj/4Oa/laS4BmMrdzoPt/c3j4G6v4EwfgTXn1RPDenh7IJqytlvCwpBfEjRHiz6+WFE1x8+UtfgF8fHNZPvMxMGNRIVm/a4mzNqn4Rk0ioolD1dkZkpzXUaaS7IB+IYXNKJpqVj2/yOYffNOQos1yH9Meqp12Py3BtFHS7UuD5RgoDiNXngCu4DYju9xAHXstxEqHK0+5b0usPT+sO1jzAPNo/vQSyDsuNraGRynVUo0Je8XjNQO36hf+zIxdd5yT7MjYtBj6oWHtqOF+ohzHmLNG1/t/mxFC63W8L8RhyEqWJigB0ELVIsf/aIc2yegK1rJ9WSv4oEyJlmpg51nv8eqWFDecD+MqqHJGMpKQSJpR6J4ukHOmhT6cxJ+iZMBWUqRiuokP9LjGXrFILsGlX/mdLmsASz9Et1g9NlHOTa8KrFrzNb4VwuBAljhEVr0f7kWp+4tXzOMr2TzjlLHzXjegjNxqP1h7fjnVOfyLWe7or1MalyHZq1hU/uPyZM8FZj6pId6MV568jfFmy3hhiUMYFNNABNBmAViys3nlUa1KGGM6q82bU9l92OQGwwPJg= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3516.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66946007)(9686003)(53546011)(86362001)(55016003)(38100700002)(76116006)(921005)(64756008)(5660300002)(8676002)(66476007)(4326008)(66556008)(66446008)(6506007)(6636002)(38070700005)(316002)(52536014)(71200400001)(33656002)(122000001)(7696005)(82960400001)(8936002)(508600001)(26005)(2906002)(186003)(83380400001)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ioUPLeich3kfas1okKwJDTxaGSu2RjhO8O29GHUgksdtIy3AJmWw85HgTH6s?= =?us-ascii?Q?WdLz1Z9dBz8JGHIUxDJls8Dxm3tN/CzIJpAZ/5k01mlbMYPk0vzedlAV64RS?= =?us-ascii?Q?iXDd3Y9F+s5/77uXRdqWWGoJPUgiiPl927M2wnAzTPCsNUkPp75V2KcY3TqI?= =?us-ascii?Q?E7r54Oxb8bCTf1meqEFCQ2H08NnWdorGJj0RHkBKr4zjDxp6nNaKFUDB1Jcu?= =?us-ascii?Q?S3EBEfhu9/+z9zr+GxJSUZjYqLw2vzWCdPsj1tKKsoatn1bWno1JVGBrgvEJ?= =?us-ascii?Q?0dqwm6tK3VKvlAShIEijgui0mF0/OG2Ur0aOa0yyCwclyllX4PsiudJUQhwd?= =?us-ascii?Q?RC9lw0y+HIg93bOK1KYk6b7YkSEt1XDALHCNW465turBqv1R6LgEPWbJwEf3?= =?us-ascii?Q?a3A2+rzOVoTVFUP9wY14XJb5dJwe8/IyqQ7MitSp7kWA73BcjMFPXYsmkFwB?= =?us-ascii?Q?tSIPQjNNCZD227Lamkr/ZqoPwhlGM38O2ologMalOpcPXi0Lmy4I4YAk+Iuv?= =?us-ascii?Q?o22qZy1f7TYaIZmU0aNuFTnFIhEjzh/iOTVWAE+8+C6X4HS7Qa7yOZm+SLeL?= =?us-ascii?Q?QfwjWgbwJ6Y2HU4AD5DAb/tXf6Q38xClSwvE8qJr/QRue2yhpoigp2mei2QN?= =?us-ascii?Q?/XVT/K/kk4Os6Kh/C0QNGMb3FRbcth63jvfBNJHkUbZL1EVJWgwsg/bdRC5Z?= =?us-ascii?Q?leIad7En+BlT2FiOqMqU9erKHy7je0bKzba0atAEg1IdTb2kg2OGSDGZXgVX?= =?us-ascii?Q?8/rE/f+Ma/9d2QfT9paSkyC17yvFI3fi97U2tvs/bfbKKcG6I8psqty0WuFz?= =?us-ascii?Q?ci/mxrk4rKE1z8MyM39MI4jWNrcsxW2GGm0z1bNS3QyGdtdL57r//iepcHEc?= =?us-ascii?Q?uAnsid9Db2QHy/gldLXPbyYvWYjQTU7Zp9N7NHJj/IPwT3hMJCAOdhyTfSgv?= =?us-ascii?Q?hKiRdSJs0qu0lkpg20Z/MMcb59DFNUQ49pQXF80lJ8N0F+bodgHC9hWPMqrR?= =?us-ascii?Q?KbdjHM4nEvwu7LhKkLMIn8H71po4YYt6n8McD3DBciRhZ4NcZqTjfUm6jLxC?= =?us-ascii?Q?GaZ2qtMND0Yf9akahF20MYOtOQ39V6yEwlExtIizGHP56bHcxW1pNI5aD+ST?= =?us-ascii?Q?VS/fmuI3TEv/Wf9kmUAK8Kmyp3V0uMKmNvsndNvEZ0GgrB4taaTkoYu0alY/?= =?us-ascii?Q?384AD6XxSOX7/ab1f4mxaRYPFZKHu3lGMkWQhANCpAUDqx0yIk/DyGgvQoT/?= =?us-ascii?Q?rR9b64ycjhpCqDD7AIRDW7iuGSNRUMMWbWqoKUnlwbV0CsBUp/PvxmHxMZpf?= =?us-ascii?Q?gSp7RZNkW21T3yA+6tk4BGEMrkq4FMtUzXyXJCCebRKaNru6dD7am9tfe1Fk?= =?us-ascii?Q?Sukh9IwSlcb52iu/ufhXbvI5EoV+OR6XcQe5cqUh/Ok5oTqqYTXVAco6ObXq?= =?us-ascii?Q?jydtwIol1WNl9oqHPZE81pKJbpxvsnnVfG53a/ypTxkoTWvMXYzo3tbZN1nS?= =?us-ascii?Q?ygf8cYpVmenCwPP5b8TpZn/xzb8vD/Liyv/o4egwW4qRDId+sM0rFkOGroTW?= =?us-ascii?Q?3j8IQctlNkS5kakywisTcweSIuQ87pbSk+BZdikt4kDzsNZpUtvXWboEtLve?= =?us-ascii?Q?irkjlOI2E4cugkVIhoCbhIg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3516.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc681210-f06a-4c5a-99e9-08d9f2ba4d46 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 08:40:22.2384 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZxSK6KCmRDJ2Zc2/xD62m1Q5JiBUtSIvi1Pt+ZBlUQJsypUowJTjkiTwIb3LyyuE91iVIETl/ASgXckrhj3jhQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2233 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Wenxuan, > -----Original Message----- > From: Wu, WenxuanX > Sent: Thursday, February 17, 2022 6:14 PM > To: Yang, Qiming ; Zhang, Qi Z > ; Li, Xiaoyun ; Singh, Aman D= eep > ; Zhang, Yuying > Cc: dev@dpdk.org > Subject: [PATCH 1/2] app/testpmd: fix quit testpmd with vfs and pf >=20 > From: wenxuan wu >=20 > When testpmd startups with pf and vfs,this error occurs when quitting, re= sults in > pf is released before vfs ,so the vf would access an freed heap memory. >=20 > The solution is that release our allocated ports in reverse order,add two= macros > RTE_ETH_FOREACH_DEV_REVERSE_OWNED_BY and > RTE_ETH_FOREACH_DEV_REVERSE,which would be used in quit procedure of > testpmd, error is fixed. >=20 Please correct grammatical errors and refine your commit log. > Fixes: d3a274ce9dee ("app/testpmd: handle SIGINT and SIGTERM") > Cc: stable@dpdk.org >=20 > Signed-off-by: wenxuan wu > --- > app/test-pmd/testpmd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > e1da961311..698b6d8cc4 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3384,12 +3384,12 @@ pmd_test_exit(void) #endif > if (ports !=3D NULL) { > no_link_check =3D 1; > - RTE_ETH_FOREACH_DEV(pt_id) { > + RTE_ETH_FOREACH_DEV_REVERSE(pt_id) { > printf("\nStopping port %d...\n", pt_id); > fflush(stdout); > stop_port(pt_id); > } > - RTE_ETH_FOREACH_DEV(pt_id) { > + RTE_ETH_FOREACH_DEV_REVERSE(pt_id) { > printf("\nShutting down port %d...\n", pt_id); > fflush(stdout); > close_port(pt_id); > -- > 2.25.1