DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Yuying" <yuying.zhang@intel.com>
To: "He, ShiyangX" <shiyangx.he@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Zhou, YidingX" <yidingx.zhou@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	"Singh, Aman Deep" <aman.deep.singh@intel.com>,
	"Burakov, Anatoly" <anatoly.burakov@intel.com>,
	"Li, Xiaoyun" <xiaoyun.li@intel.com>,
	Alvin Zhang <alvinx.zhang@intel.com>
Subject: RE: [PATCH] app/testpmd: fix secondary process not forwarding
Date: Wed, 8 Feb 2023 03:22:23 +0000	[thread overview]
Message-ID: <DM6PR11MB3516AA76F9BA15227DA846108ED89@DM6PR11MB3516.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM6PR11MB3946CB97E9AB9103C5F762EAF7C29@DM6PR11MB3946.namprd11.prod.outlook.com>

Hi Shiyang,

> -----Original Message-----
> From: He, ShiyangX <shiyangx.he@intel.com>
> Sent: 2023年1月13日 17:08
> To: He, ShiyangX <shiyangx.he@intel.com>; Zhang, Yuying
> <yuying.zhang@intel.com>
> Cc: dev@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>;
> stable@dpdk.org; Singh, Aman Deep <aman.deep.singh@intel.com>;
> Burakov, Anatoly <anatoly.burakov@intel.com>; Li, Xiaoyun
> <xiaoyun.li@intel.com>; Alvin Zhang <alvinx.zhang@intel.com>
> Subject: RE: [PATCH] app/testpmd: fix secondary process not forwarding
> 
> @Zhang, Yuying Hi, please take a look at this patch! Are there any comments?
> 
> >-----Original Message-----
> >From: He, ShiyangX <shiyangx.he@intel.com>
> >Sent: Wednesday, January 4, 2023 10:02 AM
> >To: Stephen Hemminger <stephen@networkplumber.org>
> >Cc: dev@dpdk.org; Zhou, YidingX <yidingx.zhou@intel.com>;
> >stable@dpdk.org; Singh, Aman Deep <aman.deep.singh@intel.com>; Zhang,
> >Yuying <yuying.zhang@intel.com>; Burakov, Anatoly
> ><anatoly.burakov@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>; Alvin
> >Zhang <alvinx.zhang@intel.com>
> >Subject: RE: [PATCH] app/testpmd: fix secondary process not forwarding
> >
> >>> Under multi-process scenario, the secondary process gets queue state
> >>> from the wrong location (the global variable 'ports'). Therefore,
> >>> the secondary process can not forward since "stream_init" is not called.
> >>>
> >>> This commit fixes the issue by calling 'rte_eth_rx/tx_queue_info_get'
> >>> to get queue state from shared memory.
> >>>
> >>> Fixes: a78040c990cb ("app/testpmd: update forward engine beginning")
> >>> Cc: stable@dpdk.org
> >>>
> >>> Signed-off-by: Shiyang He <shiyangx.he@intel.com>
> >>
> >>Would it be possible to fix this the initialization of ports variable,
> >>rather than doing a per-state fixup here?
> >
> >In multi-process scenario, the secondary process does not initialize
> >the queue state in the 'ports' variable, and the ethdev's queue state
> >may be changed by any other process, which causes 'ports' queue state
> >of per-process and ethdev's queue state are inconsistent. Therefore,
> >getting the queue state from ethdev is a feasible way which I can think of.

You should fix the queue state in the 'ports' variable of secondary process in the initialization
of ports variable instead of fixup here.

  reply	other threads:[~2023-02-08  3:22 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-30  7:55 Shiyang He
2022-12-30 17:23 ` Stephen Hemminger
2023-01-04  2:02   ` He, ShiyangX
2023-01-13  9:07     ` He, ShiyangX
2023-02-08  3:22       ` Zhang, Yuying [this message]
2023-02-08  6:38         ` He, ShiyangX
2023-02-20  5:39           ` Zhang, Yuying
2023-02-20 12:45 ` lihuisong (C)
2023-02-21  2:52   ` He, ShiyangX
2023-02-21  6:37     ` lihuisong (C)
2023-02-21  6:51       ` He, ShiyangX
2023-02-21 15:44 ` [PATCH v2] " Shiyang He
2023-02-22  6:20   ` lihuisong (C)
2023-02-23 14:41 ` [PATCH v3] " Shiyang He
2023-02-23  8:08   ` lihuisong (C)
2023-03-06 15:16     ` Ferruh Yigit
2023-03-06 15:05   ` Ferruh Yigit
2023-03-07  3:25     ` He, ShiyangX
2023-03-07 11:41       ` Ferruh Yigit
2023-03-08  2:05         ` He, ShiyangX
2023-03-08  2:54           ` lihuisong (C)
2023-03-08  9:54             ` Ferruh Yigit
2023-03-08 16:19   ` [PATCH v4] " Shiyang He
2023-03-08 10:20     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB3516AA76F9BA15227DA846108ED89@DM6PR11MB3516.namprd11.prod.outlook.com \
    --to=yuying.zhang@intel.com \
    --cc=alvinx.zhang@intel.com \
    --cc=aman.deep.singh@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=shiyangx.he@intel.com \
    --cc=stable@dpdk.org \
    --cc=xiaoyun.li@intel.com \
    --cc=yidingx.zhou@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).