From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF3C7A0032; Fri, 18 Feb 2022 09:39:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF6E640395; Fri, 18 Feb 2022 09:39:56 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id D5D6D40150 for ; Fri, 18 Feb 2022 09:39:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645173595; x=1676709595; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7R3fWKyO/AUTWUXWVpGx+YOIYUF7+vihQJf8Bf14rh8=; b=a0z61zcsnpLcNn451Uf6eTJfCJn3FS7+xp5WYtIICX01JE4nALXA84vS nSLhVzZwkadgzypwa3v4BCwGRtRW28P/lxnG5z3Kc90IcxndBUWqGwSrV xZcmKsheScrBdzKCcc1PeRDV8h1zf03+0OL9KkQOkNjyXc+lZWbGXtSGk jtdgo+W1WKyWGbipKa7bmgO4o9A6E+8wxNRsuRm9mJrnsIHx2WP7zENm5 WGFDpVvQb2igMGtYj3aS/lksauqPw7zbIMG1S1/IFvh8bZ+I8tSD26Vxq YVjgn+zXcu/b8xDRIJASWAWe5oSJfrSLyIpbpDKvJzMDPOWJV4MeKZOPG g==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="337528331" X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="337528331" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 00:34:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="505155060" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 18 Feb 2022 00:34:57 -0800 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 00:34:56 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Fri, 18 Feb 2022 00:34:56 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Fri, 18 Feb 2022 00:34:56 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.174) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Fri, 18 Feb 2022 00:34:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C0hAf1YOGVEjfyJnb0F7mXM0saBOhnb2D7sPGyQzBieu31YmJMsnab7Y5iS4blDHsPuEYbqcUY1/HMlaqfmoWg2b38U6+zXMoE6o/zDGHZLaN4opZ8RQ3NJBEsZro2jPSxTP/rYa4c1c4WpJbJ3Oqf6oZ2M7MF9+ruPrawTM2fmYxeJ9wrlOogvu9+sA8dni0Etd9A4MV/bm1wuUHyTsh5Q7DKNVUPh7RTKFm1V8lMoq0j6OCWZCf7tC5lkJ1epEJDJWEnVH1lJKM/Ev7+LE++yb0wzMq6V6YywPQzghC8JOoVBz2l8XElfGiLx1kvLnKGFghy9E8ZEBT+paGb16lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RDR8sWWVNwTfCtTTS46lYKmeZnA2QQjKgUSbcXeKkuM=; b=EfQ+b16hvJxyQfzWxM8wKg1pEllOq152rFSpRCZHopQy822N2huPeFMRYqBEMhSEHa1bRuQxKlWDCg1kLKtObb3LMA22nulVQXz9GI4N42sRfr0yEkpW2A6cZfYmqMCVhNefCMKkHATUpBqwC1vRQunMIjvLr5vEGSyirf1Zavmg0OjlV7w5Y2OBESmhyrG1/b3IzTmsoLQLqJ8mjsYfW/umA+dxV1LbMMbIowE8chdDNU4AJKw5lQ/o46b5i72Cuhd353//A6YaDJRwbxLxV9IkOvDD/OqJtdQ4mcNcESsDoQlbyud3sGoqQfp/R3wY6iHR0L3Q5aCX+zd3Y+RY9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3516.namprd11.prod.outlook.com (2603:10b6:5:72::13) by DM5PR1101MB2233.namprd11.prod.outlook.com (2603:10b6:4:4f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Fri, 18 Feb 2022 08:34:52 +0000 Received: from DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::1c27:af5d:3e9e:d172]) by DM6PR11MB3516.namprd11.prod.outlook.com ([fe80::1c27:af5d:3e9e:d172%4]) with mapi id 15.20.4975.019; Fri, 18 Feb 2022 08:34:52 +0000 From: "Zhang, Yuying" To: "Wu, WenxuanX" , "Yang, Qiming" , "Zhang, Qi Z" , "Li, Xiaoyun" , "Singh, Aman Deep" CC: "dev@dpdk.org" Subject: RE: [PATCH 2/2] lib/ethdev: add reverse macro to quit testpmd Thread-Topic: [PATCH 2/2] lib/ethdev: add reverse macro to quit testpmd Thread-Index: AQHYI+oH0mri3nig4EafxY1PaaLxu6yY+jnA Date: Fri, 18 Feb 2022 08:34:52 +0000 Message-ID: References: <20220217101428.385751-1-wenxuanx.wu@intel.com> <20220217101428.385751-3-wenxuanx.wu@intel.com> In-Reply-To: <20220217101428.385751-3-wenxuanx.wu@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f93fd006-43ca-4da8-d83a-08d9f2b98884 x-ms-traffictypediagnostic: DM5PR1101MB2233:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3631; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7JmzgHJ4usINq3v/wWR1U0RDjlgpt9wiBP2s9wogmWvSnZqBA88ofvAkVAa7AmHmgdsJksHCTuryBylGj87XKR93M/kIwF2kHk7dSRqlpiWXHaom02/DgAH1uD9l+oiUVfFxUxVTD9bWCPA8HznjekxM2+eUzhfvH6YluYtaQpgFFizIquF27cHfPO0BkKbijQ4FDdYjIvgTH5PO6783h7AnjxoAXnR5pBpLJzebrCustYYrm+dFsmZPXrEjZVqyGgAlLzfaVSKCtMOGRwEXKrbTwq90eDi55qpC7VqWKzfw1dJZsU2l1wy9h3T8pkevWGbZRYTi+4qy9N07Ni1oOJAI2uG2YKqjT+9vHU2+WxbX9aPM5jTSzfHBoH6bfdBnCFDz8GuNpgjtbwnUg3Ifq5UbgEk26yFEhYitNCfUJVuhaiKhhFzRmywSrY12qQh9absPsYRxpCTfBLWV4dgMteayFm8GlTR1E6cureu9918ZS5ivkwPZ4z8NtI/n+Q++fSqRnjKQoWQcZsFLRIB32r2pdDZukSKIO4GkEIvPUGgt9nbQOuIV5R6ZWNd0k/rxIbAFX40ELbdS//0b8pAhTxdySTJ83DEMbwPzJtbfLtMAfGPUEbHyQCA6olpzFcDBJVMWElQzyvxSRI+7DRFWsp/SI5vbZdTv5m0/llDfEXMIG5zu2mnKlE3H0tUycGbCPhiKb16d8oDVXq8sC6j6tpHlATZrFSNWSpocPilw/jY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3516.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66946007)(9686003)(53546011)(86362001)(55016003)(38100700002)(76116006)(921005)(64756008)(5660300002)(8676002)(66476007)(4326008)(66556008)(66446008)(6506007)(6636002)(38070700005)(316002)(52536014)(71200400001)(33656002)(122000001)(7696005)(82960400001)(8936002)(508600001)(26005)(2906002)(186003)(83380400001)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bKL9t08sLVANbyb5FcSt6Sl1OCFgeD5FAWgKK/2/z1/xE1leaCtcIOenzxyf?= =?us-ascii?Q?T0SWcyLRYTvW/w/euGd8+Pso5h3uoB9zXXQZ4TPnQk6ubKgI+ouSqZ3IIyd8?= =?us-ascii?Q?IyXAZu4DEbpZdXQj0S04n+7d9LQ8ozEOQgk5V8KL208dqQq8mq/KEiEwRtgg?= =?us-ascii?Q?2CJpgDF6ZnQnvdWfCr+afQMVAIhN37gzRBHBxo5VhFYhQUEw13Ffg9dmPS7k?= =?us-ascii?Q?UsnD+lLHjWx6U+wfvmhC7/a566Gko9iMSTvYA/C3My/WKtn+nXafq/CjbAda?= =?us-ascii?Q?xzaPYEPdoE93vUYjMuTQTJ7FTHozOwxetxpnioZ8E+OVAGz/C1qdLTpdvI2M?= =?us-ascii?Q?nMKaGrAVJNKssx1nGvq/1Av3WMbICG84YjUd3jDuG8KnpXiLQYwsKT6yWREq?= =?us-ascii?Q?mxfN72zpYA8vJ5/Z5jIssRsGD4YSrBfJQoHEmsrrQ04LLJ55b8zY6eHsbAtd?= =?us-ascii?Q?XKnKBVfhH1m0n82LvQaViWHJzwJVFDOIJ5cALQjMFYXXDp1z46BHZrHa5jIZ?= =?us-ascii?Q?rugtyi/balEarHe2Ac772eAepkNs7kZmuMMh4UTEruVgkldGzR9gxqLL6n1t?= =?us-ascii?Q?p1eI45nb4qXUWVtV/xhoRSaXIwtEc6Fw44aQ3pGT9A847eFADuCoEuS/u+yG?= =?us-ascii?Q?g48DFVf3rxsxRig0fvlhGao4MDhmbi+mL4hd+QaiD9CgemmlPELskWSeACj6?= =?us-ascii?Q?69jsMhaD15FL4mgn6ItkoNTTJN9iaoPFUDyUz3xxx3fePRdTt+LhgsN3jAHg?= =?us-ascii?Q?4ppDxZChhPSmrXXEctWXnmX30QYRuZEDJ4/ueXtY0HAU7cFRc3sbyDvicSqG?= =?us-ascii?Q?iP2S3l1IKWTCzvYr54e+US2c3Kj2PpbZKMPVqoYsh2po5OezgmMNY4EuI4Mj?= =?us-ascii?Q?VgISzVCiZFASbbooicQDKEGTNPoCpTUNeG5MtQ3bfbKG4f66E8j1BXm/+YEU?= =?us-ascii?Q?vle8hO7yBtsrnoXVXMAeV9s3FH5PZUIItZHQXETze62PsqHStAIlN/wX+1FP?= =?us-ascii?Q?gdjdcXfFPlnp4ip9vBnZJw9y6gYFGJ6laEe8vRtezgC4c+2ntnndzudQgwoN?= =?us-ascii?Q?TWJSzAGnXKg8PFBDwl1QvPTPPYe9SNjz67tDrt4KuOPHWrE91cUFrEsnPt5U?= =?us-ascii?Q?jgOef3KgBUwaNmQ4+ZnOGQ/L0e/p5HCYQzA45UFaNj2TJgSUOuIAphdbGw/I?= =?us-ascii?Q?y2S+4qvW1+DrxQ7E76mgdXXWU24mOmhAw4dKzOXTo6CmWws2bqJ2nWYTRqQ8?= =?us-ascii?Q?aGQeuxnNQHVv10gMyDRvnl96AvttZVqSw9yvZhQYcQknMieiLVVLSwnEi7aS?= =?us-ascii?Q?GdRI9tL7z4lPLsYk/TZyjxo48Xo1GEGqQlNkRDwBtJPSG4QqthEo3Ukb9vrR?= =?us-ascii?Q?CbthufWlKp+rPF8P3Jk8d7mnmWaNXch8G70GOB6dEIDfKT4x0ZKvE8i3ov+B?= =?us-ascii?Q?e4obfsVbGrLS4sD1i+wOwtDfj2F+vVRkGodbAOPlXW4K0EsIDEqUh3q5apIN?= =?us-ascii?Q?VBByz758toLiE0zNny1QAe86LhOUEV0887CyGnykcJjIYsexRcatUcHv5+jh?= =?us-ascii?Q?0lWz2vvB5AyO0c6J+NIN8j8Zhn0t0CdbPVCQe3PeLS48oRwM6kNvYt31nvdX?= =?us-ascii?Q?DPGM3HWBPtH/GmNQjg/7Z8w=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3516.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f93fd006-43ca-4da8-d83a-08d9f2b98884 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2022 08:34:52.1664 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OJe1MwuqxMAVMvlX0quoRV5+IzRSG+cWYgtQuduj2DlAlhMQne6MuknHgTznkU4o+z2//jIdGKJf/9NPID/Svw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2233 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Wenxuan, > -----Original Message----- > From: Wu, WenxuanX > Sent: Thursday, February 17, 2022 6:14 PM > To: Yang, Qiming ; Zhang, Qi Z > ; Li, Xiaoyun ; Singh, Aman D= eep > ; Zhang, Yuying > Cc: dev@dpdk.org > Subject: [PATCH 2/2] lib/ethdev: add reverse macro to quit testpmd >=20 > From: wenxuan wu >=20 > There is a heap-free-after-use bug when quit testpmd with pf and vfs, sto= p and > close ports in reverse order is a more reasonable approach. Please explain the issue and your fix in detail. Since your patch is a fix,= you need a fix line here. > Cc: stable@dpdk.org >=20 > Signed-off-by: wenxuan wu > --- > lib/ethdev/rte_ethdev.h | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h index > 2660e4f374..e080840b06 100644 > --- a/lib/ethdev/rte_ethdev.h > +++ b/lib/ethdev/rte_ethdev.h > @@ -2185,9 +2185,13 @@ struct rte_eth_dev_owner { > * @return > * Next valid port ID owned by owner_id, RTE_MAX_ETHPORTS if there is = none. > */ > -uint64_t rte_eth_find_next_owned_by(uint16_t port_id, > +uint64_t > +rte_eth_find_next_owned_by(uint16_t port_id, > const uint64_t owner_id); >=20 > +uint64_t > +rte_eth_find_prev_owned_by(uint16_t port_id, const uint64_t owner_id); > + Please keep consistency of code style of similar declaration. > /** > * Macro to iterate over all enabled ethdev ports owned by a specific ow= ner. > */ > @@ -2212,6 +2216,14 @@ uint16_t rte_eth_find_next(uint16_t port_id); > #define RTE_ETH_FOREACH_DEV(p) \ > RTE_ETH_FOREACH_DEV_OWNED_BY(p, RTE_ETH_DEV_NO_OWNER) >=20 > +/** > + * Macro to iterate over all enabled and ownerless ethdev ports in rever= se > order, for quit purpose. > + */ > +#define RTE_ETH_FOREACH_DEV_REVERSE(p) \ > + for (p =3D (rte_eth_dev_count_total() - 1 >=3D 0) ? > (rte_eth_dev_count_total() - 1) : 0; \ > + p < rte_eth_dev_count_total(); \ > + p--) Use rte_eth_dev_count_total() function can only get the number of valid por= t instead of port id separately. You should can refer to the logic of RTE_ETH_FOREACH_DE= V(p). > + > /** > * Iterates over ethdev ports of a specified device. > * > -- > 2.25.1