From: "Zhang, Yuying" <yuying.zhang@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>
Subject: RE: [PATCH v3 13/14] net/i40e: fix whitespace
Date: Fri, 11 Nov 2022 06:23:31 +0000 [thread overview]
Message-ID: <DM6PR11MB3516D9754E1416F03C0338C68E009@DM6PR11MB3516.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20221109232451.265059-14-stephen@networkplumber.org>
Hi,
Could you add fix line and Cc: stable@dpdk.org?
The fix looks good to me.
> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: 2022年11月10日 7:25
> To: dev@dpdk.org
> Cc: Stephen Hemminger <stephen@networkplumber.org>; Zhang, Yuying
> <yuying.zhang@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Subject: [PATCH v3 13/14] net/i40e: fix whitespace
>
> Add space after keywords.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-off-by: Yuying Zhang <yuying.zhang@intel.com>
> ---
> drivers/net/i40e/i40e_pf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index
> 15d9ff868f3a..7050e0057d8e 100644
> --- a/drivers/net/i40e/i40e_pf.c
> +++ b/drivers/net/i40e/i40e_pf.c
> @@ -956,7 +956,7 @@ i40e_pf_host_process_cmd_add_vlan(struct i40e_pf_vf
> *vf,
>
> for (i = 0; i < vlan_filter_list->num_elements; i++) {
> ret = i40e_vsi_add_vlan(vf->vsi, vid[i]);
> - if(ret != I40E_SUCCESS)
> + if (ret != I40E_SUCCESS)
> goto send_msg;
> }
>
> @@ -996,7 +996,7 @@ i40e_pf_host_process_cmd_del_vlan(struct i40e_pf_vf
> *vf,
> vid = vlan_filter_list->vlan_id;
> for (i = 0; i < vlan_filter_list->num_elements; i++) {
> ret = i40e_vsi_delete_vlan(vf->vsi, vid[i]);
> - if(ret != I40E_SUCCESS)
> + if (ret != I40E_SUCCESS)
> goto send_msg;
> }
>
> @@ -1577,12 +1577,12 @@ i40e_pf_host_init(struct rte_eth_dev *dev)
> * return if SRIOV not enabled, VF number not configured or
> * no queue assigned.
> */
> - if(!hw->func_caps.sr_iov_1_1 || pf->vf_num == 0 || pf->vf_nb_qps == 0)
> + if (!hw->func_caps.sr_iov_1_1 || pf->vf_num == 0 || pf->vf_nb_qps ==
> +0)
> return I40E_SUCCESS;
>
> /* Allocate memory to store VF structure */
> pf->vfs = rte_zmalloc("i40e_pf_vf",sizeof(*pf->vfs) * pf->vf_num, 0);
> - if(pf->vfs == NULL)
> + if (pf->vfs == NULL)
> return -ENOMEM;
>
> /* Disable irq0 for VFR event */
> --
> 2.35.1
next prev parent reply other threads:[~2022-11-11 6:23 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 19:14 [PATCH 00/14] whitespace around keywords Stephen Hemminger
2022-11-09 19:14 ` [PATCH 01/14] eal: fix whitespace Stephen Hemminger
2022-11-09 19:14 ` [PATCH 02/14] cmdline: " Stephen Hemminger
2022-11-09 19:14 ` [PATCH 03/14] timer: " Stephen Hemminger
2022-11-09 19:14 ` [PATCH 04/14] ip_frag: " Stephen Hemminger
2022-11-09 19:14 ` [PATCH 05/14] testpmd: fix whitspace Stephen Hemminger
2022-11-09 19:14 ` [PATCH 06/14] test: fix whitespace Stephen Hemminger
2022-11-09 19:14 ` [PATCH 07/14] examples/qos_sched: " Stephen Hemminger
2022-11-09 19:28 ` Dumitrescu, Cristian
2022-11-09 19:14 ` [PATCH 08/14] examples/vhost: " Stephen Hemminger
2022-11-09 19:14 ` [PATCH 09/14] l3fwd: " Stephen Hemminger
2022-11-09 19:14 ` [PATCH 10/14] examples: " Stephen Hemminger
2022-11-09 19:14 ` [PATCH 11/14] bus/pci: " Stephen Hemminger
2022-11-09 19:14 ` [PATCH 12/14] net/e1000: " Stephen Hemminger
2022-11-09 19:14 ` [PATCH 13/14] net/i40e: " Stephen Hemminger
2022-11-09 19:14 ` [PATCH 14/14] net/bnx2x: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 00/14] whitespace after keywords Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 01/14] eal: fix whitespace Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 02/14] cmdline: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 03/14] timer: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 04/14] ip_frag: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 05/14] testpmd: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 06/14] test: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 07/14] examples/qos_sched: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 08/14] examples/vhost: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 09/14] l3fwd: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 10/14] examples: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 11/14] bus/pci: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 12/14] net/e1000: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 13/14] net/i40e: " Stephen Hemminger
2022-11-09 19:53 ` [PATCH v2 14/14] net/bnx2x: " Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 00/14] whitespace after keywords Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 01/14] eal: fix whitespace Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 02/14] cmdline: " Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 03/14] timer: " Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 04/14] ip_frag: " Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 05/14] testpmd: " Stephen Hemminger
2022-11-11 6:30 ` Zhang, Yuying
2022-11-11 7:12 ` Zhang, Yuying
2022-11-09 23:24 ` [PATCH v3 06/14] test: " Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 07/14] examples/qos_sched: " Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 08/14] examples/vhost: " Stephen Hemminger
2022-11-10 1:48 ` Xia, Chenbo
2022-11-09 23:24 ` [PATCH v3 09/14] l3fwd: " Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 10/14] examples: " Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 11/14] bus/pci: " Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 12/14] net/e1000: " Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 13/14] net/i40e: " Stephen Hemminger
2022-11-11 6:23 ` Zhang, Yuying [this message]
2022-11-11 7:12 ` Zhang, Yuying
2022-11-11 16:48 ` Stephen Hemminger
2022-11-09 23:24 ` [PATCH v3 14/14] net/bnx2x: " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3516D9754E1416F03C0338C68E009@DM6PR11MB3516.namprd11.prod.outlook.com \
--to=yuying.zhang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).