From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE6B041C27; Tue, 7 Feb 2023 02:11:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 469F740ED9; Tue, 7 Feb 2023 02:11:15 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 59739406A2 for ; Tue, 7 Feb 2023 02:11:13 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675732273; x=1707268273; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=phzmABa/tfU/dbvEXGeZTxnfTI5I7TOHQuOFDcaM4F0=; b=CPd2Nr9XCD7MNYtfZ/9ZbOB74pILyPWXKFOAYpOTq4RxdU8/tVkiXSXD yY1ZYAV9GEKfVyTX6pt2AvhP8U7In7T2mkZSpIuC2RoHMj0PEO35tqxa8 VGS8ssErkWc/FrC5s3dSAK/KPpTARG8IfAHTx3gEaVD8rvARjgSoVqTX3 bewQuQH3K4doIu1j7b9w1DOe5NNkliXs2WlfWcq4LsHgPOUscCwseHGyd Q1XArGQJ5oOXkRtfnAIghTw4VM8MhtCTBAJeaxegg1uEh5Qs66rf5e82K 9Z+1h40Awur0UtE4MaZjI3pj4f87RrYN6iaCbkzWf5NeU40q6eE2bo72k w==; X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="331501868" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="331501868" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2023 17:11:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10613"; a="790610223" X-IronPort-AV: E=Sophos;i="5.97,278,1669104000"; d="scan'208";a="790610223" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 06 Feb 2023 17:11:12 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 17:11:11 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 6 Feb 2023 17:11:11 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 6 Feb 2023 17:11:11 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 6 Feb 2023 17:11:10 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M+TrOxLI+q6qg0DZaYWyvmg/rKQd+syKFOfVOca0m/ToGsgbtbsgahhIG6jj1xmn+RenMrhfKLg+rSHi5UX4RPE/aLoeqF/b9GYif5cyfKvldQFal61e/v2EUXrqvF5s4bg+LszTB/2NVsHBnAulRYHD9evI59nPsgRQ3iIDufdJUwhV0yaMbfWWqdJ+vADyj/OoQcW8KnjWMne5/LiVRdds4N5zL/ccsKioZRUZX/fBP1HWM0HE7eEY2LAMkJzoqmdtNOt6QkGtghga+0JUJWsS0fMkZe/qDlkwV6XJlScVUNFBjlZqg7qDDmqTakCm4Niz/HPbuzMep6Bmpmac/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OlSrIh3R1zogtALEbP2DZ8bfwNdoE1hlPLUgecFd/rs=; b=UzAalRziM71lAAcoZKbrbYVlulz0F9Yu6ZvLbqPgXSd4NxFDyDApOWS9cQOUNMVS2zEiYsEsazdAK3r446nyMTFcS3omYY9v+C73/26m3pmMg3DABDHgbgxjUSpSelNGEomiGlLSCnP/t5SO0sJQ+rFUVvc1ajhin0IuoFIesCemYPpJXL51Pb7N59cXGp2JKh7kD+y7evWl3sWatmMxQUtZsv/dx2kz85T1BYeALT/ih67ClyXlEXp8HhSr4+O/poLrPfXeOE4Gx60v1Lyi1BwwjIIXW0u7eXbk0ZzCt+fkrKdq/WRUq5u71lDNLPvR+EcmiAt2y66mczWiGrA8EQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3530.namprd11.prod.outlook.com (2603:10b6:5:72::19) by SJ2PR11MB7454.namprd11.prod.outlook.com (2603:10b6:a03:4cc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.36; Tue, 7 Feb 2023 01:11:08 +0000 Received: from DM6PR11MB3530.namprd11.prod.outlook.com ([fe80::d4bf:943d:a195:b08e]) by DM6PR11MB3530.namprd11.prod.outlook.com ([fe80::d4bf:943d:a195:b08e%4]) with mapi id 15.20.6064.034; Tue, 7 Feb 2023 01:11:08 +0000 From: "Huang, Wei" To: Chengwen Feng , "thomas@monjalon.net" , "ferruh.yigit@amd.com" , "Xu, Rosen" , "Zhang, Tianfei" CC: "dev@dpdk.org" Subject: RE: [PATCH 2/2] raw/ifpga/base: fix mmap retcode check fail Thread-Topic: [PATCH 2/2] raw/ifpga/base: fix mmap retcode check fail Thread-Index: AQHZOhoba9LjGj9y8U6UNpzHlOGfUK7CrbRw Date: Tue, 7 Feb 2023 01:11:08 +0000 Message-ID: References: <20230206105311.9577-1-fengchengwen@huawei.com> <20230206105311.9577-3-fengchengwen@huawei.com> In-Reply-To: <20230206105311.9577-3-fengchengwen@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3530:EE_|SJ2PR11MB7454:EE_ x-ms-office365-filtering-correlation-id: 00ff83c2-1bdd-4f09-bdc1-08db08a831db x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 7jHSnTd8YZL0JM9dECWnXXsD6g8If8H5qpm8NCbviLEQp+e0e14y1Wu43oBZkVFXN/wyp9LaemLkACaeSxyCAdbWifEvnWbHp6UbYDk6LfiHn0yjKk8w3fDEp9XGeRtpyIRIr60RSjEy7n5lNIkBKgzZ4JG5cQpvJN7MWIi5eCxlGTpS3bFocnpS33GNCMADuh5ORvm1TFFAxwLff6JIz3pQO8V4m1hcGsS3mE803+6w2yKM5vChcN0pBWVMgP4mqfTqcyD7pM0TZdcB0XXh3uq+Sye7m9J1CHpV7GlOWjh9yf5UgpqteAePk5gLg36ndpz1GHu+cNhOzGpbet3xaAZ9j+LNZabllKL/OCCIBezooRKpZdNCdzkyq4f91sT6JSABLMfpS+vuAhA2Oe2Byoyn9NK5W+kCr9e7EkH2e8Uk1OCaCa8qnFMrq146NX2JXUKE/V/ALL2YZYIc8qF8Uy7sihjrcwfIIPS/gqi3Gd/s0Ys4uPazVRogIqZvp/z6T5ycTbY9Bd7+MdwB5Y1AKJt5almNAMXFi/mUKRZ0nVDX/GSorT6xE5ZLm/whwUos9NzczJffPBvY5h37EjZNumBtjt1PHAuOppfPI89cp1TDLLt7nqFTKUT6V0OBmDqKmG4TaNYcQ+q0vpwF1CENguvbDpbwsKoiyI1iZxOcd3QpfbvjFCVibL9rqjS6p1J6HUnytI0/+S6ReTK9sgfWxA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3530.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(366004)(396003)(136003)(39860400002)(346002)(376002)(451199018)(7696005)(478600001)(110136005)(316002)(6636002)(41300700001)(83380400001)(66446008)(4326008)(66476007)(66556008)(76116006)(8936002)(8676002)(186003)(26005)(38070700005)(53546011)(64756008)(52536014)(71200400001)(66946007)(6506007)(9686003)(82960400001)(38100700002)(86362001)(2906002)(5660300002)(122000001)(33656002)(55016003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vJmgo4qXwV9a4/2N7E1q0L8k2bZVut7a8/HCZ3+rozqZW9hR9+ZtrNbu/cRq?= =?us-ascii?Q?wwPfGqbDEauAYDaoGcZrZzv8ZMfl+NzF/mbcL1GzaMLSJG0dQMINKLl2iVaN?= =?us-ascii?Q?h93SRaIQ2mqTQKHdm5ERmDfiaFO+ypg8WB0s8xtmtMe8VxB4kqi0eDVsEGht?= =?us-ascii?Q?wem7TyEmwXi8ps5D1UdAgYVnaDyFqDwjwVYe2NM12AjdJVdYA10b2ODLBk2B?= =?us-ascii?Q?Qa8AziBmSVAzfA8UcxyspCabBOMgFeIDeBVOA2ug7BIcPlCmxlrcK1kfmEp7?= =?us-ascii?Q?Z5MbcuZaxze1DtE96G+/jO0eWIQw5qQhFjwgkRhwSoQG6zLRxIX9ST7ZcQKL?= =?us-ascii?Q?Dti7WCUcsepzwSuVnVzHNOfUV1aiL3rXXt1pBnqmEUxZ3NwO4XPGl3CEZSjg?= =?us-ascii?Q?ktW11WjAP3E6kv2NpN2bRgqgZn08y0MpRAY2qhNXVr1LTI6EQ0nrgiu9qbMc?= =?us-ascii?Q?bHV1rbygK6fSkPs3VZcbR6UQPbj+WghFDvidc9xlTihPYU1RARNLfQA7kOmQ?= =?us-ascii?Q?E2EYqGKCzkSM672e3XiYM+lMGFqxYn1JEfaYC+34XEnCFRUArrk/X3zjbElk?= =?us-ascii?Q?fBAYaXvTAoMxaCPmFrC6Vw8FCgSdMAWyRu7Ms57mCciG5er0G1GmO/Lz9Rhf?= =?us-ascii?Q?eyKKHVsqy6MmdyWaJEyS26VxHJ2CkgpUzNNe9p3Fel75Vz/1XpIvUwFb9n67?= =?us-ascii?Q?kAL/yxOEHj1gMxuwBTL1nOQ2ev14cQwSZMZjLrdHbSrM1mb6tptsbgYcFDp2?= =?us-ascii?Q?e8npUF0tPs9xRHMtFjFY2wC5IRSVpJSd2LeOiPoJQMbpDmTi5C01yu7eGnHu?= =?us-ascii?Q?yUSPEFF02PziHPVJlpZGcFxNRSkqv5Kfi1QiHAJbpghT4+AEumpyTYGFfh92?= =?us-ascii?Q?tbX3U7FNkmgRkfXgBsl5MUFkMM3UVavQeLFRyLGVxU9g7ueMLN6nz5ASUDkw?= =?us-ascii?Q?JQOQg/D0SfBm3WMjnSM9i8bpa+3NFOvSqBvwaG4ndVTO337m9MLni6kQkCG0?= =?us-ascii?Q?CVldEvUXHjgS9DWIPjow2WrBygZItSldF2IhRpQ0I9xz8LH0gr241aPaU0Bh?= =?us-ascii?Q?qxoInx69A9u906gylH0bmNqc2eGdWAjcFwqoqlTgYeV9twK4M7p+i7aix5ii?= =?us-ascii?Q?iyq28edaRok9Dbvd9Jw77A+vBMWLW1NxTPL0I/oVo29uFMyo1+9bHdFpBLo2?= =?us-ascii?Q?jKsEgdFiPh65jF+hvOFgC7NEVLXC/P662hOJhc/eC5TQy7vBQYOypH33Qcb0?= =?us-ascii?Q?wXazJPnLtlUsve+EcAVUbFYFuSHDCwSSpF33F7ILUnAxgh7Bz/c2qEzNkKds?= =?us-ascii?Q?WGDnZzqePpfsHCpGdH9ADsQx5Nh345lg1+MH8Mc1ibiecJhy934mfhTJZt09?= =?us-ascii?Q?626E6IOV+QQAEW65iYTT10apC6SLMMGZ0WA0yBOPX8k9v/uzxBg4otvU0XZ3?= =?us-ascii?Q?wIhiJxMKITnwId1ZpUq7UXcgDYZgY/CcAysSE4UfKViQ3AEN9CY4sq5ixhiZ?= =?us-ascii?Q?Vd8eKdc7jHzjNnhMwOvWMLDMER8YRm3kFVPiTQhkyF/TT0IM9E4c7ej6KiPP?= =?us-ascii?Q?Ocb2j5xs7YKCC/WqjoWshCg9fcv2GQa4iP1GmNCI?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3530.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 00ff83c2-1bdd-4f09-bdc1-08db08a831db X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2023 01:11:08.6913 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T37rNq7MP/szq1TMSlHphha5BGOpUqNVF5rHIgTVRidtQYbgxJSIhs2H/BMRrTJqWY+nh8uyAuwd96+VAwT61w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7454 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org It looks good. > -----Original Message----- > From: Chengwen Feng > Sent: Monday, February 6, 2023 18:53 > To: thomas@monjalon.net; ferruh.yigit@amd.com; Xu, Rosen > ; Zhang, Tianfei ; Huang, > Wei > Cc: dev@dpdk.org > Subject: [PATCH 2/2] raw/ifpga/base: fix mmap retcode check fail >=20 > The MAP_FAILED should be used to determine whether the mapping is > successful. >=20 > Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in multi= - > process") > Cc: stable@dpdk.org >=20 > Signed-off-by: Chengwen Feng > --- > drivers/raw/ifpga/base/opae_hw_api.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/raw/ifpga/base/opae_hw_api.c > b/drivers/raw/ifpga/base/opae_hw_api.c > index 1117c3e160..6d48d227d6 100644 > --- a/drivers/raw/ifpga/base/opae_hw_api.c > +++ b/drivers/raw/ifpga/base/opae_hw_api.c > @@ -380,7 +380,7 @@ static pthread_mutex_t > *opae_adapter_mutex_open(struct opae_adapter *adapter) > PROT_READ | PROT_WRITE, MAP_SHARED, > shm_id, 0); > adapter->lock =3D (pthread_mutex_t *)ptr; > - if (ptr) { > + if (ptr !=3D MAP_FAILED) { > dev_info(NULL, > "shared memory %s address is %p\n", > shm_name, ptr); > @@ -499,7 +499,7 @@ static void *opae_adapter_shm_alloc(struct > opae_adapter *adapter) > adapter->shm.size =3D size; > adapter->shm.ptr =3D mmap(NULL, size, PROT_READ | > PROT_WRITE, > MAP_SHARED, > shm_id, 0); > - if (adapter->shm.ptr) { > + if (adapter->shm.ptr !=3D MAP_FAILED) { > dev_info(NULL, > "shared memory %s address is %p\n", > shm_name, adapter->shm.ptr); > -- > 2.17.1