From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3049BA00C5; Tue, 4 Jan 2022 09:35:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B217540040; Tue, 4 Jan 2022 09:35:33 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 8BA044003C for ; Tue, 4 Jan 2022 09:35:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641285332; x=1672821332; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=bgxJx23/GYIY1kJSDp+TgZsS5cWU5qIfhrEsk2g6qzk=; b=k851y/K7GKalhVr6vqRLiwZNMHqhTA1M3SqNaHDkWHTvaSyzDDfouRxL DF3EzFPwtPIKw1VGUHXySEWVPycovIw1sSmWfsZwqgZ+3hbIV7a0UADO1 AM5Bj47KoSVlXJDSdgxHCm0VgFmSMWCWVKcpTuSXrGLxt98oNu8e6ptfB h//SI0uh5CD/djLJKJvt5QqSrVYu3aYKArlDGobAQJfmABWnMvWLCQgOu xZra/+sslOUu746FP/dHOvjECSYHl27dHyLPIl4hb0h7wqjgZdxuqDkWd POxe6eXuMygW5fOXNPreBhSZin0LfXygABHuxP8eyid8x99lDu8doAg1n w==; X-IronPort-AV: E=McAfee;i="6200,9189,10216"; a="328525689" X-IronPort-AV: E=Sophos;i="5.88,260,1635231600"; d="scan'208";a="328525689" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2022 00:35:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,260,1635231600"; d="scan'208";a="471981145" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 04 Jan 2022 00:35:31 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 4 Jan 2022 00:35:30 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 4 Jan 2022 00:35:30 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 4 Jan 2022 00:35:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KcJbHYomwxRkbUuZGW4xCIXSxzShhJUvB9SsTx9MmlcnD2FvdsKh6KJnvjGdYmYJwViXsDcXNAgnP08kjHgqllC9SHGdsXEe7rvnT1OaweDxfVl5jfs550Ee2o4hQFywH3VIyUgfjctRrx4Yz4gkp5h4TKBtBBsNzyT14EDcFALQdMktgL7FE1mMn/Q60UWQJhwP4XAbvctO4wjXM33WusF/Hobbhe5KvMfdr5h1QN8fStH0s3d2ru1hMFaD6ZXaDZ0oawc6E/aioxFxNqCUe2KbVOcasA7l5A8HN2sunzMluznebFvZ/BtLmNCYq0zJb/AbxUvO7b7Nl7rGxhncFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V1xMWf492pNbkRY9CeKs5EJXIAQCwQbCyeCVeqIk+Q8=; b=L2zH3SUVsR+9mYqAsCD5qjaB8jC2pQZc23GwQ76UDfuEIjcJb5vG8RlS0pJLpzrkkZyz5EbqusYhDcLTRYN1Xnkvw5yqpucLD0TEj5fprb7OzJIDQgHE8uC8eHXPYG7lH6lTnESvJ8UwDuVVVIr71ueLcijCx/gedpRUyYYZ/tAR7tnj128Y2O1TwVGptGKi947GjrmgaVSXf56w/9Y93tXfo8Im8blyTIL71uZ9c2pQGGRRNeewjTBPdhNYfBH1yoRXMR8PTonNrq2H6LSxic8oxiEKs96iQNXDldcBVc4i+yZAsj/TxXUuFWiDN5vFSSqh7t+vjfkVL2fTUmhffw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3673.namprd11.prod.outlook.com (2603:10b6:5:145::26) by DM6PR11MB3756.namprd11.prod.outlook.com (2603:10b6:5:136::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4844.15; Tue, 4 Jan 2022 08:35:26 +0000 Received: from DM6PR11MB3673.namprd11.prod.outlook.com ([fe80::59b5:5701:236b:9a88]) by DM6PR11MB3673.namprd11.prod.outlook.com ([fe80::59b5:5701:236b:9a88%3]) with mapi id 15.20.4844.016; Tue, 4 Jan 2022 08:35:26 +0000 From: "Liu, KevinX" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Zhang, RobinX" , "Wang, Jie1X" , "Yang, SteveX" Subject: RE: [PATCH] net/ice: fix error forwarding IPv6 VXLAN packet Thread-Topic: [PATCH] net/ice: fix error forwarding IPv6 VXLAN packet Thread-Index: AQHX7Bq8dZtWN0Q9ZkqkdvIR295OxaxPkisAgAMelnA= Date: Tue, 4 Jan 2022 08:35:25 +0000 Message-ID: References: <20211208095626.85026-1-kevinx.liu@intel.com> <96854bbfaeaa44adab468f9e88af11fb@intel.com> In-Reply-To: <96854bbfaeaa44adab468f9e88af11fb@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e39b4581-3673-41aa-3967-08d9cf5d2843 x-ms-traffictypediagnostic: DM6PR11MB3756:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ld7q33BxwHXr+Y4RA3DVKkzp0yTuOGvecmWu8j+VRxotakXXq8V5gZ0Fs7UeauLD2nDxzQYGBHgSlUSsty0VRLaCiirohtrCuBTBCCfqP0J8bYcFqzp5gy5jqUPDSRU+sFPw+9uqPRI7jtzZrqvN38RIWsS+5m8uEXnd91BYA51IdFow4chS3ExQUaKU8ziILsQa/7IsGO9zaVkEKA2TJmqrutkKqfHDVyAWcZQSDnUwjnsFhfX0Lv838TNjc1etjA8J715HaPdKRhq+Q+44IQpXFMp26YEXnY33Vs9jyqSc03NiaZWb+jZ5RjWbFq1b/sq+MQJrY8Ik6hfbaC2mWMIcN4gqTKq/itvz4ohn0FJ/ZhKwv8bi55vwzAyYZ3AYjugpFM0CXrIUHqJXpN3SzzqdXwvIf0mcXfcD7/SYLOk2zzPRLvpN+pf+pzhcksBzkciRXIhMDyGuSSdG2KVhuER5ny6S/wYuVCu/SUPG2h0K9z1cjGXFz/Kiq1o/Qx/rhxt6/WA3aM3Xxy3Cw5T42xhvslk8Jx1WqMUsWf1nJQ5sBtBZuxVUcY0CBdKIfVznvcMMtHxgZ6bQYm+Na+felmekbHhMx3M5Gety/by9QVa00PBqnrVfKYujb1AuvsSDd6yArGQIoZHndA+jc7zNhngPzBcKEtbhewaO2qMTYj1eAGcKVZFjtZv39Wtn3Vf8qE+UHD5ZrwRxQM6TRdDxAw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3673.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8676002)(86362001)(9686003)(6506007)(2906002)(316002)(508600001)(53546011)(82960400001)(7696005)(55016003)(38100700002)(186003)(122000001)(76116006)(83380400001)(52536014)(8936002)(71200400001)(26005)(66446008)(66556008)(64756008)(66476007)(110136005)(66946007)(38070700005)(54906003)(33656002)(4326008)(107886003)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?VS92TGhXbXlaTmNlSjBqVUpPRnlvdDN2bHZTNGZSQmNLN2FxYmxZNUQy?= =?iso-2022-jp?B?YUJqRm5HNUNiYVhzRHJuYWFITlpWVEt4ejd3ZUZCdmorYlRqeWc1MG5O?= =?iso-2022-jp?B?alAvSDl3UUsvZW5jSXo3UTVDem1RdmY2YVFtc2p0OG9PeFc3NmRXQXA2?= =?iso-2022-jp?B?eXBtT1dqcnh5WVJxMG1UQXB4Skp3UEVJbmdBdGtLUmYxK1owbmllSkNs?= =?iso-2022-jp?B?RnU2ZlA2OS8zRHJzZk9xNGFFUExGQ1V1YVQ2bENSdHBrRFFRLzMyOVlB?= =?iso-2022-jp?B?aVR5SVV0KzFHdmpSUFprU05UU0tQaWZIeDJ1TWJveW5icnFVbytEL3VV?= =?iso-2022-jp?B?aS9BbTFoVU81MExSQWlNK2xvcEViNE5VZjNDcld0L1l1Qm5DOUhPaFAx?= =?iso-2022-jp?B?V3NLYkN6bW1jMFNCVU9NTUY3OUErM05Oa0t6TkZwTEJNMGRsOFNpeVFU?= =?iso-2022-jp?B?TW0zYzFEc2FleEFBZWN4b0daSit2KzVQVXhRak5mZklmTUVJVFUrckM5?= =?iso-2022-jp?B?ajJudmZNQ1lBampYc2UvRlYydVZ4MWRDckpqSFRzcFk3ZzBoWENLZExZ?= =?iso-2022-jp?B?cjJWdkdwVVhyemhpR1pLZXM1TjdKUzlQcW5ySzkvZGJtbzNSOW9yMEdY?= =?iso-2022-jp?B?V2ZMSURqRkVaclUxMWVvbjB0SXhsVnY3Y0JiaG5jS0FGL083ZmlSSlNF?= =?iso-2022-jp?B?azZEc053QmYwWHFhSUNpVlhhd3o4bU5ESEVSTDRCVThqbElrMWRVaEVp?= =?iso-2022-jp?B?eGlPY2xFV3BRd0J5K2hULzVYSnIxMlhiQ2syNVNqb1kyaUtLUERTY29m?= =?iso-2022-jp?B?enZvaGNiS0dPS25mZURnSzRTOWlaRnN6TVhMS1Q5NER5Ym9YQWhVRjdv?= =?iso-2022-jp?B?eUJJdjQvWmxQdlllRmM1WkxUd09mOWo0ak5Ba1hoU1ZNV3BBWlFyaE5Z?= =?iso-2022-jp?B?UFZPZjhSaEdTalNickZpQ3pUeDdqd0h4SkUyU3p5dW9UaXZUamV3L0pL?= =?iso-2022-jp?B?UnJIUTRlbVBYajhlcUhlVUlsNU9LQzBaVERiVk1raW1BMUErcXhnc2JW?= =?iso-2022-jp?B?SEQrRGtsVjUyMWlyWGhRRHdRME1MZyswYzFyeXJRcmFMUDlHTXZGNGFR?= =?iso-2022-jp?B?ZmQzSjNieEViclZzcXJxT2U2NXY1ZmpJVk9NZGl0a2tQbmllVVdHYi9S?= =?iso-2022-jp?B?R0JsT29mU3N0RzFMbXFBR09aT3hsVzh2TkxhVHI3WTQ3SHZ5dng5L0Va?= =?iso-2022-jp?B?Rm5hSFVWSEh2MGlIWGkvQitxV2ZYc1lVa0l3Tk9maW5NcTdUWUpwaGQz?= =?iso-2022-jp?B?TTlzMzVUTEp5eEFpUXBOdGJObUlQell6dWxRTWZDS1llU2RSRFhqRHRL?= =?iso-2022-jp?B?QUxLQ05WVmFLSXRYc1JzM2gwdnd3ZldzV3lINFBiRncrZWIwclVGSE1j?= =?iso-2022-jp?B?aDloOXExZWNmdzVvQWhOdjZVYjJId0VNSy80cUNWeVhINk1ZZ0Z5SUVv?= =?iso-2022-jp?B?bW5iNFZIY1JvSmRqclg1T2pUN3kzSjlsRGZkTkFrbjNlQkxhdURzOFZD?= =?iso-2022-jp?B?MG1MYW5rK3hjMU95UEVGQ2NUYmxDRHVidFZQYWF4eHlYc0E5aFJ4U1ZB?= =?iso-2022-jp?B?eW9rNTAreWFWQlM0V1NnVzVmQkhud09JMUxTYXREOFVzQ2JuU1c1OG1x?= =?iso-2022-jp?B?UThrMmVGdXM0RThqMzBzOU9mcWNtbFlTbzdZbWlNaC9wNm00L3FKYWhF?= =?iso-2022-jp?B?UERpRk1FZUJTTWRYQnZlM2l2blBJOFpaY2N4ZGZ3aFFtbzM3WWRFNEtN?= =?iso-2022-jp?B?SXM3Z0VodXFjUURHeC93S0ZwTDdyQ1RkWit6UlFFQmlZbTB6TUpsSXVa?= =?iso-2022-jp?B?Nzg5eWVaV002S2hjSHo5Y3pVLzZCeXZwdEUxblpiNnl3QkZJQXdPWGl6?= =?iso-2022-jp?B?WGpudUZDRWEyUUVFc3oxVjVhQzY5bGN4aGxHNy83QjBBLytMQ0JoZlJZ?= =?iso-2022-jp?B?ZDBXQWpWY3dnNzYyZVpkVkt2dDhKSzJOdmcwNHd0cnNoSEpENkR0MTNz?= =?iso-2022-jp?B?d1RGRVh0YjVhMUFDMDhTZXVmalRkUVZzRnRsTVR3ajFtaytBa29zaTg4?= =?iso-2022-jp?B?QmwxemFFOFJ3bDU3azYwVEJuK0RXTkpJSVpDRnR4ZnVkaW5DVTNCUzRN?= =?iso-2022-jp?B?amxxTzEzMWlWOUhRaHlJUDBjRVc0T0pZb3RRaGFIWjY3THFMNVdOb0RF?= =?iso-2022-jp?B?aG9EbWt6ejJqZkJPZDVWUmVpdGJ6WFVQbFNxYStkTDBHNE1lOGdrb2RP?= =?iso-2022-jp?B?QVhET0g2SGMzeWhlaFBMVzVPSU9iMjNjdkE9PQ==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3673.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e39b4581-3673-41aa-3967-08d9cf5d2843 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2022 08:35:25.9976 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /Tv4oTI0NYGI0MVQWTERGSqZI8NKQ7rXx6TCS4s+YU0E56Y7E1I7weQkYD9+tvk0PUV55Y5FkL2+q9Lulc1gWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3756 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Zhang, Qi Z > Sent: 2022=1B$BG/=1B(B1=1B$B7n=1B(B2=1B$BF|=1B(B 16:46 > To: Liu, KevinX ; dev@dpdk.org > Cc: Zhang, RobinX ; Wang, Jie1X > ; Liu, KevinX > Subject: RE: [PATCH] net/ice: fix error forwarding IPv6 VXLAN packet >=20 >=20 >=20 > > -----Original Message----- > > From: Kevin Liu > > Sent: Wednesday, December 8, 2021 5:56 PM > > To: dev@dpdk.org > > Cc: Zhang, RobinX ; Wang, Jie1X > > ; Liu, KevinX > > Subject: [PATCH] net/ice: fix error forwarding IPv6 VXLAN packet > > > > In ice_txd_enable_offload(), when set tunnel packet Tx checksum > > offload enable, td_offset should be set with outer l2/l3 len instead of= inner > l2/l3 len. > > > > This patch fix the bug that the checksum engine can forward tunnle pack= ets. >=20 > s/tunnle/tunnel >=20 > > > > Fixes: 28f9002ab67f ("net/ice: add Tx AVX512 offload path") > > > > Signed-off-by: Kevin Liu > > --- > > drivers/net/ice/ice_rxtx_vec_common.h | 52 > > +++++++++++++++++++-------- > > 1 file changed, 37 insertions(+), 15 deletions(-) > > > > diff --git a/drivers/net/ice/ice_rxtx_vec_common.h > > b/drivers/net/ice/ice_rxtx_vec_common.h > > index dfe60c81d9..8ff01046e1 100644 > > --- a/drivers/net/ice/ice_rxtx_vec_common.h > > +++ b/drivers/net/ice/ice_rxtx_vec_common.h > > @@ -364,23 +364,45 @@ ice_txd_enable_offload(struct rte_mbuf *tx_pkt, > > uint32_t td_offset =3D 0; > > > > /* Tx Checksum Offload */ > > -/* SET MACLEN */ > > -td_offset |=3D (tx_pkt->l2_len >> 1) << > > +/*Tunnel package usage outer len enable L2/L3 checksum offload*/ if > > +(ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) { > > +/* SET MACLEN */ > > +td_offset |=3D (tx_pkt->outer_l2_len >> 1) << > > ICE_TX_DESC_LEN_MACLEN_S; > > > > -/* Enable L3 checksum offload */ > > -if (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) { -td_cmd |=3D > > ICE_TX_DESC_CMD_IIPT_IPV4_CSUM; -td_offset |=3D (tx_pkt->l3_len >> 2) > << > > -ICE_TX_DESC_LEN_IPLEN_S; -} else if (ol_flags & RTE_MBUF_F_TX_IPV4) { > > -td_cmd |=3D ICE_TX_DESC_CMD_IIPT_IPV4; -td_offset |=3D (tx_pkt->l3_len= >> > > 2) << -ICE_TX_DESC_LEN_IPLEN_S; -} else if (ol_flags & > > RTE_MBUF_F_TX_IPV6) { -td_cmd |=3D ICE_TX_DESC_CMD_IIPT_IPV6; - > td_offset > > |=3D (tx_pkt->l3_len >> 2) << -ICE_TX_DESC_LEN_IPLEN_S; > > +/* Enable L3 checksum offload */ > > +if (ol_flags & RTE_MBUF_F_TX_IP_CKSUM) { td_cmd |=3D > > +ICE_TX_DESC_CMD_IIPT_IPV4_CSUM; td_offset |=3D (tx_pkt- > >outer_l3_len >> > > +2) << ICE_TX_DESC_LEN_IPLEN_S; >=20 > Is this fix also cover IPv4 Tx checksum offload? Yes, cover it. > Please refine the title to reflect what exactly the patch does if necessa= ry. >=20 > Btw, could you also check if any fix needed in ice_txd_enable_checksum? > I saw inconsistent offset configure on l3_len between scaler path and vec= tor > path. > Its better to always keep them identical. >=20 >=20 I checked code in ice_txd_enable_checksum, and it should also be fixed here= . I will send a new patch of v2. Thanks Kevin