From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A207A0540; Thu, 7 Jul 2022 08:59:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A23240A7F; Thu, 7 Jul 2022 08:59:14 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id DABE4406B4 for ; Thu, 7 Jul 2022 08:59:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657177153; x=1688713153; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gcXURfgB3UFosv+Z7COumGlVbiCJ2Bn1mN5cXI2ooVw=; b=Z8rXaLkOS/iYWx+G/JhuBqq6kaYyP7Wt2OpJSJZ57s7xocZ441a0s51r HLu4TwUKcSNRxhm2R1lSYppUqhYEp6yZBBbG9sh9OfK7mjvhRy02ckRYp VlTswsAMo20ROz3f9Sy/vJVf7F6tpCOjrGc9BzpYNjU6mYiM0sl/iFyGp YHBzeDB8Pex/XVOvmcT531DopU28TXlgjxnry2BBzqSTWcXZ0YlHqsU+a wiFSqZ8joCeatqTK3jSp6AAhuAiPGkaYw8IFKfJvmVuC6PQXVLuA8X5o+ Ag22vS3JOjf1tH8pCYi9HoCAJVoELiyJzQ/LwVDDNWxl33cTYlPGOgWXq g==; X-IronPort-AV: E=McAfee;i="6400,9594,10400"; a="266977580" X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="266977580" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2022 23:59:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,252,1650956400"; d="scan'208";a="839812619" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga006.fm.intel.com with ESMTP; 06 Jul 2022 23:59:11 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 6 Jul 2022 23:59:11 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 6 Jul 2022 23:59:11 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 6 Jul 2022 23:59:11 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 6 Jul 2022 23:59:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iPhMuCeZ0X/y6wQPCHQjsB0xN3ySb99YfPwFwZO7sJ5NDkgrAeewizsl85Ik+Wt/p3OSU8uxWS/Qa6UVwvPoOGScSc4lSjnOZn2x+7cFnpIUV/l4tPIYHtSpVhvGCEtVF8vHEtWCc+qU6PklIpYs9kbW5FFu4hAmYISORVn5R9ZU44+v/549EWQa9HQsC8Em9+NaOB24NulHh4LLDi244L7/6R4GrnMMND13LzyFcyZFUJAPz2FJosfqknRN1xY1isS4DQBc6T7KnAbXTwm3np0aot/yhIyU/BQQd+6q+fiwwAaNqE2m1re2N9kzzCrmjZoJv56C8qqYv9o4JWnyFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=IRllAXECi1tijYD2Ai+w8HG7sx751X2uaoUPV/jYUJA=; b=ig0ovFSd+IKBv322N8cfD/jq7finsJn8oPYenkuAyOZOkcyuJJHpahMLWo73267D8CFZ6uw2kiSOOmq+bjXzhZD1D1wYMhAhdHSnNqiDfEM/jNUxQhMo7wIM1NvwJuR8G5jUtBZ6jO4jgdnWw7zdpDRdCpksZ6sNmeUUVv/KOCVbCpzpwAY+uiB71GF476mE7Lt+Ixo+VuJ1TieNI4YdteTzjFfmZP094C9jxhbSSwRisqmhZjxgx+EqKE9Z74GzPaJgaLkyaHMca7BvOHWbxqfGYh6dXK7e5rVqWXaKDxBFRq3ui+1zju+pKQxriJFd1J2YVRoNYPZLi9xzcQ9+AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3673.namprd11.prod.outlook.com (2603:10b6:5:145::26) by MN2PR11MB4174.namprd11.prod.outlook.com (2603:10b6:208:154::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 7 Jul 2022 06:59:09 +0000 Received: from DM6PR11MB3673.namprd11.prod.outlook.com ([fe80::451a:843b:9068:7b5]) by DM6PR11MB3673.namprd11.prod.outlook.com ([fe80::451a:843b:9068:7b5%4]) with mapi id 15.20.5395.022; Thu, 7 Jul 2022 06:59:08 +0000 From: "Liu, KevinX" To: "Yang, Qiming" , "dev@dpdk.org" CC: "Xing, Beilei" , "Zhang, Yuying" , "Yang, SteveX" Subject: RE: [PATCH] net/i40e: restore disable double VLAN by default Thread-Topic: [PATCH] net/i40e: restore disable double VLAN by default Thread-Index: AQHYkaw1N8ze3KqYFUyYb+2BbY3XMa1yeZKAgAAAz7A= Date: Thu, 7 Jul 2022 06:59:08 +0000 Message-ID: References: <20220707104732.1816933-1-kevinx.liu@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 21bce348-adde-4e66-0d4d-08da5fe63092 x-ms-traffictypediagnostic: MN2PR11MB4174:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: ZguCdTttzTchUxadfB5AB6616zTD6WVxhQ306egwAEDHFVpVfEeIpl+cL6Zufd6PGPwETAGGDlpS2o+Mlr9QsnNsw/oJHBqSs3R/H9d2dyiV/R7TLT+UgdUYEKCNCFW7Jt8C9Hg9BOc53SJRnk9co/ccIlzptTbWBDb3NPwDkJrSwCFMDkPabvH9jGTiO0CInVRo9i4uyt6pAR1jodnt0YndV9641fqsVLvg9lLcXXQdKFua8hJxoSB8TWlMOVHu+corPyc5E8C9ts467fwXwpJDVzBRAxvd3GYDJibpNqMmngoixdnFtjMlJaYN2QivmNb7VVMZColp//qhYth7xyqtiCWPT2WmsiuNdNkGyAHj49poDTfQxQjbamdNYLMU+7vXuJyQ6Ys/LutPNULdWoy37BPNwxz8C5Yu2484wpgwQoIXvgR9yupI7hkseYTqD+ziAGL7WgUt/P5/cWm8qcF0ux2Y07RM22Qqn74uyRiAyC1iYuCegvsSMZ21sBP/ycOVefuwjCCeHqTTcxEyraETz+xb0l1ROs6SIUn741ZHVUNnBPVsd8hEadH1oOI8Sx7bGdy4jXDCceDS1Zi2aLIvSsd9HTr+rb6FUAfPOaHoslINdHVt9cIvf0OPLMWZBwgCGbmMfZFUtPeBEWS7GeyJDIGk1PVvLC1CxEOybuuQn+SxMtv8wYAB+s408roA08Hw6buRWFIEvxjf6+Qmj68LYkb9JjBYu8ytK9g6+Ab9SKdiasTWeJtZPf3DlbRp1G6XFWWBIODC0a0mzrNJHOB/z1w6Hb+7VvHUgnqcWG1TVWS2Uqh5EStx/hpSEBBN x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3673.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(136003)(376002)(366004)(396003)(346002)(39860400002)(38070700005)(33656002)(41300700001)(186003)(122000001)(66556008)(7696005)(107886003)(6506007)(82960400001)(9686003)(2906002)(53546011)(83380400001)(26005)(110136005)(54906003)(478600001)(38100700002)(52536014)(8936002)(64756008)(4326008)(55016003)(66446008)(66476007)(66946007)(86362001)(8676002)(71200400001)(5660300002)(76116006)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-2022-jp?B?VUZCY1hRZDNTemtWTlMrdXljMVBXVXpJRS8xd1QwM3cxd0dDRElZTU84?= =?iso-2022-jp?B?K2h6UmZTNzYxcC9XY0s2RDhhOHdCRWZqSlM0ZXZ4OHZYRG9CVFhuS2hP?= =?iso-2022-jp?B?cmFNOUhXYTZNM3BKR2RnV0oxdGRTMGp3US82L3d1NStnN2ZhVkVjc011?= =?iso-2022-jp?B?T2o3QUt2aFdyVzNQK2o5R1U1NjBEVHVuRjMwYXR6Y3ZWalpEYitKQ2R0?= =?iso-2022-jp?B?VDljcjNCbUEzdHhNNEJCalVLUzRIR0FHdG1OdWl0RHhtaVpBY2pHQlFR?= =?iso-2022-jp?B?dGI2SGxGdGhPY3M3WHhlWWtXSGEwY1ljU1M0VFExaTFsVkU3akFKZ1g5?= =?iso-2022-jp?B?SzVjMUxZWmRWVThnK3JBM2ZLUm5JRGlMSE1NSGUzTVBqWlpRWGd3bWY5?= =?iso-2022-jp?B?WEtPa1RoM2g4V3hRbEpIWnpxQ1FXZ3VUUlk1UmlXZUNUNmVPdkErd3J4?= =?iso-2022-jp?B?Tmc0RnVnMmFPSnowQ2NHYXk2K0w3TmZhY1hoNWRwNjRhKzVVSWFmVEVa?= =?iso-2022-jp?B?TkJTNE9UWEpSb3pwUWZFMkh0eGJvVEQ4NzJEQlpuZ21EcjdkSkg2MVVU?= =?iso-2022-jp?B?elhnTm5QeWQ0bXl0azhKRGhBaHNrVVJTUUh4aGNLTTQ3MTBFU0hxclVn?= =?iso-2022-jp?B?alFSR3UxVkR2NlFqRFJveitnU1haL1dMSmt0Rkt6VVM4cFJ2dm9HSFpu?= =?iso-2022-jp?B?VW5nUHNvaGZlWWRabTRzK1A4d3JPSTR3WU1pUlVyOXNEdjBWeWZLK0tN?= =?iso-2022-jp?B?dFJQTnJ1YTVXeXkrUGZTZTdrNjlKQmFud0ZRS0tBTzB2MUJ0ak5aU1dM?= =?iso-2022-jp?B?VDVheGhUaDljLzkvRUtUM1F0TFh0YmZ3YkNyNkxacUk0ZXo5WmhpNnEw?= =?iso-2022-jp?B?YUJTNFJWZjVTVHZNSmJPV3B5ZkZJNmUrKzEvT1JhNW5tdTBIbUtRVWlI?= =?iso-2022-jp?B?elVlemQyTnZUdnE0SEpESWN6TXlJeEpYanQ3Z2Mvc1BQVktxOFFVVlpr?= =?iso-2022-jp?B?emljRWlrMit5UnJueEYxRDlSczNlSlZjUUJueU5YaXdtMnJSTkJReklT?= =?iso-2022-jp?B?a1VJdnpiVzZXbXp3NmxyZWIyTjQ3bTFDczVqdUptVWhUOENFVVNVU0t6?= =?iso-2022-jp?B?Zmx5NVcwaWtLOUE2S2Rac1g5TGN6UkdVRFlSYm1WeDlEYnJjZTI0RVV3?= =?iso-2022-jp?B?dXh2WDZ5NENnZ3Z3VjNhbkxDdW45QTlkY2FXREkxSHkyWXVZRjdWRlQ3?= =?iso-2022-jp?B?aXkzaVBqY2o4bVlIOHNQTC96UEs0WGxVSWlyc0FPL2dML2dleU1mNlBa?= =?iso-2022-jp?B?VElNRXZXZDdrakxSU2JocXJud3k4MEcwVTRYMjZiblNMU21OR1RnWXor?= =?iso-2022-jp?B?Y2o0cXIzcFJGampWU2FKK2ZYZ09NbTR1bEdmVm1WdFU4RUhVNFkySEMw?= =?iso-2022-jp?B?MFp6M0I4cG5uMGVVWWd5TXZoanRQS2xOTzg3MjFYa1lQZnpFS21iVUtx?= =?iso-2022-jp?B?Y1Zqek5JbmxVaVB4MU9EVUhDTTlHMFZzWXh1RkphQk5wZWlqWkx2cFZ0?= =?iso-2022-jp?B?a2w5aU1kcGQwK3ZVVkE1UXF4dXFCRFB6OWFxaFFzUzZ5M2t4WDJJaFEr?= =?iso-2022-jp?B?WEN2RlJtQis4V05IVWNBa3JldlRXT0tjVXovOGw2QWNlaFA5eE5LTzQx?= =?iso-2022-jp?B?cWZzT0FuTUVjbWFCMGh0Y0JtcHlhZmRhRk8wWi9GYUEvUkJhR1dnMHhD?= =?iso-2022-jp?B?ZHovZzNhdlhRWldtNjdncjM2aE1kMUdPSkREUCs2YS9TYnJ2RDVyQTAz?= =?iso-2022-jp?B?SGYySXcvWUxZV1FPeUNqei94NG91ZnVUUXhDeVVVZ21qR2xxS0JTbkZz?= =?iso-2022-jp?B?cE1LSDBkYTZpdldIdE9SamdOci9hRS9mUzd2RFMyMENiT1VYVDhqWHlu?= =?iso-2022-jp?B?WHVsRzNUNHlrMWQyNG84ZGE5SFN5ZlczanU5VVp5NSswTkxPUy83a1VW?= =?iso-2022-jp?B?RFU3cjdRQ2RSUnc3YXpCczZHS0Vxak8zc1R1ZlNySlJIUWRVeUtKalU0?= =?iso-2022-jp?B?N0xOU254R2R4MklKZ3pDakdWM1E1SThxb2huWm4rRHoyUmd5bFI5dVoy?= =?iso-2022-jp?B?WUtBWmk1MU9GS1dGYmFOOTJIcStLYm1IMVk1TzZtQ2phRCtTRnliM0tK?= =?iso-2022-jp?B?ckllZFp5MUtSMlJZTUtaM0xFM2hxWHFkblBTT2dicWJmekFnMHNoakgr?= =?iso-2022-jp?B?K1hDVjl3OWZtNldDUHgra090Yko0RFlGUUExQXpHRTdSSCt1RmU0ZlIz?= =?iso-2022-jp?B?YWNyTg==?= Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3673.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 21bce348-adde-4e66-0d4d-08da5fe63092 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jul 2022 06:59:08.8185 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MbsqoLr4+445z80pj3T2eXvUXCgS1/xWC/JREiKmZbDCgKjQFF30KXa3xpbY4AjFFpX5WC/bZqb9Z3Q7b5n+Mw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4174 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Ok, I'll tidy it up again. > -----Original Message----- > From: Yang, Qiming > Sent: 2022=1B$BG/=1B(B7=1B$B7n=1B(B7=1B$BF|=1B(B 14:55 > To: Liu, KevinX ; dev@dpdk.org > Cc: Xing, Beilei ; Zhang, Yuying > ; Yang, SteveX ; Liu, > KevinX > Subject: RE: [PATCH] net/i40e: restore disable double VLAN by default >=20 > Hi, >=20 > > -----Original Message----- > > From: Kevin Liu > > Sent: Thursday, July 7, 2022 18:48 > > To: dev@dpdk.org > > Cc: Xing, Beilei ; Zhang, Yuying > > ; Yang, SteveX ; Liu, > > KevinX > > Subject: [PATCH] net/i40e: restore disable double VLAN by default > > > > Restore disable double VLAN by default. >=20 > Please add detail reason, like will caused performance drop issue. > > > > Fixes: ae97b8b89826 ("net/i40e: fix error disable double VLAN") > > Signed-off-by: Kevin Liu > > --- > > doc/guides/nics/i40e.rst | 6 +++--- > > drivers/net/i40e/i40e_ethdev.c | 12 ------------ > > 2 files changed, 3 insertions(+), 15 deletions(-) > > > > diff --git a/doc/guides/nics/i40e.rst b/doc/guides/nics/i40e.rst index > > 85fdc4944d..f61c327726 100644 > > --- a/doc/guides/nics/i40e.rst > > +++ b/doc/guides/nics/i40e.rst > > @@ -969,10 +969,10 @@ it will fail and return the info "Conflict with > > the first rule's input set", which means the current rule's input set > > conflicts with the first rule's. > > Remove the first rule if want to change the input set of the PCTYPE. > > > > -Disable QinQ is not supported when FW >=3D 8.4 - > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > +To use VLAN functions, need to enable QinQ when FW >=3D 8.4 >=20 > Not only this issue, you should cover all the issue we know. >=20 > Vlan related feature miss when FW>=3D8.4 > ~~~~~~~~~~~~~ > If upgrade FW to version 8.4 and higher, some vlan related issue exist: > 1.vlan tci input set not work > 2.tpid set fail > 3.need enable qinq before use vlan filter 4.outer vlan strip fail >=20 > > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > -If upgrade FW to version 8.4 and higher, enable QinQ by default and > > disable QinQ is not supported. > > +If upgrade FW to version 8.4 and higher, when using VLAN functions, > > +need to > > enable QinQ. > > > > > > Example of getting best performance with l3fwd example diff --git > > a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c > > index > > 684e095026..117dd85c11 100644 > > --- a/drivers/net/i40e/i40e_ethdev.c > > +++ b/drivers/net/i40e/i40e_ethdev.c > > @@ -4027,12 +4027,6 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, > > int > > mask) > > } > > > > if (mask & RTE_ETH_VLAN_EXTEND_MASK) { > > - /* Double VLAN not allowed to be disabled.*/ > > - if (pf->fw8_3gt && !(rxmode->offloads & > > RTE_ETH_RX_OFFLOAD_VLAN_EXTEND)) { > > - PMD_DRV_LOG(WARNING, > > - "Disable double VLAN is not allowed after > > firmwarev8.3!"); > > - return 0; > > - } > > i =3D 0; > > num =3D vsi->mac_num; > > mac_filter =3D rte_zmalloc("mac_filter_info_data", > > @@ -6296,7 +6290,6 @@ int i40e_vsi_cfg_inner_vlan_stripping(struct > > i40e_vsi *vsi, bool on) static int i40e_dev_init_vlan(struct rte_eth_= dev > *dev) { > > - struct i40e_pf *pf =3D I40E_DEV_PRIVATE_TO_PF(dev->data- > > >dev_private); > > struct rte_eth_dev_data *data =3D dev->data; > > int ret; > > int mask =3D 0; > > @@ -6307,11 +6300,6 @@ i40e_dev_init_vlan(struct rte_eth_dev *dev) > > RTE_ETH_VLAN_FILTER_MASK | > > RTE_ETH_VLAN_EXTEND_MASK; > > > > - /* Double VLAN be enabled by default.*/ > > - if (pf->fw8_3gt) { > > - struct rte_eth_rxmode *rxmode =3D &dev->data- > > >dev_conf.rxmode; > > - rxmode->offloads |=3D RTE_ETH_RX_OFFLOAD_VLAN_EXTEND; > > - } > > ret =3D i40e_vlan_offload_set(dev, mask); > > if (ret) { > > PMD_DRV_LOG(INFO, "Failed to update vlan offload"); > > -- > > 2.34.1