From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88BC9A0547; Wed, 27 Oct 2021 03:58:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2855840E0F; Wed, 27 Oct 2021 03:58:27 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id C9944407FF for ; Wed, 27 Oct 2021 03:58:25 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="290891716" X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="290891716" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 18:58:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="635481720" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga001.fm.intel.com with ESMTP; 26 Oct 2021 18:58:24 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 18:58:24 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 26 Oct 2021 18:58:24 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 26 Oct 2021 18:58:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VqX28edFuSkKDeW9mQ1dQ7F2HMGBN5Jbg3Z2ZWzA28h2DUc722ol8ucltafBdf4SV1N+xvsJ3LUlVyVtMAy7egQttxxVNIpDHraXhatAOmvb3rjVdGmXA2iYviePYTGjp8ImGMChj6P/wc3lbYnD/4cLIHGZhEF5TGvByNIJz+DmyScXAqsyK6D6Ic+26j5HKIYmLD50HgoHgcfGM0/Bj+w2/+utSGVJp3JOKuGJwWpKdTYIY/E9oyHeILVBxUa76r7QlvNIX5S3Pxp2odxbty42UCjQ0NFYo1BubLKUOGpezXy5rZa31kKjEa45n/PgmIfGjR9a41vk2OeHWysCHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kFJ5siG8svrFnPJIdpSS8/sJeMkiKgqTOlgtEnFtz2s=; b=B2tdLFmVkniwJ+SX9A20pMKVpGEQmxohO7HdWWrHuaZBntx7PD9t6D4JRaj+0Cuv2jEa99NXxg74TSc+Js96x5POOvYxM3ckPmA584oBvyTuWehtyGyIvrcj5EXAXwCL92i0lIhj7jpyKMqOl1A6XAmPY7pWOTVtNG5CuulMCBsVoCdyVoQ7tpaqDk69xWADSnTVnIL2CrkG1vnY4mnzdEkcOjQCeZpNWtZ9MyLFkEI1Jt/RtRxmHjRE188JsVxtHIOzuOB/yKkofme+fSKQhUU7QC4RG31VMhxAKnyJnASaSTQGjrGllMBLhMDa6wbQsQKlSzQwycLyIvRmaLLeoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kFJ5siG8svrFnPJIdpSS8/sJeMkiKgqTOlgtEnFtz2s=; b=XdZGHdj2PK7gNsbY5PRWkGRBDiUKXwqrOT6PktuYxKTPkGuHFGh5UWFISbtIGKAlWq56R5FLcRxYEiCC0r2bA7oiVeFr2Fwd/qt7JgsdiPBkMAWwVOyRM8zVPA0M6CzrIvLLDPuSM928Pd5a70QPNtlW78M1P83rXhGNZwxhndo= Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25) by DM6PR11MB3545.namprd11.prod.outlook.com (2603:10b6:5:141::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 27 Oct 2021 01:58:19 +0000 Received: from DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::2129:bad3:5aa7:a751]) by DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::2129:bad3:5aa7:a751%4]) with mapi id 15.20.4628.020; Wed, 27 Oct 2021 01:58:19 +0000 From: "Guo, Junfeng" To: "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "Wang, Haiyue" , "Yan, Zhirun" Thread-Topic: [PATCH v4 2/4] net/ice/base: add function to set HW profile for raw flow Thread-Index: AQHXymFW0+1nkfyG80iv9SDH86n5t6vmBqWAgAAJimA= Date: Wed, 27 Oct 2021 01:58:19 +0000 Message-ID: References: <20211014153705.3301663-6-junfeng.guo@intel.com> <20211026120056.1442501-1-junfeng.guo@intel.com> <20211026120056.1442501-3-junfeng.guo@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d9d5756f-7137-4e04-d2e3-08d998ed400d x-ms-traffictypediagnostic: DM6PR11MB3545: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UGyxayRkLzJH7buJwUrLnHZefqwSwz9erjv2qTHYqojQS8G5AohbxJlkI3akhZvg51GsT4s1K3K/7Xd13VJHf0ScPi2eszo7Aan6nVG166aCfits1PSOrJrvGw8JWZb4wIwoAwXihPgeXCFYcZHFULZ67WcnC/+HetGQIP09Os5TycHYzDaYj4ZNMM0JX7HR2TJg1MTetQ0Q4Cq1I3zAEqO+IpoQ6W4IB1a1B+rpe5lT0kV981+5hO5DxlsHNW4NWrDCgOVvTKY1No1y50KDe2Mb2R1x4BrxxoQuftYI2yXrG9btPeZnqpN9MlopAOIVBTyikL0yylLZVAViFHuPpk0KAcuf+o8VeHhaHcu4jqALRRzD1K74e2Yp51RxiLfX19S8Jxwv/fA684Epc99+0t/zXm3MW1QEpANX+1EcHjPzfP1os+QwWrtML/qHM0K/ub3pgNA+oLWTXtemq6/vhJZDbAC6pt3TDW2YKXoKBT4O62p/C4umPOpxrNL9W2Lbu64B4HFegnR2ZNSKmToY7+fBshrjEacmzjsbZlW2py07zSGBQgw5dPAKJoadn4SKWRCLBJP6UgpzcbOnpc1KiUQJVk7oM9ZaOVV1Qx9Z4g+0FxNVWs00KKbGu3okXJ4ukMp/QxtRsXyex6jP35m8T6NqaPIyA3ljKkrfkdEUkqLJDh4CEHluk9JTHqU+DbrEIEEvBJwydI6Td6xpCFdIVQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(38100700002)(122000001)(53546011)(55016002)(6506007)(54906003)(110136005)(4326008)(7696005)(9686003)(71200400001)(52536014)(8676002)(186003)(38070700005)(66556008)(26005)(5660300002)(83380400001)(66446008)(6636002)(66946007)(64756008)(316002)(66476007)(76116006)(107886003)(86362001)(508600001)(2906002)(33656002)(82960400001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?a+HSrDmWjV+UO4syongt8rDPn01kZPlZIbnbosqyqCx7Z1X8ZEJkm7+7OU4A?= =?us-ascii?Q?ldyyQ8cPMBwRYdGGlsPeA+kcf9pqBDXHS5XGt7UHZqEM49UkUqbiqoslWgjq?= =?us-ascii?Q?1FRmnEIsC/cECjBZmg+WOXveqBv3txAB93CH7RKX5Z2/oe9hnUn58HPjq6DS?= =?us-ascii?Q?LO1kcKZhM/8E9/uRlotzZAAmwqJd6EmYLI/WsdSNoP2xMy9zTWdpfupCGpIQ?= =?us-ascii?Q?Pj33M/fFmKD7lOdAkkAjmIZHvQq7+lBiYDi6Oge5s5w9BtlE7hstH8USPMLQ?= =?us-ascii?Q?1jpJSJVXbxbqPAzK/e3qodCsZdZY0d6bEfyqD9UO0H3+VmAJ7ZeW8uLZ3aII?= =?us-ascii?Q?pN2fKvpLzev2k4VcyWOuvuOaq+qTwpWWYqi5C6peRIVZzGyTZ+2IUigGVO8M?= =?us-ascii?Q?Kp7DpFkYpcSmkbanAfs1MkWknRS4m2ztZF6S7pONVgOvrcQG1RwvdSK8eC3D?= =?us-ascii?Q?ykyshqtffaOARRlhLDAKfQpHDm05uONxvVnhsIFiyD6gctdxkrxbE6fmSXWI?= =?us-ascii?Q?eD0JvkZewpbRFd8d+mv2mziTV1+LDgVeomnM2c4kj7dWMlCQKmL/M0eMLTAj?= =?us-ascii?Q?Hthy6QKOlfYd2vV8YePCrY/3l+icksZsqS+gdvoyS+QsBkkXJnXmnxqTvMw/?= =?us-ascii?Q?GILf7VJq8o7JZSgbSxPDEcGzfeH3JIapkSaTM7v3rkgK3PXDzLR0o8BefkMJ?= =?us-ascii?Q?DBX0V5pLPInz8uk/Y0ivhUNNn0lO4pDSJtBJSIHFhQ2ODZG6AJV8vMZ0dC2g?= =?us-ascii?Q?JPgrHWgAajKsvl0gdspvRQm4WaenO+jc6UC90ahfyMZI7+9q2SEC6oUo7rn0?= =?us-ascii?Q?GnqdRCFRRjnCGmGNwA6ttGY3V/7u1e/PomRM1U2Pn2/SLT8dqdxk5Qa+Dr05?= =?us-ascii?Q?rEr1CqKqvhM54d1hpPPXcESAxvddn8jdxFHq1fJoXzuHwngxXzxuC5Esg2Yl?= =?us-ascii?Q?0AnBAhx1msbepF08KurxCurzei2aLVUyQM6DhIAyaXOUqUgIKkWA0JKUm2yP?= =?us-ascii?Q?NBwR7vGBmZqJbgXmpKQQKUubOYi1AgES8wFiQPMCAI4I8jiZkycilQNnRHVi?= =?us-ascii?Q?6BPNjdaBTiQ/cK6gl/jpqTaQesDRo4aiYM/dSPm3neL1ye5U5aOlhreAeTPo?= =?us-ascii?Q?tw3pgUGLQt4OYCvEfgyby6FdO//rANfFt6tXX//0HhaLZ80fkad2Q9emvOFv?= =?us-ascii?Q?DnoxosqsfgejprmWoUV8+rJr8ztNGDFgw+SaNddY1jPKzbXrDDbQaWSf6efX?= =?us-ascii?Q?jSkoj3qTNU74gkBjGc5mDKuPCmn7Cmzsdk7oHeXv2OJueShc05vbsBtehmMD?= =?us-ascii?Q?uJ6usy7pCaEYcXtKmT6AbZ4tI/9i78NTkPInqLZp/G504ZUgxazEzlYf5eKu?= =?us-ascii?Q?8VKDVsrD9+LSC8ZdO0iyNssgYP1N6mn+kEYvVj9LHfFuoRLAxbvrzJA7oFGK?= =?us-ascii?Q?ybQ0KX4Iw6aMDE/8XF/uPCVmpabeI2ozfpkDnvblxRGLYh7P+KHRcaWJ6181?= =?us-ascii?Q?2Z9VTFYmMWXBBSe1r/ujifPWq1TR5t9clkoWGHtd0Oaa22WwVF1pE+j5zfTg?= =?us-ascii?Q?Yn/7butWI6+wVcHLn2rZmSH4UUzgldOEG5sl3bVF2aL9NTDhcaCvHBobzZ10?= =?us-ascii?Q?D5ylN3eB4V0QQzugciB2wgg=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d9d5756f-7137-4e04-d2e3-08d998ed400d X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 01:58:19.8385 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: q0oYA0E3m0LHy7k3GTiYMTQMzGeWI1BGsGDPldSQp45SScr1PvrR8fvOB7kYUY4EE+ll92AN37REXX15NUuIow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3545 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 2/4] net/ice/base: add function to set HW profile for raw flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, October 27, 2021 08:58 > To: Guo, Junfeng ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; Yigit, Ferruh ; Wang, Haiyue > ; Yan, Zhirun > Subject: RE: [PATCH v4 2/4] net/ice/base: add function to set HW profile > for raw flow >=20 >=20 >=20 > > -----Original Message----- > > From: Guo, Junfeng > > Sent: Tuesday, October 26, 2021 8:01 PM > > To: Zhang, Qi Z ; Wu, Jingjing > ; > > Xing, Beilei > > Cc: dev@dpdk.org; Yigit, Ferruh ; Wang, > Haiyue > > ; Yan, Zhirun ; Guo, > Junfeng > > > > Subject: [PATCH v4 2/4] net/ice/base: add function to set HW profile fo= r > raw > > flow > > > > Based on the parser library, we can directly set HW profile and associa= te > the > > main/ctrl vsi. > > > > Signed-off-by: Junfeng Guo > > --- > > drivers/net/ice/base/ice_flex_pipe.c | 55 ++++++++++++++++++ > > drivers/net/ice/base/ice_flex_pipe.h | 4 ++ > > drivers/net/ice/base/ice_flow.c | 85 > ++++++++++++++++++++++++++++ > > drivers/net/ice/base/ice_flow.h | 4 ++ > > 4 files changed, 148 insertions(+) > > > > diff --git a/drivers/net/ice/base/ice_flex_pipe.c > > b/drivers/net/ice/base/ice_flex_pipe.c > > index 06a233990f..030655f3f0 100644 > > --- a/drivers/net/ice/base/ice_flex_pipe.c > > +++ b/drivers/net/ice/base/ice_flex_pipe.c > > @@ -6365,3 +6365,58 @@ ice_rem_prof_id_flow(struct ice_hw *hw, > enum > > ice_block blk, u16 vsi, u64 hdl) > > > > return status; > > } > > + > > +/** > > + * ice_flow_assoc_hw_prof - add profile id flow for main/ctrl VSI flow > > +entry > > + * @hw: pointer to the HW struct > > + * @blk: HW block > > + * @dest_vsi_handle: dest VSI handle > > + * @fdir_vsi_handle: fdir programming VSI handle > > + * @id: profile id (handle) > > + * @fv_found: found fv in fdir fv list > > + * > > + * Calling this function will update the hardware tables to enable the > > + * profile indicated by the ID parameter for the VSIs specified in the > > +VSI > > + * array. Once successfully called, the flow will be enabled. > > + */ > > +enum ice_status > > +ice_flow_assoc_hw_prof(struct ice_hw *hw, enum ice_block blk, > > + u16 dest_vsi_handle, u16 fdir_vsi_handle, int id, > > + bool fv_found) >=20 > Do we really need this fv_found parameter? The value of fv_found is set based on the maintained profile info list in t= he PMD. So we need this parameter to add profile id flow for FDIR in the shared cod= e. >=20 > If fv_found is true, seems nothing has been done in this function, why no= t > just check the flag outside the function? Yes, ice_add_prof_id_flow should be processed after ice_add_prof. It's ok if we just move the ice_add_prof_id_flow processing into func ice_f= low_set_hw_prof, and delete the func ice_flow_assoc_hw_prof to reduce the code size. For RSS, the ice_add_prof_id_flow for adding dest_vsi_handle should always = be processed. So this function has other RSS logic to add soon. >=20 >=20 >=20