From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB0A1A00C2; Tue, 27 Sep 2022 09:27:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D777A410D0; Tue, 27 Sep 2022 09:27:51 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 9947940696 for ; Tue, 27 Sep 2022 09:27:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1664263669; x=1695799669; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=MmxFQYZcNJfnxqdEh72moMWBbBrTzm2+uOdwthedzFw=; b=lF3gtYFPu2QdZCF/aPGdcbiyHkcHsyWHzad5XCsJbZ5v3FaAioV5rK8b KUerafnQX/aW0Bv6mmKK77DAnKB6XpXKdYtg+MSzvklIAqdnICjmZjcy/ wi2uFfmqsh2ugnR9ekklAAZSULY9GbsyLDFVvJSer4guVbiWRY6wh8IG2 REhU+sXamQnFr2b9BohMR27RIa6jTLLA3qq9Mu/jKq4527u8u3/fhirg4 hYwwFySOZJ8yJpWEyUjzMiUhtWJcJ+ZeaRfpEjqUy8gV939tb2JtcQ5wG hPKqfv6rc/ttErywq2xyOGohJSbePOFj2sz0Sb26KJHuXHKdhQ3MquiZA g==; X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="281615886" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="281615886" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Sep 2022 00:27:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10482"; a="616733638" X-IronPort-AV: E=Sophos;i="5.93,348,1654585200"; d="scan'208";a="616733638" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 27 Sep 2022 00:27:48 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 00:27:48 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 27 Sep 2022 00:27:47 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Tue, 27 Sep 2022 00:27:47 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.49) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Tue, 27 Sep 2022 00:27:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MEvv19oEzgFMA/zIwWH+FP9/Jwhq4TIDqcAsYNBGbaaqdcV6nOLZZaeh5lfTTGseEt+8UERR4KjDtVkU6/V2eaZ/lcNUFMAhlK5NXVkElfJOcteRPkW6x4UQi8RI8QbK+p80k9IFnFZLXrY45oWCME+X44tFl5kzlIlQiM6P6GabofeCmxDYLp3a33KVuDwUxatUGjhlWoCCR1OqNcqqTJCjt87Gb0BM9m0Vlu8Y68cijCnAecO2LeDyby4B/b9xfjKkcPsiYyyDAOKoS9+z3OU8KK9f5qehgBc9IfpYxMrA91lzuhnuc57vcDdhdNpnnp77jI1vCPqKD2813GMOUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MmxFQYZcNJfnxqdEh72moMWBbBrTzm2+uOdwthedzFw=; b=Zr6qWtSnylh5i04k6sk9hGmuPRQgLrr3RlBQP8SCw7uU0/NpLsMB2jwyGiZ5NPAFdFQpb1nFcD5D7/dX5HgN3mydM/v7ezCMEDU1tXvzy+LtegP9KHdSZZDp3J1vYTqBpC8m07eQkjoeqYXjCqHHSF8Wm5I6tlId1Q00TBEDNsiMy04ipFhXHuujU7aqncigGyHyS8L6+yQ+plGFs32/M1sW2HMXV4eiVROHGL8agTNit1CIfItT6vTMHnBrm7rkxrxZfKPsl1JIXputka9oO5xh0LX1JD9+7sLQpZ9wtk3MF9qelPu2gwU9syQGQEfEJf0NMKhFpjGLcqekhKJhBA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25) by PH7PR11MB6555.namprd11.prod.outlook.com (2603:10b6:510:1a9::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5654.26; Tue, 27 Sep 2022 07:27:46 +0000 Received: from DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::126d:f905:c1d6:dcb9]) by DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::126d:f905:c1d6:dcb9%5]) with mapi id 15.20.5654.026; Tue, 27 Sep 2022 07:27:45 +0000 From: "Guo, Junfeng" To: Stephen Hemminger CC: "Zhang, Qi Z" , "Wu, Jingjing" , "ferruh.yigit@xilinx.com" , "dev@dpdk.org" , "Li, Xiaoyun" , "awogbemila@google.com" , "Richardson, Bruce" , "Lin, Xueqin" , "Wang, Haiyue" Subject: RE: [PATCH v3 1/9] net/gve: introduce GVE PMD base code Thread-Topic: [PATCH v3 1/9] net/gve: introduce GVE PMD base code Thread-Index: AQHYzzBbNlOV+7lUekKW70N9QaFat63tXkmAgAWH00A= Date: Tue, 27 Sep 2022 07:27:45 +0000 Message-ID: References: <20220829084127.934183-11-junfeng.guo@intel.com> <20220923093829.3019525-1-junfeng.guo@intel.com> <20220923093829.3019525-2-junfeng.guo@intel.com> <20220923115731.1ef62488@hermes.local> In-Reply-To: <20220923115731.1ef62488@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3723:EE_|PH7PR11MB6555:EE_ x-ms-office365-filtering-correlation-id: 17f10241-8a8b-4bb5-9f52-08daa059c5be x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qefSMewdfC6pdK9qlpMYfcrfTi3PzzJwIOq6yXBZQO52oEB+GX6Q3g6Y0crQtezobXpcxzCS9dmGQbyhMe/5GzQv3EBWfme0lygs1v1MYxhQQZ4O4rtp7RP2D4bfDvkId2z2uRNPMqSPwH9RDKUsyO5WGw2qw1hGTVpjHRFnxviAjv8pVc5iL1azcousLV5X23V18D+STjvyvSFzuP2zhhnHKO8nn8bZ/9LJv8EM8Azl5MX4Iol8B9lGfWWwvD0eHcNpi+OJVGroEAh/eByZYhdHDJQVCQfmhawMjja8B2O8SARVCt0xVWym+lYMQyFeAsm7piux+e3gAv7fxk8mea1KqH0EQcsg5xegZoySogepYKtorXGle/bPieNwNb3eI4ToRFKYK0PGx/fI10cFfeBRrYc5/lptBLdKCwzyjpPeyKllOJehv01W3v84Jde8UUgmUM65fIMXLT4LjBHBQ+sgJnPn0cK7zFivPpruH4vZp+H4VsaeOiAJNTfSecDY9gWUdg+eHOgdWxs4TmHUmpFJnL2WEsClWwxcnQpjHiasjE6GMcOv4kROsha0E2+zDGESux1+Bd2COmXwejnPdKIxo/zoCIdGWKFQdVQQDfVOzoPKbIZasa4aCMHoLmA5OXkqrxbnICI3ZsNbDa6cR1ucZ6qb6y7yP2GjUNrTSeyhSnwXalSlQmqUIRfxVyiijAnlH6KzoBadn2Uz2N77BnYUeljgq/6YGvV5ff+glL6ejkMzTMtZtj8eYN7+mrFWeC96Qgfnc+TWZDqTtyhR4g== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(39860400002)(376002)(346002)(396003)(366004)(451199015)(33656002)(55016003)(71200400001)(478600001)(6506007)(7696005)(26005)(53546011)(9686003)(83380400001)(38070700005)(8936002)(52536014)(2906002)(4744005)(5660300002)(86362001)(54906003)(66476007)(6916009)(186003)(66556008)(66946007)(316002)(82960400001)(66446008)(76116006)(122000001)(107886003)(38100700002)(8676002)(64756008)(4326008)(41300700001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gYWwJqPebYn8+Be+r8fO78zA7QYkoaXHqwsw7TKHlGFuc0/59tNaEzkEnY1X?= =?us-ascii?Q?WZ6ccbUS0HgtFP3Zw9meJa4CqVAyNNMeiWfF6qKgRUmZNc0NWKa4+nfOUoTN?= =?us-ascii?Q?bp6LRxPBBbueAau+lARbV2P/Itwr7Pgk0KASxcNmbBSkUQgvbWEviMpR6d8c?= =?us-ascii?Q?DnwNvLYYb/L7lzTQESOtz5cCE6/wtNJ7Qc81H8vsQGLsiTKcTC22u9/TGYP9?= =?us-ascii?Q?sJrGwitxHs3VeFQv115iyuTe9ZQWGpNjmdqiw/Ydw8Bcguaq9coyRp50mEnC?= =?us-ascii?Q?fLI9aYLhPmtMbAZImrLz2LLvytZDpvhjII9Q5GYMNUlwmjIT0962hAw6CoFs?= =?us-ascii?Q?2V4GhN5gmcocO/vaEJhy3U0pBa0DqtE1z2cn+ydYhWOUg0PxtT/vxUyGS6HG?= =?us-ascii?Q?2zhy8yHycd2K80bYiHsYcrKuvNyCMw36XELvKaxRehYQGjRD9RJSMsauPAnh?= =?us-ascii?Q?r95/CoNWzCYlpobol2T9fzaZCGKzx48/fNY9A9SVecLHmM/PhJZ8yPNTxuMR?= =?us-ascii?Q?d1JYzxouYQ+pyxUXd87MpEFE9gRZUpLVIWvJK1vOd483jdVxjt7PfeAsF/GL?= =?us-ascii?Q?MTTIG0J2E+uuzurQUZG8aCphcNGg1GDd2KKz+zcoEfUeLs5lu0LMkkgMA72v?= =?us-ascii?Q?cRpOjvWeFXWEdQwULdz1J0Tts3yzZsYaUafvw6QQYCJHRE1FrwxcuCtiteqc?= =?us-ascii?Q?lMQR7/EDu8eX/EbNU85cwtGKV6CzGpdkznrtE1iiyWha0xMXDT4soGpf9QUF?= =?us-ascii?Q?CNPz24QyD+s5WHDCOOK4zzzCy3IcokzzUksN3lehCRUo0Ki/yUdpuBZ140ZI?= =?us-ascii?Q?/MWJjdnZMCQ936tBH9hJyB6fYmCvj1Vr8FYeZ4Fu5Lx1fU1ASFSwbaj9Vh1e?= =?us-ascii?Q?SrH9Mwy+45DjU4g6Goc0eHIWhFilew2IOeDcFhEriB+m2absF7xG4rC52CZM?= =?us-ascii?Q?KTZdOOq22AZOtE1T665ffWKZI/A8QIi0u/jwNo7TLLqvfmqEvpr+zPesbPAJ?= =?us-ascii?Q?9DqwVYzOqIftFLD1w2JEpMQu3za6zvksRPioPRAxAuK/qxZ40NVpBq8UpKQR?= =?us-ascii?Q?GznKXsWXhZQvL2Mcl1P2X3QQjDqEItrnqNoL4G5/tsJnhc4bGNHaMD/U/CsI?= =?us-ascii?Q?GuISWuFJUZ/JvEA4Ug6tRBpfWD1te/JOOA8zR0vMEnfwCExiQNDiTB+I7MmL?= =?us-ascii?Q?aSerfgSZmagRyv98ET4+mWeijPanaG37ex3djxyTSQoz7nmR+/L7enVbbxox?= =?us-ascii?Q?MiszEBvLXzden+MtnZX1hsH6ZMWwqL/Zk1uLP+/SWe7eBn4idSytATJk2aSO?= =?us-ascii?Q?zGvTifcGq3yVGoZJV2kGZ65uzW5nxMBvNakrS3FJrUq0ccGHMoBbAOnuZkWd?= =?us-ascii?Q?YsDCUPIP9uaiESID8/+pwAySfr9wedXlc5bYeU8qVBuLpC8KWZrxHQvaLVHK?= =?us-ascii?Q?PUK+8/CtGIyBGf8E/S8NeLAylwOI2R0mF+3WZe5Tovl/z3jsd7cDYN8iAvt3?= =?us-ascii?Q?yUUFX4YpkLrx96/cNVN6MKt1uX2IS/6zKOSpn92WhoVnurLKIFLE5QiUnDeH?= =?us-ascii?Q?+cusuhKZhrSHlUOz/dD2ROMHEELc9YABOup/L6m3?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17f10241-8a8b-4bb5-9f52-08daa059c5be X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2022 07:27:45.6171 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LVTL0Do4oFkxLsIzoepcj9q3gR4v013RlNG9TlxhxmTrzh4Go68twRmZ4DMwF1i7eXKFc/JT3VfhLB6/Q2Bmng== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6555 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Saturday, September 24, 2022 02:58 > To: Guo, Junfeng > Cc: Zhang, Qi Z ; Wu, Jingjing > ; ferruh.yigit@xilinx.com; dev@dpdk.org; Li, > Xiaoyun ; awogbemila@google.com; Richardson, > Bruce ; Lin, Xueqin ; > Wang, Haiyue > Subject: Re: [PATCH v3 1/9] net/gve: introduce GVE PMD base code >=20 > On Fri, 23 Sep 2022 17:38:21 +0800 > Junfeng Guo wrote: >=20 > > +#define GVE_DEVICE_OPTION_TOO_BIG_FMT "Length of %s option > larger than expected. Possible older version of guest driver." >=20 > Why do you need #define for this? This macro is used by gve kernel driver and we just keep it here. Thanks! >=20 > +#define GVE_DEVICE_OPTION_ERROR_FMT "%s option error:\n" \ > +"Expected: length=3D%d, feature_mask=3D%x.\n" \ > +"Actual: length=3D%d, feature_mask=3D%x." > + >=20 > Why such a wordy multi-line message, please use single line This one is also from gve kernel driver. Will update with single line message in the coming version. Thanks!