From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9874AA0547; Wed, 27 Oct 2021 04:51:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6814E40E0F; Wed, 27 Oct 2021 04:51:54 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 55BB540DDA for ; Wed, 27 Oct 2021 04:51:53 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10149"; a="253605579" X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="253605579" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2021 19:51:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,184,1631602800"; d="scan'208";a="724742447" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga005.fm.intel.com with ESMTP; 26 Oct 2021 19:51:52 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 26 Oct 2021 19:51:51 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 26 Oct 2021 19:51:51 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.104) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 26 Oct 2021 19:51:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kXCdXvL3ZNF6uyULkAiADFbY67/1CpbO2o2OXhKNWqo+82a6mTH80DAYZUeVnz3iCdaDRpMteUAcVgmtDBUPwvSw7s4rpMRuAtmSVBjZdFNMK330VV2jRKSvM/9oQjTFdyZTa4mB/jK0WV8Bj+hacwnixvbrjG5jonD+KoZPtMWxnbT/D+t/RpU8S0SEYxU/vlhHYWwGEYPiwZ2gpVgM5cmrijCH6V8df6D9hYqzAdzy6dYJx76RaVT1769Klf94YYdZT5V/KKA+HH+EdTlwCcbjH8g6vPQgOTtEorRwaQTV/7MzehLiT8ARMmbyB2ky3XqyiErJdWhg5N7o5WwwHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eQIX+jKUjtyGV97xHSvdIbLH0Km6QbdTrCIxLUo1Xsc=; b=S3x8QURZlw0UOD69CbnsXG5A8SVgKuEnJuT/ujIzPDVrZyjam/ZdicMXKCDIekwy1Yzi831KiQQkv/34dSEdp/X5eKO4Ha6fyIGR+hUcqzbF72Ch02AFMlNAiytmYceQCQaCY8G3wjni6MTwyzFBqfSrJb2q/CKmwunrtEX/tJfNeWf3wkeQMPIW/kSkTVZTW26OMtI9Sigb/coLGnrOLncapJyS4YdOavL6Fs7XvRE3ds3s00DoPbuYPLMiQtETESX4OEYXgKaPeIDkGdwa/7wdlAYJfY94GJAkkL7B8di1vSb5VLKzQnA4Y0rfaTz12/nOhCBcaUc0oUdFDLPFXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eQIX+jKUjtyGV97xHSvdIbLH0Km6QbdTrCIxLUo1Xsc=; b=vewb5lr7yic/TwwKZBUhjaWegWgQzGTFRRRmsny/gxjidenoQ/9S0vYSNwFJ76kQNoIDVGJfREuIQT1HLAx5mBGocJUMM3hfKdyPisDQpNBjmctcz5O2BvgD02JMpm47d5vKWM0ZfzhnYZHt6mU3s68srsVRBKeZc/69uJLHcgc= Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25) by DM6PR11MB3241.namprd11.prod.outlook.com (2603:10b6:5:58::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18; Wed, 27 Oct 2021 02:51:47 +0000 Received: from DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::2129:bad3:5aa7:a751]) by DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::2129:bad3:5aa7:a751%4]) with mapi id 15.20.4628.020; Wed, 27 Oct 2021 02:51:47 +0000 From: "Guo, Junfeng" To: "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" CC: "dev@dpdk.org" , "Yigit, Ferruh" , "Wang, Haiyue" , "Yan, Zhirun" Thread-Topic: [PATCH v4 2/4] net/ice/base: add function to set HW profile for raw flow Thread-Index: AQHXymFW0+1nkfyG80iv9SDH86n5t6vmBqWAgAAJimCAAAzCgIAACS1A Date: Wed, 27 Oct 2021 02:51:47 +0000 Message-ID: References: <20211014153705.3301663-6-junfeng.guo@intel.com> <20211026120056.1442501-1-junfeng.guo@intel.com> <20211026120056.1442501-3-junfeng.guo@intel.com> <805636af8f454523b64f456a8436c068@intel.com> In-Reply-To: <805636af8f454523b64f456a8436c068@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 353dd505-e842-466b-0309-08d998f4b81a x-ms-traffictypediagnostic: DM6PR11MB3241: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nLjEVQ5sw4bNyGubcRl04oRd/K9KVaACQPWiURqgFSOLcdxWI2OXhySt5a79fmBVHcgAWq9Y4sDx6jHiRrMdlWAPMK7ODE74rj88JbKHVHYkozUdHKCZQ4cZKnr8JnbOEn7yRE3LLBETMqUFM6LrcdiyJ5XNT/gZBGZrTFL6srVPPShv9gYPirA0uKmcFvglEbn73vqdCWJJAlKkelCtztQVReZMDaeIcOeIag19cSRowlR6grueldfzfVGSsg5ENeyhGTZar7LvyIuxhiMcxJcqkgJYM9j5H1mb08VooZ3md/BZJKoJBmWsenPy0sZ5+HJOi8rEusksmYCwlrkRoWv6lmKXAMrSx4+EqNkyM7vV/TfB8bUF8IzQwSLnNbDD0n74qLGM1ujEB236dM04MCHgRqmsjYjtglQx7WOoOXsjtG0SpFOY6KD9Vwh6xdRQB2K1Jbsh/sd4naWNHKSCJHFT/jcFLYMFbgl6qTrAt4s49QKC7LUYhkqjUf2Li6AhldQGPp9UenGjxw6/p5a3lcs7bJu147IARG0WpMgF+XjUWtQT4DI02dWuC5Fzz4iVAybpIvvhtiYHNrhZs5GePk69H+y1vUBg758DnPNB97whIikGCpQWc0r6LSSXmfFbeMj45nzLuPKpjlVaC9CjjBOBLx0gCYuO6fsnIY7d35SbT4HZ8sJXjTUpI683TEJT3sUOC4wrjgF3MIsAhBfSUw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(54906003)(26005)(110136005)(38100700002)(64756008)(8676002)(2906002)(4326008)(186003)(71200400001)(53546011)(82960400001)(52536014)(316002)(66446008)(7696005)(86362001)(6506007)(55016002)(9686003)(38070700005)(508600001)(83380400001)(5660300002)(6636002)(66556008)(107886003)(66476007)(66946007)(8936002)(76116006)(122000001)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?y+1Fjw1WhDVGXIjpzemwus/+vvMlUsoJycx0QCGo8MVQ811DaNwvrwxs5U63?= =?us-ascii?Q?Ln3+JB3oRWWOGsINCBIPqPSJ02XvE2lbz4tS8Yi+nDnlBUhpxzX7Zwv+crxn?= =?us-ascii?Q?oL90zG8OkyxfcJJp1lU1rGvNrwYasuZANchHnsshKlYBddBzMNNKnj1Y5suQ?= =?us-ascii?Q?35IB8BOfGN+j1iB3DGOjUew0lZ6xNc7XlJ3ujG6HfbhONlfAFPEqbcljUSVO?= =?us-ascii?Q?G2VuUlt7QayvRidSaGMr9o80aMQf5uuOv6m1HbWaEvXLpkYCiz+g2tVFdOL+?= =?us-ascii?Q?HIiQxdhsHjuv6ZkiCA18w0iakjTfGJ/pkBzhLi8LAeieCQ92ih0o89RZRLRA?= =?us-ascii?Q?mveyx8/3wAXIMSU0/sn/TQSKl7krSGNVoDv0xlI6BXuEcX3paSv2X4e1zibg?= =?us-ascii?Q?PR5KYkNJBw9BROkuRxeLcdEyDuotzi+3W102V0V93Q7aLHagoL5TBE8Q7x/U?= =?us-ascii?Q?8cBTVAPS1WpPGwxKv2QJv3+TojvMtZxRUU7JyhZvi40bAIP+dtMky9BpN2yQ?= =?us-ascii?Q?re9ZMwV+sEHay83+aavEpdyOFMbXT75kTGRkxsaF+G1wySeL14e8TwOI3Y3r?= =?us-ascii?Q?x4YnwRyCkCibYYoln6EC/q2VuSUv6DpNJ0Y1Y4JtccZ2ykG7v1Zf7tiuxHSo?= =?us-ascii?Q?aZWwx9mR8mG2nU30U3YG6n2Hzfpu3CKbeKFekBv8qPd29uUi5CBHfStI3WAO?= =?us-ascii?Q?TlatEJwfe4Xzq2fM/G+hNSUFe2lAnsz5BV+YaneQxFZNDppIzuvne8XPaxcd?= =?us-ascii?Q?z0ZQn1nUKWc6TSpFunQC9SBvO3ObwKwgfmw92+itmhcP8lPE6ouNg/zhMASC?= =?us-ascii?Q?G7QGSJv+nFl6zCbdFF3PzLkDbGD384sL3daFStieFsrKizA2Ujs/+ZGlycBI?= =?us-ascii?Q?KoLG5/z3bOI3/fkCdQrIqzsVeQw4xPGxkkyz6/8J1H9NNaE9CaEb+P1VXOl7?= =?us-ascii?Q?pYRgYl7/wuXIkn/qCeYmogVhWaWi0KgY01aezgD+ko04lqCsqRYxeZjCQPG9?= =?us-ascii?Q?1fBsi0BuE4qnIdWta+RGAd5PcLk1rKXKcUASKUgH+nNFnzsnK9IaobLNwQT6?= =?us-ascii?Q?rF9LC74WAqCiKIlnFr42AIm1UG5K7/pLXpltJscqceIzo0RkFc3vg5szcC7e?= =?us-ascii?Q?XLdlq1oUBg1EWXtiEUJkwxMqoWs1TD8HtObHDG/TklfOzYC76Y6VXh91vP+b?= =?us-ascii?Q?fW0EmG2GQsU142POfBcIgbhINwN8jaoBsK4eFUgZtOOmU82v288Ykd8JBj+W?= =?us-ascii?Q?6J0zzTuNod2/shD2fdjLv7nzgBlDknIDeo/skp7us+e33nzpR7QfGuLYJYLr?= =?us-ascii?Q?kjJpzAmZ3HEykwuNzl7HrxLNY/HlvqYIr2ek/CdkgXWXzfhnPDYCxNtd3rIY?= =?us-ascii?Q?dREAo7RBw8Tv+U4FoEJS9XOGhFaYkZKmrJWKxW+imfkVl0plUE72VDaK1DpH?= =?us-ascii?Q?UXFKX7G/1Yb+R6ZbnKwa1WzuZUkwHaKrZxH526srdD3B4WRk16MZkn2xr+o1?= =?us-ascii?Q?1GYA292ksmbPfcz0ZRFad42jSPRXR5w2ryprV44RnqCYL0Xvhk8GgsnsqQUN?= =?us-ascii?Q?LNGgKR/jgwkN7Th/+RaTkmi26n43On6F29FZiWM8pkv4YSrnmy97XB3HfmYF?= =?us-ascii?Q?oFjM9Nu24rBZ5ikhlEv+IFU=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 353dd505-e842-466b-0309-08d998f4b81a X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Oct 2021 02:51:47.6251 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rOdzMRdKiiwa4v92KFQ5G3HL3q8ax9WyMNCEJH2Ae4QkotHYnEnw0ob6Koan7G+JGxSRzJkN0hUaeCvAPwb1Lw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3241 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4 2/4] net/ice/base: add function to set HW profile for raw flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, October 27, 2021 10:18 > To: Guo, Junfeng ; Wu, Jingjing > ; Xing, Beilei > Cc: dev@dpdk.org; Yigit, Ferruh ; Wang, Haiyue > ; Yan, Zhirun > Subject: RE: [PATCH v4 2/4] net/ice/base: add function to set HW profile > for raw flow >=20 >=20 >=20 > > -----Original Message----- > > From: Guo, Junfeng > > Sent: Wednesday, October 27, 2021 9:58 AM > > To: Zhang, Qi Z ; Wu, Jingjing > ; > > Xing, Beilei > > Cc: dev@dpdk.org; Yigit, Ferruh ; Wang, > Haiyue > > ; Yan, Zhirun > > Subject: RE: [PATCH v4 2/4] net/ice/base: add function to set HW > profile for > > raw flow > > > > > > > > > -----Original Message----- > > > From: Zhang, Qi Z > > > Sent: Wednesday, October 27, 2021 08:58 > > > To: Guo, Junfeng ; Wu, Jingjing > > > ; Xing, Beilei > > > Cc: dev@dpdk.org; Yigit, Ferruh ; Wang, > Haiyue > > > ; Yan, Zhirun > > > Subject: RE: [PATCH v4 2/4] net/ice/base: add function to set HW > > > profile for raw flow > > > > > > > > > > > > > -----Original Message----- > > > > From: Guo, Junfeng > > > > Sent: Tuesday, October 26, 2021 8:01 PM > > > > To: Zhang, Qi Z ; Wu, Jingjing > > > ; > > > > Xing, Beilei > > > > Cc: dev@dpdk.org; Yigit, Ferruh ; Wang, > > > Haiyue > > > > ; Yan, Zhirun ; > Guo, > > > Junfeng > > > > > > > > Subject: [PATCH v4 2/4] net/ice/base: add function to set HW profil= e > > > > for > > > raw > > > > flow > > > > > > > > Based on the parser library, we can directly set HW profile and > > > > associate > > > the > > > > main/ctrl vsi. > > > > > > > > Signed-off-by: Junfeng Guo > > > > --- > > > > drivers/net/ice/base/ice_flex_pipe.c | 55 ++++++++++++++++++ > > > > drivers/net/ice/base/ice_flex_pipe.h | 4 ++ > > > > drivers/net/ice/base/ice_flow.c | 85 > > > ++++++++++++++++++++++++++++ > > > > drivers/net/ice/base/ice_flow.h | 4 ++ > > > > 4 files changed, 148 insertions(+) > > > > > > > > diff --git a/drivers/net/ice/base/ice_flex_pipe.c > > > > b/drivers/net/ice/base/ice_flex_pipe.c > > > > index 06a233990f..030655f3f0 100644 > > > > --- a/drivers/net/ice/base/ice_flex_pipe.c > > > > +++ b/drivers/net/ice/base/ice_flex_pipe.c > > > > @@ -6365,3 +6365,58 @@ ice_rem_prof_id_flow(struct ice_hw > *hw, > > > enum > > > > ice_block blk, u16 vsi, u64 hdl) > > > > > > > > return status; > > > > } > > > > + > > > > +/** > > > > + * ice_flow_assoc_hw_prof - add profile id flow for main/ctrl VSI > > > > +flow entry > > > > + * @hw: pointer to the HW struct > > > > + * @blk: HW block > > > > + * @dest_vsi_handle: dest VSI handle > > > > + * @fdir_vsi_handle: fdir programming VSI handle > > > > + * @id: profile id (handle) > > > > + * @fv_found: found fv in fdir fv list > > > > + * > > > > + * Calling this function will update the hardware tables to enable > > > > +the > > > > + * profile indicated by the ID parameter for the VSIs specified in > > > > +the VSI > > > > + * array. Once successfully called, the flow will be enabled. > > > > + */ > > > > +enum ice_status > > > > +ice_flow_assoc_hw_prof(struct ice_hw *hw, enum ice_block blk, > > > > + u16 dest_vsi_handle, u16 fdir_vsi_handle, int id, > > > > + bool fv_found) > > > > > > Do we really need this fv_found parameter? > > > > The value of fv_found is set based on the maintained profile info list = in > the PMD. > > So we need this parameter to add profile id flow for FDIR in the shared > code. >=20 > I mean if we parse fv_found =3D true into ice_flow_assoc_hw_prof, nothing > will happen, > So why not just remove the parameter and we can do below >=20 > If (!fv_found) > ice_flow_assoc_hw_prof(...) >=20 > its always better to reduce unnecessary context for simple purpose in a > function. Sure, updated in the coming patch set. Thanks! >=20 > > > > > > > > If fv_found is true, seems nothing has been done in this function, wh= y > > > not just check the flag outside the function? > > > > Yes, ice_add_prof_id_flow should be processed after ice_add_prof. > > It's ok if we just move the ice_add_prof_id_flow processing into func > > ice_flow_set_hw_prof, and delete the func ice_flow_assoc_hw_prof to > reduce > > the code size. > > > > For RSS, the ice_add_prof_id_flow for adding dest_vsi_handle should > always be > > processed. > > So this function has other RSS logic to add soon. > > > > > > > > > > > > > >=20