From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE828A0093; Tue, 29 Nov 2022 02:42:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63FD54021E; Tue, 29 Nov 2022 02:42:35 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id D727540042 for ; Tue, 29 Nov 2022 02:42:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669686154; x=1701222154; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=V9zPCtfhT68Tp/VhWln5I+QTabnGPVBAiBBV59JotXw=; b=ghv68GGmCJppI0WrBTqsB0Jsvi17B18VErGOZ4UVPQeETv9YwshWqgFD ME9QFxzghAHbb5fYZUnCXV0X+ePzeiUhrkISwSb/bUuIeiq+GOirESJDs NP0Eu/U/cfyMDfa2LpQtxQYq7n44gbXk4NOfPhdju/ePGCIO8mjE/60yO eZTrlxaZjMakS8Wvs1zrUMKQh0BRJZNe2EspoNFo0iuonFZ2EJEBK4ZWm kDCBR8zAg0WiYlRom3QfxMg0JTSfSEhpG19hcIEyqoEGB1GvQiuW4PCVZ +XyUt0wCMZG8QGcqwVxzljhP+yggGx4ymfm8Ipg8bEeQySUBAMbMZyPYl g==; X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="302583550" X-IronPort-AV: E=Sophos;i="5.96,201,1665471600"; d="scan'208";a="302583550" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2022 17:42:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10545"; a="594083896" X-IronPort-AV: E=Sophos;i="5.96,201,1665471600"; d="scan'208";a="594083896" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 28 Nov 2022 17:42:32 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 28 Nov 2022 17:42:31 -0800 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 28 Nov 2022 17:42:31 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 28 Nov 2022 17:42:31 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 28 Nov 2022 17:42:31 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZgYiPkYxFNWNCB8tUVyyCBFhfdKfEJwo/IS5ZXWINlc7S3555yUJXgItHn4nAexXpHlHg7qnO4eoiIW5qmPU5d11zgG7oaLFr1z3BeJHiHQDe0FBT7ZO16i1eKlIZIkx5QyASiQ/P7TySSB+KdydAbzzKuXRTrgqgLL8toEzaTdRXUR1aWHKn66XGrYyM3Xl10rdvL0/jkbi0AboysbGF1OhHWVkA/0O+LcRLa2nCreEZ2Tfa5+Ocr9i55U2fIXciXPqQBgRBCdf/lt3L4zx+3VKZjdtmuIeV08VNjYI3OtwQBB9/T7qA0afQ83xUx3fwwyX85jnjQHzzgdtXIVKJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pi90q9ICn/X/Tqv0CNw35+19dMndrdqpPzrBkHNPqrg=; b=WKZ5U99eNCRVLR8kiX4yhKPUGeIURAR9oTq4V4pTrFdd706aziHB+G4E/7tW+CgSI0l1MEP9nwERCFbklty7PT7XJV9I6/C06Bcwb1WRbY95AGE+mICz3A4EgwToA6+ozmYg+rJtEyVMotrWWCcFdhkDj+EUfNQsmGXx8f96hzNI2etOTq5JhGtkUlNdeonYbTvH4j6M4+rtLuUI9Tjl3jHdLddncc3AUu24YuVoieO+NPJaKQhxTUCpngB4/mK3NwxQXVOlCRovhf8vPRtgOwcaZLkZRlxM0iAIUUXa48uTyZEE04FLeZn6XZIqnxiwe5nNMFetkuS6ggkM4pEU5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3723.namprd11.prod.outlook.com (2603:10b6:5:13f::25) by SJ0PR11MB6814.namprd11.prod.outlook.com (2603:10b6:a03:483::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.23; Tue, 29 Nov 2022 01:42:29 +0000 Received: from DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::5e14:f8ea:d14:4708]) by DM6PR11MB3723.namprd11.prod.outlook.com ([fe80::5e14:f8ea:d14:4708%4]) with mapi id 15.20.5857.023; Tue, 29 Nov 2022 01:42:29 +0000 From: "Guo, Junfeng" To: Stephen Hemminger , Ferruh Yigit CC: Rushil Gupta , "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" , "dev@dpdk.org" , "jeroendb@google.com" , "jrkim@google.com" , "Li, Xiaoyun" Subject: RE: [PATCH] net/gve: add support for basic stats Thread-Topic: [PATCH] net/gve: add support for basic stats Thread-Index: AQHY/9d8MwgJvnCNPkKj+a7vLeqVaK5OTIgAgAAHboCAAjcrAIAA7+GAgAK59ACAAGfbAIAAiGEg Date: Tue, 29 Nov 2022 01:42:29 +0000 Message-ID: References: <20221124073335.3985214-1-junfeng.guo@intel.com> <20221124085926.46430390@hermes.local> <12af66b4-0715-a0f0-a401-664632189e80@amd.com> <20221126093433.7b3b5078@hermes.local> <38d43919-f060-4ccc-67e6-180957015dc5@amd.com> <20221128092420.311409ad@hermes.local> In-Reply-To: <20221128092420.311409ad@hermes.local> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3723:EE_|SJ0PR11MB6814:EE_ x-ms-office365-filtering-correlation-id: 620a78c9-be56-44a7-4bd3-08dad1aaf9e4 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vV5PlxauVryuoVI814W5fA5Mr3pFG2/6YCSh48g+Lpfgb7bWaFTQNN/kdRXKc/AcEseTaz6a/KXP9lRVPRSbpPWetouYWLDDFmwKkIvnAT3K1CZJTve8cwNxJQfWEYc8WNUkQ8u7x4phRO/pwrMGQ13cUdlze92FJCX/lYSpASiWdQO/TyRVssIicCUvbgIftpz5Fmd1nXgS4anq2Vvfr29oOU8C+r8C7MSrJDjcX5yobzwV/qtbHSuKMyS9K7tYCwd99Zx7YqX5Ixof5U8ePxLFwNpcJ+93H/u09Zx0tAEyj6gl7Qc1A5Ot1Z/rgo4H+ckcl5PlsMv3n3zQ85yoMMiTcqBrpFkG64yYvIPsuo7/oTbyMxfIJekbXNQIejlnhTC6+YIejj1UydEuviFMRfTBA73X7hmcj13XiN0xmnui/jG8uLUlT4QDg54nnaREwwsU9uMwl18DV93eRIPTsem2U5reCrpJcn4mCypWnwfzcuuPR/mxbFEBsKHdnKHTsJD87N+fn2n3KCbCgDW1Fy/X35AGP1oa0vxu2h3dkQhXQzpxintzQZTif3LWuAc8BejhbC00RRSXVxhfNOQ2zEfpI9i5klSEEE0bRazDyD2tw7/xzZeo6s3IHYR/HeTBQgcs56xGf9HOxz+4sQ2VnqeGz/lfqK5xGqhyBHjbgx5ovPyIWe5jVoEb/j1uhB5WQKUia1Wpz4lkzEPl8X6FYyRWabdLZwxxyKOe5PyyM/Y= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3723.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(396003)(366004)(376002)(39860400002)(136003)(451199015)(76116006)(66476007)(66556008)(66946007)(64756008)(66446008)(8936002)(33656002)(82960400001)(8676002)(41300700001)(5660300002)(4326008)(107886003)(86362001)(7696005)(122000001)(53546011)(9686003)(26005)(6506007)(83380400001)(54906003)(110136005)(186003)(55016003)(38070700005)(38100700002)(478600001)(316002)(71200400001)(52536014)(2906002)(21314003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W3AnQM/dom6T0x7ML2xuQLxtXN5wJMcds9y5bChtap3iZ7zMv+t9FDcrfIvh?= =?us-ascii?Q?nuC+yzvlM+FRHRgm9RxSbhCwoyZDmBYSt2ttRzPoRImFy42RFnu0kO1uRaqJ?= =?us-ascii?Q?ZyBwFa0wSiSIj1bCAOs7WVUw4I6LY2pOAAcMhhIiYV1GRZUhOk37YNAVmB2I?= =?us-ascii?Q?JvUEKrcCQp9v3LvjuFlBtpfjtV3MFKE0SLXPlnZAfAKgETzc3Z/sgRwvnhox?= =?us-ascii?Q?DBLdXjEfu6x5gldMhvnmLeYAZ81YuWSk7w8x6wIJCPY5fFRkvVcJQ5NUgZdW?= =?us-ascii?Q?L8alU8ENQyQjGteANyllIbRet3vILNWNlN/obrcp9ZxDFkJFDBlAG8PfBFBt?= =?us-ascii?Q?xMXijbnKhuymwOaXiCZ7odyKXuknX7jFQcJg2XIsZWK+on8yRMROVtc0hLlC?= =?us-ascii?Q?VKoyliCyMgTYaajyWbyA8+vY5XN9jIEp4tI8CuDa5HIcJOYfwq7PRnX9WHQ7?= =?us-ascii?Q?SiJwB6hB1zL2EvKwQWOp5QZpfcM6Ba53PTRUliVZVQ9d/d8jI4pe4xwe4iu7?= =?us-ascii?Q?hI2/+vyh24eSdZkDkj3kTph3yXvj+upexWeiAMOkfZAx4jaq0M4Te3hyUReB?= =?us-ascii?Q?SeqokmtHwK7lEcu1qDmJQX4fUzKrONmFYDOHEudg75dTfEaXTub9XU0aBF1O?= =?us-ascii?Q?FGPx63DCGvYPUeysYiPgu1f5ErudOKGobogk4gt4GRbBsuOPrWgMql4dfph1?= =?us-ascii?Q?SD5YkPuRveqPiyjEXoUEMlBT5+MRoDee2V3/8bfovPBdBP5pdbLz1hOuXa6l?= =?us-ascii?Q?5NvMVZ+xxvlHZ4+sqA2zSgObyS8qXzsv+K7/srlZTda1+sxgkMe2VmkNaZoB?= =?us-ascii?Q?etLkoKixuH6XmS7UjPuNBhKKAxicNxZlsB38aT+QVFniY86yjND0Y1C5afDz?= =?us-ascii?Q?+bc01v2JOBggCYQX9m7co9pBdOcoOQpSsLd6LlR2gQzwhuM1b4qworUqKm8F?= =?us-ascii?Q?mpaD3L8ZxpPn77fV+aIY5TmRsZThZHFbExkqOMwoUc2BVoTgh44Xjvb/m4Nq?= =?us-ascii?Q?nk+vrfaKfUS8ERKbOe55GJe+x2TkSD9kFBrpXMPimatP0n9HQ3pBbRei3pWM?= =?us-ascii?Q?Oc4i8iwkwa9Kd1xZy2D0y0nrrRMMBHOvwchFnzce4wjSgrXrHyTe9GgeXitm?= =?us-ascii?Q?F8H0sfaPyY9tEKQuoGiTS8Yi7/EvcTallAkoa/SN17s7GqPSxCkuLWCsj46T?= =?us-ascii?Q?YWaf+h4+/ZKQwTxBBXnbNn2yuWOJirYAdVd33IpjTyjx9sccCIjbha+QrImO?= =?us-ascii?Q?V7ICHDqO8eoaQARqgcnB9626em9Zjw+Wb0lPDPiC7luLMIOQdN01JlhK4voJ?= =?us-ascii?Q?2Tn6mY8enFzh6sL++c9R4qdt5vx21tlhwBcFwmSH9EeF/OGy01LEfcQ8Z6Xh?= =?us-ascii?Q?+480URqPXEXrGieU9FcF7K8HJmgecZ16RkCiCl3wcs8Ho7XsTdXRxfbBGiV1?= =?us-ascii?Q?bNG5gsX+kPt5EsPUS1KQgSeTOyJiGcS1UiX2gUk8hFXgl7OVPETFC7l3KbJT?= =?us-ascii?Q?pzOE4CAgTt51YH2j29zKOgwUZrt5m+YQ6Ochbm6MyQij0G/JAxs3hb6dQ/XQ?= =?us-ascii?Q?BOtzCMnwRw6PKrvT5h9dlN218Xy+dIpGwXXuQ7D5?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3723.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 620a78c9-be56-44a7-4bd3-08dad1aaf9e4 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2022 01:42:29.3167 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ipWVQEUZtSYCzDqaZXdKQNzH9xAFtG2xmkm4nE54aXa86cFlGrLQHpVD4G20tU/A2N3HThZvevt3E1PI1wd+cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB6814 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Stephen Hemminger > Sent: Tuesday, November 29, 2022 01:24 > To: Ferruh Yigit > Cc: Rushil Gupta ; Guo, Junfeng > ; Zhang, Qi Z ; Wu, > Jingjing ; Xing, Beilei ; > dev@dpdk.org; jeroendb@google.com; jrkim@google.com; Li, Xiaoyun > > Subject: Re: [PATCH] net/gve: add support for basic stats >=20 > On Mon, 28 Nov 2022 11:12:38 +0000 > Ferruh Yigit wrote: >=20 > > On 11/26/2022 5:34 PM, Stephen Hemminger wrote: > > > On Fri, 25 Nov 2022 19:16:00 -0800 > > > Rushil Gupta wrote: > > > > > >>>> > > >>>> The driver should be filling in the per-queue stats as well. > > >>>> q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors > > >>> > > >>> > > >>> Hi Stephen, > > >>> > > >>> Queue stats moved to xstats, and there is a long term goal to move > all > > >>> queue stats from basic stats to xstats for all PMDs, and remove > interim > > >>> 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag. > > >>> > > >>> That is why request to new PMDs is to not introduce queue stats in > basic > > >>> stats, but in xstats. > > > > > > Agree that xstats are better but: > > > > > > * the current checked in version of GVE does not have driver op for > xstats > > > > > > * if driver fills in the q_XXX[] stats then eth_dev_get_xstats_basic = will > be > > > able to use it. > > > > > > > That is an option, but it will require driver to add > > 'RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS' flag what we want to get > rid of in > > long term. > > That is why we are requesting new driver to add the xstats > > implementation instead of adding queue support in basic stats. It is up > > to PMD to provide xstats implementation if they want queue stats. >=20 > Agreed, having xstats in driver is the best way. > Doing what virtio does now would be a good example. Sure, the xstats implementation is planed to be added in the coming release= s. Currently the gve PMD only have some basic features supported, and will have the rest features enabled gradually (might co-dev with Google team). Thanks Stephen and Ferruh for talking about this feature and giving the detailed explanations and concerns. >=20