From: "Guo, Junfeng" <junfeng.guo@intel.com>
To: Joshua Washington <joshwash@google.com>,
Jeroen de Borst <jeroendb@google.com>,
Rushil Gupta <rushilg@google.com>,
"Li, Xiaoyun" <xiaoyun.li@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>,
Ferruh Yigit <ferruh.yigit@amd.com>
Subject: RE: [PATCH v2] net/gve: fix RX buffer size alignment
Date: Tue, 14 Nov 2023 02:41:40 +0000 [thread overview]
Message-ID: <DM6PR11MB3723D394B70C3EB478DCCEB9E7B2A@DM6PR11MB3723.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231113231206.376452-1-joshwash@google.com>
> -----Original Message-----
> From: Joshua Washington <joshwash@google.com>
> Sent: Tuesday, November 14, 2023 07:12
> To: Guo, Junfeng <junfeng.guo@intel.com>; Jeroen de Borst
> <jeroendb@google.com>; Rushil Gupta <rushilg@google.com>; Joshua
> Washington <joshwash@google.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Ferruh Yigit <ferruh.yigit@amd.com>
> Subject: [PATCH v2] net/gve: fix RX buffer size alignment
>
> In GVE, both queue formats have RX buffer size alignment requirements
> which will not always be respected when a user specifies an mbuf size.
> Assuming that an mbuf size is greater than the DPDK recommended default
> (2048 + 128), if the buffer size is not properly aligned with what the
> device expects, the device will silently fail to create any transmit or
> receive queues.
>
> Because no queues are created, there is no network traffic for the DPDK
> program, and errors like the following are returned when attempting to
> destroy queues:
>
> gve_adminq_parse_err(): AQ command failed with status -11
> gve_stop_tx_queues(): failed to destroy txqs
> gve_adminq_parse_err(): AQ command failed with status -11
> gve_stop_rx_queues(): failed to destroy rxqs
>
> This change aims to remedy this by restricting the RX receive buffer
> sizes to valid sizes for their respective queue formats, including both
> alignment and minimum and maximum supported buffer sizes.
>
> Fixes: 4bec2d0b5572 ("net/gve: support queue operations")
> Fixes: 1dc00f4fc74b ("net/gve: add Rx queue setup for DQO")
> Cc: junfeng.guo@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Joshua Washington <joshwash@google.com>
> Reviewed-by: Rushil Gupta <rushilg@google.com>
Acked-by: Junfeng Guo <junfeng.guo@intel.com>
Regards,
Junfeng Guo
> ---
> drivers/net/gve/gve_ethdev.c | 5 ++++-
> drivers/net/gve/gve_ethdev.h | 8 +++++++-
> drivers/net/gve/gve_rx.c | 7 ++++++-
> drivers/net/gve/gve_rx_dqo.c | 6 +++++-
> 4 files changed, 22 insertions(+), 4 deletions(-)
>
> --
> 2.42.0.869.gea05f2083d-goog
next prev parent reply other threads:[~2023-11-14 2:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 0:34 [PATCH] " Joshua Washington
2023-11-11 4:18 ` Ferruh Yigit
2023-11-13 22:47 ` Joshua Washington
2023-11-13 23:12 ` [PATCH v2] " Joshua Washington
2023-11-14 2:41 ` Guo, Junfeng [this message]
2023-11-14 12:56 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3723D394B70C3EB478DCCEB9E7B2A@DM6PR11MB3723.namprd11.prod.outlook.com \
--to=junfeng.guo@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jeroendb@google.com \
--cc=joshwash@google.com \
--cc=rushilg@google.com \
--cc=stable@dpdk.org \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).