From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37F5642969; Mon, 17 Apr 2023 08:30:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C4E7E40DFB; Mon, 17 Apr 2023 08:30:50 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 87C9940698 for ; Mon, 17 Apr 2023 08:30:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681713048; x=1713249048; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8eMBToOdwGJ+xfu36mAyNN+HMvD0HsAZDUQvB3q0EFI=; b=SOko5faE1V0uDGgAsBIL2Nebz/Biwkz6oM75wHcBJNyqQOH/sA8m2p48 CPZBNweJ8dYfqwgBqdam7sLWpaYxOg50sc5xdpTk16y1eIHLFT3mVfVcK iqFvJH0mK1qut3XInkxANemQkH1LbmC3L3pSymjf7IqibS05bQn2ITfNV uvei9/TzElsCDg84YFiAaQElVFSpS3esiXzKj7R05MFSPnlBsNjLeXLrb FnsmwJ2yZvHVsOL27RBgRRPHDh9nxazMW0sZNsWu+GDVQFeJwDlCAX05x +ij1HvLAjNSujNR5xI4jw/L8LKFXsHxa7qO63v/oYiS2lSXw8Fcj+azlq w==; X-IronPort-AV: E=McAfee;i="6600,9927,10682"; a="431107395" X-IronPort-AV: E=Sophos;i="5.99,203,1677571200"; d="scan'208";a="431107395" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2023 23:30:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10682"; a="723142116" X-IronPort-AV: E=Sophos;i="5.99,203,1677571200"; d="scan'208";a="723142116" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga001.jf.intel.com with ESMTP; 16 Apr 2023 23:30:46 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Sun, 16 Apr 2023 23:30:46 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Sun, 16 Apr 2023 23:30:46 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Sun, 16 Apr 2023 23:30:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bssTz4rCCmbfg5HwoGDSRgjUy3R+VfC3gktKd3FNtbg+mYoNQnt8W6IMHO4yf9lsd3njHef4Oe9rlpublTmJPNVqL+KczEYEjjPPYQbD8ONxIPWI8dlTS+wbwoIAMzo4dIx+2W00iLE42RqYysb7I4iIAJecEYoNju2YfTa4oq7mcuOYxGWcvfQ0A5pbA5+4A+4nxBItXV2t4ssd39qaIClh0eLPoI2jO5m5Wy+uX6NpuFlb9ef3vgd8EigQdD++ozHKVv5JWjgwdtldfnsFB3joAu/uDP34qTJcXeUU8Pq80ajwK4Rg6xAbL5Ws8vupa6wGflSQxnSdmOwERHlZ5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y0qQ86JLXoHFi1R51aide/jVg+4Z4ICUNqtysB5AR4k=; b=hDF4vnUVcjx/KhtkAHl9+8i7DsQJyXqi5LpS3+1pMDHLxuN+5HSjAwDyDAD/K7uLbX2Qj13miQFO0kFouIKERNpoEw7YiYeaNgAPrtA0t0vhdsiue15MI3oNHwC7jZ58NI/ORB8+cRYjhVVT9EtcNMW5bKklehJsqN8i8ybEu2wttQhTv6UyGk5fncW9wl1cFMzS04UzeA9MsgFBtbKLwmAk5zBeHVK42FxaxuqXBXicbYsbZZbS5kVr2cnTsXaXUTlPH3yeOP9OPBbbzkL7KL5MoNOb9bi4zvDexH/esgZEUSef8ZyQTxrse4GKj9/G7+ZUXI1qhsIvdOI0Wlhr8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3868.namprd11.prod.outlook.com (2603:10b6:5:19f::13) by PH7PR11MB6425.namprd11.prod.outlook.com (2603:10b6:510:1f7::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.49; Mon, 17 Apr 2023 06:30:45 +0000 Received: from DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::d0e5:45c5:88e:f324]) by DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::d0e5:45c5:88e:f324%4]) with mapi id 15.20.6298.030; Mon, 17 Apr 2023 06:30:44 +0000 From: "Naga Harish K, S V" To: "pbhagavatula@marvell.com" , "jerinj@marvell.com" CC: "dev@dpdk.org" Subject: RE: [PATCH v3] eventdev/eth_rx: fix invalid memory access Thread-Topic: [PATCH v3] eventdev/eth_rx: fix invalid memory access Thread-Index: AQHZaRzoHaRXcLzLcU+tSCG+K0WvV68vF7yg Date: Mon, 17 Apr 2023 06:30:44 +0000 Message-ID: References: <20230405094332.2862-1-pbhagavatula@marvell.com> <20230407064732.891-1-pbhagavatula@marvell.com> In-Reply-To: <20230407064732.891-1-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3868:EE_|PH7PR11MB6425:EE_ x-ms-office365-filtering-correlation-id: ba33a669-4258-4d6c-1621-08db3f0d45c3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GF5TXqiqcaYz8HDEMKbMiirohfC2eZLim0Emh0X8dfoDkvqVzZiGNAQ5F5KrpR5b5swegoSChMmqcgdGlvG7k52FXA5iAPff/pf7Zl5vMvD08F7CvjV/6xZzYmDDxakB/bLwHqwNtuchAS4kwJ/I/N/6MVrMZN8lHWbVAKqbrkaQ4GtZMCM4F1BDnUkC/TkyViah+ihPakmsbYjHyVEcWK1uDAGS3Z45lyBV+mqaQUYr58Uu6RvE05BS+5WpEM8Nl9N1fio3IYoAsWZhyq+LeZ5gNCzfg4wzR2ahKy6R08CM+nedTHg9rBA5Z0uAm2GTI9NkMatbP7jYqwh1OV51xH9UAHSoNmNyr1R8+6f1ETxSfn7OQ/ffSSaLYFnLaIYwozIDzsDDwEPxVlcKrpTJBDbdyjcoKBjr8no+P4udvU4frud8F3eSjtOPlkX2fcMTG9ykQE6/rQ5hZHhusSpUbbJbEKT0oONHCXtQOz2BpROufXgYXiF6oav0UsrZeHkOyqg1ZW5PWExjFQW73eKU1gPwi3TrV+bBNwXTxqfoNu1WY9hApTPwUTIs4pLEMtuRtu9ndXeBAYEyt0TRHxjKoVZyaQgpl/Ajtpj3Tan0kUXuVrr1KxIHSqlQ1Z+MvhgN x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(376002)(396003)(346002)(366004)(136003)(451199021)(8676002)(478600001)(71200400001)(38100700002)(8936002)(316002)(82960400001)(41300700001)(64756008)(66476007)(4326008)(55016003)(66946007)(76116006)(66556008)(66446008)(122000001)(110136005)(186003)(2906002)(53546011)(38070700005)(6506007)(26005)(86362001)(9686003)(83380400001)(33656002)(52536014)(5660300002)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aS0BRCbhMLptCkzCTPfeb19jwYVeHeTrgjFlbae6JWrtnRby0wgD4Akzmv//?= =?us-ascii?Q?yXyxBe0OHnOkj+MAQ6vbZ6XYoPC33hzbWXLWBqyoHMLQnlXHcj0c6TKdLyau?= =?us-ascii?Q?hSwMGYBqdkQUD988NQF4JdPaed+LnU6AMaqG9XImTmMtnmoWoDS08Xh6x6/S?= =?us-ascii?Q?fAkgQmhI7aPEfZZzIYx+uhi2B0uKFXHm+8NuX/kAdH2xdlMupusQu4pBBkV5?= =?us-ascii?Q?NnQ7dRXNKG9reNVgYjaMccEH9883aQSQjX+2T26Ic7UJTyLttATZ68fRZosx?= =?us-ascii?Q?4SCV3q9gniGgcH8R+nzruijfueI95Wvhhv2bdEjVuCPwnMJaGnEkJAKt50/Q?= =?us-ascii?Q?wWrBdew+0YTsigEr5q13uUv6TPRMT5RD/jiAK4SNNxcRsanFiIDVtbxdFcYE?= =?us-ascii?Q?F4xg3mpDEWnjahxroqJd/i5IaGxSnr2xtHcaDcjdMbiBi0VIOSGAn/L+Wyzg?= =?us-ascii?Q?px7eMpDabyrdeq17aEi8i7nfK0sdmyCdstU4zyg4Hh/NbyOcdkSSddyz1Fjs?= =?us-ascii?Q?5F6ikP25PzQxnZLmQVOR6HRUYcmTz3WJk4sek0bJ4hGv0m3WDl5TlKrzpH/m?= =?us-ascii?Q?WFa3558d2UENooFSMkqzSeou4HOMx77f28tfrvldglWPb94DUwbKhgEbzDUs?= =?us-ascii?Q?UJbIDkpIjHRe1KLNQ2twfQ+FEOlxdxCo52GIqxQWGVXzYSiBms18mwoRkLsD?= =?us-ascii?Q?qoidMAMlzIs2IwD5ap3bJZSxqxkstG5vs3ivtg3ojONbrboZMQj17Z1rnPya?= =?us-ascii?Q?TFT/xX8p7bP2Vi3cj7c8L6t/WGO35TItUTpYACQl4IdtrrFZ9KtAQ7E7kSaX?= =?us-ascii?Q?SvMumgsAZe63uO29urxfN/DD9+Y93RAJ5DnSEj991lHGDtYSTqrtkuCrkYnr?= =?us-ascii?Q?75QF825gxpqO7lfE8G9UhezWTa9TmOOAAggHCOSsWGAeN3BytmSg9XEs39iy?= =?us-ascii?Q?+hkUGh37PCetEL0gfedEreOLDLeVmmky+aoQhjKMWyRoU6+Yuij7SObd0PSI?= =?us-ascii?Q?E0jMC/iF6h9UWQqMW9NyO3FJH11D7CoxyUCNMZ82kwJvo2dIXJQ3G1cw1D9C?= =?us-ascii?Q?EW3AaYSu4GzY6fRYAuoCHDHUm8x/1y+UROMm9oVfGoZq6SDYLo5T0+Ixesgs?= =?us-ascii?Q?rD44dcerDzRAfVaCuCVC4LYVZTqSygFHKBGrMyqTuQijctWMNEoHZ5e4V7qC?= =?us-ascii?Q?JDInAwI1MO2xEosQFa6GMSQqHKrcXMJ4cOgGRj959FkEIZrF7Yt3SD3K7BpN?= =?us-ascii?Q?57T6URAetDZNZ8y0wZfS656s0AJu61dstdLvTxQ019Pfv0tyuokLgU/GdYDp?= =?us-ascii?Q?60GQ/BnddTIra8Wpguy6lQu6fLDDAnFe6MgdtPj4FNPv/7gflxnbv+RCZKzX?= =?us-ascii?Q?WQKhKsIPpv9Pd6T1zkCIySfqasDwVSMoJPm8HzSgxQvs17RP84O0aX0bsoHg?= =?us-ascii?Q?X331tkSFux9g5OqgHNJkfPXZfgXSDkEpisOIIGWoqahlSQP8fJTmLxyxpKG1?= =?us-ascii?Q?ZPkdI9tgubRHWo6jMYYlT4y1wHEeusH148/AiDdD63oZ8jaGwLN6OabymXUy?= =?us-ascii?Q?L8adTgBbx1HsMHhQeS42P+YFg8DKdvyWTA0+nGeiCUfFzRiNWfA858DuazNj?= =?us-ascii?Q?oQ=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ba33a669-4258-4d6c-1621-08db3f0d45c3 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2023 06:30:44.0195 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iXNJnPdxJswMkAb48DmO553/i3niwoC1lkrnQspOjDM4mRVjLf7lk+3qlZKOZHH+c+h4yM6VYxoNOj+jvcTh4+AJuf2XxO1UYLogR9JHsQw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6425 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Acked-by: Naga Harish K S V > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Friday, April 7, 2023 12:18 PM > To: jerinj@marvell.com; Naga Harish K, S V > Cc: dev@dpdk.org; Pavan Nikhilesh > Subject: [PATCH v3] eventdev/eth_rx: fix invalid memory access >=20 > From: Pavan Nikhilesh >=20 > Rx adapter internal service structures are only initialized when non-inte= rnal > port is added to the adapter. > Check if Rx adapter service is initialized to determine if runtime set/ge= t > parameters are supported. >=20 > Fixes: 3716f52186af ("eventdev/eth_rx: support runtime set/get > parameters") >=20 > Signed-off-by: Pavan Nikhilesh > --- > v3 Changes: > ---------- > - Teardown queue when test is not supported. >=20 > v2 Changes: > ---------- > - Remove unused variables. > - Fix spell check. >=20 > app/test/test_event_eth_rx_adapter.c | 10 ++++++++-- > lib/eventdev/rte_event_eth_rx_adapter.c | 24 ++++-------------------- > 2 files changed, 12 insertions(+), 22 deletions(-) >=20 > diff --git a/app/test/test_event_eth_rx_adapter.c > b/app/test/test_event_eth_rx_adapter.c > index cfe6052d7e..52d146f97c 100644 > --- a/app/test/test_event_eth_rx_adapter.c > +++ b/app/test/test_event_eth_rx_adapter.c > @@ -1201,7 +1201,7 @@ adapter_intrq_instance_get(void) static int > adapter_get_set_params(void) > { > - int err; > + int err, rc; > struct rte_event_eth_rx_adapter_runtime_params in_params; > struct rte_event_eth_rx_adapter_runtime_params out_params; > struct rte_event_eth_rx_adapter_queue_conf queue_config =3D {0}; > @@ -1230,6 +1230,10 @@ adapter_get_set_params(void) > /* Case 1: Get the default value of mbufs processed by Rx adapter */ > err =3D > rte_event_eth_rx_adapter_runtime_params_get(TEST_INST_ID, > &out_params); > + if (err =3D=3D -ENOTSUP) { > + rc =3D TEST_SKIPPED; > + goto skip; > + } > TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); >=20 > /* Case 2: Set max_nb_rx =3D 32 (=3DBATCH_SEIZE) */ @@ -1302,11 > +1306,13 @@ adapter_get_set_params(void) > "Expected %u got %u", > in_params.max_nb_rx, out_params.max_nb_rx); >=20 > + rc =3D TEST_SUCCESS; > +skip: > err =3D rte_event_eth_rx_adapter_queue_del(TEST_INST_ID, > TEST_ETHDEV_ID, 0); > TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); >=20 > - return TEST_SUCCESS; > + return rc; > } >=20 > static struct unit_test_suite event_eth_rx_tests =3D { diff --git > a/lib/eventdev/rte_event_eth_rx_adapter.c > b/lib/eventdev/rte_event_eth_rx_adapter.c > index c1cd124002..a8a5564b65 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -3466,30 +3466,14 @@ > rte_event_eth_rx_adapter_instance_get(uint16_t eth_dev_id, static int > rxa_caps_check(struct event_eth_rx_adapter *rxa) { > - uint16_t eth_dev_id; > - uint32_t caps =3D 0; > - int ret; > - > if (!rxa->nb_queues) > return -EINVAL; >=20 > - /* The eth_dev used is always of same type. > - * Hence eth_dev_id is taken from first entry of poll array. > - */ > - eth_dev_id =3D rxa->eth_rx_poll[0].eth_dev_id; > - ret =3D rte_event_eth_rx_adapter_caps_get(rxa->eventdev_id, > - eth_dev_id, > - &caps); > - if (ret) { > - RTE_EDEV_LOG_ERR("Failed to get adapter caps edev %" > PRIu8 > - "eth port %" PRIu16, rxa->eventdev_id, eth_dev_id); > - return ret; > - } > - > - if (caps & RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT) > - return -ENOTSUP; > + /* Check if there is at least one non-internal ethernet port. */ > + if (rxa->service_inited) > + return 0; >=20 > - return 0; > + return -ENOTSUP; > } >=20 > int > -- > 2.25.1