From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 934A0A0543; Wed, 14 Dec 2022 10:50:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E28E400D6; Wed, 14 Dec 2022 10:50:57 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id B0AC04003F for ; Wed, 14 Dec 2022 10:50:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671011454; x=1702547454; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NzTNuZ61utThwYaMTMUZGyPMA3N5MTJTl9f6SkzLbs4=; b=YT3bWVKpKAJobeYbj7x6PJDzk/2qupbbQ73cMPJ4S8rgSfYSuDGlXfCr xCXzuTYPz/weI8eaupuB88rWhWzMfGXCyahTsAhkrQCO+ahFnIcYNCBz3 cSgmnGkNIYFzQvKdmKV7FvYPbcZqWGd1GP3xiBTjnPL8L40LiCURid+6J Cbm2xOLDsaaoGUJu9tYjCLrxiVDZAUp+UgTcQaQyjCigCUHw6dBiYsao1 MWOPC2NjbKiAGfgeT3BO7rHlULKZOjARtrxrD6amccNd+xRt2jnZ3yYbH lutIArcVPQfl7eir5q9UBo4ljdriOrIhxE+CkJUOV5tqTRkPn3PznHCe9 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="298043697" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="298043697" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2022 01:50:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="894233520" X-IronPort-AV: E=Sophos;i="5.96,244,1665471600"; d="scan'208";a="894233520" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 14 Dec 2022 01:50:53 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 14 Dec 2022 01:50:53 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 14 Dec 2022 01:50:53 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 14 Dec 2022 01:50:53 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.105) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 14 Dec 2022 01:50:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NzJDubD4Jpazi5oE9MdTXMqU6QyYIJ9mKBoQIzL4HhwEqq2fwCjMj0CpQ3IlpnpBmcUGJRWzkL9cdW/daveSEhTZeplttZKgTQ1rk7S4+wxMZsLtjTgP2VEjXCeydsHDuesk3yW7dXL/bcMj4GHEFQOdJmguifQF3Qg0+1+8zOOan30QxAjyDEdJ0CsXXpBXsZbOqa+M8vYlbqr1lNpevVziMUlJ8NeJbGdSfq21ZuFdBc2356lFjUsAxq2MoeBS0MJR7r3ddcA0EiNSLV2P/QAQAoYxmigEDU/tW/StJT2Gp1Ih+xqoBItnmki5g9k/KQGbt3ZAsf41bvVtf9dEKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CuFQ4bBfRnXJlOTLj0sCMyxEge6wKUgCTHMNENrU4w4=; b=SIOSuEb7ngecwqJDPzKGTW8KDj1qZGkm+sfMdZwX7UrIY7u340muNlsKf5rQHziNuzGYGpM1HeTQ2IQ0+2edy97aY/xgSDUCh6hDhEFG2LjfrhNOmY+xsHpUH5WJ30WyDEOzWBVln09KCiAq1Qh/H8u4ZzZBk8d09hC2tD0cZ02xtuv/CoVCx5x7Dybht4GXyponQoYrqkJaaOaig08zwMSQgGOUV/weK+Rd56L99536WcSpak93aOozLo18CxqYp6IgCbuoJt9yIM07E3QVWfQjZJ8QttZgoE2d33scMzpmcxaVhG68qInpFPEwCqRzR6JG1O7STYgEcC7/9457iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3868.namprd11.prod.outlook.com (2603:10b6:5:19f::13) by BN9PR11MB5340.namprd11.prod.outlook.com (2603:10b6:408:119::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Wed, 14 Dec 2022 09:50:48 +0000 Received: from DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::ab8e:89f1:e2a4:583c]) by DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::ab8e:89f1:e2a4:583c%5]) with mapi id 15.20.5880.019; Wed, 14 Dec 2022 09:50:48 +0000 From: "Naga Harish K, S V" To: "Jayatheerthan, Jay" , "jerinj@marvell.com" , "Carrillo, Erik G" , "Gujjar, Abhinandan S" CC: "dev@dpdk.org" Subject: RE: [PATCH v2 1/4] eventdev/eth_rx: change eventdev reconfig logic Thread-Topic: [PATCH v2 1/4] eventdev/eth_rx: change eventdev reconfig logic Thread-Index: AQHZD4pe12vnhirY/kqGHifu1eqbYq5s+ciAgAApiSA= Date: Wed, 14 Dec 2022 09:50:48 +0000 Message-ID: References: <20221214055551.913821-4-s.v.naga.harish.k@intel.com> <20221214070440.921488-1-s.v.naga.harish.k@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3868:EE_|BN9PR11MB5340:EE_ x-ms-office365-filtering-correlation-id: a8b67acc-77af-4a5d-9b88-08daddb8ad88 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: b5yBH+2U4CdZGQwvPAujb8H/jSKcj/CVs+PZ0N0xKjAxGqloMYecoIiCbkIiI8y9Umg5d9S+4bje5GH3PfbH/68JPdcH39I6LZNwqAuOxwaG0V53XlCXLP1rYZGpulk32gmHp1YvhazH6KL/w31/FEQKa4b/booG4EtiPu7fzHbyDCSYiQOnWGLFXFEy245gV5BAaPGCHziSaE171YPtGnbT/z5Q823rbSItQGi+dGiVy4U42EPRTR6Fj1EXathpA6R4Hd2aXWe4GU4XBzolIz3YX5OZ1syeG0BfSxHxiAmYcIsvt3v6UB6iIyRSXcgV6s6coPJFWCieq6CHuxghOuVZtjlxYoqdJep9aCK5q4YOL+0OzJlIs6vsggeHFY4Srpw/2FPi2+jxpLREl7tJpprwr0U7FPXYEZTQkA2xjIjXyABvfyO4+qm0QNim/35LsQe9XmIPJvFq1WZ03veChBzUsUbT5BgVqDrGnDexWiwmlzMgV+qIMZJUOhvlIkdL9rUZzJ+6Fv0hIrd2/1xtOym0dbrXsGX91DGqSOuJEE9SSuakuV9aT9VhnFwd0hQ/2w+rJIVmZ0zr0MTG0ZlLGsjkjfpYv/R7Vt/nqCsiCIkefsIdfTaLiXAXRf95dmFFEphb3z3eKhY7RsuVebf5ZtYohUkYT6MeWjNCSDxPun4SCY6iTcpSQDiei7TiyTO+AVMkh2aRE21bRdAm4ktv8Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(366004)(376002)(396003)(136003)(39860400002)(451199015)(33656002)(41300700001)(8936002)(52536014)(478600001)(71200400001)(38100700002)(86362001)(122000001)(82960400001)(55016003)(53546011)(5660300002)(38070700005)(66446008)(66946007)(186003)(6636002)(64756008)(4326008)(110136005)(76116006)(66556008)(316002)(8676002)(9686003)(66476007)(83380400001)(6506007)(26005)(2906002)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WuDeHy9Do1SpRbM6gMG5M/nH310JNmocSPZQ/UMTTrwNQ5Y4fhpCfPpTFJeY?= =?us-ascii?Q?dxUCxkdBBVJ8fpPu779El51NQ07LA9jYaLpkVgnArEMTh4/WUT6IPj0gzmlz?= =?us-ascii?Q?ey7vEQ8c/qHYUQleoy8MYecVGOA3EAJNub9qpRfSfWbVlOBATw7ECRxCXIr0?= =?us-ascii?Q?TBu7QXLdTdefCLZSHIVNzUFc8p2rh4yCCLPkItgiOedeWusRajxCZX9IX9fp?= =?us-ascii?Q?tuwFOnk8nMfEpU5cY9f6ao/8vNdoPGVvEo53On3tP3nhJWPTot76S9yS75Wl?= =?us-ascii?Q?PWqbNqd147h2/hTZj8LWeKjSc2EQtKlLYnVnvPrBye9OEpROEWcEqFMS1voz?= =?us-ascii?Q?E6VPYRkL9gaCQeNTmDP6w09CXRWNqUWPcLR2je8uAOQioph4XBWrVfzTdk/X?= =?us-ascii?Q?PGAYiZ/NkX3qB/Uo/U1hot1ek/6SMyKS++yIcYaXG+QNCncB5pGf9N6ICs7J?= =?us-ascii?Q?YolxT/qjAis/GOmf792Awud51TeSzxkTw5F0FXMTBaktjq2moY2n+L9gfMWr?= =?us-ascii?Q?ojmqDWn52aHt+8CaMO6VNpkkPGmrRGTOaWRcM1Hm0fgREyM2gzXQ3PeOjtCM?= =?us-ascii?Q?k/M5Lki0qq0tDyg0NmnxDl1KXMA3eFMrv8fRyyDiFNLkjHix1RFT5iFnJtat?= =?us-ascii?Q?GJtgYlgL+VmyDvXV1Mj3lrhJ9kcS+V/IB/b4sHq3nSIq2PXN9wGnWtQGYSdL?= =?us-ascii?Q?l8uj/dO5VmmhXkbTKC1O7WbmAdSabq8guTM+Lu0S4ekWcBLji9WJ3aAKnICu?= =?us-ascii?Q?WewmaOxBxHx6aC4e4mZ9B1c9GvH27jyBLUR3k/nJZqRqKXSXz2+vhXs7keln?= =?us-ascii?Q?IRwozl6lRGKL34nzTanjpIQhpqgQ7fz2TEC7HOL1j8OJXPmHMUOuijEIuxv7?= =?us-ascii?Q?KiI9YEv8mJ6jCuibs6f764IzXjEyOtVvnbUWHMJvnT7/h3b7Br/QEO9AwTkR?= =?us-ascii?Q?k/ZC31jZKP47Gq1udh0V8RTubH3Ce8Ipz0QqCM614rN+of9HJGCpRH2QI1mE?= =?us-ascii?Q?+liLGPGPWUr6sNd/f0hdye1rIsdEgQ/RWiN10BggCzPMlNXD0creb3eSo7Jo?= =?us-ascii?Q?x+aYpYFbTKcnklthYfFqNceIKSXWwCv5Fjx3r4SZHucB+UBmHEjzQI0dyk6H?= =?us-ascii?Q?rMVbEv2ZtFGQji89pLsO4fdpx/tqPDR8Kj404BmhoBpWub7Qv62Dx40CyJWg?= =?us-ascii?Q?M0USINPPyhiiU0gaUXoMudgJtaQWWJ2+QO58m8382CTa7ArtLgKQe+Djn4pX?= =?us-ascii?Q?LmG/RQ9HqydRTXTJKoEynBcpatBmEYrnLUjG74CDf2ryW0ThMvceK18R6nLE?= =?us-ascii?Q?wQC2edr3hHH4/p12vOGavm/S3Mzqm7yOGp+J0a45gz5Xrc8MAtzGmGZbc4k1?= =?us-ascii?Q?XbNw+FQuW/E5BhZvEI9a/oYqXSw9LNtCA2tOug4P19jkmB4ixSu2ponLGVK9?= =?us-ascii?Q?6v+G+noEjNUmIQW0XCdLZoijtaIM1rLPcuHwJhAtXxB2WazySud7AJ53YLMn?= =?us-ascii?Q?BvGxuZMtENXWQXf6A92ekA9DEWpMjjqOopm+mLf//nnPz8fB955wN7TsvmgL?= =?us-ascii?Q?3NjiMF829/TUhJKgPAcEZFNuEZ08aiNWEtsCqQfvFs1kUo6Maf7wszcMnayP?= =?us-ascii?Q?NA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8b67acc-77af-4a5d-9b88-08daddb8ad88 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2022 09:50:48.1166 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +mjfX6EtCL3x9eZ6s+zEdPCPkZktXLRIyzBXPTZb/YAiZWgMsjuVn5WTWjQCAob8azcARpOoV80XSvCcVpaz9sra0yJEZwsgzl37TgON/5k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5340 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Jayatheerthan, Jay > Sent: Wednesday, December 14, 2022 1:01 PM > To: Naga Harish K, S V ; jerinj@marvell.com; > Carrillo, Erik G ; Gujjar, Abhinandan S > > Cc: dev@dpdk.org > Subject: RE: [PATCH v2 1/4] eventdev/eth_rx: change eventdev reconfig > logic >=20 > > -----Original Message----- > > From: Naga Harish K, S V > > Sent: Wednesday, December 14, 2022 12:35 PM > > To: jerinj@marvell.com; Carrillo, Erik G ; > > Gujjar, Abhinandan S > > Cc: dev@dpdk.org; Jayatheerthan, Jay > > Subject: [PATCH v2 1/4] eventdev/eth_rx: change eventdev reconfig > > logic > > > > When rte_event_eth_rx_adapter_create() or > > rte_event_eth_rx_adapter_create_with_params() is used for creating > > adapter instance, eventdev is reconfigured with additional > > ``rte_event_dev_config::nb_event_ports`` parameter. > > > > This eventdev reconfig logic is enhanced to increment the > > ``rte_event_dev_config::nb_single_link_event_port_queues`` > > parameter if the adapter event port config is of type > > ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > > > > With this change the application no longer need to configure the > > eventdev with > > ``rte_event_dev_config::nb_single_link_event_port_queues`` > > parameter required for eth_rx adapter when the adapter is created > > using above mentioned apis. > > > > Signed-off-by: Naga Harish K S V > > --- > > v2: > > * Fix build error > > --- > > --- > > .../prog_guide/event_ethernet_rx_adapter.rst | 18 > ++++++++++++++++++ > > lib/eventdev/rte_event_eth_rx_adapter.c | 3 +++ > > 2 files changed, 21 insertions(+) > > > > diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > > b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > > index 116c0a27c6..8fc9be0a9d 100644 > > --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > > +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > > @@ -71,6 +71,24 @@ set to true. The function is passed the event > > device to be associated with the adapter and port configuration for > > the adapter to setup an event port if the adapter needs to use a servi= ce > function. > > > > +Event device configuration for service based adapter > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +When rte_event_eth_rx_adapter_create() or > > +rte_event_eth_rx_adapter_create_with_params() is used for creating > > +adapter instance, eventdev is reconfigured with additional > > +``rte_event_dev_config::nb_event_ports`` parameter. > > +This eventdev reconfig logic also increment the > > +``rte_event_dev_config::nb_single_link_event_port_queues`` > > +parameter if the adapter event port config is of type > > +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > > + > > +So the application is no longer need to configure the event device > > +with ``rte_event_dev_config::nb_event_ports`` and > > +``rte_event_dev_config::nb_single_link_event_port_queues`` > > +parameters required for eth_rx adapter when the adapter is created > > +using above mentioned apis. > > + > > Adding Rx Queues to the Adapter Instance > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > > b/lib/eventdev/rte_event_eth_rx_adapter.c > > index cf7bbd4d69..34aa87379e 100644 > > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > > @@ -1532,6 +1532,9 @@ rxa_default_conf_cb(uint8_t id, uint8_t dev_id, > > rte_event_dev_stop(dev_id); > > port_id =3D dev_conf.nb_event_ports; > > dev_conf.nb_event_ports +=3D 1; > > + if (port_conf->event_port_cfg & > RTE_EVENT_PORT_CFG_SINGLE_LINK) > > + dev_conf.nb_single_link_event_port_queues +=3D 1; >=20 > Can add more comments in doxygen for nb_single_link_event_port_queues > and nb_event_ports fields pointing out they are configured by application > with worker necessity in mind. Adapter necessity is handled in adapter > create now. >=20 > This comment can be applied to other adapters as well. >=20 The above details are covered in the programming guide already. > > + > > ret =3D rte_event_dev_configure(dev_id, &dev_conf); > > if (ret) { > > RTE_EDEV_LOG_ERR("failed to configure event dev %u\n", > > -- > > 2.25.1