Hi all,

 

The API “rte_event_eth_rx_adapter_create_with_params()” is an extension to rte_event_eth_rx_adapter_create() with additional adapter configuration params structure.

There is no equivalent API existing today for “rte_event_eth_rx_adapter_create_ext()” API. We may need to have one more adapter create API for this.

That makes so many Adapter create APIs and will be confusing for the user.

 

   I am proposing the following changes to the Rx adapter create APIs which will consolidate the create APIs to 2 in number with all possible combinations.

 

Current RX Adapter create APIs

Proposed changes

 int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,

                    rte_event_eth_rx_adapter_conf_cb conf_cb,

                    void *conf_arg)

 int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,

                  rte_event_eth_rx_adapter_conf_cb conf_cb,

                  void *conf_arg,

                  struct rte_event_eth_rx_adapter_params *rxa_params)

 int rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id,

                    struct rte_event_port_conf *port_config)

 int rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id,

                   struct rte_event_port_conf *port_config,

                   struct rte_event_eth_rx_adapter_params *rxa_params)

 int rte_event_eth_rx_adapter_create_with_params(uint8_t id, uint8_t dev_id,

                    struct rte_event_port_conf *port_config,

                    struct rte_event_eth_rx_adapter_params *rxa_params)

                     Will be deprecated.

 

The applications that are currently using rte_event_eth_rx_adapter_create_ext() or rte_event_eth_rx_adapter_create() APIs for creating Rx adapter can pass NULL argument for the

Newly added argument which will behave same as before.

 

Let me know your comments for this change.

 

Patchwork link:

https://patches.dpdk.org/project/dpdk/patch/20230801094004.51939-1-s.v.naga.harish.k@intel.com/

 

-Harish