From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D46A842FB1; Tue, 1 Aug 2023 12:04:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5AD4E40F16; Tue, 1 Aug 2023 12:04:32 +0200 (CEST) Received: from mgamail.intel.com (unknown [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 494B440A89 for ; Tue, 1 Aug 2023 12:04:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690884270; x=1722420270; h=from:to:cc:subject:date:message-id:mime-version; bh=HibNluxUoaqmPynWtXLyBKn/HOvhzEh+TMX/ecSj8rE=; b=AJK5Z+Sn5kFfTfl+DnKoL0J9ECnmDdmCDYsAYB2sjsX4T36KKAMXabC3 5tcKLdsAQXJdfppPwoiMEZT54sWcIKaNZvJ/vEvm2LwecWbO4gV7cPiSr eBtFltwqPJ55cVKBByODrlMDvmILhBK5kF8KBlaftGaJlhBrTsMbLGUL3 jFIw4k3AMU0ZRAfiOAYc5pRsW3WXqe3so68hDOeDiFqELJ+l+Uk/omLLf RosDQVF1h3jgaEjLrKf+tqP9GQacfhatyNDVRZI1Vks2AcbkBtkKgA+HS bQdYBg2IKCuW1i7Nmg6sCN7acLI/3seJvfL8/RN5rLfy1W9K3wyMTqrxN A==; X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="400207979" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208,217";a="400207979" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 03:04:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10788"; a="818740056" X-IronPort-AV: E=Sophos;i="6.01,246,1684825200"; d="scan'208,217";a="818740056" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by FMSMGA003.fm.intel.com with ESMTP; 01 Aug 2023 03:04:28 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 1 Aug 2023 03:04:28 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Tue, 1 Aug 2023 03:04:28 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Tue, 1 Aug 2023 03:04:27 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jepgTwBkpWisCOuMLb4WRHvr3A+1miQLXiAjxIR6qS/WdKsiK+1KcitHdAX12oLtz15dLTmamgDaOn3xTq+53fsuhxKDlFp8fBZ+/U4K7XA4zHQuVWSvyYZNRDJ1FPdj38ZCOzIrfipAs+tgr80qWhhgYVhA6AvfBRb9Vj3FguWTQjImN5uLE5VDRxx2te5jnH5/Gz42++4+6C+eQdroigoXpC+6ZjhwdNCqDQqwgR7gwN6umgfEA/JTkxQHgBQZrVM9cpdSCmJ9nO4453dkUt9V2zAtr290fK+fpgEt+CpMnab9NCoDnidB9nCXwuYjyzMKkxxS6ilbnAO4H6tBgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XAswpXjYKzmRLjO18jKy/tKnFA2mkL8ZZacu2MOUs08=; b=GqfzPo0YzLyDsZXn6F47MTgi596UqM4v7CM6FS3sFusNkVvd99G4/9Emg7t8Zf1Nh2yLn1BWPUSdMmDFNLqr4ib8+9umW6WSN1jcBO8bhq7JniS4S55vswrGf0IAhB/howR7z4vfncs3Gv33ELCesNefd8j7NE2Oi87+gQTG1BJ8vygsXBdzbr+J6PW3ceF0wB4DnomFwOMdtIVdF51r9uAtakgfF8VEz/VHeEd5xPsvzTDrI8CINUtUrTjnomxvkD/46rWecjBG4SmTcKM8qURHu0BshOYAAjd6bURXXlHt2q19x1kYwdmnlY/LaX+WbrqXYlZqnDQl74BkYnFz2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3868.namprd11.prod.outlook.com (2603:10b6:5:19f::13) by IA0PR11MB7332.namprd11.prod.outlook.com (2603:10b6:208:434::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.34; Tue, 1 Aug 2023 10:04:06 +0000 Received: from DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::2729:6170:6e40:89c6]) by DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::2729:6170:6e40:89c6%7]) with mapi id 15.20.6631.043; Tue, 1 Aug 2023 10:04:05 +0000 From: "Naga Harish K, S V" To: "jerinj@marvell.com" CC: "Jayatheerthan, Jay" , "Gujjar, Abhinandan S" , "dev@dpdk.org" Subject: [RFC] Rx adapter create API changes Thread-Topic: [RFC] Rx adapter create API changes Thread-Index: AdnEXPFMrkqNqIwTSPWkdBsy+uSR/A== Date: Tue, 1 Aug 2023 10:04:05 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3868:EE_|IA0PR11MB7332:EE_ x-ms-office365-filtering-correlation-id: 2b074621-b4de-4d0f-f755-08db9276a3e8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qy5i6QDihKy6n9caH+UC/20Ksg6AFIyF4YbiiIu9bCVYVK5BIBwNV1q3D2TRMfOmmDiWDffG3bVKG7jRMc6IAK2nrH2n5d701NnDa7iNJB3FmsqSEbwH0K+5FLuIYFjh2x8GFCtql1Pr9b5CrwtXTF2LNrr/Kanc1uyW2csdtAwobt4wWMyzu3p2qHZTBGbL1c0SJ0FWkD7X5qv/xf0KnyuimRY/PI2C/IeR8WkHqerziQQrxGEakiGo7pbCuWiweihzoqEnt7MQAO/ZW5jCPj9ifaKu0Br/V9fOigJsgczX3zLOOFiz6jKh3bLu+jFhSrksgP/QMwFd26ppA4F6pORL55lpw571kcH31HurDs9NZ5CVUvCCLfnnUNpET5w7Vum+ivi8ZI9b+uoXJG4t+ELb0jPcUiHhAhgcPhApowe9PKdJo49chHP5s0Ilu89Pzh9N7RZyqABNLf2FQ1XP3Tc/zcpAVumimjq4t2BDNZSubxz0gTrZw2mh+61pQH0/DNJ0r9DpWRENR8XCEXNV9w1Bd3IE1DAqSi+h0q+Dnnz8h7iCKf5VQyd+7TnQTPS+2ZUrSDFf7YfPe8CRrl24weEyqZp/hKPhF4SGwxRlaak= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(376002)(346002)(39860400002)(136003)(396003)(451199021)(38070700005)(2906002)(86362001)(33656002)(55016003)(166002)(122000001)(38100700002)(82960400001)(41300700001)(4326008)(966005)(9686003)(6916009)(316002)(26005)(8936002)(8676002)(54906003)(64756008)(66446008)(71200400001)(7696005)(76116006)(66946007)(66556008)(478600001)(66476007)(186003)(5660300002)(52536014)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?O/ry/4qwsU3xpVqerbKe/1RKtUUHKLIOFnon/Kgiiir4flll/jEKdyg3Debk?= =?us-ascii?Q?mukvUrlRNukWifpD1BdLgrNu6ryeLLSvbzUixOqNfHRdZ6svil3h8I6eira+?= =?us-ascii?Q?c79Q1lSXnmB7bH0YNjT48f+XNr+EgDYDYF7kr6U9Vv0icSNQiotnOw7vU4J8?= =?us-ascii?Q?qRaNaQKH+GDyvGO+NLoPjm1H8GUNvIKijBW23GQ0txSrixoHeFT2uSiXFZUi?= =?us-ascii?Q?zpvDRAKv3adZ4vhX6uA2E/9CU1waPKZASJ2gRkPlgCjjk1X51Ba1+wXOmj0t?= =?us-ascii?Q?ZHiyABXNYMb/rhFHEcoNeJ1dOwmh9WbAWXwlW82Vx6PDnQipWyfzYdW2eiVw?= =?us-ascii?Q?BcjbFS3lSVosVfJCu8QviSBTTLmcmfEGYGOYXX+OR3U9VR/weFjexIKhZrod?= =?us-ascii?Q?lGB72m76BMydNfiM9bsiy11k+84IgxRCwDnlZQ66Y+QgSAljx+zt50JDzWzn?= =?us-ascii?Q?1J28+vWXb2bu40RK/n+yYzwDHUcDEHGAEocf6ijKDXsM/lJ4jD92maBYK1I+?= =?us-ascii?Q?G4ztXmr9JUOwoRa3W5fkTY7Ntl0VscoZcZBxqx/ElXez8QrmNcP4OliD7CRl?= =?us-ascii?Q?Iosg0Bd6+ORO/FSY40Ni7WButQ2UPP4bTwLiSiMJdBaE11dCMBXfim6pZO/m?= =?us-ascii?Q?5LEwAyO/tGS8HbQEeEkg0MtszEH8QCNYBEq1a4/Iq1qjhirs4fa/zx/iXmgj?= =?us-ascii?Q?li+IkCxRpgv7fJd4Gl4AHd/4y63qUoE2UBOW3iqx5U3BOD1CmiS04cFUBenZ?= =?us-ascii?Q?pXWDC1YxjtRN7dFDue0dy/Pvq27tcbNDXdNsHeGNum09ozKvPgB82T3mp9lc?= =?us-ascii?Q?eyftj0LJ2qIhrUdBx6J6sZknFp9GUfc6+lDmxBDF3idpsgHFemWEn4o8qKKB?= =?us-ascii?Q?km46852Z5B5hB1iKhqYiSDC1Qd6P670j0M/rtBOv4FggyoXWpTsIz9LoNltY?= =?us-ascii?Q?sWLXsFnHS/qbVlTU1ecFTxktaMC/CnVTPq3u9Ag6sa3uma0lgowpfNoeAEeD?= =?us-ascii?Q?e+FdjSaPzMTWtzCq0Zj7Shd6Qe2TzIXUqq66PQVdfXicMqk3m/8NfnBMB3du?= =?us-ascii?Q?m2mkeVG+b5L5C1qGSInQlvXmApac9eXfvnB8q67LOrkDaL1bSIxjNEk2N/r8?= =?us-ascii?Q?roXkoVvZq4iwJc/a49sctvZ9GE9tb4bO+v185WHxKpcE99jfV+WHIs9pTTQw?= =?us-ascii?Q?MQtm9SJW5CfsA6CUD7C4hejoj8gw1pOXAabiTXFGGwROknLNRt3BkK3YV16W?= =?us-ascii?Q?qxwGR4LKXSvQaWGuhUsJTpfBjDx9sBH4Swgo8OD9xCEisFmxeCkcc329/C4h?= =?us-ascii?Q?6YlBXK1t1QcJYsnpg2bETrpt09fEAURd6Z0Ij01umjuSubzJ1SzMqO9i6nhJ?= =?us-ascii?Q?R8GIyzREjjV1w6zNxGAVNvJF2GnXnVXdxJRJWMLbTYG7T5xQ0cgoYTs8Mn12?= =?us-ascii?Q?qtLMc0Wd1jwvwOvGJ6KNZeJaCgcl45zAmeNw7XSR0xsFo8noJx7VqqjpLhuG?= =?us-ascii?Q?fy2Ek0PI1zzP8JS/OnQt2f66pywB/24pK/Cb0YvgYEDXBaexIm7vJIyJ0pKJ?= =?us-ascii?Q?Q6jPJ4rk0kXnjVObeuLghCaVPGnxkXLte/BWGdtj?= Content-Type: multipart/alternative; boundary="_000_DM6PR11MB3868D616108C66842DB96EFCA10AADM6PR11MB3868namp_" MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b074621-b4de-4d0f-f755-08db9276a3e8 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Aug 2023 10:04:05.6484 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vz8UvSwXWiybZdvPtKYhGJvbHjdJ/6uioz2gman0kuYY/RvWxURoBiTyKUPbraeZK4A7+rYr2CRiz151QDMk/ajtL/myCbmlNw2LcywvlDk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7332 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --_000_DM6PR11MB3868D616108C66842DB96EFCA10AADM6PR11MB3868namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi all, The API "rte_event_eth_rx_adapter_create_with_params()" is an extension to = rte_event_eth_rx_adapter_create() with additional adapter configuration par= ams structure. There is no equivalent API existing today for "rte_event_eth_rx_adapter_cre= ate_ext()" API. We may need to have one more adapter create API for this. That makes so many Adapter create APIs and will be confusing for the user. I am proposing the following changes to the Rx adapter create APIs which= will consolidate the create APIs to 2 in number with all possible combinat= ions. Current RX Adapter create APIs Proposed changes int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id, rte_event_eth_rx_adapter_conf_cb conf_cb, void *conf_arg) int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id, rte_event_eth_rx_adapter_conf_cb conf_cb, void *conf_arg, struct rte_event_eth_rx_adapter_params *rxa_params) int rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id, struct rte_event_port_conf *port_config) int rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id, struct rte_event_port_conf *port_config, struct rte_event_eth_rx_adapter_params *rxa_params) int rte_event_eth_rx_adapter_create_with_params(uint8_t id, uint8_t dev_id= , struct rte_event_port_conf *port_config, struct rte_event_eth_rx_adapter_params *rxa_params) Will be deprecated. The applications that are currently using rte_event_eth_rx_adapter_create_e= xt() or rte_event_eth_rx_adapter_create() APIs for creating Rx adapter can = pass NULL argument for the Newly added argument which will behave same as before. Let me know your comments for this change. Patchwork link: https://patches.dpdk.org/project/dpdk/patch/20230801094004.51939-1-s.v.naga= .harish.k@intel.com/ -Harish --_000_DM6PR11MB3868D616108C66842DB96EFCA10AADM6PR11MB3868namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable

Hi all,

 

The API “rte_event_eth_rx_adapter_create_with_= params()” is an extension to rte_event_eth_rx_adapter_create() with a= dditional adapter configuration params structure.

There is no equivalent API existing today for “= ;rte_event_eth_rx_adapter_create_ext()” API. We may need to have one = more adapter create API for this.

That makes so many Adapter create APIs and will be c= onfusing for the user.

 

   I am proposing the following changes to= the Rx adapter create APIs which will consolidate the create APIs to 2 in = number with all possible combinations.

 

Current RX Adapter cr= eate APIs

 Proposed changes

 int rte_event_eth_rx_adapter_create_ext(uint8_= t id, uint8_t dev_id,

              &nb= sp;     rte_event_eth_rx_adapter_conf_cb conf_cb,<= /o:p>

              &nb= sp;     void *conf_arg)

 int rte_event_eth_rx_adapter_create_ext(uint8_= t id, uint8_t dev_id,

             = ;     rte_event_eth_rx_adapter_conf_cb conf_cb,

             = ;     void *conf_arg,

         &nb= sp;        struct rte_event_eth_rx_adapter_params *r= xa_params)

 int rte_event_eth_rx_adapter_create(uint8_t id= , uint8_t dev_id,

              &nb= sp;     struct rte_event_port_conf *port_config)

 int rte_event_eth_rx_adapter_create(uint8_t id= , uint8_t dev_id,

             = ;      struct rte_event_port_conf *port_config,

         &nb= sp;         struct rte_event_eth_rx_adapter_par= ams *rxa_params)

 int rte_event_eth_rx_adapter_create_with_param= s(uint8_t id, uint8_t dev_id,

             = ;       struct rte_event_port_conf *port_conf= ig,

             = ;       struct rte_event_eth_rx_adapter_param= s *rxa_params)

        &nbs= p;            Will b= e deprecated.

 

The applications that are currently using rte_event_= eth_rx_adapter_create_ext() or rte_event_eth_rx_adapter_create() APIs for c= reating Rx adapter can pass NULL argument for the

Newly added argument which will behave same as befor= e.

 

Let me know your comments for this change.

 

Patchwork link:

https://patches.dpd= k.org/project/dpdk/patch/20230801094004.51939-1-s.v.naga.harish.k@intel.com= /

 

-Harish

--_000_DM6PR11MB3868D616108C66842DB96EFCA10AADM6PR11MB3868namp_--