From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BAEDA0C45; Wed, 22 Sep 2021 17:39:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8F1B411FD; Wed, 22 Sep 2021 17:39:51 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id C69E7411EC for ; Wed, 22 Sep 2021 17:39:49 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10115"; a="287293620" X-IronPort-AV: E=Sophos;i="5.85,314,1624345200"; d="scan'208";a="287293620" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2021 08:39:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,314,1624345200"; d="scan'208";a="518626670" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga001.jf.intel.com with ESMTP; 22 Sep 2021 08:39:48 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 22 Sep 2021 08:39:48 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 22 Sep 2021 08:39:47 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 22 Sep 2021 08:39:47 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.171) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 22 Sep 2021 08:39:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D/qkecXbWm2XV9O6lkqfXhKkSFsYiDkcKSiyt5oAcaqEKnRKBNTEikl8y95/TdeHU6qOW+TktkTkZawBV76mG67r4EqZXZy1p2rQzOLiwuQEvBUKoB7NxTPiQkP2o2k7uXoqy3HJZB3qkkkYhi64GJd0MOvNSZL7o9MzW0ezbcGXSGWBZm74Xw5QMCvSekc0lf1p+NU8W2uLXia89mZcZaiggXb2ENNMeEdHbkTLmyN+WZV7HDt95fVlGOpEYQcPNJzWncKm/3I8A9FHglPdQ8sNOUR0froXRE67BNbH8lNciwSjQ01BGt0p+jzgKvUm4k8P5yZfEaB6gem5nn017g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=H4ZY9RVN8RIwsw2MmbdjuoQq1UJXV4SwnAfcmtF5ehI=; b=WfLp/KZ4KUtqN/XZ0ttwimqc4Z7V0lOwAKusbmgDIJqd5BYuIDfQkO1mOBT1QHgyl54sQCJZwXq44pynSH9/UQ7gmkLAus+ZUc1RfGy3kdVm+/xE/8ArRhlksGHO6HdbhiUDvT1LXAM9Y+i7cTlFppK7QD7Y4CtTCmzjWfrw1sFsqwI1kQSEC7LgKZmqScTU9fmF11Xi6s5069PgShjF3N+I1yyxVn9KE6cjb3xmQbRIfYKHWg3btVoYfoGcoA2pxZw+UoQ+IYaLrtgpCpXwMcVqey6Z1kzfjFokS7YhVAPfaJcRJ6Q1Tb6rwz/DEtDv5W5Irq3K0vCNzfRYTXzC4Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=H4ZY9RVN8RIwsw2MmbdjuoQq1UJXV4SwnAfcmtF5ehI=; b=TTz7ApVkdeFxdLiZfMQ0okGIN88z1v/h+n2bjTH31ku8EibCmU7hQCbzkAq3NzJrmnI4s7wXQhCMbDavNScT4AxU9A1zreRmzzUNeuHsZDf8SbX78dsNnTtgTDEbshanVbwfWx0Fo3xFehi1yOL2huhHct0Fm1CLKiXN1J0MZEk= Received: from DM6PR11MB3868.namprd11.prod.outlook.com (2603:10b6:5:19f::13) by DM6PR11MB4156.namprd11.prod.outlook.com (2603:10b6:5:192::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Wed, 22 Sep 2021 15:39:46 +0000 Received: from DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::a4b7:7005:e8:ac15]) by DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::a4b7:7005:e8:ac15%5]) with mapi id 15.20.4523.019; Wed, 22 Sep 2021 15:39:46 +0000 From: "Naga Harish K, S V" To: Pavan Nikhilesh Bhagavatula , "Jerin Jacob Kollanukkaran" , "Jayatheerthan, Jay" CC: "dev@dpdk.org" Thread-Topic: [EXT] [dpdk-dev] [PATCH v2 3/5] eventdev/rx_adapter:add per queue event buffer configure support Thread-Index: AQHXrsooKMY7XsOT0kyZMJlaEnlYYKuu8bpAgAFAHMA= Date: Wed, 22 Sep 2021 15:39:46 +0000 Message-ID: References: <20210918131140.3543317-1-s.v.naga.harish.k@intel.com> <20210921092146.1778421-1-s.v.naga.harish.k@intel.com> <20210921092146.1778421-3-s.v.naga.harish.k@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69003f2a-4d78-4a56-ac65-08d97ddf34b5 x-ms-traffictypediagnostic: DM6PR11MB4156: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:747; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iwicXk6AYh/jayLU+IxsHyXbp5fZMYMBBtDpxNyvlMkMgXQczK4dlwBK4RtcaEcqUIWz4KnJZNUtA7v5ko6TwRmLqUlhMCTu2PY1y7KiZlCNA1UhnydBHnGkfG0UI/n8uMFcKvfn5w40zzrtx8c5fEeLt1KJRyb6qknZIXeVDCZ0W1zr0mniGHUVDQ6nWl3O3SPVFMhDQtWRTVd5hW4eLIdK5WLFwMKK3Ssq7jfY5c/usROyKHzKr0Olw49BUI8pye/lxnOw4BBMjRQFWwUDwO30u6zqIf+84FapZfLBdyADoyRrL6hWM03SI31LADANA4FlML67ZMXawnotNrTAr11h0nwlYCKLX9bnvNXLVXF2LjeRT0Rl5TGav2honXWMWnE3C6UWb7gQlmEO2eIcW9g804LXqgz5AbbCHRLwqloYpRFK5dCKxdkBBKSfnEccqHhvo0K/fUmhxnrIcmS7G/u3vyc92S2GpcjuEBTD4SmkPVakk6lI7w3q/MjjUnS4OpGvosMB3sk8wtq3OytwK+4dUedEJ5Dvh39iWLdbKMVRCZ7dLgHDekjFfVOngnkbqEVPqmQc9sqFj6NW4630hBctP+Rb2l3mvYrworvjeZrU716PaxvLJlPbMLxPlbJ+cT4amL9Qw4fjZUhAJemFfTvE6JjbvD3qdgc9B2kL2SMdqaT/93Z8r3S2nBN7lIq1xqPlUL7kfdK6gzWDmWSCng== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(6636002)(55236004)(5660300002)(508600001)(2906002)(52536014)(186003)(66556008)(9686003)(6506007)(64756008)(122000001)(66476007)(7696005)(38100700002)(83380400001)(71200400001)(110136005)(8936002)(66446008)(86362001)(53546011)(66946007)(26005)(316002)(4326008)(76116006)(8676002)(55016002)(38070700005)(33656002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RqRNLWTjQ5U3VpDFdmsjN5j0S8B0L2ExX4wxhCFbZXpwncHhuTFLMDwE5QVy?= =?us-ascii?Q?/ANuT6//4BiVa+ll5TQ1g4Ch9EIXfT/723Y4Kr/ygz8Ckr3CjhDHCu4ukepw?= =?us-ascii?Q?+qFGz7ukLz0xwK+21kg583M2vMpQ8I8h03UV4f55fvOfYjrsA/ujfTSSELfc?= =?us-ascii?Q?YgMMONT4Wa0VeTL5SrjkXphpFq7J9Oq6KhuuWnosEsEEvfc2ZYFPgaF/q8S2?= =?us-ascii?Q?lxRMfqoi1yd3t6Xdwmk6vtgsslkKTi2UXaVhxI8FKvDPKrkzFwEN2jDG+Ose?= =?us-ascii?Q?hFMawJ69IYfs92BOzCJhp84i2tvipZVP3uryqJGMv39WK4Oll9wb5BIj7yFO?= =?us-ascii?Q?4RLMWWStWVEseV/CykrUhRae7HuWeyNMysQoQGiiq4sMGQY0xMQr3+316yb8?= =?us-ascii?Q?UinZNAzhQijMY4HhWiPnXeHJtGXTC9mdjIKPkznoG0a+rHxXhshExGyKsBW1?= =?us-ascii?Q?HPozs8siGw19/MpEtBtyoR54BHW+2QvbEWXzOv6oplrKl7MnQ46n7d53JWGF?= =?us-ascii?Q?Y27DVNBm1xauz8xG34rkHPu4O/7eiAohBCMc92pKZCVLCWCQRaA+++miCVOt?= =?us-ascii?Q?Lc/yLTLn4W9R0dfsm9YIb/jIDsFnVxoWpLlftpi2k8XIQnxMozSy09t29WwY?= =?us-ascii?Q?Wd6niaRdDhFxButTttRmWXadsjRNI8thrpryooS5ujatQED64qXBYP8k3leX?= =?us-ascii?Q?+kcrOZnpOsB0zY1boxjIUkRLeMnrAUypKAH8E8AfET9SdmYcQrBsfKPyVELV?= =?us-ascii?Q?dubdIJ06iFxYETW15CqDwxLXsVGFQldZ+m7/eAmcqdhok6mQnXszYodWtVWs?= =?us-ascii?Q?Gcl9a1mRXevGoju/9ZJb1WcFf4RTKtCRv5XwNXuq/tRJ4+XDpFMBcNZzw4lH?= =?us-ascii?Q?dljzIzxuNK7QY0pFlT5ckGVwuBMAKNBrLzjRHB5weN0+2Ttoi0931EhezeqX?= =?us-ascii?Q?U50sUyRCMpRUhU96Z4ajyyrqxAyiSE5fN5+uVuCGR1+HZfeSZUjA1hBLHuxI?= =?us-ascii?Q?s5LyNantbFuw43RBiNmytKl/yJHI6gkWVl4HRNNYn/IjojIvzvzvfSDlOxBq?= =?us-ascii?Q?r1y8rDZ2DWnodBHXdnk7PUJjOtrGQ0x08srwpQVda6HO8DFBRGJ/1iIfExX6?= =?us-ascii?Q?D9F6sWW7kL2o7l9tnL0DJcaJkZ2zgs9x4EfO6zbbM/56Bf0fce2x7nztOE1c?= =?us-ascii?Q?jveOiyA5Prq0VIJZmBRjCCwpGxOl0WdOjyadoxXOhZitB/uV8hdtu8ogTW2z?= =?us-ascii?Q?xnvnnPKU38AnX7igq6Q0aLhAv5h7kzcdNzrFPnEZNffb1FIJmzf0cTNBqIBR?= =?us-ascii?Q?D0f83eztVeb2KeeFYjYaC4Fn?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69003f2a-4d78-4a56-ac65-08d97ddf34b5 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 15:39:46.3856 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Iz8pTLIT3fbxnxD0A/Gl0AVLWRSDKquRk+F1Vj+/AL1dddziNPz4TU88E/tdsTY+GYm+VdiamS0Rq4BUuiAQiMGk9MHxnB05B59I+h2MW/s= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4156 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] [PATCH v2 3/5] eventdev/rx_adapter:add per queue event buffer configure support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, September 22, 2021 2:02 AM > To: Naga Harish K, S V ; Jerin Jacob > Kollanukkaran ; Jayatheerthan, Jay > > Cc: dev@dpdk.org > Subject: RE: [EXT] [dpdk-dev] [PATCH v2 3/5] eventdev/rx_adapter:add per > queue event buffer configure support >=20 >=20 >=20 > >-----Original Message----- > >From: dev On Behalf Of Naga Harish K S V > >Sent: Tuesday, September 21, 2021 2:52 PM > >To: Jerin Jacob Kollanukkaran ; > >jay.jayatheerthan@intel.com > >Cc: dev@dpdk.org > >Subject: [EXT] [dpdk-dev] [PATCH v2 3/5] eventdev/rx_adapter:add per > >queue event buffer configure support > > > >External Email > > > >---------------------------------------------------------------------- > >To configure per queue event buffer size, applications sets > >``rte_event_eth_rx_adapter_params::use_queue_event_buf`` flag as true > >and is passed to ``rte_event_eth_rx_adapter_create_with_params`` > >api. > > > >The per queue event buffer size is populated in > >``rte_event_eth_rx_adapter_queue_conf::event_buf_size`` and passed to > >``rte_event_eth_rx_adapter_queue_add`` api. > > > >Signed-off-by: Naga Harish K S V > >--- > > .../prog_guide/event_ethernet_rx_adapter.rst | 19 ++++++++++++--- > >---- > > lib/eventdev/rte_event_eth_rx_adapter.h | 4 ++++ > > 2 files changed, 16 insertions(+), 7 deletions(-) > > > >diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > >b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > >index dd753613bd..333e6f8192 100644 > >--- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > >+++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > >@@ -62,12 +62,14 @@ service function and needs to create an event port > >for it. The callback is expected to fill the ``struct > >rte_event_eth_rx_adapter_conf structure`` passed to it. > > > >-If the application desires to control the event buffer size, it can > >use the -``rte_event_eth_rx_adapter_create_with_params()`` api. The > >event buffer size is -specified using ``struct > >rte_event_eth_rx_adapter_params::event_buf_size``. > >-The function is passed the event device to be associated with the > >adapter -and port configuration for the adapter to setup an event port > >if the -adapter needs to use a service function. > >+If the application desires to control the event buffer size at adapter > >level, > >+it can use the ``rte_event_eth_rx_adapter_create_with_params()`` > >api. The event > >+buffer size is specified using ``struct > >rte_event_eth_rx_adapter_params:: > >+event_buf_size``. To configure the event buffer size at queue level, > >the boolean > >+flag ``struct > >rte_event_eth_rx_adapter_params::use_queue_event_buf`` need to be > >+set to true. The function is passed the event device to be associated > >with > >+the adapter and port configuration for the adapter to setup an event > >port > >+if the adapter needs to use a service function. > > > > Adding Rx Queues to the Adapter Instance > >~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >@@ -79,7 +81,9 @@ parameter. Event information for packets from this Rx > >queue is encoded in the ``ev`` field of ``struct > >rte_event_eth_rx_adapter_queue_conf``. The servicing_weight member > of > >the struct rte_event_eth_rx_adapter_queue_conf > > is the relative polling frequency of the Rx queue and is applicable > >when the -adapter uses a service core function. > >+adapter uses a service core function. The applications can configure > >queue > >+event buffer size in ``struct > >rte_event_eth_rx_adapter_queue_conf::event_buf_size`` > >+parameter. > > > > .. code-block:: c > > > >@@ -90,6 +94,7 @@ adapter uses a service core function. > > queue_config.rx_queue_flags =3D 0; > > queue_config.ev =3D ev; > > queue_config.servicing_weight =3D 1; > >+ queue_config.event_buf_size =3D 1024; >=20 > Wasn't this set to 6 * BURST_SIZE in the previous patch? Application may choose to use any value for the event buffer size. That is the purpose of this change, to change event buffer size as per Application requirements. >=20 > > > > err =3D rte_event_eth_rx_adapter_queue_add(id, > > eth_dev_id, diff --git > >a/lib/eventdev/rte_event_eth_rx_adapter.h > >b/lib/eventdev/rte_event_eth_rx_adapter.h > >index a7881097b4..b9f0563244 100644 > >--- a/lib/eventdev/rte_event_eth_rx_adapter.h > >+++ b/lib/eventdev/rte_event_eth_rx_adapter.h > >@@ -199,6 +199,8 @@ struct rte_event_eth_rx_adapter_queue_conf { > > * Valid when > >RTE_EVENT_ETH_RX_ADAPTER_QUEUE_EVENT_VECTOR flag is set in > > * @see > >rte_event_eth_rx_adapter_queue_conf::rx_queue_flags. > > */ > >+ uint16_t event_buf_size; > >+ /**< event buffer size for this queue */ > > }; > > > > /** > >@@ -265,6 +267,8 @@ struct rte_event_eth_rx_adapter_params { > > /**< size of event buffer for the adapter. > > * the size is aligned to BATCH_SIZE and added (2 * BATCH_SIZE) > > */ > >+ bool use_queue_event_buf; > >+ /**< flag to indicate that event buffer is separate for each > >queue */ > > }; > > > > /** > >-- > >2.25.1