From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22364A00C5; Mon, 19 Dec 2022 06:45:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF5E140698; Mon, 19 Dec 2022 06:45:23 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id A297A40695 for ; Mon, 19 Dec 2022 06:45:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671428721; x=1702964721; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=v8BjKEhcbwRmxm6amIjlJCEAS6mhVJ8bd4ItfbjhRDw=; b=gV1v98Frk2aMQJmj2kQBjsmlJ9LgnWAqwBacshoo7dnqmHTLwxpbgRBF lkFU9BKjJdI+ynp+qWvyHAURCm2ionlaIo4ftkhhUWSR27Bs8l2Fu2j61 g7O2xlmlxFVBw/HhmfNpZhMrbV4PgjrYPidOHYS0uRVxGCjKI6zWzwM5Q x+TSRSIVdo8RVPE14kH2RHLo4UMwHSHf6FNayALkRxNGtDH36wfAfpgRB fJ0DNyy19YrQjDMCf9Kkzclu94cR/IhYNNpAd3nQfzbBUmN+6zCceLZND CaT5yzUWGNMS3UiqihjRhE9M8n0kOy3+yjWOiPx95RihCfLBrjZCPLc1y Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="383620127" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="383620127" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Dec 2022 21:45:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10565"; a="739211727" X-IronPort-AV: E=Sophos;i="5.96,255,1665471600"; d="scan'208";a="739211727" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by FMSMGA003.fm.intel.com with ESMTP; 18 Dec 2022 21:45:20 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 21:45:20 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 18 Dec 2022 21:45:19 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 18 Dec 2022 21:45:19 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.46) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 18 Dec 2022 21:45:19 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gMxI6xafFRiD/8oxFgU2aZR+zl70mwm1vmis+zA+wqckTJNEQCpH6Ia0U+04m0gjxZ4VYgbbKqlfgPY05Lw6kRCesIlUrp46uvq7g08ioN8uj0xcuzxEjUlG4IBx/ChSf3r6/GU6DnHTWnK+LnoaTHi1wtfmL6t1HrzA2S3dsZXrgz1bItWjtLY9RWZXfhGeAT/ojpX0ELNp5OJWzKP43DU5rseNGpwi6GgkJ0wPzZLz3oi/KNE0SAWvcfkjL//PLXsoK0F6hcU+9lmwnRdmgHCKDYpEOsvnVQafJrU+u2hfqc9OUFUwiml7WGYk+iRMx4L+es47MjQAUWCswFqpDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ad606SkaDVaF9OMRN0MXTC3cKTv30bR6RI36jvHGIAg=; b=IRhIAozcVxS2bQuV3TSelZDnjoQueCc46WHqfyivKoAlzr7AsBD6La0QI88+deODWY6F/8aby5BMwemvlVVwMcFoucNB+cdGfu4Xu+/0mRkNMsIbAceVaUu85YGV071RTEeC9EfxL1y5NMHEFlT5ev0/JzUSrU0kNqWykQJtrOCGre/Afn3a4A65ZPRnKWYfX6pGgIg2uJxsBO5O6dwK2tLtWkx36HZnTQ/7r12xrfiUQbGz141zY8N+VDhllzeTBMD3eKtzL/aFTBh7SRGbCffVLx5n46ejnOZTiMUZdCiTWseqC2zc5X7fql2E2fM0nPQLbdRIgaDTGg/DMziteA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3868.namprd11.prod.outlook.com (2603:10b6:5:19f::13) by CY5PR11MB6307.namprd11.prod.outlook.com (2603:10b6:930:21::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16; Mon, 19 Dec 2022 05:45:12 +0000 Received: from DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::ab8e:89f1:e2a4:583c]) by DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::ab8e:89f1:e2a4:583c%5]) with mapi id 15.20.5924.016; Mon, 19 Dec 2022 05:45:11 +0000 From: "Naga Harish K, S V" To: "Gujjar, Abhinandan S" , "jerinj@marvell.com" , "Carrillo, Erik G" CC: "dev@dpdk.org" , "Jayatheerthan, Jay" Subject: RE: [PATCH v2 3/4] eventdev/crypto: change eventdev reconfig logic Thread-Topic: [PATCH v2 3/4] eventdev/crypto: change eventdev reconfig logic Thread-Index: AQHZD4pipCWasrUMR0e07l8BxHKEea50mloggAAgGMA= Date: Mon, 19 Dec 2022 05:45:11 +0000 Message-ID: References: <20221214055551.913821-4-s.v.naga.harish.k@intel.com> <20221214070440.921488-1-s.v.naga.harish.k@intel.com> <20221214070440.921488-3-s.v.naga.harish.k@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3868:EE_|CY5PR11MB6307:EE_ x-ms-office365-filtering-correlation-id: 89307825-33fc-4027-0aa1-08dae1843201 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: F3C2IWwlolCuI87XCJMTzxPdZeocABTRMG5Kl+ZPSZQ84hLbUEublTBjvoZXQfVsaKaNuweUvDCOBZWSeBb2G2cRfStKPnzAQyzWF+RIWWrP29fBk6NIA6OZYfV/QHGiWETfLKplm4HVC2uaRBpACNEQPqzHLfIGrSFd7WripPLGgN9gYJ4F76KVkq1zoiFnM73nxJATjWnYOR+mf1MKgdtPz0BsbjAWF2amn6wF0734jEY+sYp6aiStjQahTbgssRt836i5vKVL7xQZlrYwNcNgc/b8j4e56/3SNtYMrVGKNggYz6tf7axhGh/cOy6ihKKCLWFirEwry+7tBpogzQBB1fG47x+iUi7jgAf8P1NQ4wgHm7uC2h1CTQceilbzP3NowMep6DpeEpAQYMdI2BwWroRKZbQb1SgdhBTzH5Tjdo9AXQl7VdRYEMsDy4jsPREgiwAYVX3jheUdPIzgVnCDozKA29w9RpeEZwNslqernwVsf+qi1gUQJdWMeSFKSJVjvSVIOyDlIeCvEBCY06+4x0AmmHA9CyopxuyNa9Li3vcIEJ5xxJD5FW7QKEMkU4ZMYUgCYesfc/ORAPHoOdYVfmS6DyMhJ/cPHVgKLCLcKbXiHbCQN+wzFZCs+kOTlitsnxgh2ozmYddOjR36n1zD3d3ToMVrx+fpGiO7utWlDdO7nwg1UoSy5XJ5anZbpYIXqu2UBGjUBxoIGQnyEw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(366004)(376002)(136003)(39860400002)(451199015)(55016003)(33656002)(4326008)(66946007)(8676002)(64756008)(66446008)(66556008)(76116006)(83380400001)(66476007)(5660300002)(52536014)(8936002)(53546011)(7696005)(6506007)(71200400001)(107886003)(478600001)(54906003)(6636002)(110136005)(316002)(186003)(9686003)(26005)(41300700001)(82960400001)(86362001)(38070700005)(2906002)(122000001)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bcV5no05vltwiR+dnkqTcDz294D7VbFm9QAixnnMiT7t381auka4zhJfnkEo?= =?us-ascii?Q?RnrraON7LG01K3OJWS9Adr+DgQBzqiGBIDFo7QQZXv5PSYjR++sTtMiqmCWz?= =?us-ascii?Q?9UJcBpG+q50wsKQoIzbUAUlL2J0dWd1fMtNMfGHMApEWo+/a4eRwCQHkFejU?= =?us-ascii?Q?1dHqyN2L88/nOm4WMNKBYXxlCSvonbbppo+w/m4nmPXGjzsErjFEQfmrcHF4?= =?us-ascii?Q?Q51hxKWrxY7Js9MN9dw/Me33aYKYF7pQeuoEm49RqWbxP2mP7A2xmR6Yd5qG?= =?us-ascii?Q?t8SnGTOWWmTu4oS8H9CLgLWGcJKRJqDXVFivQdZvu/NIlr7Azh57V5D6GcrJ?= =?us-ascii?Q?UvYewr4RQSejAMctBPtK7wkLBXi4NbWASPHoh3MvTllklSb5qfRZB/SDvVcM?= =?us-ascii?Q?0QVNd+2fjo0IQgyabd7jS8KI7jiM6EWwxxL78X9uL1u7Uo6y6cTNf8toW51i?= =?us-ascii?Q?fPfaIIvjwEzS2BDUyfvv4MIjJugzE8VJ0Fo+z/88r1LmqFJ6FVaEREviSFMp?= =?us-ascii?Q?JIE/H0xA78Egel16fS368duyuv4gIgeMtoAWovrp4ghQvvsgoV4zKUrm6zkj?= =?us-ascii?Q?LsT1e1wV5oOAIpz48+3zqEdkkx1oy6R0xCtEMbGv3cC6kiWvhWhKOIwhTSTJ?= =?us-ascii?Q?pkpDxPRRp7nhlvFVkvz7kHU3OgcGrfC+xW6u07uA3D//0QsIR8Ft/pq5+0y4?= =?us-ascii?Q?p7YF1nV/tSCtaCwK1Qi+23KPAjb9olaEjjT8JTiXZHIrJTKzkHXuU4P7PenN?= =?us-ascii?Q?/iSoyjtQA03V0ujQtNzXwuJ1f7/IwDC073SpDuqzP+3eEJVm7ZTqt7VpKWrb?= =?us-ascii?Q?Plj4XMjRDZjfV2o+DF0yvmVTQMy7Bq20x9wg5V11fbkut66pHFiDpZmLpLAq?= =?us-ascii?Q?h2lO7mvzvKFuEIuv6qWiKWNsV/2hzy+ElkFNiJ/XkKqezMbyCGGr/RdnbSGV?= =?us-ascii?Q?awrZFtDD/RxMRMuCNQZuVxDM+/4bqB4E05lB4EXfaJYMfZI4FnBg63a3Yp92?= =?us-ascii?Q?UvAHdD/97OQv+kQjpjZntJ21IBdgJfSTNFXcJd2U0th9s/XE3SNqjTfVmzSw?= =?us-ascii?Q?vqtKabMJpfJ8NvZWjXYkJH9F1DaRu7ad3ggYFZ2F+8jp9z4Lx9ob4xMxj/W3?= =?us-ascii?Q?g57JJrIi38LGAheAkdvKEvGO01Ra2bnroaS+YSutDeJxbvWRtOvTtG1l9F9X?= =?us-ascii?Q?ROtyauFaJrmybGl4n1gdXOEPFyFXMnKjuakAoigXIdicDP+JrbMDL+CcrDVW?= =?us-ascii?Q?EIDL2yEIG/lptI5hNJ0wiK8oX/gRt0xU3Ni9kwV/s7L7LNbox94roJATF6Uk?= =?us-ascii?Q?Mrr4SBksGKIe2zSUcBcoL0ovw0YBPMsQyHr3W4AW08h6QEunyWfQyaRsaWs0?= =?us-ascii?Q?+IALgpN55gFyMwzYIc0D1pMELj40zc/nb0aDfewjr7B2WjgYlsWpsEOqqieN?= =?us-ascii?Q?8Vhwczc8TzIUQ6v7CrRL/27vQUO1sXm35jhIGvPzVord1L/xshQVKASM+8Sw?= =?us-ascii?Q?kOWRa4+wP+OmtWhllH86ktI/HfAfoBeEZvTy4osC8YA0rXfY8tjld/+0Oni3?= =?us-ascii?Q?RbR2RzzJHZGsl0mUKDbzrqtGMsk7NUbnrXQCmqqCqdkOxc0LE56wgr9OBkZv?= =?us-ascii?Q?5Q=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 89307825-33fc-4027-0aa1-08dae1843201 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2022 05:45:11.6583 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aUzy/IqUAkiKuJXnZfvCGysoGPz7pEjFyncipvNd1sLgeE+iJrGqtXdj9k7iCCw2cein5XXDPCEw5PxWSeRV3OUjZ3a9WcTyNjRxwMcY24o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6307 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Gujjar, Abhinandan S > Sent: Monday, December 19, 2022 9:21 AM > To: Naga Harish K, S V ; jerinj@marvell.com; > Carrillo, Erik G > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: RE: [PATCH v2 3/4] eventdev/crypto: change eventdev reconfig log= ic >=20 >=20 >=20 > > -----Original Message----- > > From: Naga Harish K, S V > > Sent: Wednesday, December 14, 2022 12:35 PM > > To: jerinj@marvell.com; Carrillo, Erik G ; > > Gujjar, Abhinandan S > > Cc: dev@dpdk.org; Jayatheerthan, Jay > > Subject: [PATCH v2 3/4] eventdev/crypto: change eventdev reconfig > > logic > > > > When rte_event_crypto_adapter_create() is used for creating adapter > > instance, eventdev is reconfigured with additional > > ``rte_event_dev_config::nb_event_ports`` parameter. > > > > This eventdev reconfig logic is enhanced to increment the > > ``rte_event_dev_config::nb_single_link_event_port_queues`` > > parameter if the adapter event port config is of type > > ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > > > > With this change the application is no longer need to configure the > > eventdev with > > ``rte_event_dev_config::nb_single_link_event_port_queues`` > > parameter required for crypto adapter when the adapter is created > > using above mentioned api. > > > > Signed-off-by: Naga Harish K S V > > --- > > v2: > > * fix build error in documentation > > --- > > --- > > doc/guides/prog_guide/event_crypto_adapter.rst | 16 > ++++++++++++++++ > > lib/eventdev/rte_event_crypto_adapter.c | 3 +++ > > 2 files changed, 19 insertions(+) > > > > diff --git a/doc/guides/prog_guide/event_crypto_adapter.rst > > b/doc/guides/prog_guide/event_crypto_adapter.rst > > index 554df7e358..7e5dc294f2 100644 > > --- a/doc/guides/prog_guide/event_crypto_adapter.rst > > +++ b/doc/guides/prog_guide/event_crypto_adapter.rst > > @@ -159,6 +159,22 @@ which it enqueues events towards the crypto > > adapter using > > nb_events); > > } > > > > +Event device configuration for service based adapter > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > + > > +When rte_event_crypto_adapter_create() is used for creating adapter > > +instance, eventdev is reconfigured with additional > > +``rte_event_dev_config::nb_event_ports`` parameter. > > +This eventdev reconfig logic also increment the > > +``rte_event_dev_config::nb_single_link_event_port_queues`` > > +parameter if the adapter event port config is of type > > +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > > + > > +So the application is no longer need to configure the event device > > +with ``rte_event_dev_config::nb_event_ports`` and > > +``rte_event_dev_config::nb_single_link_event_port_queues`` > > +parameters required for crypto adapter when the adapter is created > > +using above mentioned api. > > > > Querying adapter capabilities > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > The same information has to be updated for > rte_event_crypto_adapter_create()'s > doxygen comments as well. Right now, you have updated the programming > guide, same updates required in .h files of all the adapters. >=20 The headers doxygen comments are updated in V3 patch set. > > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > > b/lib/eventdev/rte_event_crypto_adapter.c > > index 3c585d7b0d..5620a36dd3 100644 > > --- a/lib/eventdev/rte_event_crypto_adapter.c > > +++ b/lib/eventdev/rte_event_crypto_adapter.c > > @@ -287,6 +287,9 @@ eca_default_config_cb(uint8_t id, uint8_t dev_id, > > rte_event_dev_stop(dev_id); > > port_id =3D dev_conf.nb_event_ports; > > dev_conf.nb_event_ports +=3D 1; > > + if (port_conf->event_port_cfg & > > RTE_EVENT_PORT_CFG_SINGLE_LINK) > > + dev_conf.nb_single_link_event_port_queues +=3D 1; > > + > > ret =3D rte_event_dev_configure(dev_id, &dev_conf); > > if (ret) { > > RTE_EDEV_LOG_ERR("failed to configure event dev %u\n", > dev_id); > > -- > > 2.25.1