From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6596BA0C45; Wed, 22 Sep 2021 17:37:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48365411EC; Wed, 22 Sep 2021 17:37:25 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 02ED4411A8 for ; Wed, 22 Sep 2021 17:37:22 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10115"; a="220425687" X-IronPort-AV: E=Sophos;i="5.85,314,1624345200"; d="scan'208";a="220425687" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2021 08:37:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,314,1624345200"; d="scan'208";a="474538777" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga007.jf.intel.com with ESMTP; 22 Sep 2021 08:37:11 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 22 Sep 2021 08:37:11 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 22 Sep 2021 08:37:11 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 22 Sep 2021 08:37:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nHjS9u+KhI7sSTYFpnMa0WZguc4LCh7V6kh4o/CsSgTZKpahJkPjZMiA+oSlGY4AyfB0S6Dt78Z2gvBB6YN782iP1XOAITCc0KxfmfW6cSl1ZJ2UgZ3kNw0ZwTOc2q03j7drhfs9ibmx+NCjjOn+JXZJ/n4ZVuKZZ73aHXVQYph8GLoUw34WfGqFNytjBCFQYaJM6N+h04WPRFiCTAgKgRK91gApVaKkw3P5ej8rrs+gwFahN0NhxKb7iKmfb9snM1SkS5/pYsYKQ2fc5NiAYWuwg9bLKLTGWiDk1YJTgRJb3p8IYQqtIJ7TPLQLicj0olBgLSRbuklTZ8xthmYOSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=u2IudHfOCeR+n6QZA5XhdhuFqqfvg5ZTSvruExnnsHo=; b=cPbuf28R0sBxfSSoua1IGhSbfv30xNWeqJzafIbwejtOsD/ESOSEKhPBOFqWXYhG6ZgGEW72COiLbTBzcQxsewWSQ15+0GPlqdir6dqih4eKv/+yxqTnjdxDqXFeV4UJVbZzlLD9CYGORO6WSbFKIP2GhjAVQxHmtzSLN3JNquB+9jW4fTvjOfLdkkrJbZoRLdrw1iejU4HpiGVddHuGOO+iYGZkhRHD4KxTWsj1M8RWzlRRVqYkg39jdNvabEWJcWZ5MDofjhpUP7DwpThaEMnObp359DEvI/HXsLVuEOI2gIYgyuIfBKr0ZpJxrvXSkBTR767Bim+h/CbF2cZE9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u2IudHfOCeR+n6QZA5XhdhuFqqfvg5ZTSvruExnnsHo=; b=q4R1RRmCq4HdZrAaPstethgXXwaV8/tpytRd3Ri+NVkMXeyNoW8cIilhbUYPDE45FolZM4o8IocKUaW8d+m0BcetI60uwrBGrejpy62jUYtz7Ox536xJiTZjx+rTMAvmqCueN4gSV2zLKPqw2Fi5S6pu53UF+uk70sAWBUVyvCo= Received: from DM6PR11MB3868.namprd11.prod.outlook.com (2603:10b6:5:19f::13) by DM4PR11MB5280.namprd11.prod.outlook.com (2603:10b6:5:38b::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4544.14; Wed, 22 Sep 2021 15:37:10 +0000 Received: from DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::a4b7:7005:e8:ac15]) by DM6PR11MB3868.namprd11.prod.outlook.com ([fe80::a4b7:7005:e8:ac15%5]) with mapi id 15.20.4523.019; Wed, 22 Sep 2021 15:37:10 +0000 From: "Naga Harish K, S V" To: Pavan Nikhilesh Bhagavatula , "Jerin Jacob Kollanukkaran" , "Jayatheerthan, Jay" CC: "dev@dpdk.org" Thread-Topic: [EXT] [dpdk-dev] [PATCH v2 2/5] test/event: add unit test for event buffer size config api Thread-Index: AQHXrs2F0K+m7nnhV0K/lZEkCb5N26uu7/2AgAFBhJA= Date: Wed, 22 Sep 2021 15:37:10 +0000 Message-ID: References: <20210918131140.3543317-1-s.v.naga.harish.k@intel.com> <20210921094559.1788022-1-s.v.naga.harish.k@intel.com> <20210921094559.1788022-2-s.v.naga.harish.k@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: marvell.com; dkim=none (message not signed) header.d=none;marvell.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c4044825-1b06-456c-b0e9-08d97dded7cb x-ms-traffictypediagnostic: DM4PR11MB5280: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:121; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +DJ/9HB/OYASMSdXt8SbBXa4yNuQJ/86SBKLqRuTDNMpVSffBqQPGe94cyTZ6JJmtIuHI5QRv8aBT5kR/jURDNFMHKvowFZ33xtY/vVtGuB9dVgOVEbHSxNp6wSGywe7AR65IBtkna6NUS0cJYhwI1+hQH9XtKJQ1CQ+9F7PfJ0PIELh1nvZRf0mid7lPu0O88ZURB/z4cWSyXtux262iaTu2zbNY5y6nXGAc/2Ttl+WLxz5f3taOcSXFVjamq8a/xSGQ1w8hbBWAkmNwS+jIDeveYl2jpil1AXGjoCIXBSY6HzS3mMr7B9AGdKFrzCrZpzXPLs3d8bhVLDWAcTFhOALN6Xm5voSKCJb4ocHun/hbdsNsTPmlv61aYfW1svzpemXusjKsX5zkGBMHCGxUJPyTBnjsB6VSnnARZH5C3pZAhDi+H+L84ODdlf6gPHIAhK7H4E1MSsGXy4CrvYy7IZani7voRdI3S+GL1eZKvYMM6Yw3OK2/cKZtJQvqZMJyZkKR75mLSfP2wNHvLeTWNqMlKBNYil4Hg7rio0mLCobUZEsB0mRx2VjZ9Ild3ZMW6hTQh9OdDQZBNhTsprxp10XqxVuS5KkMAfXH+6Htctn9hcE6B//Uv9Oxou7oEDw1zPMPyIrDAHXU1UT9qeZMyrdy/gM/61wrYargkIgJxVBb9q1HvoIqAolV7+DQyIWbX0Uyi0linAXKnAO61esaQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3868.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(122000001)(86362001)(83380400001)(66476007)(66556008)(64756008)(508600001)(66446008)(8676002)(52536014)(76116006)(66946007)(6636002)(38100700002)(316002)(186003)(38070700005)(7696005)(6506007)(33656002)(110136005)(5660300002)(8936002)(55016002)(2906002)(71200400001)(4326008)(55236004)(53546011)(26005)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eTl8gTG6iI4AiD6FoLdfhwvvPcocbb9GuxjKfgpvYQHKYfqbjdIhuoDEOIc3?= =?us-ascii?Q?XuGnZCGlsr5wjDJ5QKBSk8UgTHz7LrroSOSBafM9oIrYWepAxloKpV0jGA6k?= =?us-ascii?Q?u6DWvy+4HC1qjL2kUpdCrjmZikDKmk9oNuFOukttVOGvQ7hZ//zZ0wbFkITh?= =?us-ascii?Q?8t31qUDgJdwC/Z3zFZHW6TIht62eoMfzkKVQESWk3B+oaq5LhrrnGWn+4tzK?= =?us-ascii?Q?hiiBX1vhzVDYz5GQJ3YPwrVcuYugOeQZ4a/rX22kcPZjxBL8Br5TXJ7tBY0L?= =?us-ascii?Q?eKfzcfAVgaPJRIRvA2rA19P3AbK9WzPIx7Jq4XcmODLFF4/E7kdQWXqeEZyi?= =?us-ascii?Q?4edh9r4asOkFWjxFDEq68Ps9fOkpikeUjxqOlniBWJ/bVpRWnvql6pW5D+/n?= =?us-ascii?Q?BbDSgwoq+9DHg6x84PPwRPK/5Lx9KhiH8gdEo5AFEHg6J8w9f5LPYbTzEpCf?= =?us-ascii?Q?mB5fV4PGor1MY4a+zvqcMw+WVivmjIteiOEYuQz5tOPZ7vfivKFiv8oSqFat?= =?us-ascii?Q?DhuN+EpAN67U7cNZuxl1sCsBu80hRmlNhuy//bIP9fKEdstLTgnudKs2nzK0?= =?us-ascii?Q?2ju2ptwSi+GW7a7B6cmYl063TM4M3SUI3Tk0a0gE+nNm9vsu5DQTQXetp3wc?= =?us-ascii?Q?3l7MVxs3CFXzxfIGo1qL2AcU3Gbo8HU6/GPhgbunO/kvBkzPoZySinUuwS48?= =?us-ascii?Q?Jw7WsiFStAJMGaBf70Ou4+MFWu6UFQf52kaGdLUehaoQusTZroysCJ8HrS+G?= =?us-ascii?Q?d5im3bxWC7pJC43ZIUJzKwgQwKaS+FbSogFYnWfrE0yFCRg4DS1Qh4Qf58Wv?= =?us-ascii?Q?9cCMW+nOO3Kc7Mr9TkBdccOEZSFH0Ib+hDiQWL5zIbk795Cs7KoZW10sgzDE?= =?us-ascii?Q?o3Y66Oi+2C38mgPXq6CEeDB6UeNAC8zGOgf9oP9+/BhPmgHDGNmRlztOXAYe?= =?us-ascii?Q?yjIaoMFch0XEmzWJ0pdBdF6QhFez7BM+2GkaDKvQl2IAiLVfyDcVK3TU5DT6?= =?us-ascii?Q?POFCOt+VekhdSOsxu/qM0kplxiY70Q3ofZEelfTqTdcPgABnofMm5yKwB6SN?= =?us-ascii?Q?0POkrZQcBDVE4M6zmh++tuTkZGUGPJFp/XIWp9vBo4o2Tkq3NHKECZqOnGMq?= =?us-ascii?Q?Ni67B2SKGQ96JN+LBR7ZO1tSStjr893QoofyZUFEFzXd2CgbPuaTXdNp0CHg?= =?us-ascii?Q?TRRDyelbX2eW0+QbIV8o3YXJY5+ID+t5zkf/3IWoYVW4np5d5SiBU7XHxYkd?= =?us-ascii?Q?IJeOWB8B/L4yVeX2RdbMxpSXTjHBV4ZGBKJy1GodCmEY8FsInfaGwmoJLjdc?= =?us-ascii?Q?OnzdrLzm5JpUMebrLmWHA1Tj?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3868.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c4044825-1b06-456c-b0e9-08d97dded7cb X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2021 15:37:10.5468 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: eDfaZC/40j6XBgNmDx7+KCN4yoUF3EqOO090fyx+srufkZs6A+ArWYoFQDsYm5NKCbV7t8C20eaA/L61MGxwq8y7EdYyC3EmOlmJnQYG55k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5280 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [EXT] [PATCH v2 2/5] test/event: add unit test for event buffer size config api X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Pavan Nikhilesh Bhagavatula > Sent: Wednesday, September 22, 2021 1:58 AM > To: Naga Harish K, S V ; Jerin Jacob > Kollanukkaran ; Jayatheerthan, Jay > > Cc: dev@dpdk.org > Subject: RE: [EXT] [dpdk-dev] [PATCH v2 2/5] test/event: add unit test fo= r > event buffer size config api >=20 > >this patch adds unit test for > >rte_event_eth_rx_adapter_create_with_params > >api and validate all possible input combinations. > > > >Signed-off-by: Naga Harish K S V > >--- > > app/test/test_event_eth_rx_adapter.c | 53 > >+++++++++++++++++++++++++--- > > 1 file changed, 49 insertions(+), 4 deletions(-) > > > >diff --git a/app/test/test_event_eth_rx_adapter.c > >b/app/test/test_event_eth_rx_adapter.c > >index add4d8a678..3c0f0ad7cc 100644 > >--- a/app/test/test_event_eth_rx_adapter.c > >+++ b/app/test/test_event_eth_rx_adapter.c > >@@ -428,6 +428,50 @@ adapter_create_free(void) > > return TEST_SUCCESS; > > } > > > >+static int > >+adapter_create_free_v2(void) > >+{ > >+ int err; > >+ > >+ struct rte_event_port_conf rx_p_conf =3D { > >+ .dequeue_depth =3D 8, > >+ .enqueue_depth =3D 8, > >+ .new_event_threshold =3D 1200, > >+ }; > >+ > >+ struct rte_event_eth_rx_adapter_params rxa_params =3D { > >+ .event_buf_size =3D 1024 > >+ }; > >+ > >+ err =3D > >rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > >+ TEST_DEV_ID, NULL, NULL); > >+ TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); > >+ > >+ err =3D > >rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > >+ TEST_DEV_ID, &rx_p_conf, > >&rxa_params); > >+ TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > >+ > >+ err =3D > >rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > >+ TEST_DEV_ID, &rx_p_conf, > >&rxa_params); > >+ TEST_ASSERT(err =3D=3D -EEXIST, "Expected -EEXIST %d got %d", - > >EEXIST, err); > >+ > >+ rxa_params.event_buf_size =3D 0; > >+ err =3D > >rte_event_eth_rx_adapter_create_with_params(TEST_INST_ID, > >+ TEST_DEV_ID, &rx_p_conf, > >&rxa_params); > >+ TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL got %d", err); > >+ > >+ err =3D rte_event_eth_rx_adapter_free(TEST_INST_ID); > >+ TEST_ASSERT(err =3D=3D 0, "Expected 0 got %d", err); > >+ > >+ err =3D rte_event_eth_rx_adapter_free(TEST_INST_ID); > >+ TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL %d got %d", - > >EINVAL, err); > >+ > >+ err =3D rte_event_eth_rx_adapter_free(1); > >+ TEST_ASSERT(err =3D=3D -EINVAL, "Expected -EINVAL %d got %d", - > >EINVAL, err); > >+ > >+ return TEST_SUCCESS; > >+} > >+ > > static int > > adapter_queue_add_del(void) > > { > >@@ -435,7 +479,7 @@ adapter_queue_add_del(void) > > struct rte_event ev; > > uint32_t cap; > > > >- struct rte_event_eth_rx_adapter_queue_conf queue_config; > >+ struct rte_event_eth_rx_adapter_queue_conf queue_config =3D > >{0}; > > > > err =3D rte_event_eth_rx_adapter_caps_get(TEST_DEV_ID, > >TEST_ETHDEV_ID, > > &cap); > >@@ -523,7 +567,7 @@ adapter_multi_eth_add_del(void) > > uint16_t port_index, port_index_base, drv_id =3D 0; > > char driver_name[50]; > > > >- struct rte_event_eth_rx_adapter_queue_conf queue_config; > >+ struct rte_event_eth_rx_adapter_queue_conf queue_config =3D > >{0}; > > > > ev.queue_id =3D 0; > > ev.sched_type =3D RTE_SCHED_TYPE_ATOMIC; @@ -594,7 +638,7 @@ > >adapter_intr_queue_add_del(void) > > struct rte_event ev; > > uint32_t cap; > > uint16_t eth_port; > >- struct rte_event_eth_rx_adapter_queue_conf queue_config; > >+ struct rte_event_eth_rx_adapter_queue_conf queue_config =3D > >{0}; > > > > if (!default_params.rx_intr_port_inited) > > return 0; > >@@ -687,7 +731,7 @@ adapter_start_stop(void) > > ev.sched_type =3D RTE_SCHED_TYPE_ATOMIC; > > ev.priority =3D 0; > > > >- struct rte_event_eth_rx_adapter_queue_conf queue_config; > >+ struct rte_event_eth_rx_adapter_queue_conf queue_config =3D > >{0}; > > > > queue_config.rx_queue_flags =3D 0; > > if (default_params.caps & > >@@ -753,6 +797,7 @@ static struct unit_test_suite event_eth_rx_tests =3D > >{ > > .teardown =3D testsuite_teardown, > > .unit_test_cases =3D { > > TEST_CASE_ST(NULL, NULL, adapter_create_free), > >+ TEST_CASE_ST(NULL, NULL, adapter_create_free_v2), >=20 > Please use a meaningful function name. In case of failure I don't thing "= v2" > will gave any meaning The test case name is changed with proper name in v3 of patch set. >=20 > > TEST_CASE_ST(adapter_create, adapter_free, > > adapter_queue_add_del), > > TEST_CASE_ST(adapter_create, adapter_free, > >-- > >2.25.1