From: "Zhang, AlvinX" <alvinx.zhang@intel.com>
To: "Wang, ShougangX" <shougangx.wang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC] net/i40e: refactor of hash flow
Date: Mon, 26 Oct 2020 02:05:06 +0000 [thread overview]
Message-ID: <DM6PR11MB3898260FBF79BCB3F0AAFBE89F190@DM6PR11MB3898.namprd11.prod.outlook.com> (raw)
In-Reply-To: <DM6PR11MB39786520BA891215ADC8DA67881A0@DM6PR11MB3978.namprd11.prod.outlook.com>
Thanks Shougang,
Yes, I will update them.
BR,
Alvin
> -----Original Message-----
> From: Wang, ShougangX <shougangx.wang@intel.com>
> Sent: Friday, October 23, 2020 4:43 PM
> To: Zhang, AlvinX <alvinx.zhang@intel.com>; dev@dpdk.org
> Subject: RE: [dpdk-dev] [RFC] net/i40e: refactor of hash flow
>
> Hi, Alvin
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Zhang,Alvin
> > Sent: Friday, October 23, 2020 2:56 PM
> > To: dev@dpdk.org
> > Cc: Zhang, AlvinX <alvinx.zhang@intel.com>
> > Subject: [dpdk-dev] [RFC] net/i40e: refactor of hash flow
> >
> > From: Alvin Zhang <alvinx.zhang@intel.com>
> >
> > 1. Delete original code.
> > 2. Add 2 tables(pattern RSS type matched PCTYPE, RSS type to input set).
> > 3. Parse RSS pattern and RSS type to get PCTYPE.
> > 4. Parse RSS action to get queues, RSS function and hash field.
> > 5. Create and destroy RSS filters.
> > 6. Create new files for hash flows.
> > 7. Update doc.
> >
> > Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
> > ---
> > doc/guides/nics/i40e.rst | 4 +-
> > drivers/net/i40e/i40e_ethdev.c | 840 ++++++-------------------
> > drivers/net/i40e/i40e_ethdev.h | 43 +-
> > drivers/net/i40e/i40e_flow.c | 617 +------------------
> > drivers/net/i40e/i40e_hash.c | 1315
> > ++++++++++++++++++++++++++++++++++++++++
> > drivers/net/i40e/i40e_hash.h | 34 ++
> > drivers/net/i40e/meson.build | 1 +
> > 7 files changed, 1587 insertions(+), 1267 deletions(-) create mode
> > 100644 drivers/net/i40e/i40e_hash.c create mode 100644
> > drivers/net/i40e/i40e_hash.h
> >
> <snip>
> > diff --git a/drivers/net/i40e/i40e_hash.c
> > b/drivers/net/i40e/i40e_hash.c
> <snip>
> > +#define I40E_HASH_VLAN_RSS_MASK (ETH_RSS_S_VLAN |
> > ETH_RSS_C_VLAN)
> > +#define I40E_HASH_L2_RSS_MASK (ETH_RSS_ETH |
> > ETH_RSS_L2_SRC_ONLY | \
> > + ETH_RSS_L2_SRC_ONLY)
>
> This should be ETH_RSS_L2_DST_ONLY, right?
> > +
> > +#define I40E_HASH_L23_RSS_MASK (I40E_HASH_L2_RSS_MASK |
> > \
> > + I40E_HASH_VLAN_RSS_MASK | \
> > + ETH_RSS_L3_SRC_ONLY | \
> > + ETH_RSS_L3_SRC_ONLY)
>
> ETH_RSS_L3_DST_ONLY ?
>
> > +
> > +#define I40E_HASH_L234_RSS_MASK (I40E_HASH_L23_RSS_MASK
> > | \
> > + ETH_RSS_PORT |
> > ETH_RSS_L3_SRC_ONLY | \
> > + ETH_RSS_L3_SRC_ONLY)
>
> ETH_RSS_L3_DST_ONLY ?
>
> Thanks
> Shougang
next prev parent reply other threads:[~2020-10-26 2:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 6:56 Zhang,Alvin
2020-10-23 8:42 ` Wang, ShougangX
2020-10-26 2:05 ` Zhang, AlvinX [this message]
2020-11-12 2:59 Zhang,Alvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB3898260FBF79BCB3F0AAFBE89F190@DM6PR11MB3898.namprd11.prod.outlook.com \
--to=alvinx.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=shougangx.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).