From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2A545A046B; Thu, 9 Jan 2020 15:30:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 08A571DE4F; Thu, 9 Jan 2020 15:30:18 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AB6701D40E for ; Thu, 9 Jan 2020 15:30:15 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2020 06:30:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,414,1571727600"; d="scan'208";a="254610472" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga002.fm.intel.com with ESMTP; 09 Jan 2020 06:30:14 -0800 Received: from orsmsx113.amr.corp.intel.com (10.22.240.9) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 06:30:14 -0800 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX113.amr.corp.intel.com (10.22.240.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 06:30:14 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 9 Jan 2020 06:30:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AS+2eBx8RDqF3JeCSKHL/77k2Oxk2Rb58YDnx+hc1mLo+P089K30DMqfY2DPPkd/OAguDaALLpnWDNdslo/fPQrDir3SL2xSGcfiyOFxY+JJhdpZ71FVicTr3OYEWqWviyjiuLgTTMfqdeG/AmH6vrQDa2Qge4DuOceCytrG9NJmu9ZnnT4+96WeaiOZ37+qBPiLrV4SfPMb9IOHBecF0lUxhknRUohWS68dQwhJ8yvUi0g05UL4P8MWRu/cR9vqfWSV7bbAwT8az0mUet1wtBtsDI8INLPHgK0Hdlkj6cj0XAI7XeogcGXMdgzhGYhnceAklsARJBwSSBxbEKyFfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KcvIaW1rokIMTKL25iWcaaYxbDazUeqKBmPqiGOEyHg=; b=ClRkOMIE6XKZ2MhnUocRn+/X/WTMaYB+gPBQjyYgOdzETAvZXjynnXJPHSOjYhMoZ9nYdjJlKR8iY3hKeIfqouGvCg2oDxwdQMjRSdb5zwRm8L44ChVjcaX7ZRnYxf/V9h1l3Ld+mPN5HjXqNpM5cgByniGfo3gl8ykhD/n1jmx2f7/XCwAZ/MVmytzZdNtIRDX3z2aesd8fF171uOCHbV6GIpqrkpWoJUN4Yxl3FPTnJFGaVlJtdR7vmqiW1g66BlFsVGjuCG3MwJuxzZy8xri3TLcB8IzO9amL3iHMz6rvyLEehvcTYukpUBx1afRIbb5nhIy+cLGvLIZ+GU8Gbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KcvIaW1rokIMTKL25iWcaaYxbDazUeqKBmPqiGOEyHg=; b=RKIvzHUdvCBLh/zvpwQlvDM3ZbTwJxFkDCu44Vug/dJ8KEoiKTrsmMsY8Cr4TraO3UJ42sZGr0k2+DeQqjokv+2lTXBxUQHuxJ36wjds/FCd8Debbr/6liUCfMNSGSFUQZkx7LVchKSv2ZeKOqM0ECr3HKIt7sA8pZNGmXvkQ7M= Received: from DM6PR11MB3914.namprd11.prod.outlook.com (20.176.126.24) by DM6PR11MB3035.namprd11.prod.outlook.com (20.177.218.77) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2602.10; Thu, 9 Jan 2020 14:30:09 +0000 Received: from DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26]) by DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26%6]) with mapi id 15.20.2623.011; Thu, 9 Jan 2020 14:30:09 +0000 From: "Iremonger, Bernard" To: "Zhang, Qi Z" , "dev@dpdk.org" , "Xing, Beilei" , "Doherty, Declan" CC: "Ananyev, Konstantin" , "Byrne, Stephen1" , "Zhang, Helin" Thread-Topic: [PATCH v3 6/9] net/i40e: display Flow Director packet Thread-Index: AQHVxubLSbMHfVRhnEu28nil9pPxtKfiRzSAgAAU5ACAAAOWgIAAA/EA Date: Thu, 9 Jan 2020 14:30:09 +0000 Message-ID: References: <1576577756-648-1-git-send-email-bernard.iremonger@intel.com> <1578572194-594-7-git-send-email-bernard.iremonger@intel.com> <039ED4275CED7440929022BC67E7061153E020E9@SHSMSX105.ccr.corp.intel.com> <039ED4275CED7440929022BC67E7061153E021DD@SHSMSX105.ccr.corp.intel.com> In-Reply-To: <039ED4275CED7440929022BC67E7061153E021DD@SHSMSX105.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmEyZmRlNDctM2VhMC00ZDNlLWI3ODUtMWI4ZWJkNzk4OTU1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiMVkwNFc2c2ZxRmxEXC9pVitMYTJxeTlKd1k5UlB4OXl1c0dHbHVVZE1PQ3pWRnFGdGtcL1VobEdEb0crSVlHdHRnIn0= dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernard.iremonger@intel.com; x-originating-ip: [192.198.151.185] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57dea9a3-d1f7-4521-a1be-08d795106e32 x-ms-traffictypediagnostic: DM6PR11MB3035: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-forefront-prvs: 02778BF158 x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(13464003)(189003)(199004)(4326008)(107886003)(86362001)(2906002)(8676002)(81156014)(5660300002)(498600001)(26005)(81166006)(52536014)(71200400001)(186003)(53546011)(6506007)(6636002)(110136005)(66476007)(66556008)(66446008)(66946007)(64756008)(54906003)(55016002)(33656002)(7696005)(8936002)(76116006)(9686003); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR11MB3035; H:DM6PR11MB3914.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2ca+R9Fb/yH+CoZsJFOqSoFtohCKqr1mGboEnsqFJC2KGLGoccUREkOMwIQ85lN1IMxUPHK/9hyGo5TUnyCpr0LqNq/4JpiWQbuxGi9MOB4ZlvzrhnJRrv5YzTkZ47CGsS4oGpdmqDc9/SbpDRxw6qsqSWdGZoDtPz246X7BMlXiuAoYb44PFBZB/Od0X4tf86AvXB61Z73AN6wlzz4nF/cDiOSrvJOTf8Z1ENONCSEz+7Xd1D4gxQ4ESep7pSLXNd6jJR7enf4Q66GaQo+/2TbhL0mbYwoZxxrYYHJBf0nzdawfb9gZevayt38nxRKDJdpZGgSG3rzDe0YejyWAE/547VV/YJ7H6WdtGYsfONgtAgRkoMAi/QcGD15K5WpCZR4fOwHu9yk6D/xeRgvh3Q0OhvBDEsFKa2XP2TpdBmS7wFPkuePk3kOWBhz11W+ol1382xTQV1RETG5VyD+nJMF4bMg0spmAsThfQ+a0K04VAcTzV1D7E98J9LGQx10j Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 57dea9a3-d1f7-4521-a1be-08d795106e32 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jan 2020 14:30:09.5552 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +eqN8DOuH2BoQPMUciJY81MLQ/cvqxygGo9rPQIAY0dMgQiiv/VCsyNFwQB7B3vtNfjiOJwZJ98nlYVucDOqscrUwaEN360MR7Myc6Hag48= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3035 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Qi, > > > Subject: RE: [PATCH v3 6/9] net/i40e: display Flow Director packet > > > > > > Hi Bernard: > > > > > > > -----Original Message----- > > > > From: Iremonger, Bernard > > > > Sent: Thursday, January 9, 2020 8:17 PM > > > > To: dev@dpdk.org; Xing, Beilei ; Zhang, Qi > > > > Z ; Doherty, Declan > > > > > > > > Cc: Ananyev, Konstantin ; Byrne, > > > > Stephen1 ; Zhang, Helin > > > > ; Iremonger, Bernard > > > > > > > > Subject: [PATCH v3 6/9] net/i40e: display Flow Director packet > > > > > > > > call rte_hexdump in i40e_flow_fdir_construct_pkt() in i40e_fdir.c > > > > > > > > Signed-off-by: Bernard Iremonger > > > > --- > > > > drivers/net/i40e/i40e_fdir.c | 4 +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/i40e/i40e_fdir.c > > > > b/drivers/net/i40e/i40e_fdir.c index > > > > 3fa6297..78329d2 100644 > > > > --- a/drivers/net/i40e/i40e_fdir.c > > > > +++ b/drivers/net/i40e/i40e_fdir.c > > > > @@ -21,6 +21,7 @@ > > > > #include > > > > #include > > > > #include > > > > +#include > > > > > > > > #include "i40e_logs.h" > > > > #include "base/i40e_type.h" > > > > @@ -805,6 +806,7 @@ i40e_fdir_fill_eth_ip_head(const struct > > > > rte_eth_fdir_input *fdir_input, > > > > fdir_input->flow_type); > > > > return -1; > > > > } > > > > +rte_hexdump(stdout, NULL, raw_pkt, len); > > > > > > Why we need this? Does this just for debug? > > > > Useful to see the packet constructed by this function, otherwise no > > visibility on what is happening. > > Needed for debug. >=20 > But this may flush the screen if we create 1000 rules by script and it im= pact > the rule programming performance, should this code only be called when > debug mode is enabled? Yes, probably better to call in debug mode only. Will change in v4 patchset. > > > > > > Regards > > > Qi > > > > > > > return len; > > > > } > > > > > > > > @@ -954,7 +956,7 @@ i40e_fdir_construct_pkt(struct i40e_pf *pf, > > > > &fdir_input->flow_ext.flexbytes[dst], > > > > size * sizeof(uint16_t)); > > > > } > > > > - > > > > +rte_hexdump(stdout, NULL, raw_pkt, len); > > > > return 0; > > > > } > > > > > > > > -- > > > > 2.7.4 > > > > > Regards, Bernard. =20