From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 305C0A04FA; Wed, 8 Jan 2020 10:46:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 806851D413; Wed, 8 Jan 2020 10:46:04 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 1373F1D15E for ; Wed, 8 Jan 2020 10:46:01 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jan 2020 01:46:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,409,1571727600"; d="scan'208";a="370902166" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga004.jf.intel.com with ESMTP; 08 Jan 2020 01:46:00 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Jan 2020 01:46:00 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 8 Jan 2020 01:45:58 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 8 Jan 2020 01:45:58 -0800 Received: from NAM04-CO1-obe.outbound.protection.outlook.com (104.47.45.57) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 8 Jan 2020 01:45:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h4NvCLPUqTjKDVo4PhgSXP6EgrVPmLEmK8brlNadwQx6GdKssmTxEAy5KOnz6DYpoE6nUn4lP1/6xBxpg5Ve5XUSoWnQNYjWxwsYvpIcB+Y9U3lEgzzAgBXz/YMpVq2IzLvE7jc0CqqlUmIk0DO1Xt89tOV9/6V08wdY4J6LFVVdhxBVOG14IEwkAOlnYZ3r08gzL8e9695K74GXceyGOUbmHkoYtJNQR14rbODh0qm+6W9vorYVZ6h7+GAPfVGsqXU+bmFSY1Fz+MgEHBIGH2iIZAe7DwZsZxZFsnltFdBKiSTD+jqIv3+KiwTS1uFQdi42Vgex8q7MFsYlwGz0xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pei0advuVgE1nuiwmstHix86RBEoca3T51SsGijZUmY=; b=g7pI7qD3lVlfvjVxgWIwSHi4uYiI11Q/McuWk0iOWTm3rr0VgxlyMr5hXDezZxQqFnSE9/crOIX+5Et6DpKsn/Pf2OtbfMZ0LV44cU1DwT6Pf+CQJODYubXQo1pO8dvvxU9qLY2Qzmoaq2OVgL0S2oTQi1OGm5ZviyRlDQP8mPhCLa8BfF2JkPPgD5bSHtKmPFvgkNEGwlw60mHbgWMf9YRJAe7LVzup3mzwhtVtrr58JCoWEkHU7frlm1E9jFMDM4RYWcqQm9QBFRQsOFIspedhjUyUFuQXXUpgWIq7kCRhTcm0IxM8wqb/TEFxfGcrS/eiIx8+a7EF+VRwZrjcAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Pei0advuVgE1nuiwmstHix86RBEoca3T51SsGijZUmY=; b=VFPI46Pt6vbIgYlHai3Nglwh6ttfq677FKo3OKo+lFMN+ItC2l671KbzsGXzdX8x1V8Tx52wr98vc8cYKwq3KgvCxis+kBDJCvbJOcXwcZiDDT8r9TMMrnBdh0qGjK7ekOo61TH/OArPVO2lV//8i7l5YnuslZDUK6fBTm2NNGw= Received: from DM6PR11MB3914.namprd11.prod.outlook.com (20.176.126.24) by DM6PR11MB4380.namprd11.prod.outlook.com (52.132.248.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Wed, 8 Jan 2020 09:45:54 +0000 Received: from DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26]) by DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26%6]) with mapi id 15.20.2602.016; Wed, 8 Jan 2020 09:45:54 +0000 From: "Iremonger, Bernard" To: Stephen Hemminger , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit Thread-Index: AQHVxZGHweC6yU78yEin/jjlqmHg3afghTgg Date: Wed, 8 Jan 2020 09:45:54 +0000 Message-ID: References: <20200107174056.9397-1-stephen@networkplumber.org> <20200107185942.21202-1-stephen@networkplumber.org> In-Reply-To: <20200107185942.21202-1-stephen@networkplumber.org> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWNmOWIwOTEtNWUxYy00ZjgwLWIzMjctMmEwZjNiZTBjZjE4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiR2tkS2U1cW1NWVJSOVwvTGMrK0J5dFo1OCt5NFR4TTJIMCswMDlEOWxsR01mVEVoY29XSklKeldkTmJBeTVFMTgifQ== dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernard.iremonger@intel.com; x-originating-ip: [192.198.151.176] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 19931205-48ae-4668-1eea-08d7941f8e2c x-ms-traffictypediagnostic: DM6PR11MB4380: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2089; x-forefront-prvs: 02760F0D1C x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(39860400002)(396003)(136003)(376002)(366004)(346002)(13464003)(199004)(189003)(81156014)(7696005)(6506007)(478600001)(8676002)(53546011)(52536014)(5660300002)(8936002)(81166006)(66946007)(66476007)(66446008)(76116006)(26005)(64756008)(66556008)(86362001)(110136005)(9686003)(71200400001)(186003)(2906002)(33656002)(55016002)(316002); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR11MB4380; H:DM6PR11MB3914.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 8i5fqCjNtjnNY/Wqo4n3hZpXTmnZvLQwCbaboqzMNEW6l1srMryZeOKeBm1OMAG6p7RYh8kg+rZfii0ncWQ43x3bI0AaKFWP3CSmfejChGfSXxQpdUQK1ZWp1QNt2EyZnvTT6yWgC+mYRVlzqUEYfSgOJSwbHL5LzYQNhura5FkSjE+l9mqk3mRxOi6k/9Us8+ScRWw9VMDAJ8h1VQYFMUgdiRXJPpuGY2graqJBLYlKzkWMySjTxyVI+Hb0gVLYJ2qwcKOzeZ5sXPFlZKrs/IXyyCbbMVY6J+0GCUct6//L4Nkn6N924KMMVb0rGyL+i44uZizOtlIyY7Zj6qtwavCzzyPl5A69i0fMP/RlYS1/AP3HnI8WklasnWlmDn5dPAi+MgcBkwcCR8GjlBuOxVqYMIhALlbNO2LzKCxycxGP4E9JjA/0W3eyZGpH9on2Mzwh3+9N2xQOoWDYEaV0umpX4ZKC/bMbDbSUe3xOsu3QsfCUiVYUB09GDifpJUky x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 19931205-48ae-4668-1eea-08d7941f8e2c X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2020 09:45:54.6107 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NZ19QdgRXqor300glRA0hRevjyVrhM6l63WWtgrkqlPd2+iMMYVoG99JzP/P5YA/T3qCYQCaeUMegCTzIL8tJ8mXeMU3wce3ADT+vCB5fXo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4380 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Stephen, > -----Original Message----- > From: dev On Behalf Of Stephen Hemminger > Sent: Tuesday, January 7, 2020 7:00 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH v2] testpmd: call cleanup on exit >=20 > The rte_eal_cleanup code is not exercised by testpmd which is the most > used DPDK test tool. Add a call at end of program. >=20 > This helps exercise free and close paths which can be checked with tools = like > valgrind. >=20 > Signed-off-by: Stephen Hemminger > --- > v2 - report errors >=20 > app/test-pmd/testpmd.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > b3746822366f..2eec8afda1ec 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3570,5 +3570,10 @@ main(int argc, char** argv) > return 1; > } >=20 > - return 0; > + ret =3D rte_eal_cleanup(); > + if (ret !=3D 0) > + rte_exit(EXIT_FAILURE, > + "EAL cleanup failed: %s\n", strerror(-ret)); > + > + return EXIT_SUCCESS; > } > -- > 2.20.1 This looks like a fix to me and is probably worth backporting, it should pr= obably have a fixes line. Regards, Bernard.