From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B08AA0562; Tue, 31 Mar 2020 13:03:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6B4A32BCE; Tue, 31 Mar 2020 13:03:25 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 53D5D3B5 for ; Tue, 31 Mar 2020 13:03:23 +0200 (CEST) IronPort-SDR: WIeQCZHyGh3l+4ndHLNifd4EIZNtKV8JDVhOHz0OZ/7NntHYiy4btRy8GooXksi9kxXJgxtJMU qHvTxllW80rQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2020 04:03:22 -0700 IronPort-SDR: 5L7+E2BmgRd32Q9Q18Cgh2BoxbrW9ifg8C/R9vL9IC2p9Z2d2fsM4SrKxcfgfhEF/xzT1GB0oR 6M9s81yDVMOQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,327,1580803200"; d="scan'208";a="422255428" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga005.jf.intel.com with ESMTP; 31 Mar 2020 04:03:22 -0700 Received: from ORSEDG002.ED.cps.intel.com (10.7.248.5) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 31 Mar 2020 04:03:21 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (134.134.137.101) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 31 Mar 2020 04:03:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ue/0/ThMWdGEeYmkaNkYB4MTtmfJAXHcUuv1Wh7KdvgTkQd5qXPQiTpnsrJhXDHVF8NVju5WDxrfioFMnKJQI/yE3E7YAXfDjAdulL6V+gPuRibzjRHzrl1ZKzTQka23lY7l+5viPmMV5pWehcrEtSgMfGxHAU0rcCy8YpMjvRTyBMJhiN3Cq5qqWn7k7hZ2JNVGyFuoJKmHfr6rheJbu6k9L1GET5RxvAcNbcsjcVPuC3Alpel2DWFCgHZTs00qdvF4gkhR1iEQv3g/yILweK1cfBsDgKIsw0B/XiosEWtOqMsScBz+ogQmKUqE4a/zRlLNWWKaVCd6tWX0vXkLFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QHjrNrUUBg4SPe2hWIQdfulglg7KNw6GnM0Zk5QtEYc=; b=FZuaCiCkmNuTjxLGyODEC0kTFBNVic5QpEaDVlbeuM4QdJ3SG0g1/4pOCKUracPWN6vAbzm9aafoSVQVQJKL6FWPbU4uhWELz0ftXSafUwBgvXotcPADI9QS8mWyxo+mijacY3wdRO3tbWsZfjtGzTVQHrKQoNRaWrvzDLUDJz2OSyBRDRoFzkN3a2/88dorVT04EKWDywZ0HEe7hkHIcqOTXVzR9m7w8ridZdWs/Rd1Da7CYbs4lFPAs4u68Yknwzw68p5P0vrG1TMecWqfrKGJnOjPbhf/F3ckdJ4HrMXjzVXJKx7/NZyqnLqg087QJ8Y7fJW078qglwfREaVK6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QHjrNrUUBg4SPe2hWIQdfulglg7KNw6GnM0Zk5QtEYc=; b=pXaTXOp7GqOzhXVdZIzBZlutCk3i6eBjDPR+DTEtIThiHSNVzvl0M45ReSi1MwgIBN+pCndJ0Z1g/xJz9ZFCdXGUA/TOf2/M0pLd9iWmOeky7Awegyb9lWVJoU+J9xKXdTjnggtLhwZ/870+kZ+hWsCiTth7mAVFVLzFwpFgobU= Received: from DM6PR11MB3914.namprd11.prod.outlook.com (2603:10b6:5:197::24) by DM6PR11MB3418.namprd11.prod.outlook.com (2603:10b6:5:6e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2856.19; Tue, 31 Mar 2020 11:03:19 +0000 Received: from DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::7d4f:cc97:aa95:dd3b]) by DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::7d4f:cc97:aa95:dd3b%7]) with mapi id 15.20.2856.019; Tue, 31 Mar 2020 11:03:16 +0000 From: "Iremonger, Bernard" To: Ori Kam , "dev@dpdk.org" , "Xing, Beilei" , "Zhang, Qi Z" , "Doherty, Declan" CC: "Ananyev, Konstantin" Thread-Topic: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP and AH Thread-Index: AQHWB0LuhI4wTWOj1kyrUzLcORiabKhiiDng Date: Tue, 31 Mar 2020 11:03:16 +0000 Message-ID: References: <1584535089-29499-1-git-send-email-bernard.iremonger@intel.com> <1585151755-15837-3-git-send-email-bernard.iremonger@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernard.iremonger@intel.com; x-originating-ip: [192.198.151.172] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2a4ca94b-7409-45c5-9909-08d7d5631d4f x-ms-traffictypediagnostic: DM6PR11MB3418: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-forefront-prvs: 0359162B6D x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3914.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(10019020)(346002)(376002)(396003)(366004)(136003)(39860400002)(4326008)(66476007)(64756008)(76116006)(52536014)(66946007)(81166006)(8936002)(7696005)(66556008)(478600001)(66446008)(81156014)(316002)(186003)(26005)(5660300002)(71200400001)(33656002)(6636002)(53546011)(107886003)(9686003)(2906002)(55016002)(6506007)(110136005)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E3BRKhICtO0E+qTBs+W8OabbTGETTOSZJsmbMrleEUI5MIMsfCMh4j7qSjCuwJ45CiHmuhTpbROIrBDQuv0Y/6S5tb7so6fDA7nuUFz5Og+QApSOcuwazDMCocynP2MwNKwbzlyHm4z5KFz+IyjVLzwoQr2NerfZVSb2lm2A+9KN8M4zSoLbgwdUC9vbBQJNBvXzejaj+vLmngT+P7PSe1P0Wxm6Q96QA6YbxR9LaoKH7YyQxPHy4pyecw++jwpI1N5PTsL/BBM/R9Ea+C1UQKIwQXuTrqyJmjTmhNKztSA8n0JrodkuORmvtSF5lcKpsQnx59dYV5fMxtg/QzoAJ0pD5GHAJ96pQlMT9EN12cnLCjnoHXD4Nj2dlw0fCMDEgCpzRhVBpLBCPpmEDeiVoHVPdVHJj4qfoRTlRjrjsjX35TkEcwhKfBUUS7zXj8Ex x-ms-exchange-antispam-messagedata: b0gZKm91zMGxLesO5+gj94WQ5P/mxfaI1cP5YsOhVJEoAenFafTxgu7RmfGoNhO7ROQvW1ttbZYYivzRklHGgVDcBSnWRcZgRQK9dKAeXbyitxMLg7VJO+tYXC0POjKCiY5qwzO2ndqlB4SEj6sn5A== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 2a4ca94b-7409-45c5-9909-08d7d5631d4f X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2020 11:03:16.5309 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6/HP3f19dYVGnCOojIHFtQxnZIPn/JELjA69MEMJ6Sxgj/wGonqnrKlTUx7JRmElK5US8JoQ2FZp54QigPzJ6CGPIRGJ2mC8OQA5QGRQoX0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3418 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload types ESP and AH X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ori, > -----Original Message----- > From: Ori Kam > Sent: Tuesday, March 31, 2020 10:58 AM > To: Iremonger, Bernard ; dev@dpdk.org; > Xing, Beilei ; Zhang, Qi Z ; > Doherty, Declan > Cc: Ananyev, Konstantin > Subject: RE: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload > types ESP and AH >=20 > Hi Bernard, >=20 > > -----Original Message----- > > From: dev On Behalf Of Bernard Iremonger > > Sent: Wednesday, March 25, 2020 5:56 PM > > To: dev@dpdk.org; beilei.xing@intel.com; qi.z.zhang@intel.com; > > declan.doherty@intel.com > > Cc: konstantin.ananyev@intel.com; Bernard Iremonger > > > > Subject: [dpdk-dev] [PATCH v2 2/3] app/testpmd: handle RSS offload > > types ESP and AH > > > > parse RSS offload types ESP and AH > > add printf for rss_hf > > > > Signed-off-by: Bernard Iremonger > > --- > > app/test-pmd/cmdline.c | 4 +++- > > app/test-pmd/config.c | 6 ++++++ > > 2 files changed, 9 insertions(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > a037a55..997f063 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -2338,8 +2338,10 @@ cmd_config_rss_parsed(void *parsed_result, > > i, -diag, strerror(-diag)); > > } > > } > > - if (all_updated && !use_default) > > + if (all_updated && !use_default) { > > rss_hf =3D rss_conf.rss_hf; > > + printf("rss_hf %#"PRIx64"\n", rss_hf); > > + } > > } > > > > cmdline_parse_token_string_t cmd_config_rss_port =3D diff --git > > a/app/test-pmd/config.c b/app/test-pmd/config.c index 8cf84cc..df52df9 > > 100644 > > --- a/app/test-pmd/config.c > > +++ b/app/test-pmd/config.c > > @@ -106,6 +106,12 @@ const struct rss_type_info rss_type_table[] =3D { > > { "l3-dst-only", ETH_RSS_L3_DST_ONLY }, > > { "l4-src-only", ETH_RSS_L4_SRC_ONLY }, > > { "l4-dst-only", ETH_RSS_L4_DST_ONLY }, > > + { "ipv4-esp", ETH_RSS_ESP }, > > + { "ipv6-esp", ETH_RSS_ESP }, > > + { "ipv4-udp-esp", ETH_RSS_ESP }, > > + { "ipv6-udp-esp", ETH_RSS_ESP }, > > + { "ipv4-ah", ETH_RSS_AH }, > > + { "ipv6-ah", ETH_RSS_AH }, >=20 > Why do you have all those variations since they don't have any affect. > I think it should be just like your first patch, only esp and ah. > For example the udp should look like this: > flow create 0 ingress pattern eth / end actions rss queues 0 1 end types = udp > esp end / end >=20 > Best, > Ori >=20 I thought that it might be clearer to map the patterns to the flow. I will change to esp and ah in v3 patch. Regards, Bernard.