From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2BDD8A04F9; Fri, 10 Jan 2020 10:20:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D88F71E940; Fri, 10 Jan 2020 10:20:12 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2B88E1E93D for ; Fri, 10 Jan 2020 10:20:09 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 01:20:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,415,1571727600"; d="scan'208";a="216601316" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 10 Jan 2020 01:20:09 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 10 Jan 2020 01:20:08 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 10 Jan 2020 01:20:08 -0800 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 10 Jan 2020 01:20:08 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.171) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 10 Jan 2020 01:20:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NpWzAF/glLhS7H2SVdnow/2PfuooYGDdYe3FFiI5Flg4EKWD4JCYhhl52JZXRgTaOa7jPiQo92gqCErGk88hJ/OzA1fzHsKsQoJIy+yuemlyqXGfYjHGnYKkgYQgl+jFd53mdLgsTX5qaQjNYiuy1CbmrDqO+PU11TdSU1RbWZAm1E3KwcLz55iGdDkZO/1XizhddFOMSJD66wjVUCeNF0n4YX1Wu0dE1MLpz08wpxn2uXVfAxz0EYh/WQVqnPsLcrFpMv+KOKel0XLqqoJn7JWlS6f8523HX/cRsTgrqdDOFDWqJhIVJGypuwU/aq4IbAMnY7Ov2Yc+Dtm7Hykujg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G8xa1UwMFqIkPAxmc9UQuTzZc6JxZ72ormxE4lwg5EI=; b=eRFoteyyVAiR3ekndsFwOXM4J1jRj30MrOFGl2ZJZ6yBNpB6Zsf00RmLErvGLV598oZgo/Yn0+iRJUPP4YB1HMW0xWtUlWOIn1EyLAPDdV0pzOL6OeG+nBSV1GXA3YTMZ927JKeOlkHb8ePjU8R0vEaEPxr5fuH/gjrIYKODpNqpflTZi464fQvfeRRip4aEv1wiLnRFh/FOaMbk1ar2qeMSkf8/1o8oCeK32HNpvnO7tVIpR6jYd7xt1PUICNbfKPEuRYdDYrXf2X/o048RBzn7+rbtBcwX5d6P149LLKBX+WUioAwrRoESap7DmtITgFkXzv8wFP7YQIX56yOcFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G8xa1UwMFqIkPAxmc9UQuTzZc6JxZ72ormxE4lwg5EI=; b=gztLK2jETm/SIVipKeoh6MGqSFEwp9hfypAwkFYQzq7tIzskJt4kndhFQgwqRydlyLUeq59WQhKei9bDishGiC0oYuLMmjuMBex7MXah96fkpdsuoYaP4KTIEzWs20go2h5FNIXHZrJZM2clChw0YTkU8L5HsqLHPqrJOrP44iU= Received: from DM6PR11MB3914.namprd11.prod.outlook.com (20.176.126.24) by DM6PR11MB3724.namprd11.prod.outlook.com (20.178.231.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Fri, 10 Jan 2020 09:20:03 +0000 Received: from DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26]) by DM6PR11MB3914.namprd11.prod.outlook.com ([fe80::29bf:9a8f:7bba:dd26%6]) with mapi id 15.20.2623.011; Fri, 10 Jan 2020 09:20:03 +0000 From: "Iremonger, Bernard" To: "Ananyev, Konstantin" , "Zhang, Qi Z" , "dev@dpdk.org" , "Xing, Beilei" , "Doherty, Declan" CC: "Byrne, Stephen1" , "Zhang, Helin" Thread-Topic: [PATCH v3 6/9] net/i40e: display Flow Director packet Thread-Index: AQHVxubLSbMHfVRhnEu28nil9pPxtKfiRzSAgAAU5ACAAJlcgIAAqh/Q Date: Fri, 10 Jan 2020 09:20:03 +0000 Message-ID: References: <1576577756-648-1-git-send-email-bernard.iremonger@intel.com> <1578572194-594-7-git-send-email-bernard.iremonger@intel.com> <039ED4275CED7440929022BC67E7061153E020E9@SHSMSX105.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGMwYzdiNzUtZDNkNC00MzgzLWE2ODItYjJmMjc2OTMwOTVjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRHp3R3Y3d3ArZVwvakhcL3VcLzl5U2RpMHdjYVJtQUFKYUpGMDNRNmgrUWVYZFhScnJpTCtCWkNJK3NRSjlZSlFGNiJ9 dlp-product: dlpe-windows x-ctpclassification: CTP_NT dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: spf=none (sender IP is ) smtp.mailfrom=bernard.iremonger@intel.com; x-originating-ip: [192.198.151.185] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: d4346e50-e531-4a2e-220c-08d795ae46af x-ms-traffictypediagnostic: DM6PR11MB3724: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 02788FF38E x-forefront-antispam-report: SFV:NSPM; SFS:(10019020)(366004)(136003)(376002)(346002)(396003)(39860400002)(199004)(189003)(13464003)(54906003)(110136005)(6636002)(8676002)(81156014)(86362001)(81166006)(478600001)(7696005)(26005)(71200400001)(2906002)(53546011)(6506007)(316002)(8936002)(186003)(107886003)(66446008)(64756008)(66556008)(4326008)(33656002)(52536014)(66476007)(55016002)(5660300002)(66946007)(9686003)(76116006); DIR:OUT; SFP:1102; SCL:1; SRVR:DM6PR11MB3724; H:DM6PR11MB3914.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IrHQD8ThcNBDRbpqkVO4/MTDCg8tuAmt/3bVhzMjF2dT0lHJJrY/LuD7o6N6YXgAOzejgMbZfsAB2z6vEJvKYUnNppR2QtnQMijsF1d6U18RW0lI0qYM3dNpvnys02o0B5PzI7UUYii0PLAE7KagCWezxw22rp/LZigadjkEDSIA0DmWEn+6Ob6mRV5KMu9I5slp2wM/FiAhPV4zfsDGIg49ezHjYj/JutTKjASJutzG6dtHh0Lr2/7lUHk9y6x+Enf4nY7fD03nthZCUV6enFB36Cm+/8jDbh4A00fhj7dLXmlaHX9Q9mpE/F4jgw8kfDmMSgWNq6wU+gzPfyV3SoKN6XX8xbFwkEQg9HnEwTKHc2IYsvrCYN4bEcsIjY/4a7uG9CC4nRbgRliJUdN1pOy2bjsCTUejCJtlWhYeJa+ynXffvf+E8pBAxzchLPfdSdD1E7wQnPIfkPbqmSmv08siUHo/yBWHcw3H+jzNBY4sexFgcr4gZIAkb7i1DxuT Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: d4346e50-e531-4a2e-220c-08d795ae46af X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2020 09:20:03.7376 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: //CGykXxMEJMBqw8ctDgS1KWKiK3tRLfmLWYRxqa3JLcw3/S1iJYbjWjO7iNdR6R7EFtNg4jvVwS1P5615+8CaocVbR1teteE+DO/oLakcE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3724 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 6/9] net/i40e: display Flow Director packet X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Konstantin, > -----Original Message----- > From: Ananyev, Konstantin > Sent: Thursday, January 9, 2020 11:08 PM > To: Iremonger, Bernard ; Zhang, Qi Z > ; dev@dpdk.org; Xing, Beilei > ; Doherty, Declan > Cc: Byrne, Stephen1 ; Zhang, Helin > > Subject: RE: [PATCH v3 6/9] net/i40e: display Flow Director packet >=20 >=20 >=20 > > > > > > > > call rte_hexdump in i40e_flow_fdir_construct_pkt() in i40e_fdir.c > > > > > > > > Signed-off-by: Bernard Iremonger > > > > --- > > > > drivers/net/i40e/i40e_fdir.c | 4 +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/net/i40e/i40e_fdir.c > > > > b/drivers/net/i40e/i40e_fdir.c index > > > > 3fa6297..78329d2 100644 > > > > --- a/drivers/net/i40e/i40e_fdir.c > > > > +++ b/drivers/net/i40e/i40e_fdir.c > > > > @@ -21,6 +21,7 @@ > > > > #include > > > > #include > > > > #include > > > > +#include > > > > > > > > #include "i40e_logs.h" > > > > #include "base/i40e_type.h" > > > > @@ -805,6 +806,7 @@ i40e_fdir_fill_eth_ip_head(const struct > > > > rte_eth_fdir_input *fdir_input, > > > > fdir_input->flow_type); > > > > return -1; > > > > } > > > > + rte_hexdump(stdout, NULL, raw_pkt, len); > > > > > > Why we need this? Does this just for debug? > > > > Useful to see the packet constructed by this function, otherwise no > visibility on what is happening. > > Needed for debug. >=20 > Then it probably should be called only when some debug option is enabled > (either at complie or runtime)? Responded already to Qi that I will call in debug mode in v4 patchset. I think compile time should be enough. >=20 > > > > > > > > Regards > > > Qi > > > > > > > return len; > > > > } > > > > > > > > @@ -954,7 +956,7 @@ i40e_fdir_construct_pkt(struct i40e_pf *pf, > > > > &fdir_input->flow_ext.flexbytes[dst], > > > > size * sizeof(uint16_t)); > > > > } > > > > - > > > > + rte_hexdump(stdout, NULL, raw_pkt, len); > > > > return 0; > > > > } > > > > > > > > -- > > > > 2.7.4 > > > > > Regards, Bernard.