From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B9DCA00C2; Thu, 5 Jan 2023 08:33:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 314BB400D4; Thu, 5 Jan 2023 08:33:24 +0100 (CET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id 4F71D40041; Thu, 5 Jan 2023 08:33:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672904002; x=1704440002; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=OF6ZCC0QR1WtWe3mcA16A2v5N+rQ3nWYeY/h5qYtJ1k=; b=IxIXHXVqjQkPSC6RldmzCYsmddZIDxBZmeuN8KhaQcTGKkuaszgxKtXP oQQ3TtZGAnYeyvd44voSfqfWNxjSvTAJtablT0nxVXsc91S3lwd44lfxg tzNbhL1qYcHadLVFJTAs01voYWKylvX5QBE+Gx1rOFD5jXW21ELpo3Mxj fcFo/6/t/oO9g0hAopei2Z5+5ZcUYzyjSFlKEFTnIQGEfzSAL9SvUL9dk HOJ5T1ids32GMHIfh3LlVA8seIRzaDsJNeGo6xAoZ5AhkIdsCYErbAPFS zit1IFGXjPI4mdTZ4et86KKzVZhREYS1g4gfnjFRY/SPT7q/8WfZF+e76 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="384432522" X-IronPort-AV: E=Sophos;i="5.96,302,1665471600"; d="scan'208";a="384432522" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2023 23:33:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10580"; a="984191729" X-IronPort-AV: E=Sophos;i="5.96,302,1665471600"; d="scan'208";a="984191729" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 04 Jan 2023 23:33:17 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 4 Jan 2023 23:33:16 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 4 Jan 2023 23:33:16 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 4 Jan 2023 23:33:08 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GBt6JAR6FVu7dZ66jlhxGkP/y2kjnbBXPUwiW1ctkkSsv3ULQjcYNvu4BHAwSIJRT6r+TE4T4o3f1a1JJh1p0pceFfwauyCCkTTHu8CGixP1Gz6BM93H7a4bb0PVRRk0VLhqtelehVyfb6zgb6Kho+57B2zcL2jsxNhHY46HjDD8vatLJCZFot+sxpNB4KyPxu/UK7J/Kiv880aqyxSeRZIegXHo45pF/NMpI8DpL1HWx/NTIiDRX36BylMU7t0XebDz/kx1QamhUZ7FClZcnvqesitB8GLW9vCuGpm56U++iQ3ddS/9TxPCn6PKAIgTl4o+d4biGgPoSh1yBFECUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2PC1pTi/1QEPeZUgGAPjw04nbOeHhHtObE3+aAKefCE=; b=Cabn21Is/3wbxa/8WOC9gXN2325oe9RaSxAESir8TfTcHy8KRPxlKFUd00e0XxP30uU09K0ETPOag3dQvaGeclak0kmwhKhINJQnewmytBqVAiuI8lmET/vgRCnzXr7SnFANmuI+zAivtpjEm+sbQqNPKNkm6VRKNU3NE/eXCvEBYOoC18a1ZfGsid7K/I+LiuiCTPwoIsCMppYwTOJ3G1XpVIXdVP882+28Fg5e9P6TLK5lCgDImN+JvXBobxvlGObnhJwKJt23my+Kpk1HfRvqy2ZnyV4JMrt1UoX3eYS/TL4IIdS72jfxYokJurHYB74EP04Vy/CG7i+D9u6X3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3946.namprd11.prod.outlook.com (2603:10b6:5:19d::13) by PH7PR11MB6833.namprd11.prod.outlook.com (2603:10b6:510:1ec::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Thu, 5 Jan 2023 07:33:06 +0000 Received: from DM6PR11MB3946.namprd11.prod.outlook.com ([fe80::4aa8:cc71:3dea:699a]) by DM6PR11MB3946.namprd11.prod.outlook.com ([fe80::4aa8:cc71:3dea:699a%3]) with mapi id 15.20.5944.019; Thu, 5 Jan 2023 07:33:06 +0000 From: "He, ShiyangX" To: =?iso-8859-1?Q?Morten_Br=F8rup?= , "dev@dpdk.org" CC: "Zhou, YidingX" , "stable@dpdk.org" , "Yang, Qiming" , "Wu, Wenjun1" , Remy Horton Subject: RE: [PATCH] net/ixgbe: fix ixgbe firmware version get Thread-Topic: [PATCH] net/ixgbe: fix ixgbe firmware version get Thread-Index: AQHZICOB9j/c3N1LF061vYwvdpegjK6OC6IAgAETXKCAAEaJQIAACX3g Date: Thu, 5 Jan 2023 07:33:06 +0000 Message-ID: References: <20230104095142.86796-1-shiyangx.he@intel.com> <98CBD80474FA8B44BF855DF32C47DC35D87620@smartserver.smartshare.dk> <98CBD80474FA8B44BF855DF32C47DC35D87623@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87623@smartserver.smartshare.dk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB3946:EE_|PH7PR11MB6833:EE_ x-ms-office365-filtering-correlation-id: 88eec490-4a31-478b-6b05-08daeeef1621 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iSTHgzPuexUbVN55s/xo1RiovEFtvuQdQdX29hHivYuDSUKpDrIImg7IoMX8g1yyABpWMwcQqX0/LjEQw4rP987Ju51FJ0yZZP/nLk+TJOFrRAuN9HOPEOSgaAPDQOXY3wmrxFOT4kvlNEHMxS9nyW4olskp1GyO9O5kARzsDkw3s1helDzCCmlu3lv70cKsNHNWJmaIyjKI3Jtr35E1eSvkwTgjfaHdP2KWVJN28XxA/qe6lQA3bMjKfYaJ8LPi9uaGab1YrcWTXfU+GyADxzGDMRjuz3v/aUIjMmtsMA7h0Q95cL3uebAHN58lxJeeAUKk6+Ox/oKkzHo5KQTKtOysy+Ryrf84CeuKYghKRTbxaD3ksnkhUevE205P/HGHlasIlzntnGVeD8qNudZRvRTTSgylpDnbZfjlurLXuLSDmhhzWtOhPBtzAxUd1BKPhOqbnrNzOhZalviChdQxMfsWPxTxgSsYUFJZ5zT8KXjcWossdBcmPQhz542SKaBcqpNU4oEqPSqAoGbsBMDTA3L02RiZ7w00/c7RFvvl/CyzOJGL2V8d7ewJ8j/+lu8lxPVH98kOwoR01gu1SUyv1XDSEMy5IMad1wbMh3SzsvkrS2YO2LZ4/QrAJoghUBBfJazYDWtBexGKURKbLJFKvwjUEhP+NgRr7c+D4yUm+BN9hmWRbtB4czKy635W0wV1KXcZvA5/7u7ZSHopmaBJVSno7y1ux6um+B+Fcd/cWEQ= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3946.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(396003)(346002)(136003)(376002)(39860400002)(366004)(451199015)(41300700001)(122000001)(38070700005)(33656002)(82960400001)(66946007)(66556008)(8676002)(38100700002)(4326008)(54906003)(66476007)(64756008)(76116006)(8936002)(66446008)(110136005)(316002)(5660300002)(55016003)(52536014)(2906002)(186003)(6506007)(478600001)(66574015)(9686003)(26005)(83380400001)(86362001)(107886003)(71200400001)(7696005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?061p1iLTgVY/x2kwooiSWoXVKaAgA8QEDB7pxmrXcQSYjYHaz3kpSKkOg6?= =?iso-8859-1?Q?rGlOaYqJ4LfYisY7ymVU2dpVQ3F/s7tRU/X6jo3ydoFk8xqnxdzUEiPtu3?= =?iso-8859-1?Q?lAfV+8acxyFobiADUq5MtZnzaFaRTa3QaRcRVmnKWaQjevxeQh4A/uffrD?= =?iso-8859-1?Q?hvL/KcL7CsB7px8chrAO6W8IM8sfw+dqQJXYBuB22DThXCt57pNPalz+7h?= =?iso-8859-1?Q?NUon45O9pkFKzWdRXldrjoMmYHAq/rAilrLZVl3Pul4mGJs4qR1ntc21LU?= =?iso-8859-1?Q?mDcC0ZY0NlL5WaGyFQWMZAHurjfGk/32Mtj4niAgGunppKZLZo7c1fvH7V?= =?iso-8859-1?Q?GcoZdEKj7WDUlXpbJQ2XlwjnmC9XxibHivLowpV6lwVYeeQigLS8wgsZCz?= =?iso-8859-1?Q?EE6LPdqcIyTZPvb0ZdyDGRkNN5c1Xd0c8xvlEIRwDD/Hhal3l5zIa9SPMC?= =?iso-8859-1?Q?AS3jRdLHiMPOZiFBqMlTju2JtNg/Wj+uvmpclUipIf9liOT7IqmS95pv21?= =?iso-8859-1?Q?HEwwnwXtoM1RXHxd/JHoDD6CfKIMqBbtDdbBKKv5uCbEGTzDEAln3n8Lxj?= =?iso-8859-1?Q?rMsY0OVl+LO4HrTASWZR4xtdHrl3Do4WTJAp/QcSfLkUlWudan8AkibgwS?= =?iso-8859-1?Q?i1O9xF73sQ7K910jlm6Hfg6ojktGBk3/Tq0QEzL3/tKW/rCVUYbhUpE54e?= =?iso-8859-1?Q?no0Adme2cKBZBc3qErDDQbgyxTS7Qy2gtA5nJrsXxMH9TuNpwtmBCS18Qn?= =?iso-8859-1?Q?heiXwZstiYB87Q6DW/mOqPjRhFrLtPYPtEIpkMOPfeQoi/2XEkG1tglIwN?= =?iso-8859-1?Q?O/hhV9GqyvNcCrVnt4lapvFQL++qOr1gxHlTq0ciqh+lEhICmkARLIwqHZ?= =?iso-8859-1?Q?JVzxRB59tH7/rp01o1pkSHebrAoCgjyz+9TY02oXjAoIeu49ATZbzRm3p1?= =?iso-8859-1?Q?bq7M2ucxhup0sG+jOAaa1LAv9a72iWjkaPgRDzYi0+NpPd70rOUiEJYD30?= =?iso-8859-1?Q?cYd1J8wTza5k66ic9iszHOsg3PuPTwx72VkRh+DG/QEV4XrpyaxBCRqD/T?= =?iso-8859-1?Q?dqMFPcp4W61/inSbo4SA68yokl9X6X7trGPAApO4kr6vNHli+4TYZZdBkA?= =?iso-8859-1?Q?Mu5u9CGsm5SGIn8Ueb4iAtT3Mm2R7/uGteRBluiSC8cZTKmWYg14LLb2/l?= =?iso-8859-1?Q?mzZrlkJbxIcGtMvv1Iklh8d9+rZYfm6372d0zmVhGcQ08RX9dxBJyn4yUz?= =?iso-8859-1?Q?IPPk4jeCT9MXZ0fqu6gB24V5s2ecbG/gUVraQTXOIhC4k6ZWXXzFHfRXM1?= =?iso-8859-1?Q?Jt7wbMyAeL7Sr2KNuEq1wyE7iT1FIXSXoRFyFt4zy6ZafB/NT4xBC2h/ei?= =?iso-8859-1?Q?zzToBg19V/4v/g2iY/qNVAag7NpMgiwQXkSbkO1iOOJxPIHkI8ETnbJwXG?= =?iso-8859-1?Q?I+qx4FPweISLQHqB72g1gPRXBadVca6gopmrdFQCe2Z4m//giaUs7QE/eu?= =?iso-8859-1?Q?lxXE1iN7aX/MWy2wuqd3k0f4bWCBcppZN3smSP4rn3QWRLRXeNHNZKw6L5?= =?iso-8859-1?Q?Pa7vaE0VAP1LAifLeYPCrsi70KmZx8nLcwUrtnI2HhMVlV7k9Pgi+x4HVK?= =?iso-8859-1?Q?ocn1whfp0ymDWJYovK7r0ib/cMqO6yAY9w?= Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3946.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88eec490-4a31-478b-6b05-08daeeef1621 X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Jan 2023 07:33:06.1604 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5003xBpwUbdeL4adkVVQ/vStdiIr+kl255Te27UCYVV+Gv2ZERYVPdV8u6yb26UbTBO5XnrGo4kGYNW9/tpf8g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6833 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org >-----Original Message----- >From: Morten Br=F8rup >Sent: Thursday, January 5, 2023 2:57 PM >To: He, ShiyangX ; dev@dpdk.org >Cc: Zhou, YidingX ; stable@dpdk.org; Yang, Qiming >; Wu, Wenjun1 ; Remy >Horton >Subject: RE: [PATCH] net/ixgbe: fix ixgbe firmware version get > >> From: He, ShiyangX [mailto:shiyangx.he@intel.com] >> Sent: Thursday, 5 January 2023 03.52 >> >> >From: Morten Br=F8rup >> >Sent: Wednesday, January 4, 2023 6:19 PM >> > >> >> From: Shiyang He [mailto:shiyangx.he@intel.com] >> >> Sent: Wednesday, 4 January 2023 10.52 >> >> >> >> The firmware version obtained by dpdk-ethtool is inconsistent with >> >> that obtained by linux-ethtool. >> >> >> >> This commit fixes the issue. >> >> >> >> Fixes: 8b0b56574269 ("net/ixgbe: add firmware version get") >> >> Cc: stable@dpdk.org >> >> >> >> Signed-off-by: Shiyang He >> >> --- >> >> drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c >> >> b/drivers/net/ixgbe/ixgbe_ethdev.c >> >> index ae9f65b334..012096021e 100644 >> >> --- a/drivers/net/ixgbe/ixgbe_ethdev.c >> >> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c >> >> @@ -3859,7 +3859,7 @@ ixgbe_fw_version_get(struct rte_eth_dev >*dev, >> >> char *fw_version, size_t fw_size) >> >> ixgbe_read_eeprom(hw, 0x2e, &eeprom_verh); >> >> ixgbe_read_eeprom(hw, 0x2d, &eeprom_verl); >> >> >> >> - etrack_id =3D (eeprom_verh << 16) | eeprom_verl; >> >> + etrack_id =3D (eeprom_verl << 16) | eeprom_verh; >> >> ret =3D snprintf(fw_version, fw_size, "0x%08x", etrack_id); >> > >> >This looks wrong, assuming the high-word in 0x2e and the low-word in >> 0x2d. >> > >> >Perhaps the linux ethtool needs to be fixed instead? >> > >> >I don't think DPDK should aim for "bug compatibility" with Linux. :-( >> >> After following your suggestions, I read the driver source code again, >> which is implemented as the solution. I will send out V2 patch soon. > >I suppose what you are looking for is here: >https://elixir.bootlin.com/linux/v6.1.3/source/drivers/net/ethernet/intel/= ixg >be/ixgbe_common.c#L4106 Thanks so much! The next patch will refer to this method!