From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC899A04DE; Fri, 23 Oct 2020 10:43:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0732FA8E7; Fri, 23 Oct 2020 10:43:14 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 57C6CA8E5 for ; Fri, 23 Oct 2020 10:43:12 +0200 (CEST) IronPort-SDR: y6wBsFfo8uiPsDGj55L9MDAu2QeFtyZK9noIbtRgBiIan9EaugLVfo2TAA08YBghNsZwplKo5a 5C2q9phbQItw== X-IronPort-AV: E=McAfee;i="6000,8403,9782"; a="229281593" X-IronPort-AV: E=Sophos;i="5.77,407,1596524400"; d="scan'208";a="229281593" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 01:43:03 -0700 IronPort-SDR: lSvf0cNZ8dn9QbRB886yz1SkTWxJ53PJ5WOJMg8hBFchhGgP4sLGwjHitUYuSmYDtMyYUjBCsC TMo3wjYBDh1g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,407,1596524400"; d="scan'208";a="359541097" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by FMSMGA003.fm.intel.com with ESMTP; 23 Oct 2020 01:43:03 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 23 Oct 2020 01:43:01 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 23 Oct 2020 01:43:00 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 23 Oct 2020 01:43:00 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.57) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 23 Oct 2020 01:42:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VC3YDTQkcRxBpA4t4pCcyfhr/y42NmlbvSfDzofhy6Wm1EqooCbwqOdHDiHNz+pQsoxcBAXx55eMlBUfuC+Z+lGbZ7oXAI0l3jrT1n1l2Mb7gq0eGyJtKy+4O4e+XKNYNQsqLiMUzEPRaQixM17LMQA0hNz31h4zyEmRANU5bq8f2+azu4YEqgBKB7CScinDJ4yqBqIzKqQKGwiA0p2GcRjDtoY5P3xCqHjZ3oWgN3DhaXgC3h0jhTletEACBbpgELTJlvJOX7BBmB4lF1xUTe1IrAd9IQIDFRI27YbKxyLv+DA7YpUpWpRhSpWdGCyEL7cl+GhiyBKh6+3Ukd7B/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=obN5o4oxpCRSx6DW1RUerAku75rBQJWCv1kKzciHsHM=; b=ZRHKBSKS26YVg96i5Y9q3SC5sSDW92YOoJ8eEjkVZsn7glRbXyZe+M7PopCIPonyeiVkjxkEpERntarztLaOAoplVbuZ8hEXJ7PecXU+loX40uhkEEKUotcjMEOdzhJhn44LONP3vKAvF/OeMzChSHapL1+OdgZUB/n8nGNKqQtPnPNLYHbw9QmCi7YNHOx7h4zSCGzSGpt3ItrDthpV/sI/jnBWo7tH2V8M2IaUkwl05+CwEeGJ0VfcSAosrMtmnFrwTKRQ14TC/A5eTIbOVFbFy7w7SjqN6O2bd+imjfFVpwYvHq8R2lUIooPTEZpCYOYw2HVjCtgQP3AFi9NoJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=obN5o4oxpCRSx6DW1RUerAku75rBQJWCv1kKzciHsHM=; b=nRQD17qJdmMIgFT8l1OFPL4NL+JKjNvznxcgCLtuQsYfwPc3fH+aBb8nM/q9kIrCrlB4EyTLFTlL426aSFUItDhALx15wbhNC1LO6dlzIWR3dXGMJJDurFnIHTVCWdgXFAtXyV2JDy64eygXoDv6dbSih0HkdpMa/BTyeDD2G5Q= Received: from DM6PR11MB3978.namprd11.prod.outlook.com (2603:10b6:5:19a::14) by DM6PR11MB2842.namprd11.prod.outlook.com (2603:10b6:5:c5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3477.20; Fri, 23 Oct 2020 08:42:55 +0000 Received: from DM6PR11MB3978.namprd11.prod.outlook.com ([fe80::9895:a5e1:770d:f026]) by DM6PR11MB3978.namprd11.prod.outlook.com ([fe80::9895:a5e1:770d:f026%7]) with mapi id 15.20.3477.028; Fri, 23 Oct 2020 08:42:55 +0000 From: "Wang, ShougangX" To: "Zhang, AlvinX" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [RFC] net/i40e: refactor of hash flow Thread-Index: AQHWqQoAS17JgXBB+USrglITcpX8U6mk29bw Date: Fri, 23 Oct 2020 08:42:55 +0000 Message-ID: References: <20201023065616.50116-1-alvinx.zhang@intel.com> In-Reply-To: <20201023065616.50116-1-alvinx.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.39] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc3b1f25-6c57-4705-56fb-08d8772fa322 x-ms-traffictypediagnostic: DM6PR11MB2842: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1186; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Qd51plIBKM0Mq4g09wTt2vn6F821vyXRYgQxBYSW53G4+A40W+m1Uv0vqYx+6b3sn4PWZvnUStg52uLrokFhkVSSNGwtyBsz9+e2aVDYs1jFZpmHHgn8XDN+YHVH7ZLKN2tLMOi800H3QY1eZB3+3Q4jndf4/3PJcufqBJa7UDwwcD1X4XszPVFmjLXzuwD4eescSbnjoh6ZgmVKe/CY6m9PCwxdIkVtF2rEHzTY6iHGqR9/3EeY9IhW15kgvKOiv3J7xTnccZrPaChynSuy82gflLyDCXNukCa/5kXA3h8qhfhgtNaaATQlWk6GtyXsL6ydczUKc5TFlAnaC2gCDA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3978.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(366004)(346002)(376002)(396003)(39860400002)(66556008)(76116006)(8676002)(9686003)(8936002)(64756008)(478600001)(5660300002)(7696005)(55016002)(86362001)(26005)(53546011)(52536014)(33656002)(186003)(110136005)(2906002)(83380400001)(6506007)(66446008)(71200400001)(316002)(66946007)(66476007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: +jY2qJ06tV9I3aWiysOH/BPLuD+Tdq7gAcmmub0IZ9/dtG1cmJGqKE22IFvZiJOppZUAe/O7T1oqGoIlmePKDuVKBZPrb+RfXNl+GLnuGGyD/4ElBk2bHYxCZ/exDQtMCaw5PHrCtiEKJgPm2TcPnpOfHtI1/wYYIE7IDKU9IaOf0ZMkDYBgo6MGTdu4fMs+iCUbhqniumRSknLfXfP5SGLw+lseT8YVMsw4odtnN3JCRcxJvy6sMSO+g2tf5X8GcA0UaHDlp+PU/FkthlaLT6a/MZV8jonJQcm0mw/YRr3HGC6qulPM0CtRvvWBK7ZQCrDCRvocMVxn+Uj7/FdK743MHDhpZZttayR1sA8J/1sPX+D9xokp1BHzfa1D8MHf/niXFQAAwuwXz6PskvAFl2cNdMsJrw0k/+606DR5zalkevYa8n4Qr5hvJmg9X0sMKLMMCiDoxa3ZKi7uTXE72ZpjWVPQm/Tj6tWBlxMXY6zX58mqgf8RHBsULNxb0rTc0Ki8wltiyPY6DnSUQW50a1zoluh0okRewRVU9XPIvPdXUMkQXCJRGrcHgzL20+hXDDdTcHuB+JEwVnmq92OwdGiJ2j1XYm2JpGDe05yHQvW23VSj4t2zcFO0FV3+UYji2B2J01+Fw9NfY5fU/2EUow== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3978.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc3b1f25-6c57-4705-56fb-08d8772fa322 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Oct 2020 08:42:55.5401 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: N9rJ3jgH4/Y5PkAVyJaiaBmvwmWvqDhQ+WxPEK9VDj5w79RNIjdzMzpyKjuw67NWeANf9TCm+49MAhkfh+7DfMAqsdtLAWEbMUpco27lw+A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2842 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [RFC] net/i40e: refactor of hash flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Alvin > -----Original Message----- > From: dev On Behalf Of Zhang,Alvin > Sent: Friday, October 23, 2020 2:56 PM > To: dev@dpdk.org > Cc: Zhang, AlvinX > Subject: [dpdk-dev] [RFC] net/i40e: refactor of hash flow >=20 > From: Alvin Zhang >=20 > 1. Delete original code. > 2. Add 2 tables(pattern RSS type matched PCTYPE, RSS type to input set). > 3. Parse RSS pattern and RSS type to get PCTYPE. > 4. Parse RSS action to get queues, RSS function and hash field. > 5. Create and destroy RSS filters. > 6. Create new files for hash flows. > 7. Update doc. >=20 > Signed-off-by: Alvin Zhang > --- > doc/guides/nics/i40e.rst | 4 +- > drivers/net/i40e/i40e_ethdev.c | 840 ++++++------------------- > drivers/net/i40e/i40e_ethdev.h | 43 +- > drivers/net/i40e/i40e_flow.c | 617 +------------------ > drivers/net/i40e/i40e_hash.c | 1315 > ++++++++++++++++++++++++++++++++++++++++ > drivers/net/i40e/i40e_hash.h | 34 ++ > drivers/net/i40e/meson.build | 1 + > 7 files changed, 1587 insertions(+), 1267 deletions(-) > create mode 100644 drivers/net/i40e/i40e_hash.c > create mode 100644 drivers/net/i40e/i40e_hash.h >=20 > diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c > +#define I40E_HASH_VLAN_RSS_MASK (ETH_RSS_S_VLAN | > ETH_RSS_C_VLAN) > +#define I40E_HASH_L2_RSS_MASK (ETH_RSS_ETH | > ETH_RSS_L2_SRC_ONLY | \ > + ETH_RSS_L2_SRC_ONLY) This should be ETH_RSS_L2_DST_ONLY, right? > + > +#define I40E_HASH_L23_RSS_MASK (I40E_HASH_L2_RSS_MASK | > \ > + I40E_HASH_VLAN_RSS_MASK | \ > + ETH_RSS_L3_SRC_ONLY | \ > + ETH_RSS_L3_SRC_ONLY) ETH_RSS_L3_DST_ONLY ? > + > +#define I40E_HASH_L234_RSS_MASK (I40E_HASH_L23_RSS_MASK > | \ > + ETH_RSS_PORT | > ETH_RSS_L3_SRC_ONLY | \ > + ETH_RSS_L3_SRC_ONLY) ETH_RSS_L3_DST_ONLY ? Thanks Shougang