DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] bus/ifpga: remove useless check while browsing devices
@ 2022-01-05 10:26 Maxime Gouin
  2022-01-11 15:12 ` Kevin Traynor
  2022-01-13 14:19 ` Xu, Rosen
  0 siblings, 2 replies; 4+ messages in thread
From: Maxime Gouin @ 2022-01-05 10:26 UTC (permalink / raw)
  To: dev; +Cc: Maxime Gouin, Rosen Xu, Qi Zhang, Tianfei Zhang, Olivier Matz

reported by code analysis tool C++test (version 10.4):

> /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
> 67    Condition "afu_dev" is always evaluated to true
> 81    Condition "afu_dev" is always evaluated to true

The "for" loop already checks that afu_dev is not NULL.

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")

Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
---
 drivers/bus/ifpga/ifpga_bus.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
index cbc680928486..c5c8bbd57219 100644
--- a/drivers/bus/ifpga/ifpga_bus.c
+++ b/drivers/bus/ifpga/ifpga_bus.c
@@ -64,8 +64,7 @@ ifpga_find_afu_dev(const struct rte_rawdev *rdev,
 	struct rte_afu_device *afu_dev = NULL;
 
 	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
-		if (afu_dev &&
-			afu_dev->rawdev == rdev &&
+		if (afu_dev->rawdev == rdev &&
 			!ifpga_afu_id_cmp(&afu_dev->id, afu_id))
 			return afu_dev;
 	}
@@ -78,8 +77,7 @@ rte_ifpga_find_afu_by_name(const char *name)
 	struct rte_afu_device *afu_dev = NULL;
 
 	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
-		if (afu_dev &&
-			!strcmp(afu_dev->device.name, name))
+		if (!strcmp(afu_dev->device.name, name))
 			return afu_dev;
 	}
 	return NULL;
-- 
2.30.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] bus/ifpga: remove useless check while browsing devices
  2022-01-05 10:26 [PATCH] bus/ifpga: remove useless check while browsing devices Maxime Gouin
@ 2022-01-11 15:12 ` Kevin Traynor
  2022-01-13 14:19 ` Xu, Rosen
  1 sibling, 0 replies; 4+ messages in thread
From: Kevin Traynor @ 2022-01-11 15:12 UTC (permalink / raw)
  To: Maxime Gouin, dev; +Cc: Rosen Xu, Qi Zhang, Tianfei Zhang, Olivier Matz

On 05/01/2022 10:26, Maxime Gouin wrote:
> reported by code analysis tool C++test (version 10.4):
> 
>> /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
>> 67    Condition "afu_dev" is always evaluated to true
>> 81    Condition "afu_dev" is always evaluated to true
> 
> The "for" loop already checks that afu_dev is not NULL.
> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> 

Cc: stable@dpdk.org

> Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Kevin Traynor <ktraynor@redhat.com>

> ---
>   drivers/bus/ifpga/ifpga_bus.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index cbc680928486..c5c8bbd57219 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -64,8 +64,7 @@ ifpga_find_afu_dev(const struct rte_rawdev *rdev,
>   	struct rte_afu_device *afu_dev = NULL;
>   
>   	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
> -		if (afu_dev &&
> -			afu_dev->rawdev == rdev &&
> +		if (afu_dev->rawdev == rdev &&
>   			!ifpga_afu_id_cmp(&afu_dev->id, afu_id))
>   			return afu_dev;
>   	}
> @@ -78,8 +77,7 @@ rte_ifpga_find_afu_by_name(const char *name)
>   	struct rte_afu_device *afu_dev = NULL;
>   
>   	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
> -		if (afu_dev &&
> -			!strcmp(afu_dev->device.name, name))
> +		if (!strcmp(afu_dev->device.name, name))
>   			return afu_dev;
>   	}
>   	return NULL;
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] bus/ifpga: remove useless check while browsing devices
  2022-01-05 10:26 [PATCH] bus/ifpga: remove useless check while browsing devices Maxime Gouin
  2022-01-11 15:12 ` Kevin Traynor
@ 2022-01-13 14:19 ` Xu, Rosen
  2022-01-19 16:53   ` Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: Xu, Rosen @ 2022-01-13 14:19 UTC (permalink / raw)
  To: Maxime Gouin, dev; +Cc: Zhang, Qi Z, Zhang, Tianfei, Olivier Matz, Huang, Wei

Hi,

Thanks.

> -----Original Message-----
> From: Maxime Gouin <maxime.gouin@6wind.com>
> Sent: Wednesday, January 05, 2022 18:27
> To: dev@dpdk.org
> Cc: Maxime Gouin <maxime.gouin@6wind.com>; Xu, Rosen
> <rosen.xu@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Zhang, Tianfei
> <tianfei.zhang@intel.com>; Olivier Matz <olivier.matz@6wind.com>
> Subject: [PATCH] bus/ifpga: remove useless check while browsing devices
> 
> reported by code analysis tool C++test (version 10.4):
> 
> > /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
> > 67    Condition "afu_dev" is always evaluated to true
> > 81    Condition "afu_dev" is always evaluated to true
> 
> The "for" loop already checks that afu_dev is not NULL.
> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> 
> Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  drivers/bus/ifpga/ifpga_bus.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/bus/ifpga/ifpga_bus.c b/drivers/bus/ifpga/ifpga_bus.c
> index cbc680928486..c5c8bbd57219 100644
> --- a/drivers/bus/ifpga/ifpga_bus.c
> +++ b/drivers/bus/ifpga/ifpga_bus.c
> @@ -64,8 +64,7 @@ ifpga_find_afu_dev(const struct rte_rawdev *rdev,
>  	struct rte_afu_device *afu_dev = NULL;
> 
>  	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
> -		if (afu_dev &&
> -			afu_dev->rawdev == rdev &&
> +		if (afu_dev->rawdev == rdev &&
>  			!ifpga_afu_id_cmp(&afu_dev->id, afu_id))
>  			return afu_dev;
>  	}
> @@ -78,8 +77,7 @@ rte_ifpga_find_afu_by_name(const char *name)
>  	struct rte_afu_device *afu_dev = NULL;
> 
>  	TAILQ_FOREACH(afu_dev, &ifpga_afu_dev_list, next) {
> -		if (afu_dev &&
> -			!strcmp(afu_dev->device.name, name))
> +		if (!strcmp(afu_dev->device.name, name))
>  			return afu_dev;
>  	}
>  	return NULL;
> --
> 2.30.2

Acked-by: Rosen Xu <rosen.xu@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] bus/ifpga: remove useless check while browsing devices
  2022-01-13 14:19 ` Xu, Rosen
@ 2022-01-19 16:53   ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2022-01-19 16:53 UTC (permalink / raw)
  To: Maxime Gouin
  Cc: dev, Zhang, Qi Z, Zhang, Tianfei, Olivier Matz, Huang, Wei, Xu, Rosen

> > reported by code analysis tool C++test (version 10.4):
> > 
> > > /build/dpdk-20.11/drivers/bus/ifpga/ifpga_bus.c
> > > 67    Condition "afu_dev" is always evaluated to true
> > > 81    Condition "afu_dev" is always evaluated to true
> > 
> > The "for" loop already checks that afu_dev is not NULL.
> > 
> > Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> > 
> > Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
> > Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: Rosen Xu <rosen.xu@intel.com>

Applied, thanks



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-01-19 16:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-05 10:26 [PATCH] bus/ifpga: remove useless check while browsing devices Maxime Gouin
2022-01-11 15:12 ` Kevin Traynor
2022-01-13 14:19 ` Xu, Rosen
2022-01-19 16:53   ` Thomas Monjalon

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git