From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5C22427DE; Mon, 20 Mar 2023 07:54:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3E2940A7F; Mon, 20 Mar 2023 07:54:50 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 0E9A8406BC; Mon, 20 Mar 2023 07:54:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679295289; x=1710831289; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=gZBQO0h0qRHFz27KKdWv6a4pMiteXUthjbDV9lQi5F4=; b=UmRaKG5kNNOektG7ur/5Y+Y3BoMHdKPAPrUkX+4AtXrHTpP6NWUf8Zdr e4h7OTj4XUUwmLXQ0qchWG77lU1p5g0MCbNu9vu6wQqwE1jE5Qq2M3nW1 8jBETW0Z1iOCPJlmBt/Ywz/z8UbtC/EN9EzysgS9vHrcI5NRiswiHd1kU r1nCf+A97IwgrEZdWciBpxLlcaRThqZtEq/J03mEoPvCWu3aFSsR5y75v sYqLnpvKrrZD8H9Cbci8lZIvRmVSNL587wG6SV8PZPCTXDUwNRYpJJY68 /pwDPLqAFDjNYl5wRxJZMUrbFiAPYtbv/3SL5VbNvMu/qHFDV9Vzx1BIl A==; X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="336089139" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="336089139" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2023 23:54:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="824367454" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="824367454" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 19 Mar 2023 23:54:45 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Sun, 19 Mar 2023 23:53:42 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Sun, 19 Mar 2023 23:53:42 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Sun, 19 Mar 2023 23:53:42 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Sun, 19 Mar 2023 23:53:42 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0Rs1pyDV6kJxT/Y7wfk5R9pUbYqwsPCXEkQZMU22jcUwUMXVW6gjBVMVF3wJQYOaM97aOr90BwdiK3trh0XWlvsS9dRFEl1YJ9/y8bVHn6ZwtM36OoAbB6DkG3jkYCizTEwelPoEz+24lzQHGpwRU0+kT4tKJ9LmVdKlS2rQH8IBHYjQoMfgMviY9kQmdVFuKe77X2qaVhsI5f6apyLF0Tr94iGSm+hNF0SePBQFv99WJXJeF3WaEsT+i4TsA+Q5p2zXJQ5w9Uh/pmBq7TGjNFgiPz/WbfEpp6ce/bwKRXONAbSB2NTGtRdXFIOHh5GMGE1zETkTt6ADUOZvJCv2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DTEZw8GdPq4tZfp+XIPk68gXKPUiZxcydHeiWoW5UeM=; b=ImpIQ01uVtJYnjbFBzFIvCzXAGmhwVmn3pXejJWFEXqvR+9EtEsjvnOm0gXShCMO6kSLE430XQjidicJ/EX5EwL56OJGMzbar4auz94kBksuGjWy855c1iSexI4z87Q/07hn9J6ivI4K4xpWWeZR+Ceo5hWnj9qaebJ1Xz+RAgYjmzBAh/vF0uKPxcwWhTu8PiY5hX5eZBVLiSXypoXiy8qBxcFw1hj8Zp2mXTI+MVM7fnvfXAmkiFHJXaSoQtC4OUFXw5nhkKlTVE25jZPOMrO0Es/NLOTQ94J7vFIkJQBcq6nEv7lZJ+uk2/tVOpT2r7vr45iOXXBOG0TQuAP+ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4252.namprd11.prod.outlook.com (2603:10b6:5:201::26) by PH7PR11MB7988.namprd11.prod.outlook.com (2603:10b6:510:243::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 06:53:40 +0000 Received: from DM6PR11MB4252.namprd11.prod.outlook.com ([fe80::5735:cfcd:8b34:761e]) by DM6PR11MB4252.namprd11.prod.outlook.com ([fe80::5735:cfcd:8b34:761e%7]) with mapi id 15.20.6178.037; Mon, 20 Mar 2023 06:53:40 +0000 From: "Xu, Rosen" To: "Huang, Wei" , "dev@dpdk.org" , "thomas@monjalon.net" , "david.marchand@redhat.com" CC: "stable@dpdk.org" , "Zhang, Tianfei" , "Zhang, Qi Z" Subject: RE: [PATCH v1] net/ipn3ke: fix thread exit issue Thread-Topic: [PATCH v1] net/ipn3ke: fix thread exit issue Thread-Index: AQHZWHH7IZaTAheG3Eqjudg3WrGz/K8DQHkQ Date: Mon, 20 Mar 2023 06:53:40 +0000 Message-ID: References: <20230316204506.360432-1-wei.huang@intel.com> In-Reply-To: <20230316204506.360432-1-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4252:EE_|PH7PR11MB7988:EE_ x-ms-office365-filtering-correlation-id: 75692b8c-4dbc-4118-06e6-08db290fd6ae x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KtA+qGV6A/NL7yn7bsndfcjgXVLe28SYn8jrKsUihVI3Nuca76B9xxQ44TmhByizueoRd7Z+5xZpR3UtvqDTmK1jxzNDQFbJkZB529l2x4xhLEVTQ0mra43xmFI/IxdWnPSqI2EEpYh3dPnsgSjkfscF9bgjNLMIhWDss3wFGjfbK/KMZpjfx66EUFNIHbro0B045BZ7+ODyKNQjOaeEVP194jLs9xpW8lT9bctyG6fyGnYaCfIHqQx/GvMy2cYVTlXC0Jh6dHiHxuCICcePn/ciaqcmTbDD0wkH76JN1KUll4lgxvnpgwH0fEFnJaCyOiqHMGdJ2gori0MThAm8Hf2vYc0CGne6Rf/xIVgrRsk+WaZzldA//5g6OELTzllHGtDA5MgTG0Ctm4M5eE6yrIwTlVOEauDjQll24XD909Xj5JO5V62uSON/2bdQ2Dy/ALNBW+Gmfcj9SaVZpL/LmdRdFHU4wZMWtS/QS14rKtbYxxH0GBT5qRiw4lQyewZiedJXGb84CzwgdEOVpgOMa67olWL1MgEnlWdchBv74bP/dwbfYaG/fqVIDp62nI7B4WXzWbAHuTBjuDlCdMBp/f9jKCl89a4qWTpimMYM5cZOszFs86g8GazjoD5Rh9R+GSzOXsk7ybiqlzCem/mG0qHo4V2+DRXS9XfpnbdF3cJS0pHpRXp4TdD3bzipy2L7xZ4iwn3DcfCH7ozyiKkEyg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4252.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(396003)(346002)(376002)(136003)(366004)(39860400002)(451199018)(110136005)(478600001)(316002)(26005)(6506007)(71200400001)(53546011)(54906003)(7696005)(82960400001)(2906002)(38070700005)(8676002)(66946007)(64756008)(76116006)(66446008)(66476007)(66556008)(4326008)(122000001)(5660300002)(107886003)(86362001)(38100700002)(41300700001)(33656002)(8936002)(52536014)(55016003)(9686003)(186003)(83380400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?jgnf/6LlHS8gCyZ823pJoLl1l3f5vhwhx2YyZLrPW23OB0HnYAXpfbkzinfM?= =?us-ascii?Q?02d94WyoMkxvoZ49zbsXEJ1PMe9/HcMqh+7+JWWyVhAHE7miBuCmPsRcH4ja?= =?us-ascii?Q?3Qn36LEPVR8DtiwUecFy/jvF6vPp7D3w2aa5oORnhLTIW0UMNRCQwYN/dtoJ?= =?us-ascii?Q?kt00IWdoccsy5EZUuDuxiFh1J/bVM4vlK9ot6WGjPrVO5BSrvc7ydxWfrqTr?= =?us-ascii?Q?1msoOECfYyV9PQg9hmvgqHqq31l/IjGSEezp/Xw0+v6zwlGXOW8ydt7F8SI6?= =?us-ascii?Q?/KiL39qKO4q/5Y/ovwvD5K9S0Y3GphLzC86iy6KnhlFwHHKR2jlW3guN//wa?= =?us-ascii?Q?SetlJxo9VpARgxFqYZD72Hkm+7m7tCjFUZr7i4VJJdI4ih14L0bowprSnKJl?= =?us-ascii?Q?LOcEZGILhMOHgiIuw4IQ7JGM3WcG2xDFKZi2teaexL6m7ftCpk3i8EYQEfU1?= =?us-ascii?Q?iyyVHfQZMTM+4rGqN1YOGbkJXGfYDyGx5FAttu/UqPS1mT4BsDCeSMHiIcDq?= =?us-ascii?Q?KE9EEGzWg4uXiQYzwwPIunsYdandqy3rulqgHYIFhcqvpNRViKxtdrfG/ene?= =?us-ascii?Q?Y3V1Op8E3TMNKTzSCSZTkgKDWQE56WVUM0/vWQapjo7VdSoSiuEBHiysopAG?= =?us-ascii?Q?JVACszlLk5+8o2beMUVtWi5lTaY+KsdE/mFK+HB6/dGHSiHi/Y10GsOx6pD9?= =?us-ascii?Q?OUPGfpt9o2hEH0KNfBLYSgP9kUWgz79+z9AhXtSjSsqPNQyCbNOoDc4wSiEd?= =?us-ascii?Q?0BPLV+3/D999ch0DP4gYX1zKMJn7SZvDiuHma73C+1vKnlMnCnIIC35L9lSM?= =?us-ascii?Q?4pD6d8s2FCvEdaZWd2Q3B/tLZzxMZdHuDq68EcmzycSNaU2swShpcqYGmK1q?= =?us-ascii?Q?vwo77B3I+h/n7Xns3+zQHR9U7ISYJZeti7bPtbT6ul1d5M+CT8eUbKZVwOZm?= =?us-ascii?Q?8OTTHR2D3Lpt7CpfVt+t2veNat6IRGPj0M6CJLeIJhaj7u/4LGym6WYawu7P?= =?us-ascii?Q?sSgiU+V4009zmP9JCZi2ncPyN6aFc0+1wj+It8FXHRuB4KPY1Oai8IsdI+SN?= =?us-ascii?Q?vVA9euetrq9U9u7xY8sAURJ7/mBowKHrZ7CKjs9y2EPSVWd50TmePzPz9kTB?= =?us-ascii?Q?5D0WQkDP+VueV7wpfSps84EoLavDhKbz+e7DoVjJLPF8rM6nKgw8toCgCKmV?= =?us-ascii?Q?Pyq9bEYQAZTmBRbWqS6Qe1Hcln3J9zrWlDDItYa45PpJMRzZ+1nMrx+f8M7p?= =?us-ascii?Q?kvjHg4C1BVZEriJ4JU1sB/Te9/qZJM01Mq22DNXPrLCc0FoZWi8oOiwcqtiJ?= =?us-ascii?Q?C84yFFnJb+ViSiSS5tiDMK/Z28lTvoLHCUd2AB/SsXoXNrNzjr+ffAJDkpLx?= =?us-ascii?Q?QwK8qbFrRvsrCb4JY6Hy2wIuGFXy0wk9SrhHas61scUl91DdJtNfvQf6Kmz6?= =?us-ascii?Q?j5VC5nIZxc9PQgMvr2l2Isy9kBilQh03r2kei3DK2TdW016vA/vLl20LAnYh?= =?us-ascii?Q?/wm0/iVXoFT8o9t8b9MY9cQxiruM25i1FFD+JDi9Ffk8zuI3hbX3tOAhMlSl?= =?us-ascii?Q?I4NZyHQGP50uSeeRKy5lJPeMj0Qs8NXBtNTT2e+h?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4252.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75692b8c-4dbc-4118-06e6-08db290fd6ae X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2023 06:53:40.5565 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: WAa0Iuf4toyhaTT5Y4kFkOp1K9oGHtnIMnVsiPtXCpivHof0xBFqADXO29Wof4rgCdJApOmnXRPv4Vvxm1kfGA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7988 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, > -----Original Message----- > From: Huang, Wei > Sent: Friday, March 17, 2023 4:45 AM > To: dev@dpdk.org; thomas@monjalon.net; david.marchand@redhat.com > Cc: stable@dpdk.org; Xu, Rosen ; Zhang, Tianfei > ; Zhang, Qi Z ; Huang, Wei > > Subject: [PATCH v1] net/ipn3ke: fix thread exit issue >=20 > Thread does not exit after driver is removed. When there is no more > representor exist, the variable 'num' will be 0 and thread can exit safel= y at > this time. >=20 > Fixes: 70d6b7f550f4 ("net/ipn3ke: add representor") > Cc: stable@dpdk.org >=20 > Signed-off-by: Wei Huang > --- > drivers/net/ipn3ke/ipn3ke_representor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ipn3ke/ipn3ke_representor.c > b/drivers/net/ipn3ke/ipn3ke_representor.c > index 2ef96a9..e50fc73 100644 > --- a/drivers/net/ipn3ke/ipn3ke_representor.c > +++ b/drivers/net/ipn3ke/ipn3ke_representor.c > @@ -2579,7 +2579,7 @@ struct rte_eth_xstat_name *xstats_names, > } > rte_delay_us(50 * MS); >=20 > - if (num =3D=3D 0xffffff) > + if (num =3D=3D 0 || num =3D=3D 0xffffff) > return NULL; > } >=20 > -- > 1.8.3.1 Acked-by: Rosen Xu