From: "Jayatheerthan, Jay" <jay.jayatheerthan@intel.com>
To: Jerin Jacob <jerinjacobk@gmail.com>,
"Naga Harish K, S V" <s.v.naga.harish.k@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: RE: [PATCH] eventdev/eth_rx: fix queue config get API
Date: Mon, 14 Feb 2022 17:09:00 +0000 [thread overview]
Message-ID: <DM6PR11MB4348238651C2743067BEA945FD339@DM6PR11MB4348.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1PnF5SP68cmHw4BJGTFcp=pnCs9fwHDO8F1FqGjn_W0mg@mail.gmail.com>
Hi Harish,
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Monday, February 14, 2022 8:59 PM
> To: Naga Harish K, S V <s.v.naga.harish.k@intel.com>
> Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Jerin Jacob <jerinj@marvell.com>; dpdk-dev <dev@dpdk.org>
> Subject: Re: [PATCH] eventdev/eth_rx: fix queue config get API
>
> On Wed, Feb 9, 2022 at 10:40 AM Naga Harish K S V
> <s.v.naga.harish.k@intel.com> wrote:
> >
> > the memcpy size used in queue config get function is more than
> > the source size. Use correct size to avoid copy of unnecessary
> > data.
> >
> > Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get")
> >
> > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
>
> Hi @Jayatheerthan, Jay
>
> Could you review it?
>
>
> > ---
> > lib/eventdev/rte_event_eth_rx_adapter.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> > index ae1e260c08..e44499e887 100644
> > --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> > @@ -3238,7 +3238,7 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id,
> > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID;
> > queue_conf->servicing_weight = queue_info->wt;
> >
> > - memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev));
> > + memcpy(&queue_conf->ev, qi_ev, sizeof(queue_info->event));
Why do we need to assign queue_info->event to qi_ev and then copy it to queue_conf->ev ? We should be able to do straight copy from queue_info->event to queue_conf->ev.
> >
> > dev = &rte_eventdevs[rx_adapter->eventdev_id];
> > if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) {
> > --
> > 2.23.0
> >
next prev parent reply other threads:[~2022-02-14 17:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 5:09 Naga Harish K S V
2022-02-14 15:28 ` Jerin Jacob
2022-02-14 17:09 ` Jayatheerthan, Jay [this message]
2022-02-14 17:13 ` Naga Harish K, S V
2022-02-14 17:10 ` [PATCH v2] eventdev/eth_rx: fix queue config get logic Naga Harish K S V
2022-02-15 16:54 ` Jayatheerthan, Jay
2022-02-18 13:57 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB4348238651C2743067BEA945FD339@DM6PR11MB4348.namprd11.prod.outlook.com \
--to=jay.jayatheerthan@intel.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=s.v.naga.harish.k@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).