From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4C6F0A0543; Wed, 14 Dec 2022 08:31:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E947400D6; Wed, 14 Dec 2022 08:31:32 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id A63144003F for ; Wed, 14 Dec 2022 08:31:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1671003091; x=1702539091; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=FUDt7Ic28mYMpVAoJ7jMG/QJy6M3Df7EwE5Qnn/SBds=; b=iFmE/Ht1hdmSCxv/IzuEtPE9IYCaaae4+w3LpDyyhpXh7OT7O3YE/fia 10qwcw+QfYpmOi7zL1n4+/eQ+4AhPHLSSzRZK/KCdj+bMhx5yS4hW3tp4 BmfNCTrKRoEjkVI64tuNjdXtfQcMCbELYhOfWt9K0VE+NBJaaMpnd6LP8 xY9Pp1ymqhF+sxQxGEHJtopy1pk9Wh9XBZzbVGgbnD9bSjrrQLpDEtxNl dtsW7S6UApWYBCh2bKiTAsGs+9aIGCepvQq27TDwp/gZiDLRtFBfmNXo0 yLwXiYd7VQ7nUtMzx3YL5VBG0RdeY6ih0p5LXHXEI2sgWY3yww1TQIqfJ g==; X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="305974252" X-IronPort-AV: E=Sophos;i="5.96,243,1665471600"; d="scan'208";a="305974252" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Dec 2022 23:31:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10560"; a="642414271" X-IronPort-AV: E=Sophos;i="5.96,243,1665471600"; d="scan'208";a="642414271" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP; 13 Dec 2022 23:31:16 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 13 Dec 2022 23:31:15 -0800 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 13 Dec 2022 23:31:14 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Tue, 13 Dec 2022 23:31:14 -0800 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.45) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Tue, 13 Dec 2022 23:31:13 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WRwU4tVuDsMtdhpO9q3iDQqSMP+3tB8wpupdZhibM89pXDcmIcVWpJeG5ShgmpAdF84er1v7LkIcP3zObLLdjbFo1x6S/ro7nqz/fMafm8AhbrbmGiyGO2uTspRoKjWXZR90e4vH/1xNIS3/XT7UwutoUtHNAqAqR5HrJ38xg2j94JT45enLniTOOVJUPRnGmuu0sl1JeB5s+dbE0/+m5WF6RcK8jEhRH3erPSvzD7ZKJQpyjpbuVGbR919OomC2nqllQ4ipB23T87lZWj6X1jDcjlx96Wnxx8PrIaHOXSCItylHNoZpxrJdMi6mvptmtTMZKozDFdzLLqJsC+VDCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ct8XiKaMXKKwb8rArmewMkpfxx8MJu9IKxSiyZ//Ibs=; b=ZYDTq0cnvJg7E1X9g0AS80aNVyP2RJP3Kgmly/MKeuRYb6EijOtY8w1wHMetQGGmkudBt0qgX8Cilz3C4rCYadAOtWqWcVSooX3FPGcgVhhoKQg37LymzDbDZ3lTA9/3Vn6b43rFZCLyK8v0hKRvOf4qD0J+CbrsqK2ILsa9Y03eWg262Nob386VrD9nu10lQuAlvs5lO5A3Y721mSYgapPYclFoTNO7YfNhtUOTg7Y0WFpp50lryR+6qLbyKU4vPHCSODk+qY2UYVm7124iwvN0umwcieDwrH4J/gXLugL44HHU9MAQY1NOexq9iSU9IVERChIaB6R4iLvjgdfK1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4348.namprd11.prod.outlook.com (2603:10b6:5:1db::18) by CY8PR11MB7059.namprd11.prod.outlook.com (2603:10b6:930:51::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.19; Wed, 14 Dec 2022 07:31:12 +0000 Received: from DM6PR11MB4348.namprd11.prod.outlook.com ([fe80::3cda:e518:b5bf:da03]) by DM6PR11MB4348.namprd11.prod.outlook.com ([fe80::3cda:e518:b5bf:da03%7]) with mapi id 15.20.5880.019; Wed, 14 Dec 2022 07:31:12 +0000 From: "Jayatheerthan, Jay" To: "Naga Harish K, S V" , "jerinj@marvell.com" , "Carrillo, Erik G" , "Gujjar, Abhinandan S" CC: "dev@dpdk.org" Subject: RE: [PATCH v2 1/4] eventdev/eth_rx: change eventdev reconfig logic Thread-Topic: [PATCH v2 1/4] eventdev/eth_rx: change eventdev reconfig logic Thread-Index: AQHZD4pe12vnhirY/kqGHifu1eqbYq5s+ciA Date: Wed, 14 Dec 2022 07:31:11 +0000 Message-ID: References: <20221214055551.913821-4-s.v.naga.harish.k@intel.com> <20221214070440.921488-1-s.v.naga.harish.k@intel.com> In-Reply-To: <20221214070440.921488-1-s.v.naga.harish.k@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4348:EE_|CY8PR11MB7059:EE_ x-ms-office365-filtering-correlation-id: 5ad0feba-a569-4aa5-5cd8-08dadda52cfe x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Wojtsp+Boc5ubHtPWZnxodopH5ogh9A7+1Qk47H58PjdS7MZYkS5pMLNxWe2qZSaevES0b0nxCMiS9eJbB2YONtEaq173ShCmzz/QLQbl7EZM+D34UH3hQZ867y1+ZPEFKYYC5IgpZyW9P/jgA/kY1cTE42drtLaDm56/9H6WRqoxVxipC1mn1+7EcEGFw1kh6w6/yN//FY2RrqafaSQL+dFqCNWVMMxP2ZqTY+A9CfdZAbYor2oOjY1d3+/fVJuZsDdDUM2Z4NC+xL5bz5+eKqDypeSAUv90BtaWrXCMTqZjxJTZurFbJ+l1Ee+llXlddbKyNEUnNTHJV6U42jJqdJ/WcnKjNMs8+tpglwFu5kqPrFHr0vlFKwr9f60vjr7g/1yno5Kn0GcZTX1tFwPzh/PrSwRxQpsNX+83pjgOqaKBMuTWXKqelmb8BAYHTqV+xGXOtFW55YEzMK9N+tjpyK1nBwtNDgc+p/hGUWYIZLLwDtkQ7GQx6Ec3aL35JZTNTeXuGexTtfvIQv1dxWqe++de4ckIIIr9xvsUsWLAqfzTnKZhA0Qjp01ZwzZc5KJVJX6yxVcTlQO7/Vf7zlbCybv5pCVJCdmw70SsR8XcBXWLI4iMg3icn4+nj8xtVlbkFhw+fLoITwYhF9UI0Mm+9tZAF65xa2FUUm3p8UBNE7S4WjShmIyLpktI93GaqxLAysbznhkkkEHFxO8ava2zg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4348.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(346002)(396003)(39860400002)(366004)(376002)(136003)(451199015)(71200400001)(6506007)(7696005)(53546011)(9686003)(26005)(66946007)(8676002)(76116006)(66446008)(66556008)(66476007)(64756008)(33656002)(6636002)(478600001)(316002)(4326008)(110136005)(55016003)(82960400001)(41300700001)(86362001)(186003)(8936002)(52536014)(5660300002)(83380400001)(122000001)(2906002)(38100700002)(38070700005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YrydtDIX9XD/m261yV+s6a2F5GfX0pu1fZAKr8VJ4K2deWQaDOI+zdzEQ44+?= =?us-ascii?Q?yVjQSTG9yNgij/xIAKn/e/UL0ax4VskJvHBIUhbbfZjEBYa/QtaGND5kEdH8?= =?us-ascii?Q?wosTUzHAAmwY/dU5LdUrQkupxLCrD6DBhs+ECbykqPqO+ALBcVhtW4uS+Mi3?= =?us-ascii?Q?G/y1KF9mWSG1VlChG9JiClSJ8FF9cjyTZpvS3SN0/vqn3FV8Eng7iYK+jgdw?= =?us-ascii?Q?6rTPm5j5JfXIJiRM7Zz/9U3vab/g6Y1RIvJkyEFgV1DjY8+fngCGQkJ6JG8I?= =?us-ascii?Q?iMgd+potoel2gzIlBK4WT0Usyf1IPkW/amd7xdgG1ZuVEbkB9tgcRpIna4lz?= =?us-ascii?Q?z/Q/33XHBDUF/JZdiYtGHIfnoVdiVudXwWcJjEqqNa/rCS75xMQD/AdU0PQX?= =?us-ascii?Q?pKtmBVm0juC9sTVJYBcQ9V71++rA2EZ0JxQO+sanmowgg8cGRlwmUQUPQthp?= =?us-ascii?Q?EBJTjf2QzksnzVqKnf8q8yfOT8gWaexh7dMuPCuDLc+W1XlSeFZqIjVY53NT?= =?us-ascii?Q?5+Oe1FVb7j5DeNLg6DrmQgJ1EU1DZP8yalkZVAKMJDDU5Lnfh3Yv95c20vB7?= =?us-ascii?Q?H1RusuFlZMHkhbbwuUdR7RACLjpa94gLvVpTSOhot53vcm8Acn5S68ws0d1P?= =?us-ascii?Q?s+Bao5g4X/QUDsqYN4sTxiewEdwXIg3eEanA1Z/xduRQKjLnPR44MIYQSYRY?= =?us-ascii?Q?BVtPTde5YkuyPKJ3itwrYIF3G+P1YTW4TBpMzwvctaxBZa6eLxoslfo3CmOP?= =?us-ascii?Q?z09VZ/MN+auJd9it3ZyFAw9yV7ji6Ckgei8JGQhFY7EU+NoE7bRvxgAFG3Na?= =?us-ascii?Q?ByAp+5rtDQApbAlpx4J1wSvOREU8TOuez1R1LGxl1fPrTnhtLzMmFNwuhGcb?= =?us-ascii?Q?6pPC8xSVDhbr/svPBBUL24tJEO+wmNtROSsaPp/6AOyHe8RBAAREyqMLnsVv?= =?us-ascii?Q?KQeBqfvGvmKUP8mKPjgPydpiHV7LcbG/0hZ2K8ATHYU13mCiGS5l6dUEe6FE?= =?us-ascii?Q?EtIWb+8FnoznAAjgHCNfvERsE1RLwAe+O1+SX7K341UFPoxI/HAMgVDhFYpM?= =?us-ascii?Q?7R5D4YVbPYKl1xTOeDXJjDgeefDT7kRGnLq4ueGGHS2uSCzt+tBH40Rg6PBd?= =?us-ascii?Q?ZXk11oGzE8GNtNoAHI8LKYR0JCGgdiBPYJprmETRO4FXXsv9oGnNCvjQJ46Q?= =?us-ascii?Q?kCRIa5fdSmcANaFRIvQRt98kmT05o2RkIIGkZBNDeYaRou4I/E1BBjZkkbQM?= =?us-ascii?Q?I49IMd4HWhLDYFTfO2zLekgIzlwt6AkQfjBEBCoc8jeYR+MWzE6ydhiJgumx?= =?us-ascii?Q?0JWJCEtOn2FKsTFu41fjy0GXp7OOB0mzJ/GeajxiKfnqqEKlqGkz3F4Lk/Ua?= =?us-ascii?Q?IwPxsNt0QJQ9dh1kJ3GgpWz1cpfKhYRCr+CnZkoCY0YJs5iP5WbFgj0URewG?= =?us-ascii?Q?sXakynONyLLINKYNfvrw+4X+pQ1G3X26zAs16M5irLXQ8ZZCsBXM7k/u4fTQ?= =?us-ascii?Q?hwd33n9wa3tPy4fRhSfs5RSbWMqrZsfGk2CkrMzQ1kcAYjk9gXe/Y4H68o0m?= =?us-ascii?Q?qnwybFNwoRtADgFXVE3JrhoVJhdn8TZh41SXQZb1IwOD6d11mVa/hLDv8rHE?= =?us-ascii?Q?FA=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4348.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5ad0feba-a569-4aa5-5cd8-08dadda52cfe X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Dec 2022 07:31:11.9931 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: e8DUkdeJ9NLNpXSxn4t7DSYdBK6bIg9RR7JEzwSX2qyewJ0uoF9dAIbEgAtEJbTHqBEbpnoLXgTLW/0hG7WGHMF0VVL5ixIkJfMHN9vbtZ4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR11MB7059 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Naga Harish K, S V > Sent: Wednesday, December 14, 2022 12:35 PM > To: jerinj@marvell.com; Carrillo, Erik G ; Guj= jar, Abhinandan S > Cc: dev@dpdk.org; Jayatheerthan, Jay > Subject: [PATCH v2 1/4] eventdev/eth_rx: change eventdev reconfig logic >=20 > When rte_event_eth_rx_adapter_create() or > rte_event_eth_rx_adapter_create_with_params() is used for creating > adapter instance, eventdev is reconfigured with additional > ``rte_event_dev_config::nb_event_ports`` parameter. >=20 > This eventdev reconfig logic is enhanced to increment the > ``rte_event_dev_config::nb_single_link_event_port_queues`` > parameter if the adapter event port config is of type > ``RTE_EVENT_PORT_CFG_SINGLE_LINK``. >=20 > With this change the application no longer need to configure the > eventdev with ``rte_event_dev_config::nb_single_link_event_port_queues`` > parameter required for eth_rx adapter when the adapter is created > using above mentioned apis. >=20 > Signed-off-by: Naga Harish K S V > --- > v2: > * Fix build error > --- > --- > .../prog_guide/event_ethernet_rx_adapter.rst | 18 ++++++++++++++++++ > lib/eventdev/rte_event_eth_rx_adapter.c | 3 +++ > 2 files changed, 21 insertions(+) >=20 > diff --git a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst b/doc/gu= ides/prog_guide/event_ethernet_rx_adapter.rst > index 116c0a27c6..8fc9be0a9d 100644 > --- a/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > +++ b/doc/guides/prog_guide/event_ethernet_rx_adapter.rst > @@ -71,6 +71,24 @@ set to true. The function is passed the event device t= o be associated with > the adapter and port configuration for the adapter to setup an event por= t > if the adapter needs to use a service function. >=20 > +Event device configuration for service based adapter > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > + > +When rte_event_eth_rx_adapter_create() or > +rte_event_eth_rx_adapter_create_with_params() is used for creating > +adapter instance, eventdev is reconfigured with additional > +``rte_event_dev_config::nb_event_ports`` parameter. > +This eventdev reconfig logic also increment the > +``rte_event_dev_config::nb_single_link_event_port_queues`` > +parameter if the adapter event port config is of type > +``RTE_EVENT_PORT_CFG_SINGLE_LINK``. > + > +So the application is no longer need to configure the > +event device with ``rte_event_dev_config::nb_event_ports`` and > +``rte_event_dev_config::nb_single_link_event_port_queues`` > +parameters required for eth_rx adapter when the adapter is created > +using above mentioned apis. > + > Adding Rx Queues to the Adapter Instance > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_e= vent_eth_rx_adapter.c > index cf7bbd4d69..34aa87379e 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -1532,6 +1532,9 @@ rxa_default_conf_cb(uint8_t id, uint8_t dev_id, > rte_event_dev_stop(dev_id); > port_id =3D dev_conf.nb_event_ports; > dev_conf.nb_event_ports +=3D 1; > + if (port_conf->event_port_cfg & RTE_EVENT_PORT_CFG_SINGLE_LINK) > + dev_conf.nb_single_link_event_port_queues +=3D 1; Can add more comments in doxygen for nb_single_link_event_port_queues and n= b_event_ports fields pointing out they are configured by application with w= orker necessity in mind. Adapter necessity is handled in adapter create now= . This comment can be applied to other adapters as well. > + > ret =3D rte_event_dev_configure(dev_id, &dev_conf); > if (ret) { > RTE_EDEV_LOG_ERR("failed to configure event dev %u\n", > -- > 2.25.1