From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AA67A00C5; Tue, 15 Feb 2022 17:54:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB141410F7; Tue, 15 Feb 2022 17:54:41 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 66B68410F3 for ; Tue, 15 Feb 2022 17:54:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644944080; x=1676480080; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=d7Chj4nOHS/e7/jFXoGo2o7xMDiIzSWnH/9Tthto5h8=; b=CCbbAnQIdlE6MvtoNO274HJe8FetAZj7wHBqxYawVnSe4kYGAj1aS7Dl YR7bRQaLJqyrJAPBR8/GRuu4CGj6g410rZ8RsETSHxiCQdmIDGYVH1I3+ fxht2Qam2XFGH2KzWx2qOOQczEyHVULySjV0Ep8vCoi3detS5IeJbHTzf z8Via51vxIwFE5RDDQCtkjfjEEJKKmFFdFwS1UW0Wp9cndAmUjEePUJkr fshO+dKOtvYdPuw5kqptq8nwRpa7z65lXQedUL4rjn2UaBZiy3n6VLfTA gIkWQqO12019feanuuTY6gMSU4Dg3O3o7l8/0jDznDMvcRdABtarGe7Z2 w==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="274969468" X-IronPort-AV: E=Sophos;i="5.88,371,1635231600"; d="scan'208";a="274969468" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2022 08:54:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,371,1635231600"; d="scan'208";a="539421379" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga007.fm.intel.com with ESMTP; 15 Feb 2022 08:54:39 -0800 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 15 Feb 2022 08:54:39 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 15 Feb 2022 08:54:39 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 15 Feb 2022 08:54:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ARqw/fjlaLV0K25vVRVL4i086u2rwfYevTmCk1GZPLwsQrXg9Otlh5ebOfR6E2lLC1OkGd6/9eXNXQjB90Lng+4IspkZvCcMGsgAR8F819kupnDWW9+WfsBWLC+E2msDNMTRSjCHMbyGhnmT6vsM6+9N3HD8iLjzADxHhy6wvFmipsNDc1rI9ZBACqTJsuMgeYtxqbde9lgj1gK/qsDIZV5i8hT2yB4rbtD2VOvb+5ngXklcfChIkkthQBH/SE+UEtLOOqSSW9pK4hgTHzXqLOKuwVI97TB5Y2/VYvm4Ki5u9+ZtdrOnUn7YReOBfTEZFJMOSYHMDNfZsbPeW8lFpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=754OWAG5IWf7fv0wA6kBHKnmS7yWZqilvTp0iglnddQ=; b=L82+M7fDkJe4cvGu5PaMwBEdGSXBB3J2v2C1BiQvalcgo3rAc/N8uHbn6MM3/OTMHYJ5Cjv0fjxeMzIGZGntRA/Pnly7WNKeEWtGRaz3u8h//1+7rmbaQQAfbx82rAAv4cvq9Wgcz7c3QaeiVQjePYAGtwgaMiyKz8MDPfFwXlLeg8QUHgHOzFLquFCCB94VXAvlu1gZf7QOOFpMSjlF4jEQ6PvDmPBB5+5Pz9B5IqKlJ2rCmLhJSKdQG6Pj810z7490cVPMAgfkhlGHS1ke281hDDs+D7NFkOZKijYt4TPRT5pVYBkjO0DC8p+VcLD1NgF6+O3sPb2iZ7gfsNCQ5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from DM6PR11MB4348.namprd11.prod.outlook.com (2603:10b6:5:1db::18) by PH0PR11MB4999.namprd11.prod.outlook.com (2603:10b6:510:37::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.15; Tue, 15 Feb 2022 16:54:37 +0000 Received: from DM6PR11MB4348.namprd11.prod.outlook.com ([fe80::81b0:ace7:417:1c1e]) by DM6PR11MB4348.namprd11.prod.outlook.com ([fe80::81b0:ace7:417:1c1e%4]) with mapi id 15.20.4975.019; Tue, 15 Feb 2022 16:54:37 +0000 From: "Jayatheerthan, Jay" To: "Naga Harish K, S V" , "jerinj@marvell.com" CC: "dev@dpdk.org" Subject: RE: [PATCH v2] eventdev/eth_rx: fix queue config get logic Thread-Topic: [PATCH v2] eventdev/eth_rx: fix queue config get logic Thread-Index: AQHYIcXJO0/5qEAXyUaZedDO0xZEaqyU1bMw Date: Tue, 15 Feb 2022 16:54:37 +0000 Message-ID: References: <20220209050925.1552306-1-s.v.naga.harish.k@intel.com> <20220214171016.961658-1-s.v.naga.harish.k@intel.com> In-Reply-To: <20220214171016.961658-1-s.v.naga.harish.k@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8a1deecd-d779-4ac5-2b40-08d9f0a3d9f6 x-ms-traffictypediagnostic: PH0PR11MB4999:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1751; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 9uXDRasOEwSFvn0gOcx0EcbZw4XNubgha36XFXs/ZrRCB27Xlh+Q/TUIpF6+xn5aqHt9XJMvt3HetQqpSBBXLUtAQjnnpOrWAsqdFKZE8KsP1/HKfbxsV7qvP6VGHCu79Ag0hvtlq7e4FSq6zIW/yfjDZgeDUukk/G8Oe2/mWunMxD4IyE3AOTB2qCQHIFC+wUATUDhed2gOOMCwmjP0VYXl6fL1HPOMVg9+yDZ7xDGMBwkrHEcJwMini76jQLCrUskaDbGIv58z6hqpRr65eVKifaODiZoorwH9wC38aNJsZIihbAO2LoXSouks9v2OmVgdyd9ungO5s2893dn8nniJGnOxA+hPsxFAmA4W2h+1Htkzf2BlYPWD5/pFg4KdVyBctZg784G1nre0PEgw5qP5z8IZ8+NHyj8R+hZ7Gv7cUpsI8z+fA75n/8x+ObtUDNlDBrKWqfb/5utZ5HKjHrbupDvm72tyuIfrnhJFIxKSacQhR0iyYt8pMFJTIOq8uzHOntKjjoFTqszvjA/S3DVgBcxkPD7RqsvLzRr4EKkKzH/kefwdDnxowVcEQLxZrYxwVHDo0jwKjMckxFhqQuvd8UnpvaiyixpStGafVP1VRb6fJgZpz1RifcUEIjlbitAC8nuY+SXsLXjlGQs8vsIt2ULRYsZAbLiaKw3XKdTp8JNj/cG4gco1Jn4TsNGwqNeCRKoTeAaX1An8sX3ByA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4348.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(64756008)(82960400001)(8676002)(66476007)(66556008)(76116006)(38070700005)(66946007)(66446008)(110136005)(316002)(4326008)(33656002)(2906002)(8936002)(9686003)(5660300002)(86362001)(186003)(26005)(55016003)(7696005)(6506007)(71200400001)(53546011)(122000001)(508600001)(83380400001)(52536014)(38100700002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?y0QE7ow0pudo3bXuXGZi7faWHAEfPOHumgiE93u8WVTQpnfxyhl9q3v5yBE3?= =?us-ascii?Q?3sP2ZSjhguVORkI+x924l0QhcPMFS8pssuuNir4iJMomUf+lCMXieXIcHCi+?= =?us-ascii?Q?V83ImTjvHjod0NjNtUUzmznorK6w+lxhnJhvEEGf06pXhQsd2BICBz9BNVN0?= =?us-ascii?Q?OXGZ6yFMP2UZSnXKWt/3k2ciecjJVjoyGMlhwUfinWW7tnSaRfllRD1GRYWE?= =?us-ascii?Q?MxrkEpCmS5PpaUkmedaYXCyMytaH3Bny1SJEg5ILNI0Yb35gqvPy271KX2TV?= =?us-ascii?Q?qOpW8BEKI7H3pvfDsrUwe2asTw1+T/JiLZH8sI9hlKlGa89ysDnPTZ6r/223?= =?us-ascii?Q?BUKBx5HPFXOyvJWPHTDkllcE5TH21YLTFNVcFOzaB81FdLCQOxqmT10hNyFT?= =?us-ascii?Q?tvz7aS2kaOGAS2k6CrTl7xSlVUHNHGEyHXM5tcGssCAeHe0OgLsp9PwkN+3z?= =?us-ascii?Q?iQc1QgWkGMiZE4JKCgjeIp90HzJhWnandeagjsQfrj2VOBt2nObVSGDdzHsM?= =?us-ascii?Q?inmDQzdizxsZQZ9zwNBnLcvxZXbuTLsgtoCPbGgJoB1QSLXCZxtXWzamFWxe?= =?us-ascii?Q?C/gQCUjzP1Xvkiek4UHD9mG5A6noRil9QNj2bfoF0T27JUnOtmHAksC/xddA?= =?us-ascii?Q?wBqqGUdfyi/AfPssFOl0vtmweYO08uT1JixdwSESXn//1CjhyLxYN/8jNrxK?= =?us-ascii?Q?21+2tAjUWoaK4a/Zrv/qVO41PDu4hAYmrTROOfBp4h76zO84IRNLA+R5XC8J?= =?us-ascii?Q?GzqDhgFSjRBh3zU0pglORwXNVzlAgrmq9qqSddjd+5PCSQpDqlZtVyBn7q/8?= =?us-ascii?Q?pXJSLqGetaynRm7KsXf79RanCEQ5jrcdYia/6UAoWhrZgFN+q6MULu9wMgbd?= =?us-ascii?Q?26yiogKps5Yiy6PrZXuBBsz2WsMHHxH19McBCJqJmdUs8HZJrAVe4yn7GwHM?= =?us-ascii?Q?qIYhmwX+5JSp+nm9WbudvBpfY1Qmgt2YamFxacUkV4xYhUXzV3tPV6znqBY2?= =?us-ascii?Q?m/FkaCOeCpl0mUR9fm7oYRGTPCVvZpis2W1hfb0IwAUJMls3VibGBmY2/mJK?= =?us-ascii?Q?jENQW5T5kgkSZ5Z6JLoWz+ogIXhkhWP05rV2G/EbUuCxJG7SCgtLyBKs51Eh?= =?us-ascii?Q?EE5SphQGFaz0G8CRwCSkaKi956r56HQNxwPI8lkc8KLuThpe7XESQORxGRR1?= =?us-ascii?Q?3PSUfrGOCjayLNxURcpsJ9+oyrFnlVM/UfMK3uy1pwbS009zdoU6ts9C9bzS?= =?us-ascii?Q?7xe7QTdrxRDXLZv/xDWB7BytET6No+NzY6bhwunUgSgme8VZ8QHnpohMM15K?= =?us-ascii?Q?m5yzjbKXYnoLAuyh4wMJO6Qy7+EpfGDAN1TJ1quVCkhHLA3OZvOCerV1DdCS?= =?us-ascii?Q?NNGdQOH+9aVl0FzmYggADQWn7xdexbgcoJfuFTIVQjq6iue7h0BLxPj008cU?= =?us-ascii?Q?LaxMTUC5WBzQiP5fgMnP/1lw1i7iDvYOPaJVhIBpQMS0EPWkJoRIJX9Eonj9?= =?us-ascii?Q?+BpUqcACrr3I98IZn6nBtZ5NDlwa06dOpa98t55mhay8y+ti5hu4GXQLn1QT?= =?us-ascii?Q?0mWW/pdYf5bXlcdktcRTSK+kBHtZ7PLNaHJmWUhDMVkwg1Uh4/yTTQtsu7rV?= =?us-ascii?Q?jhjmVYWVyRbyeadCfZFNI67AMHk3/NpdKIFiaSK0xeObPupcVhfYFYEJp7RZ?= =?us-ascii?Q?tc+0Ig=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4348.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8a1deecd-d779-4ac5-2b40-08d9f0a3d9f6 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Feb 2022 16:54:37.6135 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: BfJmOH8Wssc5K1cwkTXnWArjuRlEVzYPXW+Eb3MBJRSKzopkkbJY5Jld17DwPgD15MgMOKrkNSyBYyiRte09y4XS/kan0lD8ij6ZaFW7UMA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4999 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Looks good. Thanks! Acked-by: Jay Jayatheerthan -Jay > -----Original Message----- > From: Naga Harish K, S V > Sent: Monday, February 14, 2022 10:40 PM > To: Jayatheerthan, Jay ; jerinj@marvell.com > Cc: dev@dpdk.org > Subject: [PATCH v2] eventdev/eth_rx: fix queue config get logic >=20 > remove the memcpy usage in queue config get function for > `event` variable which is 8 byte size and use direct copy. > Also provide vector information and event buffer size in the > queue config info. >=20 > Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") >=20 > Signed-off-by: Naga Harish K S V > --- > v2: > * remove memcpy usage > also provide vector data and event buffer size info > --- > lib/eventdev/rte_event_eth_rx_adapter.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) >=20 > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_e= vent_eth_rx_adapter.c > index ae1e260c08..28388d3abb 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -3194,11 +3194,11 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t i= d, > uint16_t rx_queue_id, > struct rte_event_eth_rx_adapter_queue_conf *queue_conf) > { > +#define TICK2NSEC(_ticks, _freq) (((_ticks) * (1E9)) / (_freq)) > struct rte_eventdev *dev; > struct event_eth_rx_adapter *rx_adapter; > struct eth_device_info *dev_info; > struct eth_rx_queue_info *queue_info; > - struct rte_event *qi_ev; > int ret; >=20 > if (rxa_memzone_lookup()) > @@ -3229,7 +3229,6 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > } >=20 > queue_info =3D &dev_info->rx_queue[rx_queue_id]; > - qi_ev =3D (struct rte_event *)&queue_info->event; >=20 > memset(queue_conf, 0, sizeof(*queue_conf)); > queue_conf->rx_queue_flags =3D 0; > @@ -3238,7 +3237,18 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id= , > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID; > queue_conf->servicing_weight =3D queue_info->wt; >=20 > - memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev)); > + queue_conf->ev.event =3D queue_info->event; > + > + queue_conf->vector_sz =3D queue_info->vector_data.max_vector_count; > + queue_conf->vector_mp =3D queue_info->vector_data.vector_pool; > + /* need to be converted from ticks to ns */ > + queue_conf->vector_timeout_ns =3D TICK2NSEC( > + queue_info->vector_data.vector_timeout_ticks, rte_get_timer_hz()); > + > + if (queue_info->event_buf !=3D NULL) > + queue_conf->event_buf_size =3D queue_info->event_buf->events_size; > + else > + queue_conf->event_buf_size =3D 0; >=20 > dev =3D &rte_eventdevs[rx_adapter->eventdev_id]; > if (dev->dev_ops->eth_rx_adapter_queue_conf_get !=3D NULL) { > -- > 2.23.0