From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39FE5431EC; Tue, 24 Oct 2023 09:23:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D739F40262; Tue, 24 Oct 2023 09:23:04 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 5B8F24021D for ; Tue, 24 Oct 2023 09:23:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698132183; x=1729668183; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5Q4vmADJavwJQOcx9vrV4474HVDi1t/RPmv0zJYukLA=; b=RF9q2rxGtiy2n6tpPgJrB9UuvNQzMfustgd/b5TWFkTNoK472rX9Ybtj Pz+e7KE/E12RCyIEtBfY9TDCsO1d6rQs8ExXRHfU2rqZ5Egx4ddkEPo7g ymIVEUE8CSkKb+9bax0Sw8oVwgI4bfYmbLVn3f+6+Ow0NtV+TnfP4qC/r TIJImSMg+DzFeN0HhLC/Es7YmC6Ou47RlgSiM+8AWxz01OQmw40pWXq2x Y4y04MIyCFvX50b6R3wL8FueGBD7nM8hj3fABYJD5DUMw393J+xy3lnd4 WFid88wEtkfGiH//qZbYwO4Yzw5q259uEHeFDrT1i7cpdzHW1NZxJWM5E Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="384200343" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="384200343" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 00:23:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="758386451" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="758386451" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Oct 2023 00:23:01 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 24 Oct 2023 00:23:00 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 24 Oct 2023 00:23:00 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 24 Oct 2023 00:23:00 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 24 Oct 2023 00:22:59 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q+Nq8KtYmon3XGoaMpeQd4l0bIpKRcoRWwCmp5Af9UVnFjh409aObodHpoE6HXMSykTVptYp+iTMztGsj+4K2ECfov56w8LzGFACxbVO9N69mFmcsW/zTq3v48pfnhwNP0r/Oem8lEVDMBpqMB3IwL7w/5nOTYem3MK+3VbMvSovHbEEOUzOiRrk222NMWxeQYBegzrSPpu/uWEYRvcGFRc4EnMoIl2MHapjOlmG2wS5Yu2kICFQmcZT2hSrvUZau40GF/Py/CFdMQYnJijrkem8UcClep2Sls5HrTtoWouTEhMXoAn9YvrOm2f4xie0S1lhkEmHwSMj8Wn+AhBsmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kg7uj/qFKpOwfzzjLvOUUuYqxqejKyPvMiBhq0wYW2Y=; b=ehhC1+D4ktUT/Z3aPDqtJMw6sA+p7XHoBt/5KTt6T+uPwg0Mf+hes+lixv3rrZdxDMJnYL2WGLAYMvCcN5Eq/Occ9kbjfDatbeEnfYW+oupg6Fbyl5NKEYjSQYKc38CL6xTFDakdsTS31M4PBs8fC7y3uKKFFAUWNqWvZVdd5nm5ujMy+rlTEjeVgMxr9oc4g5oTFLjf4xiV/qtcfxeuZFOzn1po7wVkQ83uLgDoxijqb4T30+9RjcgEDUzk5YNQpNmyaOkuiwcaz+nbgtxMIsFlDewtxPWiTcZ4AIfKVKmgkRrktN8AZCPM38B8zuLqaob5m24nErPlsHZ6XWQsaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4457.namprd11.prod.outlook.com (2603:10b6:5:203::22) by SA0PR11MB4526.namprd11.prod.outlook.com (2603:10b6:806:96::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.29; Tue, 24 Oct 2023 07:22:57 +0000 Received: from DM6PR11MB4457.namprd11.prod.outlook.com ([fe80::f794:6269:c0e4:bd71]) by DM6PR11MB4457.namprd11.prod.outlook.com ([fe80::f794:6269:c0e4:bd71%4]) with mapi id 15.20.6907.032; Tue, 24 Oct 2023 07:22:57 +0000 From: "Chautru, Nicolas" To: Thomas Monjalon CC: "dev@dpdk.org" , "gakhil@marvell.com" , "Coquelin, Maxime" , "Rix, Tom" , "Richardson, Bruce" , "hemant.agrawal@nxp.com" , "Marchand, David" , "stephen@networkplumber.org" , "Vargas, Hernan" Subject: RE: [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200 Thread-Topic: [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200 Thread-Index: AQHY3mR/OJU5Izo8vEyVyrRhEklaea4nNV6AgAGKGiCAAAWagIIyE3pg Date: Tue, 24 Oct 2023 07:22:57 +0000 Message-ID: References: <20221012175930.7560-1-nicolas.chautru@intel.com> <3141057.vfdyTQepKt@thomas> <2968027.687JKscXgg@thomas> In-Reply-To: <2968027.687JKscXgg@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DM6PR11MB4457:EE_|SA0PR11MB4526:EE_ x-ms-office365-filtering-correlation-id: 8e3abb9a-8693-4c7d-5186-08dbd4620bc6 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jpDWnujgy7jeU56vFYdOOm2/tJNQO82lh6eiwStm6D1ImERwbmpHqRO82q43/wm24eNousZXSxHN2evvC9al8tmOTFf17pzaKrUOQ4AZ4dA6BgvQkT4Ic7MmnQ0kVY+Yj7dE8Ff1uxpZQN7R3FTTxFHCWG1Oz9Y+OOUjs3+qaZDqjBXgdE8EiHTX1x0W60KayZvtO9m2uYHFFUE9cNRUn31YdGpnbXmpcGa4QfKgl6t3OdMBDgONSxcbn5sObFGAZKF+IWxHLhvBNc0SaFnIAGsnAOInZcv2l9oLn+1XG0SaspQBY+49ICosUlBZoKbPx/+XrLiRfM7ovLRvwWxbJCiIzdZXG6FmJqWs5lq6nzsAiT6IZ2i1YB8XYmP16bfIAQeR1FIVMjZWjhxl+pbl4d2eQ4QmmzT2EpPpGYqUIISB2O6c5QTHeHGQFjNVvu7oUWNl3g1+bmmdNm9BQeLP0S8MQvbiiSsoIBvXZKGu/eaKgvfqiNZZUbI7SgHXM8gcTskrM7KcnMMFb7a4laQEa6y/rkFL/OwgjQkHgkFDn7Bzhnq0xdT0F8ZaXHtFb3YidJ7YqYR0Z1V7BefMZchubkjrV0WhZzp0njGvcp8PCa3OK1MqS1IOPmWPooSX+fhX x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4457.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(366004)(396003)(346002)(39860400002)(230922051799003)(1800799009)(451199024)(186009)(64100799003)(38070700009)(55016003)(33656002)(5660300002)(4326008)(8676002)(8936002)(52536014)(41300700001)(83380400001)(9686003)(53546011)(26005)(38100700002)(107886003)(71200400001)(6506007)(7696005)(2906002)(86362001)(66446008)(66476007)(54906003)(122000001)(64756008)(76116006)(478600001)(66946007)(82960400001)(6916009)(316002)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0R3ZvF7cDUMO+fvTLffyXBCbW+sbTZyXCKfBPMPRfXB2MjGrKXMJbrwErYVU?= =?us-ascii?Q?LWe+Np3/Kmb4el+rpBH0CxVpPj5NlRjd+ak6gimrDZ/1aj6RprDh4vUfebJw?= =?us-ascii?Q?HYHkXjtzd6Adf55m3OXqIU3md3RaDPXopfQcB4RrvZK+DMIefizob/qIb02d?= =?us-ascii?Q?x6mObyvAWjlz+SL9CN0oJNqqavtF65GdJ7iRRp+gbQWfrNjIXh6XrUsOAXnz?= =?us-ascii?Q?teyV37yDVXCgpL5eRgJ8ek51e/oGzVTDlyOK0d3p2DMHCEt49E99RoFgt+EA?= =?us-ascii?Q?0cwu6AAW++ov/3EjcWH6im4rjCDvEq4+e/qL5n0exlvRPFFCPZR+vvGAZmHb?= =?us-ascii?Q?RxuQ0VvKzLUtNZmoIlgwtawcF/QM+ByDyd2SQBgLX+MpHq13QoVw1lvnhvci?= =?us-ascii?Q?O369mnDAE2c5s49cUWKsIadzplyyT9w2Omnlchur1+692Ks4mlrDdvU+HFhJ?= =?us-ascii?Q?TUbyBKA/3rf8KKox31bxYFu7LxIpd6gAGz2uqgRyuOetoVO9QN14qJVyKtcI?= =?us-ascii?Q?d9srgNfn+Nobp0+1dRlY2qLyM7Wy+z9zpRyHxif6iytFRHNCS0bIRIVqtF2J?= =?us-ascii?Q?nUUpf9GfTk5tZZLjR3tqAZ2fQXB5HVdnqyqqTYDe06AyP4uwqNPj4PYpPCvV?= =?us-ascii?Q?ylKhFEJe7uv5vxwzM3ckrW7YLVsQ6aH39XwfAR0uX4K3+t/PTrWupdMrKMVh?= =?us-ascii?Q?MwVSVqPoqJgvUDndTmSUQ1LWawuXAYxuUKTuX6Xs0y3Fu8pvzVDKCKQdmhzY?= =?us-ascii?Q?JlO7xDBPPSk/DNxEG1c9+oVxguVYpQmCGkvalJqk+tsShwdTlvqiRfSUVDw4?= =?us-ascii?Q?OU5I+wYtArefSo4SCnZDBTx91qsFiyBA5NpOUKTF8aB+0EPMgBxn++62TLgK?= =?us-ascii?Q?KXyneHGKhxqKPdDFwT6AJA5sX6O7F1QFkKkJlEhfq/l9CxIM9D54JzJUj/Fb?= =?us-ascii?Q?5DyljJVJnRuNRHuAeFAsikD8jb8cvwEmbcfl90nVyNIM1luTMhfTsUfb50Sz?= =?us-ascii?Q?vfBONWl3P2NpGKodFR1AygmUnY6bOk0Wly6TJjTVgHSxzIrAbZQxOW8zmJ/E?= =?us-ascii?Q?q0I1bibTCdFlEPzyX+j1z1dqRXRKUIGvsLye4HdJI5YPx6dTzp6oAP9N6r9f?= =?us-ascii?Q?LYx4CdWvvLyAnplly3cMFHgz3AkCPyx3ZVp2MO5MAhAxELgsoJ4aiZqnZ+Ao?= =?us-ascii?Q?EsTc6RfzqkyJk295esKTMuxsRZB5OyLDAOaKntVk8F7Ep6/q1fL1rm0lktLd?= =?us-ascii?Q?kUtkfPTRsN3OKel3Yy27+KcBJKtavJ11rENtKfmp5EBisM74DzfKzq5K5zxf?= =?us-ascii?Q?36kitqd/85/9oMippqA7ZnOLXn1UORNJJzxhlfbmq1TcgwEWPMJDjfPP18ie?= =?us-ascii?Q?bbzOh1Uqg4HbA73yttd67gTdvJ+/nsjXyCSCs2hgtpQ+P1QMZz/HdLREdvO0?= =?us-ascii?Q?ZdjiTabzyhE65bF81kusHS8fTRh/C4EuKBXYcYNNi5c5YfFmXo8UVwFXofFb?= =?us-ascii?Q?j3uPyu4hJZcKncD1iZVs+qqtfTRbW7WDe/qfZV42x24JtylFYJoWS8Gkt0c0?= =?us-ascii?Q?M08n4mYCeQI+Cm99fKtlJ+gI//lU4qQfHHC+n81mSBorMKGWF3bBW3vJVA/E?= =?us-ascii?Q?eg=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4457.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8e3abb9a-8693-4c7d-5186-08dbd4620bc6 X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Oct 2023 07:22:57.2404 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yBzzeLf3WG2eWvdIotrCkU2rulIYYt2dX+gLgXkbbT0iNrhVwNmrpMimf64fGH0jxHCnAtjEsRPRAuy0UskurejIRJy3i0m/bhu1EhNk7t4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4526 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Thomas,=20 With regards to your statement "igb_uio is going to be deprecated". Can you= please clarify whether this intent is being documented or captured anywher= e please? In any technical meeting minutes or any other DPDK doc or communi= cation, as I could not find it? Much appreciated,=20 Nic > -----Original Message----- > From: Thomas Monjalon > Sent: Monday, October 31, 2022 4:54 PM > To: Chautru, Nicolas > Cc: dev@dpdk.org; gakhil@marvell.com; maxime.coquelin@redhat.com; > trix@redhat.com; Richardson, Bruce ; > hemant.agrawal@nxp.com; david.marchand@redhat.com; > stephen@networkplumber.org; Vargas, Hernan > Subject: Re: [PATCH v12 04/16] baseband/acc: introduce PMD for ACC200 >=20 > 31/10/2022 16:43, Chautru, Nicolas: > > From: Thomas Monjalon > > > 12/10/2022 19:59, Nicolas Chautru: > > > > +Bind PF UIO driver(s) > > > > +~~~~~~~~~~~~~~~~~~~~~ > > > > + > > > > +Install the DPDK igb_uio driver, bind it with the PF PCI device > > > > +ID and use ``lspci`` to confirm the PF device is under use by > > > > +``igb_uio`` DPDK > > > UIO driver. > > > > > > igb_uio is not recommended. > > > Please focus on VFIO first. > > > > > > > +The igb_uio driver may be bound to the PF PCI device using one of > > > > +two methods for ACC200: > > > > + > > > > + > > > > +1. PCI functions (physical or virtual, depending on the use case) > > > > +can be bound to the UIO driver by repeating this command for every > function. > > > > + > > > > +.. code-block:: console > > > > + > > > > + cd > > > > + insmod ./build/kmod/igb_uio.ko > > > > + echo "8086 57c0" > /sys/bus/pci/drivers/igb_uio/new_id > > > > + lspci -vd8086:57c0 > > > > + > > > > + > > > > +2. Another way to bind PF with DPDK UIO driver is by using the > > > > +``dpdk-devbind.py`` tool > > > > + > > > > +.. code-block:: console > > > > + > > > > + cd > > > > + ./usertools/dpdk-devbind.py -b igb_uio 0000:f7:00.0 > > > > + > > > > +where the PCI device ID (example: 0000:f7:00.0) is obtained using > > > > +lspci -vd8086:57c0 > > > > > > This binding is not specific to the driver. > > > It would be better to refer to the Linux guide instead of > > > duplicating it again and again. > > > > > > > +In a similar way the PF may be bound with vfio-pci as any PCIe dev= ice. > > > > > > You could mention igb_uio here. > > > Is there any advantage in using igb_uio? > > > > > > > Igb_uio is arguably easier to use to new user tend to start with it or = specific > ecosystem. This is typically the entry point (no iommu, no flr below the = bonnet, > no vfio token...) hence good to have a bit of handholding with a couple o= f lines > capturing how to easily run a few tests. I don't believe this is too redu= ndant to > have these few lines compared to the help in bring to the user not having= to > double guess their steps. > > More generally there are a number of module drivers combinations that a= re > supported based on different deployments. We don't document in too much > details for the details since that is not too ACC specific and there is m= ore > documentation no pf_bb_config repo for using the PMD from the VF.. > > > > Basically Thomas let us know more explicitly what you are suggesting as > documentation update. You just want more emphasis on vfio-pci flow (which= is > fair, some of it documented on pf_bb_config including the vfio token pass= ing > but we can reproduce here as well) or something else? >=20 > There are 2 things to change: > 1/ igb_uio is going to be deprecated, so we must emphasize on VFIO 2/ for= doc > maintenance, it is better to have common steps described in one place. > If needed, you can change the common doc and refer to it. >=20 >=20