From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B3B3A0547; Wed, 21 Apr 2021 15:02:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33AA841AE1; Wed, 21 Apr 2021 15:02:10 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 20400410F9 for ; Wed, 21 Apr 2021 15:02:08 +0200 (CEST) IronPort-SDR: /2rPFLQGrkn/8hkdDdQ5qepu5Ll8nkL3JXrxwibXrLfp5mnR1Qj9Am5Mf5rUjeH/XTZ8oDHOu6 s1HXWFQvNljQ== X-IronPort-AV: E=McAfee;i="6200,9189,9960"; a="182822545" X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="182822545" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2021 06:02:07 -0700 IronPort-SDR: kI52/4WPmStto9lW0CcvmlRZK5urlG+eoAcEWoWUbDQ8dT7t7GviwQ7FxvLJX0TIu3TFuHa8iE Rxa6Am4q+Yfg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,238,1613462400"; d="scan'208";a="614082482" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 21 Apr 2021 06:02:06 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 21 Apr 2021 06:02:06 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 21 Apr 2021 06:02:06 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 21 Apr 2021 06:02:04 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=U+Mpn1minfSXOnmQ7xSrew405cXKW8wt5MEh6HKIw+MAKjy+LfiKSpibU8rOI7hcqyIxPztOd1ceDJakHyb0/KdE8y0/RjnoJ7bcJ4vb+fifeQV7smjvZPYlAVb+jExUauQ5rvxlC4T2Rt99EMfDkrC8hOaa9ywdqHkb02rnfn1DYIF+SSHtyufdlpuEnRo2hUMHNYHNxYIq/PHq2tkVpfGoZRboLyDGgibieTQI08tFWEACZTDf1Dif/nhTjT+S1oqC+72bpu3Qu5/D6zrxvxpEcgu16N9zQGdSTVm9lgYZwAGUDsonGiRN/6q1LKEyfYoCEwArjKn13sWti8E0zA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x0nlYAXiYuq0ZUh1J5vLAles8H4GHZ6B/Z3BaIURa8c=; b=hQjArB3ytx4uLcS5npPghob7XLn57WFODcnEBc73B5duFYjodZfl97D9Q+B/iOp56CagLHy6IaWLU48R9oeTsolGRNJwIdG2z4oMV2o0/Wd2CLR63PDbekniLuFSyjZnv+gBB1xoYqtqA5ryYsaVAvxSQaPzUMXJVotYoYVqL1NGRjbCaxuiiUs4nMouWgMXKQOu7u0qA9a6a8odmHo5kByf9xwI+cJRIpeeD5cVDjQcAljpszyjNKn0FH+VQOVxrnNORH5qsVc7PhoQAAXNNu3f/9qxDD7tW7UYrbIzqqbz5D/6lzwuNDpNGf61pgJSNdoQtizL2bZU7ZX/uWkE1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x0nlYAXiYuq0ZUh1J5vLAles8H4GHZ6B/Z3BaIURa8c=; b=cgIrzklrJHsCkWcJFYAuy2jAk1n5Q19ZPFEBY5OfJC6aSIRZk4jwA8VONIp8+AnjvUxXGtNG9cvt9nh8XGRA5EJXtLpryPOMIIrGykPZk6mD8WMpLXRC4ahEVa1GxmmVJk7BP5GNys7jgat3Fe+VqXAuBx9eAVfh+qu50dAexIw= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM5PR11MB1339.namprd11.prod.outlook.com (2603:10b6:3:d::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Wed, 21 Apr 2021 13:01:59 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::3182:6da2:8c64:f07a]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::3182:6da2:8c64:f07a%3]) with mapi id 15.20.4042.024; Wed, 21 Apr 2021 13:01:59 +0000 From: "Ananyev, Konstantin" To: "Walsh, Conor" , "thomas@monjalon.net" , "Ananyev, Konstantin" , "Medvedkin, Vladimir" , "kathleen.capella@arm.com" , "honnappa.nagarahalli@arm.com" CC: "dev@dpdk.org" Thread-Topic: [PATCH] examples/l3fwd: fib skip tx queue drain on first iteration Thread-Index: AQHXNqy1OOxA6B2wS02BoC2dkWYGoqq+7jjw Date: Wed, 21 Apr 2021 13:01:59 +0000 Message-ID: References: <20210421124842.1550979-1-conor.walsh@intel.com> In-Reply-To: <20210421124842.1550979-1-conor.walsh@intel.com> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.184.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: afb0123d-fe93-40ab-9d32-08d904c5a62c x-ms-traffictypediagnostic: DM5PR11MB1339: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:359; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5ExzPTvlQZmdLXj+HMkK+fyb5Rpq1Z/ZFK6h7JeKzqA5hym1y34nXdF7nPHZjO499ewDNyzZqTUCv/c/NpNvTk2X13vfvgObTQET4yM2Y1zEpK/O5JQ78anzsfpaZvJb2XV+k3yPhReMoMFXiWe0yOm5flMiijGb7y0PcZD3wi5rznDOd8qzvDOqhqADRWFAjXSZdygXSxcpHl7CP9XKtPF4pFMOQSlsg3/C6KnM8/hkK28S9InaS0rGwCBK15yXU6tpwZO5pZIoGQDWVHONI4+WvNudOLkBBpMKXfSLfTleiLUGb7lPebgTPiuprJ38tXiSlD5Bu/DvEada01fBHz6yRVFI/G6QTf69kChL4qSZSVR4nBPDKX3BcBJKXjAvmOU/EWcudLO7Hn0Fbrq0KUQa65TLqHc/pmBwN/ixVauS6JaMMzvQZsbPNV0qnbRBi2J2pJbahZgo3vg4zSFye6PLG6HwMYH6ZedycfteN/lZQ9kmhIWOJhcx5KX+60Y4eaueB+x4ZNO90zW4DXIMOEJMPs5vkZWJIsEtwFth1IELCWkeE39ADsjgwR4SOBZhbBkP41zIRW1S0ebQb5hZj+1/SLpOa14UAfp8eKhXzzk= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(376002)(39860400002)(396003)(136003)(346002)(5660300002)(66476007)(66946007)(66446008)(76116006)(110136005)(7696005)(6506007)(64756008)(33656002)(66556008)(55236004)(316002)(52536014)(186003)(8936002)(26005)(8676002)(71200400001)(2906002)(86362001)(38100700002)(122000001)(478600001)(9686003)(55016002)(83380400001)(4326008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?hrye+Pi2mhwNw+U9MLJfo+QNAFOfcW57AqjoCzDBkkgUhzIxRnw4nmWLzVrR?= =?us-ascii?Q?R9uyp0su3ksWJHJ+dnX5eHHfcmVqGVEHH5cudJpwIi7CknwvoYyYTfEq45Ks?= =?us-ascii?Q?rS+ARBUV2xPgGqU6sNtKVsINQtM5GniVokloQODeQc5ePg48k1TOqEASPC71?= =?us-ascii?Q?G9wUsn71Tc+GPt8SgyH0RnwAu6RHFItwcMkq/YqRyCIgL4eOJ/00HfqsrSB+?= =?us-ascii?Q?ZUzZQ5p7uEXJbMCxh9XlvcQehAUW0qZw+iW2/i/ZPBjgz85ZlZggSZ0AAyk7?= =?us-ascii?Q?CAtkttSkR5Lf7z9JBXBCsdHXGbYWS/0GgH9umMBuguK++D293Wj+biMEb6Po?= =?us-ascii?Q?ZR1jHcMr6HuYmKOjspugzHOLzYIbH1ryLt98gjTLcUrxn1UKkorHCkQX1RmG?= =?us-ascii?Q?W0TwfqVRT2+1BwFLaxtLizUKUlmLqePKlyagJ8yPnmyHqjwUjHf1gzzM3+mS?= =?us-ascii?Q?vzr07Qmfe4UFqFR8cupz+5PohYNuIZ9FFW5i2OUWjjMUKQmr2z59JP3tokHE?= =?us-ascii?Q?mzUykEEbu3R9f80pTN7PtTpuv8oMKFza0/ge5nMfHxY9/jTKkQE4CAvHPg0B?= =?us-ascii?Q?LV6f6X4a/h09wgoJaZW1GrypHtNIZlJqdV0r0AXrXOzb2RIwly1r670ToHNr?= =?us-ascii?Q?9htywrXycwyPDLSckg24Ew3KtrZygM+UXg5S/jxIF34OUb7RpXN3iW8cVuTo?= =?us-ascii?Q?cpVuHNO2OrEdUlG/hlUqFqkCW5Y7rCuyQjjt66XV8L8ElTnQw0Hvh8e0vk9I?= =?us-ascii?Q?CXQa8LaimRUJnbDIuGpO1lWMWwUL/mEL+8bdWFZOfqJ9bGk6Km6naB32I7Ah?= =?us-ascii?Q?6jbqiYb+z2GNPVzZfAjaxsA2dbKRQb9Msv/QA5lHnl8h4xppzw/c0RP03b18?= =?us-ascii?Q?q7nmAC7umX2TB1yx98F09rnNnaK8to/p9s9htUQ6yOrmmTYlDiPyoKvtI3eC?= =?us-ascii?Q?h/sVop9QSJ8CEMINgfjvsvwU9G8btoe93hKRjP0dln2+Acu5Dhz3aoP+66Kz?= =?us-ascii?Q?F6sp28FG2spUCX+hrMtFcWr8XCkK0h/2lvoGszFYbw3qI4bWPDKpRO8kafdu?= =?us-ascii?Q?sFcsLidwjeKda6EHWaOddwMCBhs4iJ2AnwfAhuH4ws+PIOZDiIIRVSl+diaH?= =?us-ascii?Q?Yk1ukFCugBlr5eh2oaX52syyz0ltakCaq7MF2l1P8X9ZbcXn7s/tW6u667in?= =?us-ascii?Q?4A8yE6lbWyWaNETT9rYC8sRsP2pyrR9YI4tmtM3hhP1RFMOaJWdxb1z0PT+6?= =?us-ascii?Q?/TNFO5D8QIarzjk/MPfh3UDd1YWdHN87mFhhI8bU1hjuO1gsMHNh4v7nwIci?= =?us-ascii?Q?ypR1k7gyvrS8bwX5uhwdxXV4?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: afb0123d-fe93-40ab-9d32-08d904c5a62c X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 13:01:59.1736 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wtiIBNqDg5HBKgjrx9vPK7anRPNh2ZPPtnaupiC2CEprrQxNl2SSDvmjrWnfIoyt4+A6Di04naQinARm/n0hB+9J2hZU28G/ORbac7Dg9Qg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1339 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: fib skip tx queue drain on first iteration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > The commit a8f8b672d575 ("examples/l3fwd: skip Tx queue drain on first > iteration") implemented a change to the em and lpm lookup methods to > prevent the TX queue drain running in the first iteration of their > packet processing loops. This patch introduces this change into the > fib lookup method, this was done to keep the fib code aligned with > the em and lpm code. >=20 > Signed-off-by: Conor Walsh > --- > examples/l3fwd/l3fwd_fib.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) >=20 > diff --git a/examples/l3fwd/l3fwd_fib.c b/examples/l3fwd/l3fwd_fib.c > index c7d7689a94..1787229942 100644 > --- a/examples/l3fwd/l3fwd_fib.c > +++ b/examples/l3fwd/l3fwd_fib.c > @@ -179,8 +179,6 @@ fib_main_loop(__rte_unused void *dummy) > const uint64_t drain_tsc =3D (rte_get_tsc_hz() + US_PER_S - 1) / > US_PER_S * BURST_TX_DRAIN_US; >=20 > - prev_tsc =3D 0; > - > lcore_id =3D rte_lcore_id(); > qconf =3D &lcore_conf[lcore_id]; >=20 > @@ -200,9 +198,10 @@ fib_main_loop(__rte_unused void *dummy) > lcore_id, portid, queueid); > } >=20 > - while (!force_quit) { > + cur_tsc =3D rte_rdtsc(); > + prev_tsc =3D cur_tsc; >=20 > - cur_tsc =3D rte_rdtsc(); > + while (!force_quit) { >=20 > /* TX burst queue drain. */ > diff_tsc =3D cur_tsc - prev_tsc; > @@ -233,6 +232,8 @@ fib_main_loop(__rte_unused void *dummy) > /* Use fib to lookup port IDs and transmit them. */ > fib_send_packets(nb_rx, pkts_burst, portid, qconf); > } > + > + cur_tsc =3D rte_rdtsc(); > } >=20 > return 0; > -- Acked-by: Konstantin Ananyev > 2.25.1