From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: David Marchand <david.marchand@redhat.com>,
"Rong, Leyi" <leyi.rong@intel.com>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: add Tx preparation for vector data path
Date: Thu, 1 Apr 2021 13:19:50 +0000 [thread overview]
Message-ID: <DM6PR11MB449129AD6A0DF2BF7AD53AB49A7B9@DM6PR11MB4491.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8zp1rhJucNVTW9agWw7cTBNMmgsyp7es83CZz75+H+RTg@mail.gmail.com>
>
> On Wed, Mar 31, 2021 at 11:17 AM Leyi Rong <leyi.rong@intel.com> wrote:
> >
> > Fill up dev->tx_pkt_prepare to i40e_pkt_prepare when on vector and simple
> > data path selection, as the sanity check is needed ideally.
> >
> > Signed-off-by: Leyi Rong <leyi.rong@intel.com>
> > ---
> > drivers/net/i40e/i40e_rxtx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
> > index 61cb204be2..b3d7765e3b 100644
> > --- a/drivers/net/i40e/i40e_rxtx.c
> > +++ b/drivers/net/i40e/i40e_rxtx.c
> > @@ -3412,7 +3412,7 @@ i40e_set_tx_function(struct rte_eth_dev *dev)
> > PMD_INIT_LOG(DEBUG, "Simple tx finally be used.");
> > dev->tx_pkt_burst = i40e_xmit_pkts_simple;
> > }
> > - dev->tx_pkt_prepare = NULL;
> > + dev->tx_pkt_prepare = i40e_prep_pkts;
> > } else {
> > PMD_INIT_LOG(DEBUG, "Xmit tx finally be used.");
> > dev->tx_pkt_burst = i40e_xmit_pkts;
>
> I find this a bit surprising to set this op at two different locations.
> Why not simply leave the value set in i40e_ethdev.c?
>
Actually I wonder should we set dev->tx_pkt_prepare to point to i40e_prep_pkts()
for simple TX path?
As I remember, simple TX path doesn't support neither multi-segment packets,
neither TX offloads.
While i40e_prep_pkts() assumes that selected tx_burst() supports all that.
If you don't want to keep dev->tx_pkt_prepare==NULL for simple TX path,
why not create a new one: i40e_simple_prep_pkts() or so?
Konstantin
next prev parent reply other threads:[~2021-04-01 13:20 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 8:53 Leyi Rong
2021-04-01 12:27 ` Zhang, Qi Z
2021-04-01 12:33 ` David Marchand
2021-04-01 13:19 ` Ananyev, Konstantin [this message]
2021-04-07 16:39 ` Ferruh Yigit
2021-04-08 8:29 ` Rong, Leyi
2021-04-08 10:32 ` Ananyev, Konstantin
2021-04-09 7:19 ` Rong, Leyi
2021-04-09 10:40 ` Ananyev, Konstantin
2021-04-13 10:23 ` Rong, Leyi
2021-04-13 10:41 ` Ananyev, Konstantin
2021-04-08 8:39 ` David Marchand
2021-04-08 8:49 ` Rong, Leyi
2021-04-19 8:36 ` [dpdk-dev] [PATCH v2] net/i40e: add Tx preparation for simple Tx " Leyi Rong
2021-04-19 9:36 ` Zhang, Qi Z
2021-04-19 10:59 ` Ananyev, Konstantin
2021-04-20 5:31 ` Rong, Leyi
2021-04-20 5:29 ` [dpdk-dev] [PATCH v3] " Leyi Rong
2021-04-20 8:03 ` Ananyev, Konstantin
2021-04-20 14:00 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB449129AD6A0DF2BF7AD53AB49A7B9@DM6PR11MB4491.namprd11.prod.outlook.com \
--to=konstantin.ananyev@intel.com \
--cc=beilei.xing@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=leyi.rong@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).