From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7B91A0A02; Wed, 28 Apr 2021 00:23:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60458410D8; Wed, 28 Apr 2021 00:23:45 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id DA8A140147 for ; Wed, 28 Apr 2021 00:23:43 +0200 (CEST) IronPort-SDR: nHH6JVwAr2j6U0KyuMYne1Zc8saZSYMywzjShKpXRjZ3vLde4HEcHQq+hYqFOIfuGzFi+j2JBb RgGhoqbZ/f/Q== X-IronPort-AV: E=McAfee;i="6200,9189,9967"; a="184085034" X-IronPort-AV: E=Sophos;i="5.82,256,1613462400"; d="scan'208";a="184085034" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Apr 2021 15:23:41 -0700 IronPort-SDR: MJk+3Y3ja2YM3H1VEhEtsU7wNNAJUulgkqAgaRovP8JizTt4Op7K1bI0vbOqpK8DIQwXH2gGwa Zx7OlxLx9NeA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,256,1613462400"; d="scan'208";a="423238921" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga008.fm.intel.com with ESMTP; 27 Apr 2021 15:23:41 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 15:23:40 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 27 Apr 2021 15:23:40 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 27 Apr 2021 15:23:40 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 27 Apr 2021 15:23:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=epzPHG7wsNjToh3IxNy06NY3P4/mihxkGD2J4mZDRGKUgR8msBkWpv37O+Mr5NVKxK/RB1AOOSEDRW8Wl8ci56x+ntvBRsHl73qPDZUhbOq4ei6OK4gW5ZJxsIEE9XjXSOhX8ESmzriGnlM8xy1RH11MQBa3HRkrLsFneDHhujHq4qbORFNldPJ3QCUL3KKwkPPVMGwIN44lqywxFnrg23l2xhewyQHZqkqqy7pQK68QZXql4AEgSZWu+TCFcrhiUgpdOcsdXIMd9atPP0ykdY1M2FELAvTFmlJHkcODd+h4M9xq9wAq/RIZejG5YWO3vBnqo+JrMZ+Mq+TZFkDbiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mSdbENDrHUOTNUuVprf49S37GnZ7EIzXMj5gKYybMTE=; b=hgmLZqV91T/yq3UNxibjUq+JlqUF3z6KfM7qZnAYWIMN20HtxKfL2X5mYcClvjbAi+qM08IteitcBsrWEHtK7ibYNECpl9ri6flS/lkDWhBlGOMs8DOgw2QiZJT5D0yAab2920j4UWir2MiwQJxd8jGKa78MSIHbowqcBie81a5HhKBUlgGwvhvoasJ68XIUsO26KnLsPDK+PKlC/iW8fBHDubC0P30m0fLwFfuaOduwj5Aex35g/8LbuJ8c4PGybWL493uwqrT9OOr22MOs9p3tuvej/V5f4pc5VcH9AEU4mu8kIXxiuzjr0Vu9zk8ItY6rQm/E1fCIEQrumDzmCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mSdbENDrHUOTNUuVprf49S37GnZ7EIzXMj5gKYybMTE=; b=k9mxbWWB6YIgdmh3IhVdDWxH9nQ1Fvi/ZXhD91GZjW08bh7Gb+oCOLWITKcJ717UMUmgZZZkNl9TXjGWEL4z6/VkpK7ZsOZs9jz1xDzQ1agY4dLdIr83RaKw5SlCeywCxfUdnU2I4SkBG5b2N+78wMW5cdL3aFA44k69mbbTU70= Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by DM6PR11MB3273.namprd11.prod.outlook.com (2603:10b6:5:56::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.23; Tue, 27 Apr 2021 22:23:38 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::15ed:b4f4:540e:ea0c]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::15ed:b4f4:540e:ea0c%7]) with mapi id 15.20.4065.027; Tue, 27 Apr 2021 22:23:38 +0000 From: "Ananyev, Konstantin" To: Honnappa Nagarahalli , Stephen Hemminger , "Yigit, Ferruh" CC: Jerin Jacob , Kathleen Capella , "thomas@monjalon.net" , "dev@dpdk.org" , Dharmik Thakkar , Ruifeng Wang , "david.marchand@redhat.com" , "Richardson, Bruce" , "jerinj@marvell.com" , "hemant.agrawal@nxp.com" , "Ananyev, Konstantin" , Stephen Hemminger , nd , nd Thread-Topic: [dpdk-dev] L3fwd mode in testpmd Thread-Index: AdcV2H0Bhkmz7z6QTBeC8FixZy3dngAaQ6AAABIFuOAAAQNCAAAAQNqgA/efEhAAAYi7gAAF6HhgAAl7GoAEe3+OoAB4fPWAABDYiwAABc478AAb06kAAAz1JoAABPozEAAH+U1g Date: Tue, 27 Apr 2021 22:23:37 +0000 Message-ID: References: <2273212.ItJIoklBD0@thomas> <20210426104720.2b892045@hermes.local> <81781e97-735c-f584-4148-ff07dedc5cb4@intel.com> <20210427090121.4f6f0089@hermes.local> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.255.184.192] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: af5a6404-91d5-4f97-a0f4-08d909cb1ab7 x-ms-traffictypediagnostic: DM6PR11MB3273: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OcH+i5yPlVtk/iFINNKE2iBYcAdgevNJavpP88j4fzb2oLNI3tXtr7Q3XhlPZBdWUgYtV94l/AcwOJsTc4wpCiaO3D4jIPO0RIRT9hPdesrvYim1gBw38afae5T+1kIoOQqQrdlUR3Jyw8E2Np+XX94QxfUzTpvX2QYNbcYDcNO4pb23L6Y896BcSxKPScwEQ21iusowKXCpyNZ8vrdZKa4aP74mJgMqF+evH5/Qn6tb3wErq+v2vivbdm/O8eeW+v4gB2j5OVLtpEGcRnxTtyeD7d5Xv1LM1HacwmBd1rSiofY0ydRZV5faGsQEOgNNCZO0dYrevfayqh5SzU9i+vaqGxuEh1VXJ+WYd0wlxCktbkNNqx00DkcKWeab0dpIV1JXVpiaY7NQbCmjybjUQ2RODBBd6NFoaW6j6h7U4/oBYqHbObO3ybXUQlyo7QIMKlG6bUxFdY37zXzNWhS1oLimf7Q3a4j/2Se9hT8WJNTXFuY+s+qtPvIxyooyAQ03uiW2GOqDnZvWOT3YOOVyFwy0sluO79YNr0YZj/HEjQQAQQ68uTemgS0jwx1JahCqtWlG0cjv/QEeTzLNyJoEHhHSlmnJkNkTEdnbLMquqjXorcj45rZmXgNZQHZMPl/VY13VGY/wSOUF6pNG6j5GPg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(39860400002)(366004)(136003)(376002)(346002)(396003)(7696005)(2906002)(7416002)(86362001)(33656002)(4326008)(66946007)(186003)(5660300002)(6636002)(8936002)(110136005)(8676002)(64756008)(66556008)(66476007)(38100700002)(54906003)(55016002)(9686003)(66446008)(316002)(6506007)(26005)(122000001)(52536014)(71200400001)(76116006)(55236004)(478600001)(32563001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?NuUL9R9VE3nu19ZXOmD7CumLn+zl2RPArBs/qUuwPlybSfXo/XMZJ8JabIkX?= =?us-ascii?Q?T7a8rZNG9bVfNMN0AF/76mYNJQEAisnuKOSFIeLQQssoEc866OI54M8tkqbb?= =?us-ascii?Q?XlflMBnHp4nrxmBC58DlF6lbEUeQ12Iw7hQKA8v0tWITscF/+kvZcQhGwMhT?= =?us-ascii?Q?XF+wqqBtIebN2epgsdY1viTwcwReC7k+DzjI+RRBz8LZKeObBJb9oR8EDAgx?= =?us-ascii?Q?f3ZMgKMVOFmxV/zUl3OEUHyZqcwV0zmGHcGN0RwKPh0xxG7f61kGw63ahnHN?= =?us-ascii?Q?uzDCcFGBXF60zKszHYh1m5QzbvcPBxC9qxXvSs6t7nXGPbn2GbYIqEHVhDLb?= =?us-ascii?Q?DU1BmONAfnNXg+UOlg3zwpTBqluABaf3C1Ksw3hLsr4eIB1vdf1TaNv1Xyzm?= =?us-ascii?Q?dDN/KlDP7SLVN59QrMvrhjiuGz9JxhK0qeo1ainj1Onv0GTpzygkETD5P+Mo?= =?us-ascii?Q?TFOByUeKfBPlQ5zTIEvaWaTo3nSLXT0py5tiM92kGL7+wD1fmqSj0lwQabta?= =?us-ascii?Q?4aPe5njANTOUtL9skdsR1ozAme6nCtFz5bMaic8Cwox5RmFYrfnvMkf3Qash?= =?us-ascii?Q?ajyAYdBVt88VPXLQ9llMqgAzyAsmH2VN685YXXq+HPTZUrLZawSxVwP7CQdM?= =?us-ascii?Q?m9QGedw+3ApQk/qXyiIIbP++Rl6IC73wmAUGzQJi5uFCic7+7PVjfu4wXN5n?= =?us-ascii?Q?olGD2ZA5hmT1FWVSmWq7ZQcvqSJCt3F/rM9JQbAgSSTHCOp4ao9Vt98cp98f?= =?us-ascii?Q?HJRVqT/XpKu3pG/XEWTcgzMBH8zTEU2I5St8Kgeik7yCltwpUv2wU5rSPjXo?= =?us-ascii?Q?z01ca/ea400Nw6S6Jxy4jMplNWC70Qir+6FBErHxZuBt5KPoITjy9r1+O32L?= =?us-ascii?Q?73TZpSFXrRf7s8gPdQ1HYgu0e38IqEBHAxxkGYZILXjTzvlwnbhNNx9o6Plw?= =?us-ascii?Q?mNtKD6xfhpDYSTU2QsW0J5/5g6mvqxI7eHO0dz/gKgLgF2KAnh4gY/3WJpfe?= =?us-ascii?Q?rr2WC4vhh8Uam7ke4OW9jS88MUOFa3+U8Iz3I3rBAPJZ0Q0LuZPL3q0og28K?= =?us-ascii?Q?0DqxK7Hi7FKI8fqWk+z3w5er5c3XGvLV7mBHYuqfvb956qU0E++UaA0RKMVE?= =?us-ascii?Q?VZXI7TFpTFG3WmAhBnkW6krnQXUEoC/DAH0KSDSpEZKz3RoOUuGRNu88Mt2U?= =?us-ascii?Q?xQM4ML5YjR7O+l+XGK+gUZg5+8nH0nTiadGSDoxA2M+0ooUQRwaLYIk37gpW?= =?us-ascii?Q?NpYcuvZ396XC91LiZqj6cXZt5K56mcstuh1bp7FGmHiz5exYO8HtwHNBMHv7?= =?us-ascii?Q?6yVPpU+BAum/Y4P0Lv2wMpCD?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: af5a6404-91d5-4f97-a0f4-08d909cb1ab7 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Apr 2021 22:23:37.6861 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qjDFR1WwsOvvC8FlC2RwKuriqwfCQ3SUHNnFWt6RKV3ZsrPEL6QOjFFAKO/FNOUgjVFxgOemD4EClvxKXjk+OwettGz91NezlF3qMFN8Tag= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3273 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] L3fwd mode in testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > > > On Tue, 27 Apr 2021 10:50:20 +0100 > > Ferruh Yigit wrote: > > > > > Agree that it may help testing to have l3fwd support on the testpmd. > > > > > > Two concerns, > > > 1) Testpmd already too complex. > > > 2) Code duplication. > > > > > > For 1), if the l3fwd can be implemented in testpmd as new, independen= t > > > forwarding mode, without touching rest of the testpmd, I think it can= be > > OK. > > > > > > Not sure how to address 2), also lets say we want to add new feature > > > to l3fwd, where it should go, to the sample or to the testpmd? > > > > The original purpose of l3fwd seems to be getting lost here. > > It was intended as an example, not a complete test or real life applica= tion. > The issue is, this app has become an industry standard for performance co= mparison between platforms (whether we like it or not).=20 > But, it > does not have a whole lot of debugging capabilities. Ok, could you list what exactly you think is missed? If we are talking about extra stats, then I still think it is probably easi= er to add it into l3fwd, then pull whole l3fwd code into test-pmd. > I think adding a L3fwd mode to testpmd will be helpful to keep the sample= application > simpler. Hmm, not sure how these 2 things are linked... Why let say adding fib-fwd into test-pmd will help to decrease l3fwd code c= omplexity?=20