From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A5C6A034D; Wed, 12 Jan 2022 11:22:38 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 344FC40141; Wed, 12 Jan 2022 11:22:38 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 67A4240040 for ; Wed, 12 Jan 2022 11:22:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1641982955; x=1673518955; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=p2dfufg9YMeIEqPi02tsz/sc1KTYO16h6Pk9KaRUkbU=; b=eKPHFUF5sfbA/B9CKxBnAgY0D2BgGvL3y5KjVJj/sF84aan3b0sP6NxW IYCLf8brojeV5BkD/6QMkx+zlyra/1lA2z0KPga6ra+rX8b/CxQr/17oG LX5+Gabt2vG4sVyfTMlbkRyoQIx4xD+3pfDTLDQbjWWGQRSNUhq0whgzO Kh9UOB9GfWGFBu2TGsWw4LjyWyBVTHfKIga4qAJlXu/uVbks/NQ9kJocD bW4vBcVsZpADG6N0ZZkeqpNbbojJegVJ5yEwqwg2BBsISJzO4v9YThzSB SAv8i/+R7K20uF5ADLDtf9YuJdHSzb9IdoOOQiaJ0kx7ZsrL9OtZHL2Cm w==; X-IronPort-AV: E=McAfee;i="6200,9189,10224"; a="242522391" X-IronPort-AV: E=Sophos;i="5.88,282,1635231600"; d="scan'208";a="242522391" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 02:22:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,282,1635231600"; d="scan'208";a="620148642" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga002.fm.intel.com with ESMTP; 12 Jan 2022 02:22:34 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 02:22:33 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 02:22:33 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 02:22:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VS49g723UhM/eXis1O1OKJ1f5dL1wfCpAHUlWoxc/7NX37jgHzizxgZnHgdQIKpQ201Ql4w7C6p8bYMWJaHzg83uQq4e633LzSBH8Tung+IbUwgM0pLaSAfsmNl2yM8+SI5Vwsunmp/6QZQJ06X/RcA80++qgi6bXCmmTrcDNjEMD/1TGCzO/IhusVxoCYEWxE35HIMKyU7epfiguB+zxbnVqTyCcbk13JqNkI/n/aVJycxxmQ8xyXLW7jXEREu2JWmD+GJeZWm4b+8b6TbgdPB9P/c1ieH7U0Yn2MeXQMbQcHTaLuWkzomVO9ipoxC6HeWNW0MZi4wt/1MMcnaH+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0K+JDZHM9g0RbqW81NFvQE+hCWyYyJcoUeasChyWyd8=; b=UQRI3ytIIjP1IFuXB9W6tl2Njwo/Js3Kud4+Jm7TB9bGSUWB6J9LrScCSgfxeKEY53z3825IjAzef0swFIpTtotRk+s+u9FGi4zZ1FiOvm2kmwJur4W0LkJwRuKU24CX4mbVFnabgI5Un99QsqIYWwOswKzdAZ7kJZV7PRuRSOA0/f5Ne2VFgyCV/khi/Yq1i11RP5JUFTWNqf1B3npP2836JJFLvg0Aig4XrFU4nc0bgTdCmvOEm2jALukI4Orr7IH1pDwSd2r6RZjYHvbEKSeanK2ak8LcQEezGbpOMo8qCtdo/LqvUfp3rvEBJBeI6E0peAAA8WBno0GtopMDtA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB4491.namprd11.prod.outlook.com (2603:10b6:5:204::19) by CH2PR11MB4311.namprd11.prod.outlook.com (2603:10b6:610:3b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.9; Wed, 12 Jan 2022 10:22:23 +0000 Received: from DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::7de4:731c:cee2:49c2]) by DM6PR11MB4491.namprd11.prod.outlook.com ([fe80::7de4:731c:cee2:49c2%3]) with mapi id 15.20.4888.010; Wed, 12 Jan 2022 10:22:23 +0000 From: "Ananyev, Konstantin" To: Akhil Goyal , "dev@dpdk.org" CC: Anoob Joseph , "Nicolau, Radu" , "Doherty, Declan" , "hemant.agrawal@nxp.com" , "matan@nvidia.com" , "thomas@monjalon.net" , "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" , "olivier.matz@6wind.com" , "Xu, Rosen" Subject: RE: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Thread-Topic: [PATCH 2/8] ethdev: add dev op for IP reassembly configuration Thread-Index: AQHYALPTAeqGGhhhEUOj73nYsC3Sy6xeCRBQgAAu0ACAAQCHYA== Date: Wed, 12 Jan 2022 10:22:23 +0000 Message-ID: References: <20210823100259.1619886-1-gakhil@marvell.com> <20220103150813.1694888-1-gakhil@marvell.com> <20220103150813.1694888-3-gakhil@marvell.com> In-Reply-To: Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.200.16 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 17c4c409-194d-446c-0c32-08d9d5b56c56 x-ms-traffictypediagnostic: CH2PR11MB4311:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tz3ZwVh7RL5E/ksuA7F5SzWMXgVCfjNJfQvBUfssjJ5+ET+h1LJg1gqa6h4cqkTk0YlrWU/2a0NzYygO5q/1WUn/vGmTT5O5RJZvEZUb73eCS+FipnVaHr7JiflxEHOPtZF0+2yUInVaQua6jS0UofRefXIBzlvkTXDFNycy1GIpsiklyYgTMX0cHjensem0j1RBR+pdfS7K0sTya09KPW5T9amiIundfdVHXxqV6COsxVYR6/MUCXNN+JHN/bEjnFnT0oHALQUXg1nSCv2MUYFpgs0CmFW1tDcYeOSrA5geb+JARaKHISbWWc0LZ3J8uqrazOKQHiLkmIKCEagaDaMoBYSqSnCBnP7MrYAzF5J5dgbWwwupl3dkRFOyKhnYhRoCA3mgk5bL1U2dCz2WmF+T+ODP3WYik2pf1B28BB6vAySLVTyaYWmh4JdWg009xsXx2xCX03FZ/o89Yb+F4B+nMW5OuU8gG6K57yBZ1Xmf01vEn1OhOQE7+sscqCU5RbAyaWF8OKypCTmhiwLvKASY3+cS3qEfkYSP9X/engMD3sAeYNnzKReCeUXTYyqO8/fz9DjLC6BlipmXg2dRVNrnrmmNQumPowfSI1PBiBD8ULh/mRb6l7kIZU7yY7jXh6RkgDLQAyfLMM0cyeJZAz2wtcliHV7+1IB9XxHmvNMTmWriQYPYbG1L2Z+STKMElwza5LLdL2ofU/8CtEivFg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB4491.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(8936002)(26005)(110136005)(8676002)(66446008)(66556008)(71200400001)(7696005)(2906002)(5660300002)(54906003)(316002)(9686003)(4326008)(66476007)(38100700002)(86362001)(186003)(508600001)(107886003)(122000001)(76116006)(33656002)(66946007)(52536014)(64756008)(82960400001)(55016003)(38070700005)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?+VJy986b1udxmu0sAZU+CQQdvPdIzM3R+8vvDGF1mECeF8OWpqRtIz4JKxdu?= =?us-ascii?Q?X+gvHHn8gGlHKx0u+CmxKGuRT7u4FQth/ZzTmxIu+uLlVl8rsRm0to9Gt/em?= =?us-ascii?Q?NXU3K6p8rYn09Q2lKwcxkLX7+7NTVHUM3+vXn41bP+Bj6jBYyRjhtPcI41Xz?= =?us-ascii?Q?OSnS9s6Fpnb81gCzSnKc6tJNo6+OY7kNVDw0NdtjJSHj/+feRps/Vk4XG+Zj?= =?us-ascii?Q?C40ApOoASHg+PYg4jEyN9m1Jgd+lpqskFjnAT+LdZkDVZV3IfVty3XtTLv7h?= =?us-ascii?Q?QQuUzrqLsMUsze2vWZhq+SXrvYQA4GGVps74BG13lvOVPTwYX0ml9QNBbkX6?= =?us-ascii?Q?iv4kOD1w2LMqNM+0qsAtsa7fkWCcOQWvzvyJ+B6VnjLyqm7afSi8cbY5OLLN?= =?us-ascii?Q?6g+EbUMxQC+34hIYxaEwukVl86d/cpjrmA0nzcjgfzRR/VgpcqQ45rRDHTaV?= =?us-ascii?Q?BpfAJ9cACAo3gjRmN+qsEDYJxM1OGdygTnvEhPWGvF1ZD8BIVPfEcZz7A2ZG?= =?us-ascii?Q?S4Sos584TQG8UTuB8nxecNRc6lrwV9Y7kSu745zSrn/tMY1o8AN1ov2zpe/D?= =?us-ascii?Q?RAuVSLkQ41ZcCxXGEiBDze6cvhn2eO0sHoFy5gkq3wlGrwDtCq7yv08ZjpCh?= =?us-ascii?Q?HFFTjwXBlkwEfx2f3HYo8MuTLu+meAxA7G4goJO5lN5o4yPnc82SRFiCcS+y?= =?us-ascii?Q?8MD911mRufqW1jLRLTgcjLBMT+gbIxS7nD+PMV3wK7rWQxLPyOtpXcLb+d+B?= =?us-ascii?Q?YgCKOeGuyqtf5F3HOc3TlYp95dbNAx+NNFFV40Y5TFsI2CYD/8gCC8F+uw5e?= =?us-ascii?Q?/rPsHSKzk/7Z/fc5RMISnF0gYS3ZbYJ7ZXuLXq/ofDHpRV0Oo1DSzebufMyC?= =?us-ascii?Q?rTNastO4E7nDVDYHRCXm3IwtMGZRRTnF9rFfKqvhlUWkNo0zbXUnSIULERt9?= =?us-ascii?Q?ucv1fvdG3dH86eqI8FXnPQq3pmBPQ4WOG40C6SH1O9tA4OyuXiLdVQHYGV/Z?= =?us-ascii?Q?2sw4UOTzYcYVk8Gl+nnXXRS/3WMWDKGBH4aFOGMfpQedC1jy1Q4kF+L27Vaa?= =?us-ascii?Q?T3JcUH153yfOsXAYg3wlYib1TD7rQNevwDAN3C2PJPhaT2KmFBtOhJEasKYp?= =?us-ascii?Q?lc5sZ4vMaviXlMoqDNF8lOjOS9UqBXYtOp1vwkZQfa80tPg76AzoJ6wYQW6D?= =?us-ascii?Q?x50e8SU83qf019dj8ylGtmPc6mV6MByMyhwg7TQS9gTPoFJYBf12xwMkt4Wg?= =?us-ascii?Q?5CC4sWAWOwEDYvADcyPYAj5hPnmUNSa1hzsGh4dGAQeD9Fr8fFWucLbSmRFW?= =?us-ascii?Q?eo2szHdHd6v4kKtjbaq6v0av4bA5kQBrSlrIUgQmO1s95PyrVFloWuStkPzs?= =?us-ascii?Q?xspHTwJJMlpZjDMiUvO41OoCewdGejMKLzVWHIhR/uNluupvwWQyMipkjgxZ?= =?us-ascii?Q?2GqlX5xl3Q6uUeUhyR94exWvWJ4NigK6h/OLAcqceJ387dOTcm+qsNsBpQJ1?= =?us-ascii?Q?DQAbF06YkK5YRZ7ItNWrzxh9MwVve9uS466yRsqOCWYZznTm12rm6nSpGNFV?= =?us-ascii?Q?oS3Ydmr6mINa+Nc3Su/Z4G8MtcY9bHsL4TM/WeP49/kfNXh9f0ks4yVNK2Pb?= =?us-ascii?Q?icuaiCAi9iLKTeldLhGJCIRNjRvKgO/k32OrT0Rxio9Y8jg8Dbnn22fxJMLf?= =?us-ascii?Q?BND4jw=3D=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB4491.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 17c4c409-194d-446c-0c32-08d9d5b56c56 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2022 10:22:23.1917 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: RmhQCLnJcsftTnbAdUHTkAUnnS91NEvWu1vlaN8AXu2bh/QLQgcHe7ByzkcKmfkW0CjNpBBW4OXKgNZ6G0RG9cCQdAU/T4jRUcy3zWQ2kbU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR11MB4311 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > > diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c > > > index d9a03f12f9..ecc6c1fe37 100644 > > > --- a/lib/ethdev/rte_ethdev.c > > > +++ b/lib/ethdev/rte_ethdev.c > > > @@ -6473,6 +6473,36 @@ rte_eth_rx_metadata_negotiate(uint16_t port_id= , > > uint64_t *features) > > > (*dev->dev_ops->rx_metadata_negotiate)(dev, features)); > > > } > > > > > > +int > > > +rte_eth_ip_reassembly_conf_set(uint16_t port_id, > > > + struct rte_eth_ip_reass_params *conf) > > > +{ > > > + struct rte_eth_dev *dev; > > > + > > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > > > + dev =3D &rte_eth_devices[port_id]; > > > > Should we check here that device is properly configured, but not starte= d yet? > Ok will add checks for dev->data->dev_configured and dev->data->dev_start= ed >=20 > > Another question - if we have reassembly_conf_set() would it make sense= to > > have also reassembly_conf_get? > > So user can retrieve current ip_reassembly config values? > > > The set/supported values can be retrieved using rte_eth_dev_info :: reass= _capa Hmm, I thought rte_eth_dev_info :: reass_capa reports max supported values, not currently set values. Did I misunderstand something?=20